omp-conductor 0.15.0 → 0.15.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "omp-conductor",
-  "version": "0.15.0",
+  "version": "0.15.1",
   "type": "module",
   "license": "MIT",
   "description": "A 24/7 dispatcher that takes ready GitHub issues to green, mergeable PRs using omp coding sessions, with tiered escalation first to an orchestrator session and then to a human.",

package/src/setup-host.ts

@@ -72,6 +72,21 @@ function systemdQuote(value: string): string {
   return `"${value.replaceAll("\\", "\\\\").replaceAll('"', '\\"').replaceAll("%", "%%")}"`;
 }
 
+/**
+ * A bare path for the settings that take exactly one, never a quoted word list.
+ *
+ * `Environment=` and `ExecStart=` unquote their values, so {@link systemdQuote}
+ * is right there. `WorkingDirectory=` does not: systemd reads the whole value as
+ * the path, so a quoted one fails `systemd-analyze verify` with "path is not
+ * absolute" and the unit refuses to start — a landmine that only fires on the
+ * next restart, because the running daemon keeps the unit it started with.
+ * Spaces need no quoting here; `%` still does, or it reads as a specifier.
+ */
+function systemdPath(value: string): string {
+  if (/\r|\n/.test(value)) throw new Error("systemd values cannot contain newlines");
+  return value.replaceAll("%", "%%");
+}
+
 function shellQuote(value: string): string {
   return `'${value.replaceAll("'", "'\\''")}'`;
 }
@@ -268,7 +283,7 @@ export function renderDaemonService(runtime: ServiceRuntime, totalWorkers: numbe
     `Environment=${systemdQuote(`PATH=${runtime.path}`)}`,
     `Environment=${systemdQuote(`OMP_CONDUCTOR_HOME=${runtime.conductorHome}`)}`,
     `Environment=${systemdQuote(`OMP_TELEGRAM_STATE_DIR=${runtime.telegramStateDir}`)}`,
-    `WorkingDirectory=${systemdQuote(stateDir())}`,
+    `WorkingDirectory=${systemdPath(stateDir())}`,
     `ExecStart=${command.map(systemdQuote).join(" ")}`,
     "Restart=on-failure",
     "SuccessExitStatus=0 143",