omnigateway 0.4.0 → 0.4.1

package/README.md

@@ -772,29 +772,26 @@ unknown plugin safer. Integrity checking proves you received the bytes the
 registry advertised, and nothing about who wrote them or what they do once the
 gateway imports them.
 
-One ships in this repository:
+None ship in this repository, deliberately. The first one did, and moving it out
+is what proved the plugin API actually works from outside: while it built as a
+workspace sibling it could reach internal packages no published plugin can, and
+two bugs hid in exactly that gap.
 
 | Plugin | What it does |
 | --- | --- |
-| [`pokemon`](plugins/pokemon) | A Pokémon companion. Each gateway key raises one that hatches, evolves, and graduates into a Pokédex on the tokens that key spends, with a shop that spends a wallet of those same tokens. |
-
-It is not installed by default, is not in the npm package, and is not in the
-Docker image. Build it from a checkout and install the result:
+| [`omnigateway-plugin-pokemon`](https://github.com/harismawan/omnigateway-plugin-pokemon) | A Pokémon companion. Each gateway key raises one that hatches, evolves, and graduates into a Pokédex on the tokens that key spends, with a shop that spends a wallet of those same tokens. |
 
 ```bash
-bun run build:plugins                              # writes plugins/pokemon/dist/pokemon
-omni plugin install ./plugins/pokemon/dist/pokemon
+omni plugin install omnigateway-plugin-pokemon
+omni plugin verify pokemon
 omni restart
 ```
 
-The path ends in `pokemon` because the installer takes the target directory name
-from the source and refuses a manifest whose id disagrees with it — so a plugin
-cannot be installed under a name that is not its own.
-
 It needs outbound access to `pokeapi.co` and `raw.githubusercontent.com` for
 species data and sprites, which its manifest declares and `omni plugin verify
-pokemon` prints back. Those assets are Nintendo and Game Freak intellectual property, fetched at
-runtime and never vendored into this repository or its published artifacts.
+pokemon` prints back. Those assets are Nintendo and Game Freak intellectual
+property, fetched at runtime and never vendored — into that repository, this one,
+or anything either publishes.
 
 `verify` is the one to run before restarting a gateway that people are using: it
 reaches the same verdict the next boot will, from the same code, without loading
@@ -819,14 +816,20 @@ from the path:
 
 ```bash
 # wherever you build — a workstation, CI
-bun run build:plugins
-tar -czf pokemon.tgz -C plugins/pokemon/dist pokemon
+bun run build                                      # your plugin's own build
+tar -czf my-plugin.tgz -C dist my-plugin
 
 # on the host
-scp pokemon.tgz gateway-host:/tmp/
-ssh gateway-host 'omni plugin install /tmp/pokemon.tgz && omni plugin verify pokemon && omni restart'
+scp my-plugin.tgz gateway-host:/tmp/
+ssh gateway-host 'omni plugin install /tmp/my-plugin.tgz && omni plugin verify my-plugin && omni restart'
 ```
 
+Whatever you pack, the manifest must sit at the **root** of the archive once one
+wrapping directory is stripped. A build that nests it — `dist/my-plugin/omni-plugin.json`
+inside a tarball made from the repository root — is refused with "has no
+omni-plugin.json at its root", and that is the most common way a plugin that
+builds fine turns out not to install.
+
 Plaintext `http://` is refused outright and always will be: what arrives over
 that fetch is code the gateway process will `import`, so anyone between you and
 the host would be choosing what the gateway runs. Silently upgrading to `https://`

package/bin/omni.js

@@ -19991,7 +19991,7 @@ var CORE_TABLES = [
   "usage_rollup",
   "virtual_models"
 ];
-var CORE_TABLE_REFERENCE = new RegExp(`\\b(?:${CORE_TABLES.join("|")})\\b`);
+var CORE_TABLE_REFERENCE = new RegExp(`\\b(?:${CORE_TABLES.join("|")})\\b`, "i");
 var PREFIX3 = "plugin_";
 function stripNoise(sql) {
   let out = "";
@@ -19999,7 +19999,25 @@ function stripNoise(sql) {
   while (i < sql.length) {
     const c = sql[i];
     const next = sql[i + 1];
-    if (c === "'") {
+    if (c === '"' || c === "`" || c === "[") {
+      const close = c === "[" ? "]" : c;
+      out += c;
+      i += 1;
+      while (i < sql.length) {
+        if (sql[i] === close) {
+          if (close !== "]" && sql[i + 1] === close) {
+            out += close + close;
+            i += 2;
+            continue;
+          }
+          break;
+        }
+        out += sql[i];
+        i += 1;
+      }
+      out += close;
+      i += 1;
+    } else if (c === "'") {
       i += 1;
       while (i < sql.length) {
         if (sql[i] === "'") {
@@ -20041,6 +20059,7 @@ function assertPluginId(pluginId) {
     throw new Error(`plugin id ${JSON.stringify(pluginId)} is not a valid identifier`);
   }
 }
+var CONNECTION_STATEMENT = /^\s*(pragma|attach|detach|vacuum)\b/i;
 function prepare(pluginId, sql) {
   assertPluginId(pluginId);
   const expanded = sql.replace(PLACEHOLDER, (_match, name) => {
@@ -20049,12 +20068,29 @@ function prepare(pluginId, sql) {
     }
     return tableFor(pluginId, name);
   });
-  const found = CORE_TABLE_REFERENCE.exec(stripNoise(expanded));
+  const stripped = stripNoise(expanded);
+  const connection = CONNECTION_STATEMENT.exec(stripped);
+  if (connection !== null) {
+    throw new Error(`plugin sql may not ${connection[1]?.toUpperCase()}: the database handle is the gateway's, ` + "and this would reconfigure it for everything sharing it");
+  }
+  const found = CORE_TABLE_REFERENCE.exec(stripped);
   if (found !== null) {
     throw new Error(`plugin sql may not reference the core table ${found[0]}`);
   }
   return expanded;
 }
+function schemaObjects(db) {
+  const rows = db.query("SELECT name FROM sqlite_master").all();
+  return new Set(rows.map((row) => row.name));
+}
+function assertOwnNamespace(db, pluginId, before) {
+  const prefix = `${PREFIX3}${pluginId}_`;
+  for (const name of schemaObjects(db)) {
+    if (before.has(name) || name.startsWith(prefix) || name.startsWith("sqlite_"))
+      continue;
+    throw new Error(`plugin migration created ${name}, which is outside this plugin's namespace \u2014 ` + `name it {{\u2026}} so it becomes ${prefix}\u2026`);
+  }
+}
 function toBinding(value, index) {
   if (value === null || typeof value === "string" || typeof value === "number" || typeof value === "bigint" || typeof value === "boolean" || value instanceof Uint8Array) {
     return value;
@@ -20083,8 +20119,10 @@ function createPluginRepo(db) {
             throw new Error("migration version must be a positive integer");
           }
           const sql = prepare(pluginId, migration.sql);
+          const before = schemaObjects(db);
           db.transaction(() => {
             db.run(sql);
+            assertOwnNamespace(db, pluginId, before);
             db.run("INSERT INTO plugin_migrations (plugin_id, version, applied_at) VALUES (?,?,?)", [pluginId, migration.version, Date.now()]);
           })();
           applied.push(migration.version);

package/gateway.js

@@ -25465,7 +25465,7 @@ var CORE_TABLES = [
   "usage_rollup",
   "virtual_models"
 ];
-var CORE_TABLE_REFERENCE = new RegExp(`\\b(?:${CORE_TABLES.join("|")})\\b`);
+var CORE_TABLE_REFERENCE = new RegExp(`\\b(?:${CORE_TABLES.join("|")})\\b`, "i");
 var PREFIX3 = "plugin_";
 function stripNoise(sql) {
   let out = "";
@@ -25473,7 +25473,25 @@ function stripNoise(sql) {
   while (i < sql.length) {
     const c = sql[i];
     const next = sql[i + 1];
-    if (c === "'") {
+    if (c === '"' || c === "`" || c === "[") {
+      const close = c === "[" ? "]" : c;
+      out += c;
+      i += 1;
+      while (i < sql.length) {
+        if (sql[i] === close) {
+          if (close !== "]" && sql[i + 1] === close) {
+            out += close + close;
+            i += 2;
+            continue;
+          }
+          break;
+        }
+        out += sql[i];
+        i += 1;
+      }
+      out += close;
+      i += 1;
+    } else if (c === "'") {
       i += 1;
       while (i < sql.length) {
         if (sql[i] === "'") {
@@ -25515,6 +25533,7 @@ function assertPluginId(pluginId) {
     throw new Error(`plugin id ${JSON.stringify(pluginId)} is not a valid identifier`);
   }
 }
+var CONNECTION_STATEMENT = /^\s*(pragma|attach|detach|vacuum)\b/i;
 function prepare(pluginId, sql) {
   assertPluginId(pluginId);
   const expanded = sql.replace(PLACEHOLDER, (_match, name) => {
@@ -25523,12 +25542,29 @@ function prepare(pluginId, sql) {
     }
     return tableFor(pluginId, name);
   });
-  const found = CORE_TABLE_REFERENCE.exec(stripNoise(expanded));
+  const stripped = stripNoise(expanded);
+  const connection = CONNECTION_STATEMENT.exec(stripped);
+  if (connection !== null) {
+    throw new Error(`plugin sql may not ${connection[1]?.toUpperCase()}: the database handle is the gateway's, ` + "and this would reconfigure it for everything sharing it");
+  }
+  const found = CORE_TABLE_REFERENCE.exec(stripped);
   if (found !== null) {
     throw new Error(`plugin sql may not reference the core table ${found[0]}`);
   }
   return expanded;
 }
+function schemaObjects(db) {
+  const rows = db.query("SELECT name FROM sqlite_master").all();
+  return new Set(rows.map((row) => row.name));
+}
+function assertOwnNamespace(db, pluginId, before) {
+  const prefix = `${PREFIX3}${pluginId}_`;
+  for (const name of schemaObjects(db)) {
+    if (before.has(name) || name.startsWith(prefix) || name.startsWith("sqlite_"))
+      continue;
+    throw new Error(`plugin migration created ${name}, which is outside this plugin's namespace \u2014 ` + `name it {{\u2026}} so it becomes ${prefix}\u2026`);
+  }
+}
 function toBinding(value, index) {
   if (value === null || typeof value === "string" || typeof value === "number" || typeof value === "bigint" || typeof value === "boolean" || value instanceof Uint8Array) {
     return value;
@@ -25557,8 +25593,10 @@ function createPluginRepo(db) {
             throw new Error("migration version must be a positive integer");
           }
           const sql = prepare(pluginId, migration.sql);
+          const before = schemaObjects(db);
           db.transaction(() => {
             db.run(sql);
+            assertOwnNamespace(db, pluginId, before);
             db.run("INSERT INTO plugin_migrations (plugin_id, version, applied_at) VALUES (?,?,?)", [pluginId, migration.version, Date.now()]);
           })();
           applied.push(migration.version);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "omnigateway",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Self-hosted AI gateway with Anthropic- and OpenAI-compatible APIs, an admin console, and a CLI",
   "license": "MIT",
   "author": "Harismawan <mail@harismawan.com>",