omni-notify-mcp 1.3.23 → 1.3.30

package/dist/ui/server.js

@@ -147,6 +147,16 @@ const SECRETS_PATH = process.env.NOTIFY_MCP_SECRETS_PATH
     || join(CONFIG_DIR, "notify-secrets.json");
 // Backward compatibility for an existing per-user install: older builds,
 // `setup-secrets.sh` and the README all placed the file at `~/.notify-mcp-secrets`.
+//
+// #444: that exact filename is ALSO where release.sh/setup-secrets.sh (this
+// repo, and BullseyeShared's shared scripts/vscode-extension/release.sh and
+// publish-ext.sh) now write PUBLISH credentials — shell `KEY=VALUE` lines
+// (NPM_TOKEN=…, VSCE_PAT=…), a different, incompatible format from the JSON
+// this constant reads. Those scripts were moved to `~/.bullseye-release-secrets`
+// on 2026-09-13 specifically to stop colliding with this legacy path. Do NOT
+// widen this constant's name, and do not let release tooling point back at it
+// — see loadSecrets() below, which now names the mismatch instead of throwing
+// a bare parse error when it happens anyway.
 const LEGACY_SECRETS_PATH = join(homedir(), ".notify-mcp-secrets");
 // AWS SendTextMessage requires E.164 (e.g. +14089812202) — strip spaces, dashes,
 // parens, dots so a user-entered "+1 408 981 2202" is accepted.
@@ -206,7 +216,6 @@ function mergePreservingSecrets(existing, update) {
     return merged;
 }
 const app = express();
-app.use((req, _res, next) => { console.log(`[${new Date().toISOString()}] ${req.method} ${req.url} UA:${req.headers['user-agent']?.slice(0, 60)}`); next(); });
 app.use(express.json({
     verify: (req, _res, buf) => {
         req.rawBody = Buffer.from(buf);
@@ -2306,23 +2315,47 @@ async function sendNotificationSummary(message, priority, client) {
     const out = await sendNotification(message, priority, client);
     return out.text;
 }
+// A shell `KEY=VALUE` file — the format release.sh/setup-secrets.sh (this repo
+// and BullseyeShared's shared release scripts) write — never starts with `{`
+// and always has at least one bare `NAME=` line. Used only to make the #444
+// mismatch diagnosable: this is a heuristic, not a parser, and only runs after
+// JSON.parse already failed.
+function looksLikeShellSecrets(raw) {
+    const trimmed = raw.trimStart();
+    return !trimmed.startsWith("{") && /^[A-Z_][A-Z0-9_]*=/m.test(raw);
+}
 function loadSecrets() {
     const path = secretsFilePath();
     if (!path)
         return {};
+    let raw;
     try {
-        return decodeB64Fields(JSON.parse(readFileSync(path, "utf8")));
+        raw = readFileSync(path, "utf8");
     }
     catch (err) {
         throw new SecretsUnreadable(path, err);
     }
+    try {
+        return decodeB64Fields(JSON.parse(raw));
+    }
+    catch (err) {
+        if (path === LEGACY_SECRETS_PATH && looksLikeShellSecrets(raw)) {
+            throw new SecretsUnreadable(path, err, "this looks like a shell KEY=VALUE file (NPM_TOKEN=…/VSCE_PAT=…), the " +
+                "format release.sh/setup-secrets.sh write — those moved to " +
+                "~/.bullseye-release-secrets on 2026-09-13 (#444) specifically because " +
+                "this path is reserved for JSON notify-channel secrets; move or delete " +
+                "the file at this path rather than editing it");
+        }
+        throw new SecretsUnreadable(path, err);
+    }
 }
 // A secrets file that EXISTS but cannot be read is a hard defect, not an empty
 // result: the caller would otherwise import nothing and believe the user has no
 // credentials, which is the silent-escalation failure this file exists to stop.
 class SecretsUnreadable extends Error {
-    constructor(path, cause) {
-        super(`secrets file at ${path} exists but could not be read: ${cause instanceof Error ? cause.message : String(cause)}`);
+    constructor(path, cause, hint) {
+        const base = `secrets file at ${path} exists but could not be read: ${cause instanceof Error ? cause.message : String(cause)}`;
+        super(hint ? `${base} — ${hint}` : base);
     }
 }
 function secretsFilePath() {
@@ -2436,6 +2469,36 @@ function importCredsOnStart() {
         log("·", "import", "secrets file present but every config field it maps to is already set — nothing imported");
     }
 }
+// Story #445 (#438's real lesson): a server with no channel configured
+// answers `/v1/health` and every MCP tool call exactly like a healthy one —
+// nothing else here would ever say otherwise. That is how a machine ran for
+// five days delivering nothing while looking fine. Called once at startup,
+// right after importCredsOnStart() has had its one chance to fix the
+// problem — loud, impossible to miss in the console, and naming every path
+// this process actually checked, so the next time this happens it is
+// diagnosed in the first minute, not five days later by someone measuring
+// real sends.
+const CHANNEL_LABELS = [
+    ["desktop", "Desktop"], ["telegram", "Telegram"], ["email", "Email"],
+    ["ntfy", "ntfy"], ["discord", "Discord"], ["slack", "Slack"],
+    ["teams", "Teams"], ["sms", "SMS"],
+];
+function warnIfNoChannelConfigured(cfg) {
+    if (CHANNEL_LABELS.some(([key]) => cfg[key]?.enabled === true))
+        return;
+    const bar = "!".repeat(78);
+    const exists = (p) => (existsSync(p) ? "exists" : "MISSING");
+    console.log(`\n${bar}`);
+    console.log("  NO NOTIFICATION CHANNEL IS CONFIGURED — every notify call will reach nobody.");
+    console.log(bar);
+    console.log(`  Config file  (${exists(CONFIG_PATH)})  : ${CONFIG_PATH}`);
+    console.log(`  Secrets file (${exists(SECRETS_PATH)})  : ${SECRETS_PATH}`);
+    console.log(`  Legacy path  (${exists(LEGACY_SECRETS_PATH)})  : ${LEGACY_SECRETS_PATH}`);
+    console.log(`  Secrets actually in use: ${secretsFilePath() ?? "none of the above"}`);
+    console.log(`  Fix: open http://localhost:${PORT} and turn a channel on, or set`);
+    console.log(`       NOTIFY_MCP_SECRETS_PATH to a notify-secrets.json with real credentials.`);
+    console.log(`${bar}\n`);
+}
 async function slackPost(text) {
     const { webhook } = slackCreds();
     if (!webhook)
@@ -3142,7 +3205,6 @@ app.all("/mcp", async (req, res) => {
         });
         return;
     }
-    console.log("[debug-url]", req.method, req.url, "query:", JSON.stringify(req.query), "ua:", req.headers["user-agent"]);
     const existingSessionId = req.headers["mcp-session-id"];
     if (existingSessionId && httpTransports[existingSessionId]) {
         const transport = httpTransports[existingSessionId];
@@ -3301,6 +3363,9 @@ const httpServer = app.listen(PORT, () => {
     // config.json cannot serve a process whose secrets file IS populated. It
     // reports the channel names it filled — never a secret value.
     importCredsOnStart();
+    // Import has now had its one chance to fix a channel-less config — if
+    // nothing is enabled even after that, say so loudly (story #445).
+    warnIfNoChannelConfigured(loadConfig());
     // Live Telegram/Slack pollers hit real external channels — never under test.
     if (!TEST_ENDPOINTS) {
         startTelegramListener();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "omni-notify-mcp",
-  "version": "1.3.23",
+  "version": "1.3.30",
   "description": "Reach your AI agents from anywhere — and let them reach you. Every notification channel is set up in one config UI with one-click server launch: desktop, Telegram, Slack, SMS, email, ntfy. Agents then notify you when long work finishes or a decision is needed, ask you a question and wait for your answer, and receive and reply to the messages you send them — with Do Not Disturb and idle detection deciding what actually gets through.",
   "main": "dist/index.js",
   "type": "module",
@@ -25,7 +25,8 @@
     "build:ui": "tsc -p ui/tsconfig.json",
     "start": "node dist/index.js",
     "ui": "npm run build:ui && node dist/ui/server.js",
-    "test": "npm run build && node --test tests/*.test.mjs",
+    "test": "npm run build && node tests/run-tests.js",
+    "test:files": "node tests/run-tests.js",
     "prepublishOnly": "npm run build:mcp"
   },
   "dependencies": {