omni-notify-mcp 1.3.22 → 1.3.24

package/dist/ui/messaging/telegramError.js

@@ -0,0 +1,6 @@
+export async function telegramSendErrorHint(r) {
+    if (r.status === 401) {
+        return "the bot token is invalid or has been revoked — open @BotFather, check the bot behind this token (or create a new one), and update it in the settings UI";
+    }
+    return r.text();
+}

package/dist/ui/server.js

@@ -13,6 +13,7 @@ import nodemailer from "nodemailer";
 import { PinpointSMSVoiceV2Client, SendTextMessageCommand, DescribePhoneNumbersCommand, DescribeVerifiedDestinationNumbersCommand } from "@aws-sdk/client-pinpoint-sms-voice-v2";
 import { tmpdir } from "os";
 import { sendWithRouting, idleReading, formatIdleReading, describePriorityRouting } from "./messaging/notificationEngine.js";
+import { telegramSendErrorHint } from "./messaging/telegramError.js";
 import { z } from "zod";
 import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
 import { StreamableHTTPServerTransport } from "@modelcontextprotocol/sdk/server/streamableHttp.js";
@@ -146,6 +147,16 @@ const SECRETS_PATH = process.env.NOTIFY_MCP_SECRETS_PATH
     || join(CONFIG_DIR, "notify-secrets.json");
 // Backward compatibility for an existing per-user install: older builds,
 // `setup-secrets.sh` and the README all placed the file at `~/.notify-mcp-secrets`.
+//
+// #444: that exact filename is ALSO where release.sh/setup-secrets.sh (this
+// repo, and BullseyeShared's shared scripts/vscode-extension/release.sh and
+// publish-ext.sh) now write PUBLISH credentials — shell `KEY=VALUE` lines
+// (NPM_TOKEN=…, VSCE_PAT=…), a different, incompatible format from the JSON
+// this constant reads. Those scripts were moved to `~/.bullseye-release-secrets`
+// on 2026-09-13 specifically to stop colliding with this legacy path. Do NOT
+// widen this constant's name, and do not let release tooling point back at it
+// — see loadSecrets() below, which now names the mismatch instead of throwing
+// a bare parse error when it happens anyway.
 const LEGACY_SECRETS_PATH = join(homedir(), ".notify-mcp-secrets");
 // AWS SendTextMessage requires E.164 (e.g. +14089812202) — strip spaces, dashes,
 // parens, dots so a user-entered "+1 408 981 2202" is accepted.
@@ -554,7 +565,7 @@ app.post("/api/test/telegram", async (_req, res) => {
             if (r.ok)
                 sent++;
             else
-                errors.push(`${chatId}: ${r.status} ${await r.text()}`);
+                errors.push(`${chatId}: ${await telegramSendErrorHint(r)}`);
         }
         catch (err) {
             errors.push(`${chatId}: ${err instanceof Error ? err.message : String(err)}`);
@@ -1510,10 +1521,11 @@ async function sendNotification(message, priority, client) {
                         headers: { "Content-Type": "application/json" },
                         body: JSON.stringify(body),
                     });
-                    if (r.ok)
+                    if (r.ok) {
                         sent++;
-                    else
-                        errors.push(`${chatId}: ${await r.text()}`);
+                        continue;
+                    }
+                    errors.push(`${chatId}: ${await telegramSendErrorHint(r)}`);
                 }
                 if (sent === 0 && errors.length)
                     throw new Error(errors.join("; "));
@@ -2304,14 +2316,37 @@ async function sendNotificationSummary(message, priority, client) {
     const out = await sendNotification(message, priority, client);
     return out.text;
 }
+// A shell `KEY=VALUE` file — the format release.sh/setup-secrets.sh (this repo
+// and BullseyeShared's shared release scripts) write — never starts with `{`
+// and always has at least one bare `NAME=` line. Used only to make the #444
+// mismatch diagnosable: this is a heuristic, not a parser, and only runs after
+// JSON.parse already failed.
+function looksLikeShellSecrets(raw) {
+    const trimmed = raw.trimStart();
+    return !trimmed.startsWith("{") && /^[A-Z_][A-Z0-9_]*=/m.test(raw);
+}
 function loadSecrets() {
     const path = secretsFilePath();
     if (!path)
         return {};
+    let raw;
+    try {
+        raw = readFileSync(path, "utf8");
+    }
+    catch (err) {
+        throw new SecretsUnreadable(path, err);
+    }
     try {
-        return decodeB64Fields(JSON.parse(readFileSync(path, "utf8")));
+        return decodeB64Fields(JSON.parse(raw));
     }
     catch (err) {
+        if (path === LEGACY_SECRETS_PATH && looksLikeShellSecrets(raw)) {
+            throw new SecretsUnreadable(path, err, "this looks like a shell KEY=VALUE file (NPM_TOKEN=…/VSCE_PAT=…), the " +
+                "format release.sh/setup-secrets.sh write — those moved to " +
+                "~/.bullseye-release-secrets on 2026-09-13 (#444) specifically because " +
+                "this path is reserved for JSON notify-channel secrets; move or delete " +
+                "the file at this path rather than editing it");
+        }
         throw new SecretsUnreadable(path, err);
     }
 }
@@ -2319,8 +2354,9 @@ function loadSecrets() {
 // result: the caller would otherwise import nothing and believe the user has no
 // credentials, which is the silent-escalation failure this file exists to stop.
 class SecretsUnreadable extends Error {
-    constructor(path, cause) {
-        super(`secrets file at ${path} exists but could not be read: ${cause instanceof Error ? cause.message : String(cause)}`);
+    constructor(path, cause, hint) {
+        const base = `secrets file at ${path} exists but could not be read: ${cause instanceof Error ? cause.message : String(cause)}`;
+        super(hint ? `${base} — ${hint}` : base);
     }
 }
 function secretsFilePath() {
@@ -2434,6 +2470,36 @@ function importCredsOnStart() {
         log("·", "import", "secrets file present but every config field it maps to is already set — nothing imported");
     }
 }
+// Story #445 (#438's real lesson): a server with no channel configured
+// answers `/v1/health` and every MCP tool call exactly like a healthy one —
+// nothing else here would ever say otherwise. That is how a machine ran for
+// five days delivering nothing while looking fine. Called once at startup,
+// right after importCredsOnStart() has had its one chance to fix the
+// problem — loud, impossible to miss in the console, and naming every path
+// this process actually checked, so the next time this happens it is
+// diagnosed in the first minute, not five days later by someone measuring
+// real sends.
+const CHANNEL_LABELS = [
+    ["desktop", "Desktop"], ["telegram", "Telegram"], ["email", "Email"],
+    ["ntfy", "ntfy"], ["discord", "Discord"], ["slack", "Slack"],
+    ["teams", "Teams"], ["sms", "SMS"],
+];
+function warnIfNoChannelConfigured(cfg) {
+    if (CHANNEL_LABELS.some(([key]) => cfg[key]?.enabled === true))
+        return;
+    const bar = "!".repeat(78);
+    const exists = (p) => (existsSync(p) ? "exists" : "MISSING");
+    console.log(`\n${bar}`);
+    console.log("  NO NOTIFICATION CHANNEL IS CONFIGURED — every notify call will reach nobody.");
+    console.log(bar);
+    console.log(`  Config file  (${exists(CONFIG_PATH)})  : ${CONFIG_PATH}`);
+    console.log(`  Secrets file (${exists(SECRETS_PATH)})  : ${SECRETS_PATH}`);
+    console.log(`  Legacy path  (${exists(LEGACY_SECRETS_PATH)})  : ${LEGACY_SECRETS_PATH}`);
+    console.log(`  Secrets actually in use: ${secretsFilePath() ?? "none of the above"}`);
+    console.log(`  Fix: open http://localhost:${PORT} and turn a channel on, or set`);
+    console.log(`       NOTIFY_MCP_SECRETS_PATH to a notify-secrets.json with real credentials.`);
+    console.log(`${bar}\n`);
+}
 async function slackPost(text) {
     const { webhook } = slackCreds();
     if (!webhook)
@@ -2835,6 +2901,10 @@ function createMcpServer(clientId, sessionTag) {
                 ? `\n\nReply with: @${sessionTag} <your answer>`
                 : `\n\nReply to this message with your answer.`;
             for (const chatId of cfg.telegram.chatIds) {
+                // A non-2xx Telegram response does NOT reject this fetch — only a
+                // network-level failure does — so this used to silently do nothing
+                // on e.g. a revoked token: no error, no log line, just a question
+                // the user never saw and no clue why. Story #443: check r.ok too.
                 await fetch(`https://api.telegram.org/bot${cfg.telegram.token}/sendMessage`, {
                     method: "POST",
                     headers: { "Content-Type": "application/json" },
@@ -2842,7 +2912,10 @@ function createMcpServer(clientId, sessionTag) {
                         chat_id: chatId,
                         text: `${askPrefix} ${question}${replyHint}`,
                     }),
-                }).catch((err) => log("→", "ask:telegram", `ERROR: ${err}`, clientId));
+                })
+                    .then(async (r) => { if (!r.ok)
+                    log("→", "ask:telegram", `ERROR: ${chatId}: ${await telegramSendErrorHint(r)}`, clientId); })
+                    .catch((err) => log("→", "ask:telegram", `ERROR: ${chatId}: ${err}`, clientId));
             }
         }
         const email = cfg.email ?? {};
@@ -3292,6 +3365,9 @@ const httpServer = app.listen(PORT, () => {
     // config.json cannot serve a process whose secrets file IS populated. It
     // reports the channel names it filled — never a secret value.
     importCredsOnStart();
+    // Import has now had its one chance to fix a channel-less config — if
+    // nothing is enabled even after that, say so loudly (story #445).
+    warnIfNoChannelConfigured(loadConfig());
     // Live Telegram/Slack pollers hit real external channels — never under test.
     if (!TEST_ENDPOINTS) {
         startTelegramListener();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "omni-notify-mcp",
-  "version": "1.3.22",
+  "version": "1.3.24",
   "description": "Reach your AI agents from anywhere — and let them reach you. Every notification channel is set up in one config UI with one-click server launch: desktop, Telegram, Slack, SMS, email, ntfy. Agents then notify you when long work finishes or a decision is needed, ask you a question and wait for your answer, and receive and reply to the messages you send them — with Do Not Disturb and idle detection deciding what actually gets through.",
   "main": "dist/index.js",
   "type": "module",