omni-notify-mcp 1.3.22 → 1.3.23

package/dist/ui/messaging/telegramError.js

@@ -0,0 +1,6 @@
+export async function telegramSendErrorHint(r) {
+    if (r.status === 401) {
+        return "the bot token is invalid or has been revoked — open @BotFather, check the bot behind this token (or create a new one), and update it in the settings UI";
+    }
+    return r.text();
+}

package/dist/ui/server.js

@@ -13,6 +13,7 @@ import nodemailer from "nodemailer";
 import { PinpointSMSVoiceV2Client, SendTextMessageCommand, DescribePhoneNumbersCommand, DescribeVerifiedDestinationNumbersCommand } from "@aws-sdk/client-pinpoint-sms-voice-v2";
 import { tmpdir } from "os";
 import { sendWithRouting, idleReading, formatIdleReading, describePriorityRouting } from "./messaging/notificationEngine.js";
+import { telegramSendErrorHint } from "./messaging/telegramError.js";
 import { z } from "zod";
 import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
 import { StreamableHTTPServerTransport } from "@modelcontextprotocol/sdk/server/streamableHttp.js";
@@ -554,7 +555,7 @@ app.post("/api/test/telegram", async (_req, res) => {
             if (r.ok)
                 sent++;
             else
-                errors.push(`${chatId}: ${r.status} ${await r.text()}`);
+                errors.push(`${chatId}: ${await telegramSendErrorHint(r)}`);
         }
         catch (err) {
             errors.push(`${chatId}: ${err instanceof Error ? err.message : String(err)}`);
@@ -1510,10 +1511,11 @@ async function sendNotification(message, priority, client) {
                         headers: { "Content-Type": "application/json" },
                         body: JSON.stringify(body),
                     });
-                    if (r.ok)
+                    if (r.ok) {
                         sent++;
-                    else
-                        errors.push(`${chatId}: ${await r.text()}`);
+                        continue;
+                    }
+                    errors.push(`${chatId}: ${await telegramSendErrorHint(r)}`);
                 }
                 if (sent === 0 && errors.length)
                     throw new Error(errors.join("; "));
@@ -2835,6 +2837,10 @@ function createMcpServer(clientId, sessionTag) {
                 ? `\n\nReply with: @${sessionTag} <your answer>`
                 : `\n\nReply to this message with your answer.`;
             for (const chatId of cfg.telegram.chatIds) {
+                // A non-2xx Telegram response does NOT reject this fetch — only a
+                // network-level failure does — so this used to silently do nothing
+                // on e.g. a revoked token: no error, no log line, just a question
+                // the user never saw and no clue why. Story #443: check r.ok too.
                 await fetch(`https://api.telegram.org/bot${cfg.telegram.token}/sendMessage`, {
                     method: "POST",
                     headers: { "Content-Type": "application/json" },
@@ -2842,7 +2848,10 @@ function createMcpServer(clientId, sessionTag) {
                         chat_id: chatId,
                         text: `${askPrefix} ${question}${replyHint}`,
                     }),
-                }).catch((err) => log("→", "ask:telegram", `ERROR: ${err}`, clientId));
+                })
+                    .then(async (r) => { if (!r.ok)
+                    log("→", "ask:telegram", `ERROR: ${chatId}: ${await telegramSendErrorHint(r)}`, clientId); })
+                    .catch((err) => log("→", "ask:telegram", `ERROR: ${chatId}: ${err}`, clientId));
             }
         }
         const email = cfg.email ?? {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "omni-notify-mcp",
-  "version": "1.3.22",
+  "version": "1.3.23",
   "description": "Reach your AI agents from anywhere — and let them reach you. Every notification channel is set up in one config UI with one-click server launch: desktop, Telegram, Slack, SMS, email, ntfy. Agents then notify you when long work finishes or a decision is needed, ask you a question and wait for your answer, and receive and reply to the messages you send them — with Do Not Disturb and idle detection deciding what actually gets through.",
   "main": "dist/index.js",
   "type": "module",