omni-notify-mcp 1.3.20 → 1.3.22

package/README.md

@@ -178,6 +178,20 @@ ending in `_b64` are base64-decoded at load, and on startup any credential it ho
 copied into **empty** fields of `config.json` (never over a value you already set).
 See `config.example.json` for a hand-written starting point.
 
+**This only works if the running server can actually find that file.** The lookup path is
+`NOTIFY_MCP_SECRETS_PATH`, defaulting to `<CONFIG_DIR>/notify-secrets.json` — and `CONFIG_DIR`
+defaults to `~/.notify-mcp`, a **home-relative** path, not the repo root. A server started via
+`npx` or the VS Code extension runs from an npm cache directory with no relationship to any git
+checkout, so simply having `notify-secrets.json` committed at the repo root does nothing on its
+own (story #438: this sat silently broken for months — every channel stayed disabled and every
+`notify` reached nobody, because nothing ever pointed the server at the repo file). Set
+`NOTIFY_MCP_SECRETS_PATH` to the repo's `notify-secrets.json` as a **persistent environment
+variable** on each machine that has a checkout (`setx NOTIFY_MCP_SECRETS_PATH "C:\path\to\BullseyeNotif\notify-secrets.json"`
+on Windows, or export it from your shell profile elsewhere) — set once, it survives reboots and
+every future server restart on that machine picks it up. Check `GET /api/config` after a restart:
+a channel listed in `notify-secrets.json` with `enabled: true` and its required fields populated
+should show `enabled: true` there too — if it still shows `false`, the file was not found.
+
 ## Inbound — the inbox
 
 Messages arriving *from* the user (Telegram reply, Slack channel post,

package/dist/ui/messaging/notificationEngine.js

@@ -156,13 +156,35 @@ export async function sendWithRouting(options) {
             summary: `Suppressed — ${decision.reason}. ${formatIdleReading(decision.idle)}.`,
         };
     }
+    // Nothing was even eligible to try — this is NOT a hold (the branches above
+    // already caught dnd/idle) and it is NOT a per-channel send error (nothing
+    // was attempted, so `errors` is necessarily empty). It is either "nothing is
+    // turned on at all" or "something is turned on but doesn't reach this
+    // priority/activity state" — story #438: the old text here ("reached 0 of 0
+    // enabled channels; the server log names which send failed") actively lied
+    // in this branch, since nothing was ever attempted and no log line exists to
+    // name. Naming what IS enabled (or that nothing is) is the whole difference
+    // between an agent that can act on the failure and one that cannot.
+    if (attempted.length === 0) {
+        const enabledChannels = Object.keys(enabled).filter((c) => enabled[c]);
+        const configHint = enabledChannels.length === 0
+            ? "no channel is enabled at all — enable at least one (desktop, telegram, email, ntfy, discord, slack, teams, sms) in the settings UI before calling notify again"
+            : `${enabledChannels.join(", ")} ${enabledChannels.length === 1 ? "is" : "are"} enabled but none of them reaches priority=${priority} while ${reach.join("/")}-class channels are reachable — check each channel's priority range and activity gating`;
+        return {
+            delivered,
+            attempted,
+            errors,
+            outcome: "failed",
+            summary: `NOT DELIVERED — no channel was eligible to try: ${configHint} — ${decision.reason}. ${formatIdleReading(decision.idle)}.`,
+        };
+    }
     return {
         delivered,
         attempted,
         errors,
         outcome: "failed",
         summary: `NOT DELIVERED — reached 0 of ${attempted.length} enabled channel${attempted.length === 1 ? "" : "s"}`
-            + `${errors.length > 0 ? `; all ${errors.length} failed: ${errors.join("; ")}` : "; the server log names which send failed"}`
+            + `; all ${errors.length} failed: ${errors.join("; ")}`
             + ` — ${decision.reason}. ${formatIdleReading(decision.idle)}.`,
     };
 }

package/dist/ui/server.js

@@ -152,32 +152,37 @@ const LEGACY_SECRETS_PATH = join(homedir(), ".notify-mcp-secrets");
 function e164(s) {
     return String(s ?? "").replace(/[^\d+]/g, "");
 }
+// The ONE list of credential-shaped fields, read by both maskSecrets() (out)
+// and mergePreservingSecrets() (back in). Before story #442 these were two
+// hand-written lists of `if`/`guard` calls kept in sync by hand — that's
+// exactly how ntfy.token got added to a channel (story #427's "brainless
+// config" import) without ever being added to either list, and leaked in the
+// clear over `GET /api/config` for as long as the channel existed. A field
+// belongs here the moment its channel gets one that authenticates outbound
+// (a token, password, or bearer webhook URL) — see
+// tests/smoke.test.mjs's naming-convention test, which independently catches
+// a field like this one being added to defaultConfig() but not to this list.
+const SENSITIVE_FIELDS = [
+    ["email", "pass"],
+    ["email", "clientSecret"],
+    ["email", "refreshToken"],
+    ["email", "accessToken"],
+    ["sms", "secretAccessKey"],
+    ["telegram", "token"],
+    ["ntfy", "token"],
+    ["discord", "webhookUrl"],
+    ["discord", "clientSecret"],
+    ["slack", "webhookUrl"],
+    ["slack", "botToken"],
+    ["slack", "clientSecret"],
+    ["teams", "webhookUrl"],
+];
 function maskSecrets(config) {
     const c = JSON.parse(JSON.stringify(config));
-    if (c.email?.pass)
-        c.email.pass = MASKED;
-    if (c.email?.clientSecret)
-        c.email.clientSecret = MASKED;
-    if (c.email?.refreshToken)
-        c.email.refreshToken = MASKED;
-    if (c.email?.accessToken)
-        c.email.accessToken = MASKED;
-    if (c.sms?.secretAccessKey)
-        c.sms.secretAccessKey = MASKED;
-    if (c.telegram?.token)
-        c.telegram.token = MASKED;
-    if (c.discord?.webhookUrl)
-        c.discord.webhookUrl = MASKED;
-    if (c.discord?.clientSecret)
-        c.discord.clientSecret = MASKED;
-    if (c.slack?.webhookUrl)
-        c.slack.webhookUrl = MASKED;
-    if (c.slack?.botToken)
-        c.slack.botToken = MASKED;
-    if (c.slack?.clientSecret)
-        c.slack.clientSecret = MASKED;
-    if (c.teams?.webhookUrl)
-        c.teams.webhookUrl = MASKED;
+    for (const [sec, field] of SENSITIVE_FIELDS) {
+        if (c[sec]?.[field])
+            c[sec][field] = MASKED;
+    }
     delete c.whatsapp;
     return c;
 }
@@ -192,24 +197,11 @@ function mergePreservingSecrets(existing, update) {
     }
     if (typeof update.muteAll === "boolean")
         merged.muteAll = update.muteAll;
-    const guard = (path) => {
-        const [sec, field] = path;
+    for (const [sec, field] of SENSITIVE_FIELDS) {
         if (update[sec]?.[field] === MASKED) {
             merged[sec][field] = existing[sec]?.[field] ?? "";
         }
-    };
-    guard(["email", "pass"]);
-    guard(["email", "clientSecret"]);
-    guard(["email", "refreshToken"]);
-    guard(["email", "accessToken"]);
-    guard(["sms", "secretAccessKey"]);
-    guard(["telegram", "token"]);
-    guard(["discord", "webhookUrl"]);
-    guard(["discord", "clientSecret"]);
-    guard(["slack", "webhookUrl"]);
-    guard(["slack", "botToken"]);
-    guard(["slack", "clientSecret"]);
-    guard(["teams", "webhookUrl"]);
+    }
     return merged;
 }
 const app = express();

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "omni-notify-mcp",
-  "version": "1.3.20",
-  "description": "Reach your AI agents from anywhere \u2014 and let them reach you. Every notification channel is set up in one config UI with one-click server launch: desktop, Telegram, Slack, SMS, email, ntfy. Agents then notify you when long work finishes or a decision is needed, ask you a question and wait for your answer, and receive and reply to the messages you send them \u2014 with Do Not Disturb and idle detection deciding what actually gets through.",
+  "version": "1.3.22",
+  "description": "Reach your AI agents from anywhere — and let them reach you. Every notification channel is set up in one config UI with one-click server launch: desktop, Telegram, Slack, SMS, email, ntfy. Agents then notify you when long work finishes or a decision is needed, ask you a question and wait for your answer, and receive and reply to the messages you send them — with Do Not Disturb and idle detection deciding what actually gets through.",
   "main": "dist/index.js",
   "type": "module",
   "bin": {