oma-coding-agent 1.1.4

package/src/cli/bench-cli.ts

@@ -0,0 +1,552 @@
+import type { ResolvedThinkingLevel } from "@oh-my-pi/pi-agent-core";
+import type {
+	Api,
+	ApiKeyResolver,
+	AssistantMessage,
+	AssistantMessageEvent,
+	AssistantMessageEventStream,
+	Context,
+	Effort,
+	Model,
+	SimpleStreamOptions,
+} from "@oh-my-pi/pi-ai";
+import { streamSimple } from "@oh-my-pi/pi-ai";
+import { buildModelProviderPriorityRank, type CanonicalModelVariant } from "@oh-my-pi/pi-catalog/identity";
+import { replaceTabs, truncateToWidth } from "@oh-my-pi/pi-tui";
+import { formatDuration, getProjectDir } from "@oh-my-pi/pi-utils";
+import chalk from "chalk";
+import type { ApiKeyResolverModel } from "../config/api-key-resolver";
+import { type CanonicalModelQueryOptions, ModelRegistry } from "../config/model-registry";
+import {
+	formatModelSelectorValue,
+	formatModelString,
+	getModelMatchPreferences,
+	resolveCliModel,
+} from "../config/model-resolver";
+import { Settings } from "../config/settings";
+import benchPrompt from "../prompts/bench.md" with { type: "text" };
+import { discoverAuthStorage, loadCliExtensionProviders } from "../sdk";
+import { resolveThinkingLevelForModel, shouldDisableReasoning, toReasoningEffort } from "../thinking";
+
+const DEFAULT_RUNS = 1;
+const DEFAULT_MAX_TOKENS = 512;
+const ERROR_WIDTH = 110;
+const BENCH_PROMPT = benchPrompt.trim();
+
+export interface BenchCommandArgs {
+	models: string[];
+	flags: {
+		runs?: number;
+		maxTokens?: number;
+		prompt?: string;
+		json?: boolean;
+	};
+}
+
+export interface BenchModelRegistry {
+	getAll(): Model<Api>[];
+	getApiKey(model: Model<Api>, sessionId?: string): Promise<string | undefined>;
+	resolver(model: ApiKeyResolverModel, sessionId?: string): ApiKeyResolver;
+	resolveCanonicalModel?(canonicalId: string, options?: CanonicalModelQueryOptions): Model<Api> | undefined;
+	getCanonicalVariants?(canonicalId: string, options?: CanonicalModelQueryOptions): CanonicalModelVariant[];
+	getCanonicalId?(model: Model<Api>): string | undefined;
+	hasConfiguredAuth?(model: Model<Api>): boolean;
+}
+
+export interface BenchRuntime {
+	modelRegistry: BenchModelRegistry;
+	settings?: Settings;
+	close?: () => void;
+}
+
+export interface BenchRunSuccess {
+	ok: true;
+	ttftMs: number;
+	durationMs: number;
+	outputTokens: number;
+	/** Generation throughput measured over the post-first-token window. */
+	tokensPerSecond: number;
+}
+
+export interface BenchRunFailure {
+	ok: false;
+	error: string;
+}
+
+export type BenchRunResult = BenchRunSuccess | BenchRunFailure;
+
+export interface BenchAverages {
+	ttftMs: number;
+	durationMs: number;
+	outputTokens: number;
+	tokensPerSecond: number;
+}
+
+export interface BenchModelReport {
+	/** Selector as the user typed it (e.g. "opus" or "gemini-3.5:low"). */
+	selector: string;
+	/** Resolved `provider/id`. */
+	model: string;
+	/** Explicit thinking level from a `:level` selector suffix; undefined = provider default. */
+	thinking?: ResolvedThinkingLevel;
+	results: BenchRunResult[];
+	/** Averages over successful runs; null when every run failed. */
+	average: BenchAverages | null;
+}
+
+export interface BenchSummary {
+	runs: number;
+	maxTokens: number;
+	models: BenchModelReport[];
+	failures: number;
+}
+
+type BenchStreamSimple = (
+	model: Model<Api>,
+	context: Context,
+	options?: SimpleStreamOptions,
+) => AssistantMessageEventStream;
+
+export interface BenchDependencies {
+	createRuntime?: () => Promise<BenchRuntime>;
+	randomSessionId?: () => string;
+	writeStdout?: (text: string) => void;
+	writeStderr?: (text: string) => void;
+	setExitCode?: (code: number) => void;
+	streamSimple?: BenchStreamSimple;
+	now?: () => number;
+	stdoutIsTTY?: boolean;
+}
+
+function getErrorMessage(error: unknown): string {
+	if (error instanceof Error && error.message) return error.message;
+	return String(error);
+}
+
+function normalizePositiveInteger(name: string, value: number | undefined, fallback: number): number {
+	if (value === undefined) return fallback;
+	if (!Number.isInteger(value) || value <= 0) {
+		throw new Error(`Expected --${name} to be a positive integer, got ${value}`);
+	}
+	return value;
+}
+
+function isFirstTokenEvent(event: AssistantMessageEvent): boolean {
+	switch (event.type) {
+		case "text_delta":
+		case "thinking_delta":
+		case "toolcall_delta":
+			return event.delta.length > 0;
+		case "text_end":
+		case "thinking_end":
+			return event.content.length > 0;
+		default:
+			return false;
+	}
+}
+
+/** Final message carries visible output — non-empty text/thinking or a tool call. */
+function hasVisibleFinalContent(message: AssistantMessage): boolean {
+	return message.content.some(block => {
+		switch (block.type) {
+			case "text":
+				return block.text.length > 0;
+			case "thinking":
+				return block.thinking.length > 0;
+			case "redactedThinking":
+			case "toolCall":
+				return true;
+			default:
+				return false;
+		}
+	});
+}
+
+/**
+ * Tokens/s over the generation window (duration minus TTFT) so queue/prefill
+ * latency does not dilute throughput. Falls back to total duration when the
+ * response arrived as a single chunk (TTFT ~ duration).
+ */
+export function computeTokensPerSecond(
+	outputTokens: number,
+	durationMs: number,
+	ttftMs: number,
+	deltaChunkCount: number,
+): number {
+	const decodeMs = durationMs - ttftMs;
+	// Fall back to total duration when the response arrived as a single chunk/non-streaming.
+	const windowMs = decodeMs > 0 && deltaChunkCount >= 2 ? decodeMs : durationMs;
+	return windowMs > 0 ? (outputTokens * 1000) / windowMs : 0;
+}
+
+interface BenchRequestOptions {
+	apiKey: ApiKeyResolver;
+	sessionId: string;
+	prompt: string;
+	maxTokens: number;
+	/** Explicit effort from a `:level` selector suffix; absent = provider default. */
+	reasoning?: Effort;
+	/** Only set for an explicit `:off` suffix — some endpoints reject disablement. */
+	disableReasoning?: boolean;
+}
+
+async function runBenchRequest(
+	model: Model<Api>,
+	options: BenchRequestOptions,
+	streamFn: BenchStreamSimple,
+	now: () => number,
+): Promise<BenchRunResult> {
+	const startedAt = now();
+	let firstTokenAt: number | undefined;
+	try {
+		const context: Context = {
+			// Codex's Responses endpoint 400s with "Instructions are required" when no
+			// system prompt is present — same guard as eval's completion bridge.
+			systemPrompt: ["You are a helpful assistant."],
+			messages: [{ role: "user", content: options.prompt, timestamp: Date.now(), attribution: "user" }],
+		};
+		const stream = streamFn(model, context, {
+			apiKey: options.apiKey,
+			sessionId: options.sessionId,
+			maxTokens:
+				model.maxTokens !== null && Number.isFinite(model.maxTokens) && model.maxTokens > 0
+					? Math.min(options.maxTokens, model.maxTokens)
+					: options.maxTokens,
+			reasoning: options.reasoning,
+			disableReasoning: options.disableReasoning,
+			// pi-ai opts every OpenRouter request into response caching (1h TTL).
+			// Bench sends a byte-identical request each run, so within the TTL
+			// OpenRouter replays the cached generation with zeroed usage — the run
+			// shows "tokens 0, TPS 0.0" at line speed. Opt back out so every run
+			// measures a fresh generation.
+			headers: model.provider === "openrouter" ? { "X-OpenRouter-Cache": "false" } : undefined,
+		});
+		let message: AssistantMessage | undefined;
+		let deltaChunkCount = 0;
+		for await (const event of stream) {
+			if (firstTokenAt === undefined && isFirstTokenEvent(event)) {
+				firstTokenAt = now();
+			}
+			if (
+				(event.type === "text_delta" || event.type === "thinking_delta" || event.type === "toolcall_delta") &&
+				event.delta.length > 0
+			) {
+				deltaChunkCount++;
+			}
+			if (event.type === "error") {
+				return { ok: false, error: event.error.errorMessage ?? "request failed" };
+			}
+			if (event.type === "done") {
+				message = event.message;
+			}
+		}
+		message ??= await stream.result();
+		if (message.stopReason === "error" || message.errorMessage) {
+			return { ok: false, error: message.errorMessage ?? "request failed" };
+		}
+		const rawDuration = message.duration ?? now() - startedAt;
+		const durationMs = Number.isFinite(rawDuration) && rawDuration > 0 ? rawDuration : 0;
+		const rawTtft = message.ttft ?? (firstTokenAt === undefined ? durationMs : firstTokenAt - startedAt);
+		const ttftMs = Number.isFinite(rawTtft) && rawTtft > 0 ? rawTtft : 0;
+		const outputTokens = Number.isFinite(message.usage.output) && message.usage.output > 0 ? message.usage.output : 0;
+		// A run that streamed no content (no delta/end event set firstTokenAt),
+		// carries no visible final content, and measured no output tokens
+		// benchmarked nothing — a genuinely empty stream (e.g. a gateway that 200s
+		// with an empty body). Surface it as a failure instead of a misleading
+		// 0-token "✓". Streaming and buffered providers that produce content keep
+		// passing even when usage is omitted.
+		if (firstTokenAt === undefined && outputTokens === 0 && !hasVisibleFinalContent(message)) {
+			return {
+				ok: false,
+				error: `provider returned no output (0 tokens, empty stream; stop reason: ${message.stopReason ?? "unknown"})`,
+			};
+		}
+		return {
+			ok: true,
+			ttftMs,
+			durationMs,
+			outputTokens,
+			tokensPerSecond: computeTokensPerSecond(outputTokens, durationMs, ttftMs, deltaChunkCount),
+		};
+	} catch (error) {
+		return { ok: false, error: getErrorMessage(error) };
+	}
+}
+
+function buildModelReport(
+	selector: string,
+	model: Model<Api>,
+	thinking: ResolvedThinkingLevel | undefined,
+	results: BenchRunResult[],
+): BenchModelReport {
+	const successes = results.filter((result): result is BenchRunSuccess => result.ok);
+	const average =
+		successes.length === 0
+			? null
+			: {
+					ttftMs: successes.reduce((sum, r) => sum + r.ttftMs, 0) / successes.length,
+					durationMs: successes.reduce((sum, r) => sum + r.durationMs, 0) / successes.length,
+					outputTokens: successes.reduce((sum, r) => sum + r.outputTokens, 0) / successes.length,
+					tokensPerSecond: successes.reduce((sum, r) => sum + r.tokensPerSecond, 0) / successes.length,
+				};
+	return { selector, model: formatModelString(model), thinking, results, average };
+}
+
+function formatBenchModelLabel(report: BenchModelReport): string {
+	return formatModelSelectorValue(report.model, report.thinking);
+}
+
+function formatMs(ms: number): string {
+	return formatDuration(Math.max(0, Math.round(ms)));
+}
+
+function formatRunLine(result: BenchRunResult, index: number, total: number): string {
+	const prefix = chalk.dim(`run ${index + 1}/${total}`);
+	if (result.ok) {
+		return `  ${chalk.green("✓")} ${prefix} ${chalk.dim("TTFT")} ${formatMs(result.ttftMs)} ${chalk.dim("TPS")} ${result.tokensPerSecond.toFixed(1)}/s ${chalk.dim("tokens")} ${result.outputTokens} ${chalk.dim("total")} ${formatMs(result.durationMs)}`;
+	}
+	return `  ${chalk.red("✗")} ${prefix} ${chalk.red(truncateToWidth(replaceTabs(result.error).replace(/\r?\n/g, " "), ERROR_WIDTH))}`;
+}
+
+export function formatBenchTable(summary: BenchSummary): string {
+	const ranked = [...summary.models].sort((a, b) => {
+		if (a.average === null && b.average === null) return 0;
+		if (a.average === null) return 1;
+		if (b.average === null) return -1;
+		return b.average.tokensPerSecond - a.average.tokensPerSecond;
+	});
+	const rows = ranked.map(report => ({
+		model: formatBenchModelLabel(report),
+		ttft: report.average ? formatMs(report.average.ttftMs) : "-",
+		tps: report.average ? `${report.average.tokensPerSecond.toFixed(1)}/s` : "-",
+		tokens: report.average ? String(Math.round(report.average.outputTokens)) : "-",
+		total: report.average ? formatMs(report.average.durationMs) : "-",
+		failed: report.results.filter(result => !result.ok).length,
+	}));
+	const headers = { model: "model", ttft: "TTFT", tps: "TPS", tokens: "tokens", total: "total" } as const;
+	const width = (key: keyof typeof headers): number =>
+		Math.max(headers[key].length, ...rows.map(row => row[key].length));
+	const lines = [
+		[
+			headers.model.padEnd(width("model")),
+			headers.ttft.padEnd(width("ttft")),
+			headers.tps.padEnd(width("tps")),
+			headers.tokens.padEnd(width("tokens")),
+			headers.total.padEnd(width("total")),
+		]
+			.join("  ")
+			.trimEnd(),
+	];
+	for (const row of rows) {
+		const failedSuffix = row.failed > 0 ? `  ${chalk.red(`(${row.failed} failed)`)}` : "";
+		lines.push(
+			[
+				row.model.padEnd(width("model")),
+				row.ttft.padEnd(width("ttft")),
+				row.tps.padEnd(width("tps")),
+				row.tokens.padEnd(width("tokens")),
+				row.total.padEnd(width("total")),
+			]
+				.join("  ")
+				.trimEnd() + failedSuffix,
+		);
+	}
+	return `${lines.map((line, index) => (index === 0 ? chalk.dim(line) : line)).join("\n")}\n`;
+}
+
+async function createDefaultRuntime(): Promise<BenchRuntime> {
+	const authStorage = await discoverAuthStorage();
+	try {
+		const cwd = getProjectDir();
+		const settings = await Settings.init({ cwd });
+		const modelRegistry = new ModelRegistry(authStorage);
+		await loadCliExtensionProviders(modelRegistry, settings, cwd);
+		return {
+			modelRegistry,
+			settings,
+			close: () => authStorage.close(),
+		};
+	} catch (error) {
+		authStorage.close();
+		throw error;
+	}
+}
+
+interface BenchTarget {
+	selector: string;
+	model: Model<Api>;
+	thinking: ResolvedThinkingLevel | undefined;
+}
+
+/** Highest-priority provider variant: native/OAuth transports outrank mirrors. */
+function pickHighestPriorityProvider(models: Model<Api>[], providerOrder?: readonly string[]): Model<Api> | undefined {
+	if (models.length <= 1) return models[0];
+	const priority = buildModelProviderPriorityRank(providerOrder);
+	return [...models].sort((a, b) => {
+		const aRank = priority.get(a.provider.toLowerCase()) ?? Number.POSITIVE_INFINITY;
+		const bRank = priority.get(b.provider.toLowerCase()) ?? Number.POSITIVE_INFINITY;
+		return aRank - bRank;
+	})[0];
+}
+
+/**
+ * Bench resolves selectors against the entire catalog (credentials are ignored),
+ * so an ambiguous id shared by several providers can land on one the user never
+ * authenticated. For non-pinned selectors, redirect to an equivalent model under
+ * a provider with configured auth. An explicit `provider/id` selector is honored
+ * verbatim — even unauthenticated — so forced benchmarking keeps working.
+ */
+function resolveAuthenticatedAlternative(
+	selector: string,
+	model: Model<Api>,
+	modelRegistry: BenchModelRegistry,
+	providerOrder?: readonly string[],
+): Model<Api> | undefined {
+	if (!modelRegistry.hasConfiguredAuth) return undefined;
+	// A pinned `provider/...` selector is authoritative; never redirect off it.
+	if (selector.trim().toLowerCase().startsWith(`${model.provider.toLowerCase()}/`)) return undefined;
+	if (modelRegistry.hasConfiguredAuth(model)) return undefined;
+
+	const seen = new Set<string>();
+	const authenticated: Model<Api>[] = [];
+	const consider = (candidate: Model<Api>): void => {
+		const key = `${candidate.provider}/${candidate.id}`;
+		if (seen.has(key)) return;
+		seen.add(key);
+		if (modelRegistry.hasConfiguredAuth?.(candidate)) authenticated.push(candidate);
+	};
+	// Canonical variants link the same logical model across providers even when
+	// ids differ (e.g. fireworks `gpt-oss-20b` <-> openrouter `openai/gpt-oss-20b`).
+	const canonicalId = modelRegistry.getCanonicalId?.(model);
+	if (canonicalId) {
+		for (const variant of modelRegistry.getCanonicalVariants?.(canonicalId) ?? []) consider(variant.model);
+	}
+	// Same-id fallback for entries outside the canonical index.
+	for (const candidate of modelRegistry.getAll()) {
+		if (candidate.id === model.id) consider(candidate);
+	}
+	return pickHighestPriorityProvider(authenticated, providerOrder);
+}
+
+function resolveBenchModels(
+	selectors: string[],
+	modelRegistry: BenchModelRegistry,
+	settings: Settings | undefined,
+	writeStderr: (text: string) => void,
+): BenchTarget[] {
+	const preferences = getModelMatchPreferences(settings);
+	const resolved: BenchTarget[] = [];
+	const errors: string[] = [];
+	for (const selector of selectors) {
+		const result = resolveCliModel({ cliModel: selector, modelRegistry, preferences });
+		if (result.error) {
+			errors.push(`${selector}: ${result.error}`);
+			continue;
+		}
+		if (!result.model) {
+			errors.push(`${selector}: model not found`);
+			continue;
+		}
+		if (result.warning) writeStderr(`${chalk.yellow(`Warning: ${result.warning}`)}\n`);
+		let model = result.model;
+		const authenticated = resolveAuthenticatedAlternative(selector, model, modelRegistry, preferences.providerOrder);
+		if (authenticated) {
+			writeStderr(
+				`${chalk.yellow(
+					`Warning: no credentials for "${model.provider}"; benchmarking ${formatModelString(authenticated)} instead. Pin "${formatModelString(model)}" to force it.`,
+				)}\n`,
+			);
+			model = authenticated;
+		}
+		resolved.push({
+			selector,
+			model,
+			thinking: resolveThinkingLevelForModel(model, result.thinkingLevel),
+		});
+	}
+	if (errors.length > 0) {
+		throw new Error(`Could not resolve ${errors.length === 1 ? "model" : "models"}:\n${errors.join("\n")}`);
+	}
+	return resolved;
+}
+
+export async function runBenchCommand(command: BenchCommandArgs, deps: BenchDependencies = {}): Promise<BenchSummary> {
+	const runs = normalizePositiveInteger("runs", command.flags.runs, DEFAULT_RUNS);
+	const maxTokens = normalizePositiveInteger("max-tokens", command.flags.maxTokens, DEFAULT_MAX_TOKENS);
+	const prompt = command.flags.prompt?.trim() || BENCH_PROMPT;
+	const json = command.flags.json === true;
+	const randomSessionId = deps.randomSessionId ?? (() => Bun.randomUUIDv7());
+	const writeStdout = deps.writeStdout ?? ((text: string) => process.stdout.write(text));
+	const writeStderr = deps.writeStderr ?? ((text: string) => process.stderr.write(text));
+	const setExitCode =
+		deps.setExitCode ??
+		((code: number) => {
+			process.exitCode = code;
+		});
+	const streamFn = deps.streamSimple ?? streamSimple;
+	const now = deps.now ?? (() => performance.now());
+	const interactive = deps.stdoutIsTTY ?? process.stdout.isTTY === true;
+	if (command.models.length === 0) {
+		throw new Error("Pass at least one model selector, e.g. `omp bench opus gpt-5.2`");
+	}
+
+	const runtime = await (deps.createRuntime ?? createDefaultRuntime)();
+	try {
+		const targets = resolveBenchModels(command.models, runtime.modelRegistry, runtime.settings, writeStderr);
+		const reports: BenchModelReport[] = [];
+		for (const { selector, model, thinking } of targets) {
+			if (!json) {
+				const resolvedModel = formatModelSelectorValue(formatModelString(model), thinking);
+				const resolvedNote = selector === resolvedModel ? "" : chalk.dim(` (${selector})`);
+				writeStdout(`${chalk.bold(resolvedModel)}${resolvedNote}\n`);
+			}
+			const results: BenchRunResult[] = [];
+			for (let index = 0; index < runs; index++) {
+				const sessionId = randomSessionId();
+				const initialKey = await runtime.modelRegistry.getApiKey(model, sessionId);
+				if (!initialKey) {
+					const failure: BenchRunFailure = {
+						ok: false,
+						error: `No credentials for provider "${model.provider}". Run \`omp\` and use /login, or set the provider API key.`,
+					};
+					results.push(failure);
+					if (!json) writeStdout(`${formatRunLine(failure, index, runs)}\n`);
+					break; // remaining runs would fail identically
+				}
+				if (!json && interactive) {
+					writeStdout(chalk.dim(`  … run ${index + 1}/${runs} streaming`));
+				}
+				const result = await runBenchRequest(
+					model,
+					{
+						apiKey: runtime.modelRegistry.resolver(model, sessionId),
+						sessionId,
+						prompt,
+						maxTokens,
+						reasoning: toReasoningEffort(thinking),
+						disableReasoning: shouldDisableReasoning(thinking) ? true : undefined,
+					},
+					streamFn,
+					now,
+				);
+				results.push(result);
+				if (!json) {
+					if (interactive) writeStdout("\r\x1b[2K");
+					writeStdout(`${formatRunLine(result, index, runs)}\n`);
+				}
+			}
+			reports.push(buildModelReport(selector, model, thinking, results));
+		}
+		const failures = reports.reduce((sum, report) => sum + report.results.filter(result => !result.ok).length, 0);
+		const summary: BenchSummary = { runs, maxTokens, models: reports, failures };
+		if (json) {
+			writeStdout(`${JSON.stringify(summary, null, 2)}\n`);
+		} else if (reports.length > 1 || runs > 1) {
+			writeStdout(`\n${formatBenchTable(summary)}`);
+		}
+		if (failures > 0) setExitCode(1);
+		return summary;
+	} finally {
+		runtime.close?.();
+	}
+}

package/src/cli/classify-install-target.ts

@@ -0,0 +1,76 @@
+/**
+ * Classify an install spec as a local path, marketplace plugin reference, or
+ * plain npm package.
+ *
+ * Rules (applied in order):
+ *  0. Looks like a filesystem path (`.`, `..`, `./…`, `..\…`, `/…`, `~/…`,
+ *     `C:\…`, `\\unc`) -> local. Routed through `PluginManager.link()` so the
+ *     `omp plugin install <path>` and `omp plugin link <path>` flows agree.
+ *  1. Starts with `@` (scoped npm) -> always npm.
+ *  2. Contains `@` after the first character -> split on the LAST `@`.
+ *     If the right-hand side is a known marketplace name, it's a marketplace ref.
+ *     Otherwise it's an npm spec (e.g. `pkg@1.2.3`).
+ *  3. No `@` -> npm.
+ */
+// Common npm dist-tags that should never be interpreted as marketplace names
+const NPM_DIST_TAGS = new Set([
+	"latest",
+	"next",
+	"beta",
+	"alpha",
+	"canary",
+	"rc",
+	"dev",
+	"stable",
+	"nightly",
+	"experimental",
+]);
+
+// Semver-like: starts with digit, or contains version range prefixes
+const LOOKS_LIKE_VERSION = /^[\d~^>=<]/;
+
+/**
+ * Detect specs that name a filesystem path rather than a package: bare `.` /
+ * `..`, cwd-relative (`./`, `../`, `.\`, `..\`), absolute (`/`, `C:\`, `C:/`,
+ * UNC `\\`), and tilde-prefixed (`~`, `~/`, `~\`). Tilde paths still rely on
+ * the shell or the caller for expansion — we only classify them so they reach
+ * the link path instead of npm-name validation.
+ */
+function isLocalPathSpec(spec: string): boolean {
+	if (spec === "." || spec === ".." || spec === "~") return true;
+	if (spec.startsWith("./") || spec.startsWith("../")) return true;
+	if (spec.startsWith(".\\") || spec.startsWith("..\\")) return true;
+	if (spec.startsWith("~/") || spec.startsWith("~\\")) return true;
+	if (spec.startsWith("/")) return true;
+	if (spec.startsWith("\\\\")) return true;
+	if (/^[A-Za-z]:[\\/]/.test(spec)) return true;
+	return false;
+}
+
+export type ClassifiedInstallTarget =
+	| { type: "local"; path: string }
+	| { type: "marketplace"; name: string; marketplace: string }
+	| { type: "npm"; spec: string };
+
+export function classifyInstallTarget(spec: string, knownMarketplaces: Set<string>): ClassifiedInstallTarget {
+	// Rule 0: filesystem path — bypass npm/marketplace validation entirely.
+	if (isLocalPathSpec(spec)) return { type: "local", path: spec };
+	// Rule 1: scoped npm package — @ at position 0 is never a marketplace separator.
+	if (spec.startsWith("@")) return { type: "npm", spec };
+	// Rule 2: @ somewhere after the first character.
+	const atIdx = spec.lastIndexOf("@");
+	if (atIdx > 0) {
+		const rhs = spec.slice(atIdx + 1);
+		// Dist-tags and version specifiers are never marketplace names.
+		if (NPM_DIST_TAGS.has(rhs) || LOOKS_LIKE_VERSION.test(rhs)) {
+			return { type: "npm", spec };
+		}
+		if (knownMarketplaces.has(rhs)) {
+			return { type: "marketplace", name: spec.slice(0, atIdx), marketplace: rhs };
+		}
+		// Not a known marketplace — treat as npm version specifier.
+		return { type: "npm", spec };
+	}
+	// Rule 3: no @ at all.
+	return { type: "npm", spec };
+}