om-memory-system 3.3.0-next.18 → 3.4.0-next.20

package/dist/services/capture-diagnostics.d.ts

@@ -52,6 +52,14 @@ export declare function getTraceDirectory(): string;
  * that do not match the trace name pattern are never touched.
  */
 export declare function pruneTraces(config: CaptureDiagnosticsConfig, now?: Date): number;
+type WindowsAclRunner = (command: string, args: string[], options: {
+    env: NodeJS.ProcessEnv;
+    timeout: number;
+    windowsHide: boolean;
+    stdio: "ignore";
+}) => void;
+/** Restrict a trace path to the current user on both Windows and POSIX. */
+export declare function protectTracePath(path: string, mode: number, platform?: NodeJS.Platform, run?: WindowsAclRunner): void;
 /**
  * Append one trace entry to the day's JSON Lines file. A single append per
  * entry keeps lines whole when Pi and OpenCode write at the same time.
@@ -64,3 +72,4 @@ export declare function writeTraceEntry(record: CaptureAttemptRecord, diagnostic
 export declare function emitCaptureAttempt(record: CaptureAttemptRecord, diagnostics: CaptureAttemptDiagnostics, config: CaptureDiagnosticsConfig, now?: Date): void;
 /** Test hook: forget which day the last trace was written. */
 export declare function resetTraceStateForTests(): void;
+export {};

package/dist/services/capture-diagnostics.js

@@ -1,4 +1,5 @@
-import { appendFileSync, chmodSync, existsSync, mkdirSync, readdirSync, unlinkSync } from "fs";
+import { execFileSync } from "node:child_process";
+import { appendFileSync, chmodSync, existsSync, lstatSync, mkdirSync, readdirSync, unlinkSync, } from "fs";
 import { join } from "path";
 import { getLogDirPath } from "./log-path.js";
 import { log } from "./logger.js";
@@ -112,6 +113,54 @@ export function pruneTraces(config, now = new Date()) {
     return removed;
 }
 let lastTraceDate = null;
+const WINDOWS_TRACE_ACL = `$ErrorActionPreference = 'Stop'
+$path = $env:OMMS_TRACE_ACL_PATH
+$isDirectory = [System.IO.Directory]::Exists($path)
+$acl = if ($isDirectory) {
+  [System.IO.Directory]::GetAccessControl($path)
+} else {
+  [System.IO.File]::GetAccessControl($path)
+}
+$currentUser = [System.Security.Principal.WindowsIdentity]::GetCurrent().User
+$owner = $acl.GetOwner([System.Security.Principal.SecurityIdentifier])
+if ($owner.Value -ne $currentUser.Value) {
+  throw 'Trace path has a different owner'
+}
+$acl.SetAccessRuleProtection($true, $false)
+foreach ($rule in @($acl.Access)) {
+  [void]$acl.RemoveAccessRuleSpecific($rule)
+}
+$inheritance = if ($isDirectory) {
+  [System.Security.AccessControl.InheritanceFlags]'ContainerInherit, ObjectInherit'
+} else {
+  [System.Security.AccessControl.InheritanceFlags]::None
+}
+$rule = [System.Security.AccessControl.FileSystemAccessRule]::new(
+  $currentUser,
+  [System.Security.AccessControl.FileSystemRights]::FullControl,
+  $inheritance,
+  [System.Security.AccessControl.PropagationFlags]::None,
+  [System.Security.AccessControl.AccessControlType]::Allow
+)
+$acl.AddAccessRule($rule)
+if ($isDirectory) {
+  [System.IO.Directory]::SetAccessControl($path, $acl)
+} else {
+  [System.IO.File]::SetAccessControl($path, $acl)
+}`;
+/** Restrict a trace path to the current user on both Windows and POSIX. */
+export function protectTracePath(path, mode, platform = process.platform, run = execFileSync) {
+    if (platform !== "win32") {
+        chmodSync(path, mode);
+        return;
+    }
+    run("powershell.exe", ["-NoProfile", "-NonInteractive", "-Command", WINDOWS_TRACE_ACL], {
+        env: { ...process.env, OMMS_TRACE_ACL_PATH: path },
+        timeout: 10_000,
+        windowsHide: true,
+        stdio: "ignore",
+    });
+}
 /**
  * Append one trace entry to the day's JSON Lines file. A single append per
  * entry keeps lines whole when Pi and OpenCode write at the same time.
@@ -125,7 +174,18 @@ export function writeTraceEntry(record, diagnostics, config, now = new Date()) {
         }
         const dir = getTraceDirectory();
         mkdirSync(dir, { recursive: true, mode: 0o700 });
-        chmodSync(dir, 0o700);
+        if (!lstatSync(dir).isDirectory())
+            throw new Error("Trace directory is not a real directory");
+        protectTracePath(dir, 0o700);
+        const dailyFile = `capture-${today}.jsonl`;
+        for (const name of readdirSync(dir)) {
+            if (!TRACE_FILE.test(name) || name === dailyFile)
+                continue;
+            const retained = join(dir, name);
+            if (!lstatSync(retained).isFile())
+                throw new Error("Trace path is not a regular file");
+            protectTracePath(retained, 0o600);
+        }
         const redact = (value) => value === undefined ? null : redactTraceText(value, config);
         const entry = {
             schemaVersion: TRACE_SCHEMA_VERSION,
@@ -135,11 +195,18 @@ export function writeTraceEntry(record, diagnostics, config, now = new Date()) {
             userPrompt: redact(diagnostics.userPrompt),
             reply: redact(diagnostics.rawReply),
         };
-        const file = join(dir, `capture-${today}.jsonl`);
+        const file = join(dir, dailyFile);
+        const existingFile = lstatSync(file, { throwIfNoEntry: false });
+        if (existingFile && !existingFile.isFile())
+            throw new Error("Trace path is not a regular file");
+        // Narrow an existing file before appending sensitive content.
+        const existingWindowsFile = process.platform === "win32" && Boolean(existingFile);
+        if (existingWindowsFile)
+            protectTracePath(file, 0o600);
         appendFileSync(file, `${JSON.stringify(entry)}\n`, { mode: 0o600 });
-        // The mode above applies only when the append creates the file; a file
-        // that already existed with wider permissions is narrowed here.
-        chmodSync(file, 0o600);
+        // A new Windows file inherits the private directory ACL until this call.
+        if (!existingWindowsFile)
+            protectTracePath(file, 0o600);
     }
     catch (error) {
         log("Capture trace write failed", { code: errorCode(error) });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "om-memory-system",
-  "version": "3.3.0-next.18",
+  "version": "3.4.0-next.20",
   "description": "Opinionated modular memory system for coding agents (OpenCode + Pi)",
   "type": "module",
   "main": "dist/plugin.js",