okstra 0.228.1 → 0.228.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/docs/architecture/storage-model.md +9 -0
- package/package.json +1 -1
- package/runtime/BUILD.json +2 -2
- package/runtime/python/okstra_ctl/code_review_coverage.py +3 -2
- package/runtime/python/okstra_ctl/qa_commands.py +6 -0
- package/runtime/python/okstra_ctl/verification_inputs.py +1 -1
- package/runtime/skills/okstra-code-review/references/review-calibration.md +2 -2
|
@@ -89,6 +89,15 @@ remains readable and is not retrofitted. Snapshot publication and reference chec
|
|
|
89
89
|
are covered by `tests/run/test_project_qa_command_gate.py` and
|
|
90
90
|
`tests/application/test_host_orchestration_render.py`.
|
|
91
91
|
|
|
92
|
+
QA declarations retain the optional `language` selector for the verifier's existing
|
|
93
|
+
diff-language skip policy. An absent selector remains absent and means always run.
|
|
94
|
+
Present selectors must be non-empty identifiers using letters, digits, `.`, `_`,
|
|
95
|
+
`+`, `#` or `-`, beginning with a letter or digit. The shared QA metadata validator
|
|
96
|
+
checks their shape during declaration loading and snapshot reading.
|
|
97
|
+
Changing a selector cannot replace a published snapshot. Frozen selectors remain
|
|
98
|
+
visible after current project settings change. The declaration immutability,
|
|
99
|
+
allowed-field and projection tests in `test_project_qa_command_gate.py` cover this.
|
|
100
|
+
|
|
92
101
|
These declarations do not prove that a command ran. Preparation does not require
|
|
93
102
|
future inspection scripts to exist, and execution receipts are a separate contract.
|
|
94
103
|
|
package/package.json
CHANGED
package/runtime/BUILD.json
CHANGED
|
@@ -83,11 +83,12 @@ def _keyed_values(text: str) -> dict[str, str]:
|
|
|
83
83
|
values: dict[str, str] = {}
|
|
84
84
|
if text == "-":
|
|
85
85
|
return values
|
|
86
|
-
|
|
86
|
+
# Reviewers write prose reasons; only a semicolon before the next `RULE=` separates assignments.
|
|
87
|
+
for entry in re.split(r";(?=\s*[A-Z][A-Z0-9]*=)", text):
|
|
87
88
|
key, separator, value = entry.partition("=")
|
|
88
89
|
key, value = key.strip(), value.strip()
|
|
89
90
|
if not separator or not key or not value or key in values:
|
|
90
|
-
raise ValueError("empty or duplicate rule assignment")
|
|
91
|
+
raise ValueError(f"empty or duplicate rule assignment: {entry.strip()!r}")
|
|
91
92
|
values[key] = value
|
|
92
93
|
return values
|
|
93
94
|
|
|
@@ -241,6 +241,12 @@ def validate_qa_commands(qa: object) -> list[str]:
|
|
|
241
241
|
|
|
242
242
|
def qa_metadata_errors(entry: Mapping[str, object], seen_ids: set[str]) -> list[str]:
|
|
243
243
|
errors: list[str] = []
|
|
244
|
+
language = entry.get("language")
|
|
245
|
+
if "language" in entry and (
|
|
246
|
+
not isinstance(language, str)
|
|
247
|
+
or not re.fullmatch(r"[A-Za-z0-9][A-Za-z0-9._+#-]*", language)
|
|
248
|
+
):
|
|
249
|
+
errors.append("language must be a non-empty language identifier")
|
|
244
250
|
identifier = entry.get("id")
|
|
245
251
|
if identifier is not None:
|
|
246
252
|
if not isinstance(identifier, str) or not re.fullmatch(
|
|
@@ -63,11 +63,11 @@ Return one compact Coverage Verdicts row per cell under `## Coverage Verdicts`.
|
|
|
63
63
|
| C-CR-0003 | - | T1=no state mutation; T2=non-test source; T3=non-test source; T4=no tests or new branches | - | src/orders/schema.py:1 |
|
|
64
64
|
```
|
|
65
65
|
|
|
66
|
-
The example uses the base structural and state-and-tests catalogs. `Checked` means inspected and no actionable finding for those rules. A criterion includes all applicable subconditions in its references; one inapplicable subcondition does not make the entire criterion N/A. Explicitly list the IDs; `all`, counts and ID ranges are not verdicts. `N/A` assigns `rule=reason`; `Findings` assigns `rule=finding-id`. Separate assignments with semicolons and multiple finding IDs for one rule with commas. Use `-` for an empty field. Every expected rule appears exactly once across the three status fields. Never infer an omitted rule as clean.
|
|
66
|
+
The example uses the base structural and state-and-tests catalogs. `Checked` means inspected and no actionable finding for those rules. A criterion includes all applicable subconditions in its references; one inapplicable subcondition does not make the entire criterion N/A. Explicitly list the IDs; `all`, counts and ID ranges are not verdicts. `N/A` assigns `rule=reason`; `Findings` assigns `rule=finding-id`. Separate assignments with semicolons and multiple finding IDs for one rule with commas. Only a semicolon followed by the next `RULE=` starts a new assignment; a semicolon inside a reason stays part of that reason. Use `-` for an empty field. Every expected rule appears exactly once across the three status fields. Never infer an omitted rule as clean.
|
|
67
67
|
|
|
68
68
|
Every row supplies one literal repository-relative source `path:line` for that cell's target file. The citation may be backtick-quoted and followed by ` — ` and a short observation before any ` :: ` rule observations. Do not substitute a rule-pack citation such as `cc:5`, a global alias such as `E01`, or another target's path. The checker verifies that the file and line exist inside the project. Additional definitions and evidence remain in finding bodies.
|
|
69
69
|
|
|
70
|
-
For `general` cells, checked G2, G3 and G5 each carry a compact observation in that same Evidence field: `target/path:line :: G2=source/path:line observed outcome mapping; G3=source/path:line observed workload and bound; G5=source/path:line applicable clauses and observed conformance`. Each observation begins with an existing project-source citation; it may cite a relevant callee. Keep rule-pack references in the catalog or the observation text, not in the project-source citation slot. Separate assignments with semicolons;
|
|
70
|
+
For `general` cells, checked G2, G3 and G5 each carry a compact observation in that same Evidence field: `target/path:line :: G2=source/path:line observed outcome mapping; G3=source/path:line observed workload and bound; G5=source/path:line applicable clauses and observed conformance`. Each observation begins with an existing project-source citation; it may cite a relevant callee. Keep rule-pack references in the catalog or the observation text, not in the project-source citation slot. Separate assignments with semicolons; the same `RULE=` boundary applies, so a semicolon inside an observation stays part of it. Findings and reasoned N/A already explain their criteria and need no duplicate clean observation.
|
|
71
71
|
|
|
72
72
|
For example, `jobs/dispatch.py:18 :: G2=jobs/client.py:25 returned states preserve the dependency outcomes; G3=jobs/dispatch.py:9 validated batch limit bounds work before parsing; G5=jobs/dispatch.py:18 public typing and exception-chaining clauses hold` records three observations in one row. `checked`, `clean` and `no issues` alone are verdict labels, not observations. The checker rejects missing observations, notes for unchecked criteria, aliases and invalid source locations. It cannot establish whether a written observation is true.
|
|
73
73
|
|