okstra 0.186.7 → 0.187.0

package/runtime/validators/lib/runners.sh

@@ -1,5 +1,10 @@
 # shellcheck shell=bash
 
+# 이 lib 은 단독으로 source 될 수 있다(계약 테스트가 그렇게 부른다). checks
+# 경로 계산은 common.sh 한 곳에만 두고, 없으면 여기서 채운다.
+# shellcheck source=common.sh
+[ -n "${OKSTRA_VALIDATOR_CHECKS:-}" ] || . "$(cd -P "$(dirname "${BASH_SOURCE[0]}")" && pwd)/common.sh"
+
 run_okstra() {
   local task_group="$1"
   local task_id="$2"
@@ -41,108 +46,5 @@ run_validator_expectation() {
 
   expected_task_manifest_relative_path="$(task_manifest_relative_path "$task_group" "$task_id")"
 
-  python3 - "$PROJECT_ROOT" "$expected_task_manifest_relative_path" "$RUN_VALIDATOR_PATH" "$expected_status" "$expected_failure_substring" <<'PY'
-from pathlib import Path
-import json
-import subprocess
-import sys
-
-project_root = Path(sys.argv[1])
-task_manifest_path = project_root / sys.argv[2]
-validator_script = Path(sys.argv[3])
-expected_status = sys.argv[4]
-expected_failure_substring = sys.argv[5]
-
-task_manifest = json.loads(task_manifest_path.read_text())
-timeline_path = project_root / task_manifest["historyTimelinePath"]
-timeline = json.loads(timeline_path.read_text())
-runs = timeline.get("runs", [])
-latest_run = None
-if isinstance(runs, list):
-    for item in reversed(runs):
-        if isinstance(item, dict):
-            latest_run = item
-            break
-
-if latest_run is None:
-    raise SystemExit("timeline does not contain a latest run entry")
-
-run_manifest_path = project_root / latest_run["runManifestPath"]
-run_manifest = json.loads(run_manifest_path.read_text())
-team_state_path = project_root / run_manifest["teamStatePath"]
-report_path = project_root / run_manifest["expectedReportRecordPath"]
-final_status_path = project_root / run_manifest["expectedStatusPath"]
-
-process = subprocess.run(
-    [
-        sys.executable,
-        str(validator_script),
-        "--team-state",
-        str(team_state_path),
-        "--report",
-        str(report_path),
-        "--run-manifest",
-        str(run_manifest_path),
-        "--task-manifest",
-        str(task_manifest_path),
-        "--final-status",
-        str(final_status_path),
-        # session-conformance 주입 시드 — prepare_run_validator_fixture 가
-        # 만든 합성 lead jsonl 디렉터리 (실제 ~/.claude/projects 미오염).
-        "--claude-projects-dir",
-        str(project_root / ".claude-projects-fixture"),
-    ],
-    capture_output=True,
-    text=True,
-)
-
-if not process.stdout.strip():
-    raise SystemExit("validator did not produce JSON output")
-
-payload = json.loads(process.stdout)
-actual_status = payload.get("validationStatus")
-if actual_status != expected_status:
-    extra = ""
-    if expected_status == "passed":
-        listed = payload.get("failures") or []
-        extra = "\n" + "\n".join(str(item) for item in listed)
-    raise SystemExit(
-        f"validator status mismatch: expected {expected_status}, got {actual_status}{extra}"
-    )
-
-if expected_status == "passed" and process.returncode != 0:
-    raise SystemExit(f"validator returned non-zero on success: {process.stderr}")
-if expected_status == "failed" and process.returncode == 0:
-    raise SystemExit("validator unexpectedly succeeded")
-
-if expected_failure_substring:
-    failures = payload.get("failures", [])
-    if not isinstance(failures, list) or not any(
-        expected_failure_substring in str(item) for item in failures
-    ):
-        raise SystemExit(
-            f"validator failure output did not include expected text: {expected_failure_substring}"
-        )
-
-if not final_status_path.is_file():
-    raise SystemExit(f"validator did not write final status file: {final_status_path}")
-
-final_status = final_status_path.read_text().strip()
-expected_final_status = "completed" if expected_status == "passed" else "contract-violated"
-if final_status != expected_final_status:
-    raise SystemExit(
-        f"final status file mismatch: expected {expected_final_status}, got {final_status}"
-    )
-
-updated_run_manifest = json.loads(run_manifest_path.read_text())
-updated_task_manifest = json.loads(task_manifest_path.read_text())
-updated_team_state = json.loads(team_state_path.read_text())
-
-if updated_run_manifest.get("validation", {}).get("status") != expected_status:
-    raise SystemExit("run manifest validation status was not updated correctly")
-if updated_task_manifest.get("contractValidation", {}).get("status") != expected_status:
-    raise SystemExit("task manifest validation status was not updated correctly")
-if updated_team_state.get("validator", {}).get("status") != expected_status:
-    raise SystemExit("team-state validator status was not updated correctly")
-PY
+  python3 "$OKSTRA_VALIDATOR_CHECKS/runners-01.py" "$PROJECT_ROOT" "$expected_task_manifest_relative_path" "$RUN_VALIDATOR_PATH" "$expected_status" "$expected_failure_substring"
 }

package/runtime/validators/lib/summary.sh

@@ -10,6 +10,6 @@ Validation completed successfully.
 - Primary task root: $(task_root "$PRIMARY_TASK_GROUP" "$PRIMARY_TASK_ID")
 - Secondary task root: $(task_root "$SECONDARY_TASK_GROUP" "$SECONDARY_TASK_ID")
 
-You can inspect the generated artifacts directly under the validation root.
+The default validation root is removed on success; set OKSTRA_VALIDATION_PROJECT_ROOT to keep the artifacts for inspection.
 EOF
 }

package/runtime/validators/lib/validate-assets.sh

@@ -1,5 +1,10 @@
 # shellcheck shell=bash
 
+# 이 lib 은 단독으로 source 될 수 있다(계약 테스트가 그렇게 부른다). checks
+# 경로 계산은 common.sh 한 곳에만 두고, 없으면 여기서 채운다.
+# shellcheck source=common.sh
+[ -n "${OKSTRA_VALIDATOR_CHECKS:-}" ] || . "$(cd -P "$(dirname "${BASH_SOURCE[0]}")" && pwd)/common.sh"
+
 # Verify that the npm build output under `runtime/` is fresh and matches the
 # source files that `okstra install` (src/install.mjs) copies into the user's
 # `~/.claude/skills/`, `~/.claude/agents/`, and `~/.okstra/` directories.
@@ -20,60 +25,5 @@ validate_seeded_assets() {
     return 1
   fi
 
-  python3 - "$SOURCE_ASSET_ROOT" "$WORKSPACE_ROOT/skills" "$runtime_root" "$validation_mode" <<'PY'
-from pathlib import Path
-import sys
-
-agents_source_root = Path(sys.argv[1])      # <repo>/agents
-skills_source_root = Path(sys.argv[2])      # <repo>/skills
-runtime_root = Path(sys.argv[3])            # <repo>/runtime
-validation_mode = sys.argv[4]
-errors = []
-
-
-def check(source_path: Path, target_path: Path) -> None:
-    if not target_path.is_file():
-        errors.append(f"missing build-output asset: {target_path}")
-        return
-    if validation_mode == "match" and target_path.read_bytes() != source_path.read_bytes():
-        errors.append(f"build-output asset does not match source: {target_path}")
-
-
-# 1. Worker agent files: agents/workers/*-worker.md -> runtime/agents/workers/*-worker.md
-#
-workers_source = agents_source_root / "workers"
-workers_target = runtime_root / "agents" / "workers"
-if not workers_source.is_dir():
-    errors.append(f"missing agents/workers source directory: {workers_source}")
-else:
-    for source_path in sorted(workers_source.glob("*.md")):
-        check(source_path, workers_target / source_path.name)
-
-# 2. Lead contract + internal lead resources: prompts/lead/* + prompts/coding-preflight/*
-#    -> runtime/prompts/*. These ship as runtime resources (okstra install copies
-#    runtime/prompts -> ~/.okstra/prompts), no longer as agent skills.
-prompts_source_root = agents_source_root.parent / "prompts"
-for sub in ("lead", "coding-preflight"):
-    sub_root = prompts_source_root / sub
-    if not sub_root.is_dir():
-        errors.append(f"missing prompts source directory: {sub_root}")
-        continue
-    for source_path in sorted(sub_root.rglob("*.md")):
-        relative = source_path.relative_to(prompts_source_root)
-        check(source_path, runtime_root / "prompts" / relative)
-
-# 3. Skill packages: skills/<name>/SKILL.md -> runtime/skills/<name>/SKILL.md
-if not skills_source_root.is_dir():
-    errors.append(f"missing skills source directory: {skills_source_root}")
-else:
-    for skill_dir in sorted(p for p in skills_source_root.iterdir() if p.is_dir()):
-        for source_path in sorted(skill_dir.rglob("*.md")):
-            relative = source_path.relative_to(skills_source_root)
-            check(source_path, runtime_root / "skills" / relative)
-
-if errors:
-    for error in errors:
-        print(error, file=sys.stderr)
-    sys.exit(1)
-PY
+  python3 "$OKSTRA_VALIDATOR_CHECKS/validate-assets-01.py" "$SOURCE_ASSET_ROOT" "$WORKSPACE_ROOT/skills" "$runtime_root" "$validation_mode"
 }

package/runtime/validators/lib/validate-prompt-metadata.sh

@@ -1,5 +1,10 @@
 # shellcheck shell=bash
 
+# 이 lib 은 단독으로 source 될 수 있다(계약 테스트가 그렇게 부른다). checks
+# 경로 계산은 common.sh 한 곳에만 두고, 없으면 여기서 채운다.
+# shellcheck source=common.sh
+[ -n "${OKSTRA_VALIDATOR_CHECKS:-}" ] || . "$(cd -P "$(dirname "${BASH_SOURCE[0]}")" && pwd)/common.sh"
+
 validate_worker_prompt_metadata() {
   local task_group="$1"
   local task_id="$2"
@@ -7,261 +12,5 @@ validate_worker_prompt_metadata() {
 
   expected_task_manifest_relative_path="$(task_manifest_relative_path "$task_group" "$task_id")"
 
-  python3 - "$PROJECT_ROOT" "$expected_task_manifest_relative_path" <<'PY'
-from pathlib import Path
-import json
-import sys
-
-project_root = Path(sys.argv[1])
-task_manifest_path = project_root / sys.argv[2]
-errors = []
-
-
-def load_json(path: Path) -> dict:
-    return json.loads(path.read_text())
-
-
-def validate_prompt_contract(
-    prefix: str,
-    worker_ids: list[str],
-    prompt_dir: str,
-    prompt_map: object,
-    required_worker_roles: object,
-) -> None:
-    if not prompt_dir:
-        errors.append(f"{prefix} is missing worker prompt directory metadata")
-    if not isinstance(prompt_map, dict):
-        errors.append(f"{prefix} worker prompt map is missing or invalid")
-        prompt_map = {}
-    if not isinstance(required_worker_roles, list):
-        errors.append(f"{prefix} requiredWorkerRoles is missing or invalid")
-        required_worker_roles = []
-
-    expected_dir_prefix = prompt_dir.rstrip("/") + "/" if prompt_dir else ""
-    for worker_id in worker_ids:
-        if worker_id not in prompt_map:
-            errors.append(f"{prefix} worker prompt map is missing selected worker: {worker_id}")
-
-    for worker in required_worker_roles:
-        if not isinstance(worker, dict):
-            errors.append(f"{prefix} requiredWorkerRoles contains a non-object entry")
-            continue
-        worker_id = str(worker.get("workerId", "")).strip()
-        prompt_relative = str(worker.get("promptPath", "")).strip()
-        if not worker_id:
-            errors.append(f"{prefix} requiredWorkerRoles contains an entry without workerId")
-            continue
-        if not prompt_relative:
-            errors.append(
-                f"{prefix} required worker is missing promptPath: {worker_id}"
-            )
-            continue
-        if prompt_map.get(worker_id) != prompt_relative:
-            errors.append(
-                f"{prefix} worker prompt map does not match requiredWorkerRoles for {worker_id}"
-            )
-        if expected_dir_prefix and not prompt_relative.startswith(expected_dir_prefix):
-            errors.append(
-                f"{prefix} worker prompt path is outside the prompt directory: {prompt_relative}"
-            )
-
-
-if not task_manifest_path.is_file():
-    errors.append(f"task manifest is missing: {task_manifest_path}")
-else:
-    task_manifest = load_json(task_manifest_path)
-    selected_workers = task_manifest.get("recommendedWorkers", [])
-    if not isinstance(selected_workers, list):
-        errors.append("task manifest recommendedWorkers is missing or invalid")
-        selected_workers = []
-
-    task_prompt_dir = str(task_manifest.get("latestRunPromptsPath", "")).strip()
-    if not task_prompt_dir:
-        errors.append("task manifest is missing latestRunPromptsPath")
-
-    task_artifacts = task_manifest.get("artifacts", {})
-    if not isinstance(task_artifacts, dict):
-        errors.append("task manifest artifacts is missing or invalid")
-        task_artifacts = {}
-
-    validate_prompt_contract(
-        "task manifest",
-        selected_workers,
-        str(task_artifacts.get("workerPromptsDirectoryPath", "")).strip(),
-        task_artifacts.get("workerPromptPathByWorkerId"),
-        task_manifest.get("resultContract", {}).get("requiredWorkerRoles"),
-    )
-
-    if (
-        task_prompt_dir
-        and str(task_artifacts.get("workerPromptsDirectoryPath", "")).strip()
-        and task_prompt_dir
-        != str(task_artifacts.get("workerPromptsDirectoryPath", "")).strip()
-    ):
-        errors.append(
-            "task manifest latestRunPromptsPath does not match artifacts.workerPromptsDirectoryPath"
-        )
-
-    timeline_relative_path = str(
-        task_manifest.get("historyTimelinePath", "")
-    ).strip()
-    if not timeline_relative_path:
-        errors.append("task manifest is missing historyTimelinePath")
-    else:
-        timeline_path = project_root / timeline_relative_path
-        if not timeline_path.is_file():
-            errors.append(f"timeline file is missing: {timeline_path}")
-        else:
-            timeline = load_json(timeline_path)
-            runs = timeline.get("runs", [])
-            latest_run = None
-            if isinstance(runs, list):
-                for item in reversed(runs):
-                    if isinstance(item, dict):
-                        latest_run = item
-                        break
-            if latest_run is None:
-                errors.append("timeline does not contain a latest run entry")
-            else:
-                latest_run_prompt_dir = str(
-                    latest_run.get("workerPromptDirectoryPath", "")
-                ).strip()
-                if not latest_run_prompt_dir:
-                    errors.append(
-                        "latest timeline entry is missing workerPromptDirectoryPath"
-                    )
-                if task_prompt_dir and latest_run_prompt_dir and task_prompt_dir != latest_run_prompt_dir:
-                    errors.append(
-                        "timeline latest run prompt directory does not match task manifest latestRunPromptsPath"
-                    )
-                prompt_map = latest_run.get("workerPromptPathByWorkerId")
-                if not isinstance(prompt_map, dict):
-                    errors.append(
-                        "latest timeline entry is missing workerPromptPathByWorkerId"
-                    )
-                else:
-                    for worker_id in selected_workers:
-                        if worker_id not in prompt_map:
-                            errors.append(
-                                f"latest timeline entry is missing worker prompt path for {worker_id}"
-                            )
-
-                run_manifest_relative_path = str(
-                    latest_run.get("runManifestPath", "")
-                ).strip()
-                if not run_manifest_relative_path:
-                    errors.append(
-                        "latest timeline entry is missing runManifestPath"
-                    )
-                else:
-                    run_manifest_path = project_root / run_manifest_relative_path
-                    if not run_manifest_path.is_file():
-                        errors.append(f"latest run manifest is missing: {run_manifest_path}")
-                    else:
-                        run_manifest = load_json(run_manifest_path)
-                        run_prompt_dir = str(
-                            run_manifest.get("workerPromptsDirectoryPath", "")
-                        ).strip()
-                        if task_prompt_dir and run_prompt_dir and task_prompt_dir != run_prompt_dir:
-                            errors.append(
-                                "run manifest workerPromptsDirectoryPath does not match task manifest latestRunPromptsPath"
-                            )
-                        validate_prompt_contract(
-                            "run manifest",
-                            selected_workers,
-                            run_prompt_dir,
-                            run_manifest.get("workerPromptPathByWorkerId"),
-                            run_manifest.get("teamContract", {}).get("requiredWorkerRoles"),
-                        )
-
-                        team_state_relative_path = str(
-                            run_manifest.get("teamStatePath")
-                            or task_manifest.get("teamStatePath", "")
-                        ).strip()
-                        if not team_state_relative_path:
-                            errors.append(
-                                "team state relative path is missing from run/task manifest"
-                            )
-                        else:
-                            team_state_path = project_root / team_state_relative_path
-                            if not team_state_path.is_file():
-                                errors.append(f"team-state file is missing: {team_state_path}")
-                            else:
-                                team_state = load_json(team_state_path)
-                                team_artifacts = team_state.get("artifacts", {})
-                                if not isinstance(team_artifacts, dict):
-                                    errors.append(
-                                        "team-state artifacts is missing or invalid"
-                                    )
-                                    team_artifacts = {}
-                                team_prompt_dir = str(
-                                    team_artifacts.get(
-                                        "workerPromptsDirectoryPath", ""
-                                    )
-                                ).strip()
-                                if run_prompt_dir and team_prompt_dir and run_prompt_dir != team_prompt_dir:
-                                    errors.append(
-                                        "team-state worker prompt directory does not match run manifest"
-                                    )
-                                workers = team_state.get("workers", [])
-                                if not isinstance(workers, list):
-                                    errors.append("team-state workers is missing or invalid")
-                                else:
-                                    team_workers = {}
-                                    for worker in workers:
-                                        if not isinstance(worker, dict):
-                                            errors.append(
-                                                "team-state workers contains a non-object entry"
-                                            )
-                                            continue
-                                        worker_id = str(worker.get("workerId", "")).strip()
-                                        if not worker_id:
-                                            errors.append(
-                                                "team-state workers contains an entry without workerId"
-                                            )
-                                            continue
-                                        team_workers[worker_id] = worker
-
-                                    run_prompt_map = run_manifest.get(
-                                        "workerPromptPathByWorkerId", {}
-                                    )
-                                    if not isinstance(run_prompt_map, dict):
-                                        run_prompt_map = {}
-
-                                    for worker_id in selected_workers:
-                                        worker = team_workers.get(worker_id)
-                                        if worker is None:
-                                            errors.append(
-                                                f"team-state is missing selected worker entry: {worker_id}"
-                                            )
-                                            continue
-                                        prompt_relative = str(
-                                            worker.get("promptPath", "")
-                                        ).strip()
-                                        if not prompt_relative:
-                                            errors.append(
-                                                f"team-state worker is missing promptPath: {worker_id}"
-                                            )
-                                            continue
-                                        if run_prompt_map.get(worker_id) != prompt_relative:
-                                            errors.append(
-                                                f"team-state worker prompt path does not match run manifest for {worker_id}"
-                                            )
-                                        expected_dir_prefix = (
-                                            run_prompt_dir.rstrip("/") + "/"
-                                            if run_prompt_dir
-                                            else ""
-                                        )
-                                        if expected_dir_prefix and not prompt_relative.startswith(
-                                            expected_dir_prefix
-                                        ):
-                                            errors.append(
-                                                f"team-state worker prompt path is outside the run prompt directory: {prompt_relative}"
-                                            )
-
-if errors:
-    for error in errors:
-        print(error, file=sys.stderr)
-    sys.exit(1)
-PY
+  python3 "$OKSTRA_VALIDATOR_CHECKS/validate-prompt-metadata-01.py" "$PROJECT_ROOT" "$expected_task_manifest_relative_path"
 }