okengine 0.6.1 → 0.8.0

package/src/runtime/dev-request-log.test.ts

@@ -3,7 +3,11 @@
  */
 
 import { afterEach, describe, expect, test } from "bun:test";
-import { isSilentDevRequest, shouldLogDevRequests } from "./dev-request-log.ts";
+import {
+  failureDetailFromResponse,
+  isSilentDevRequest,
+  shouldLogDevRequests,
+} from "./dev-request-log.ts";
 
 describe("dev-request-log", () => {
   const prev = process.env.OKE_DEV_REQUEST_LOG;
@@ -27,4 +31,19 @@ describe("dev-request-log", () => {
     expect(isSilentDevRequest("GET", "/_oke/client.json")).toBe(true);
     expect(isSilentDevRequest("POST", "/console/flows")).toBe(false);
   });
+
+  test("failureDetailFromResponse reads error.message from envelope", async () => {
+    const res = Response.json(
+      {
+        data: null,
+        error: {
+          code: "ClaimFailed",
+          data: { reason: "password_policy" },
+          message: "Password needs at least 12 characters, including a letter and a number.",
+        },
+      },
+      { status: 400 },
+    );
+    expect(await failureDetailFromResponse(res)).toMatch(/12 characters/);
+  });
 });

package/src/runtime/dev-request-log.ts

@@ -52,6 +52,8 @@ export type DevRequestLogInput = {
   readonly flow?: string;
   readonly status: number;
   readonly ms: number;
+  /** Human failure detail (error.message / code) for 4xx/5xx. */
+  readonly detail?: string;
 };
 
 /**
@@ -70,6 +72,39 @@ export function isSilentDevRequest(method: string, path: string): boolean {
   return /\.(?:js|css|map|svg|png|ico|woff2?|ttf|webp)$/i.test(path);
 }
 
+/**
+ * Extract a short failure detail from an OKE JSON envelope body.
+ *
+ * @param response - HTTP response (cloned; original body stays readable)
+ */
+export async function failureDetailFromResponse(response: Response): Promise<string | undefined> {
+  if (response.status < 400) return undefined;
+  try {
+    const body: unknown = await response.clone().json();
+    if (body === null || typeof body !== "object" || !("error" in body)) return undefined;
+    const error = (body as { error: unknown }).error;
+    if (error === null || typeof error !== "object") return undefined;
+    const rec = error as { message?: unknown; code?: unknown; data?: unknown };
+    if (typeof rec.message === "string" && rec.message.trim().length > 0) {
+      return rec.message.trim();
+    }
+    if (
+      rec.data !== null &&
+      typeof rec.data === "object" &&
+      "reason" in rec.data &&
+      typeof (rec.data as { reason: unknown }).reason === "string"
+    ) {
+      const reason = (rec.data as { reason: string }).reason;
+      const code = typeof rec.code === "string" ? rec.code : "Error";
+      return `${code}: ${reason}`;
+    }
+    if (typeof rec.code === "string") return rec.code;
+  } catch {
+    // non-JSON error bodies stay status-only
+  }
+  return undefined;
+}
+
 /**
  * Print one request line when {@link shouldLogDevRequests} is on.
  *
@@ -86,6 +121,7 @@ export function logDevRequest(input: DevRequestLogInput): void {
       flow: input.flow,
       status: input.status,
       ms: input.ms,
+      detail: input.detail,
     }),
   );
 }
@@ -115,6 +151,7 @@ export async function timedDevFetch(
   const url = new URL(request.url);
   const method = request.method.toUpperCase();
   const response = await handle(request);
+  const detail = await failureDetailFromResponse(response);
   logDevRequest({
     surface: options.surface ?? currentDevSurface(),
     method,
@@ -122,6 +159,7 @@ export async function timedDevFetch(
     flow: options.resolveFlow?.(request, response),
     status: response.status,
     ms: Math.round(performance.now() - started),
+    detail,
   });
   return response;
 }

package/src/term.test.ts

@@ -125,6 +125,21 @@ describe("term", () => {
     expect(out).not.toMatch(/\u001b\[/);
   });
 
+  test("formatRequestLine prints failure detail under 4xx/5xx", () => {
+    const out = formatRequestLine({
+      surface: "Console",
+      method: "POST",
+      path: "/console/setup/claim",
+      flow: "console.setup.claim",
+      status: 400,
+      ms: 1,
+      detail: "Password needs at least 12 characters, including a letter and a number.",
+      color: false,
+    });
+    expect(out).toContain("400");
+    expect(out).toContain("↳ Password needs at least 12 characters");
+  });
+
   test("formatStackSummary is scannable", () => {
     const out = formatStackSummary({
       project: "oke-dev-a3f791",

package/src/term.ts

@@ -300,6 +300,8 @@ export function formatRequestLine(options: {
   /** Instant for date/time columns (default now). */
   readonly at?: Date;
   readonly color?: boolean;
+  /** Failure detail printed on a follow-up line (4xx/5xx). */
+  readonly detail?: string;
 }): string {
   const s = termStyle(options.color ?? termColorEnabled());
   const at = options.at ?? new Date();
@@ -323,7 +325,7 @@ export function formatRequestLine(options: {
   const path = options.path.length > 28 ? `${options.path.slice(0, 27)}…` : options.path.padEnd(28);
   const flow = (options.flow ?? "—").padEnd(22);
   const ms = `${options.ms}ms`.padStart(6);
-  return (
+  const main =
     `${surfaceColor}●${s.reset}  ` +
     `${surfaceColor}${options.surface.padEnd(7)}${s.reset}  ` +
     `${methodColor}${method}${s.reset} ` +
@@ -332,8 +334,11 @@ export function formatRequestLine(options: {
     `${s.dim}${ms}${s.reset}  ` +
     `${statusColor}${options.status}${s.reset}  ` +
     `${s.dim}${date}${s.reset}  ` +
-    `${s.dim}${time}${s.reset}\n`
-  );
+    `${s.dim}${time}${s.reset}\n`;
+  const detail = options.detail?.trim();
+  if (!detail || options.status < 400) return main;
+  const clipped = detail.length > 120 ? `${detail.slice(0, 119)}…` : detail;
+  return `${main}${s.dim}   ↳ ${clipped}${s.reset}\n`;
 }
 
 /**