ohos-playwright 0.2.4 → 0.2.6

package/README.md

@@ -46,6 +46,15 @@ export default defineConfig(withOpenHarmony({ /* your config */ }))
 | `OHOS_PW_HDC` | `/data/service/hnp/bin/hdc` |
 | `OHOS_PW_AUTO_CONNECT` | auto (set `0` to skip device auto-connect) |
 | `OHOS_PW_INFO_PATH` | `<tmpdir>/ohos-playwright-cdp.json` |
+| `OHOS_PW_UI_HOST` | `0.0.0.0` — used when `--ui` is passed without `--ui-host` on an OHOS device |
+| `OHOS_PW_UI_PORT` | `8765` — used when `--ui` is passed without `--ui-port` on an OHOS device |
+
+### `--ui` and `--debug` on an OHOS device
+
+Playwright's bundled Chromium cannot exec inside the OHOS app sandbox, which breaks the local windows that `--ui` and `--debug` normally open.
+
+- **`--ui`** auto-injects `--ui-host=0.0.0.0 --ui-port=8765` when run on OHOS, so the UI server starts as HTTP-only. Open `http://<device-ip>:8765` in any browser on your LAN.
+- **`--debug`** has no equivalent escape hatch; running it on OHOS exits with guidance. Use `await page.pause()` inside a test, or run `--debug` from a host (Linux/macOS/Windows) connected to the device via hdc.
 
 ## Compatibility
 

package/dist/cli.mjs

@@ -35,7 +35,33 @@ if (!existsSync(resolve(pkgRoot, 'package.json'))) {
 const playwrightCli = resolve(pkgRoot, 'cli.js');
 // Node 24 has native TypeScript support; register.mts is resolved directly.
 const register = resolve(import.meta.dirname, 'register.mjs');
-const child = spawn(process.execPath, ['--import', register, playwrightCli, ...process.argv.slice(2)], { stdio: 'inherit' });
+const argv = process.argv.slice(2);
+// On OpenHarmony, Playwright's bundled Chromium cannot exec inside the app
+// sandbox (unsigned ELF). Two of Playwright's CLI modes try to launch it:
+//   --ui    : opens a Chromium window to host the UI app
+//   --debug : opens a Chromium window for the Inspector (via PWDEBUG=1)
+// For --ui, Playwright skips the local Chromium when --ui-host or --ui-port
+// is provided (runner/index.js: runUIMode). Inject defaults so users don't
+// need to remember the flags. For --debug, no such escape hatch exists —
+// fail fast with guidance.
+if (process.platform === 'openharmony') {
+    const hasFlag = (name) => argv.some((a) => a === name || a.startsWith(name + '='));
+    if (hasFlag('--debug')) {
+        console.error('[ohos-playwright] --debug is not supported on OpenHarmony.\n' +
+            '  Playwright Inspector launches a bundled Chromium that the OHOS app sandbox cannot exec.\n' +
+            '  Alternatives:\n' +
+            '    1) Use `await page.pause()` inside a test for step-through inspection.\n' +
+            '    2) Run `ohos-playwright test --debug` from a host (Linux/macOS/Windows) connected to the device via hdc.');
+        process.exit(2);
+    }
+    if (hasFlag('--ui') && !hasFlag('--ui-host') && !hasFlag('--ui-port')) {
+        const host = process.env.OHOS_PW_UI_HOST ?? '0.0.0.0';
+        const port = process.env.OHOS_PW_UI_PORT ?? '8765';
+        argv.push(`--ui-host=${host}`, `--ui-port=${port}`);
+        console.error(`[ohos-playwright] UI server bound to ${host}:${port} — open http://<device-ip>:${port} in any browser. Override with OHOS_PW_UI_HOST / OHOS_PW_UI_PORT.`);
+    }
+}
+const child = spawn(process.execPath, ['--import', register, playwrightCli, ...argv], { stdio: 'inherit' });
 child.on('exit', (code, signal) => {
     if (signal)
         process.kill(process.pid, signal);

package/dist/setup.mjs

@@ -8,6 +8,16 @@ import { INFO_PATH } from "./info-path.mjs";
 const HDC = process.env.OHOS_PW_HDC ?? '/data/service/hnp/bin/hdc';
 const BUNDLE = process.env.OHOS_PW_BUNDLE ?? 'com.huawei.hmos.browser';
 const LAUNCH_URL = process.env.OHOS_PW_LAUNCH_URL ?? 'about:blank';
+// 校验环境变量，防止通过 hdc shell 注入恶意命令。
+// BUNDLE 必须是点分隔的 Android 风格包名；LAUNCH_URL 必须是合法 URL。
+const SAFE_BUNDLE_RE = /^[a-zA-Z][a-zA-Z0-9.]*$/;
+const SAFE_URL_RE = /^[a-z][a-z0-9+.-]*:(?:\/\/)?\S+$/i;
+if (!SAFE_BUNDLE_RE.test(BUNDLE) || BUNDLE.length > 256) {
+    throw new Error(`[ohos-playwright] OHOS_PW_BUNDLE "${BUNDLE}" 不是合法的包名（期望: com.example.app）`);
+}
+if (!SAFE_URL_RE.test(LAUNCH_URL) || LAUNCH_URL.length > 2048) {
+    throw new Error(`[ohos-playwright] OHOS_PW_LAUNCH_URL "${LAUNCH_URL}" 不是合法的 URL`);
+}
 const HDC_OPTS = { encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'] };
 function hdc(args, opts) {
     return String(execFileSync(HDC, args, { ...HDC_OPTS, ...opts })).trim();
@@ -39,6 +49,10 @@ function fetchDeviceState() {
 }
 export function findBrowserPid() {
     const { ps } = fetchDeviceState();
+    // Match the main process only: its cmdline equals BUNDLE exactly.
+    // Child processes like "com.huawei.hmos.browser:render" / ":gpu" must be
+    // excluded — the DevTools abstract socket only exists on the main process,
+    // so picking a child PID leads to socket-not-found errors downstream.
     for (const line of ps.split('\n')) {
         const t = line.trim();
         if (!t)
@@ -46,7 +60,7 @@ export function findBrowserPid() {
         const s = t.indexOf(' ');
         if (s === -1)
             continue;
-        if (t.slice(s + 1).includes(BUNDLE)) {
+        if (t.slice(s + 1).trim() === BUNDLE) {
             const pid = parseInt(t.slice(0, s), 10);
             if (!Number.isNaN(pid))
                 return pid;
@@ -204,7 +218,13 @@ export default async function globalSetup() {
     const probe = await probeCdp(port);
     if (!probe.ok)
         throw new Error(`CDP probe failed: ${probe.err || probe.body}`);
-    const info = JSON.parse(probe.body);
+    let info;
+    try {
+        info = JSON.parse(probe.body);
+    }
+    catch {
+        throw new Error(`CDP response is not valid JSON (body preview: ${probe.body?.slice(0, 300) ?? '(empty)'})`);
+    }
     console.log(`[ohos-playwright] CDP ready: ${info.Browser}`);
     mkdirSync(dirname(INFO_PATH), { recursive: true });
     writeFileSync(INFO_PATH, JSON.stringify({ port, pid, socket, endpoint: `http://127.0.0.1:${port}` }, null, 2));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ohos-playwright",
-  "version": "0.2.4",
+  "version": "0.2.6",
   "description": "Playwright adapter for OpenHarmony / ArkWeb via hdc + CDP",
   "license": "MIT",
   "author": "social4hyq",