ohlcv-indicators 3.2.6 → 3.2.8

package/index.js

@@ -431,7 +431,7 @@ export default class OHLCV_INDICATORS {
           throw new Error('"size" must be a positive number greater than 0 in candleVectors.');
         }
       
-        const { stdDev = 1, lag = 0, scale = 0.05, patternSize = 1, autoMinMax = false } = options;
+        const { stdDev = 1, lag = 0, scale = 0.001, patternSize = 0, autoMinMax = false } = options;
 
 
         if (typeof stdDev !== 'number' || stdDev <= 0) {
@@ -443,9 +443,9 @@ export default class OHLCV_INDICATORS {
             throw new Error(`"scale" value in candleVectors must be any of the following numbers: ${validMagnitudeValues.join(', ')}`);
         }
 
-        if (typeof patternSize !== 'number' || !Number.isInteger(patternSize) || patternSize < 1 ) {
+        if (typeof patternSize !== 'number' || !Number.isInteger(patternSize) || patternSize < 0 ) {
 
-            throw new Error(`"patternSize" value in candleVectors must be an integer greater than 0.`);
+            throw new Error(`"patternSize" value in candleVectors must be a positive integer.`);
         }
         if (typeof autoMinMax !== 'boolean') {
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ohlcv-indicators",
-  "version": "3.2.6",
+  "version": "3.2.8",
   "description": "A JavaScript library featuring optimized trading indicators for OHLCV arrays [{open, high, low, close, value}]. This library is optimized for backtesting and trading bot development.",
   "main": "index.js",
   "type": "module",

package/src/studies/candleVectors.js

@@ -1,16 +1,8 @@
-import { FasterBollingerBands } from 'trading-signals'
-import { classifyBoll } from '../utilities/classification.js'
+const diff = (a, b) => (a - b)
 
-const diff = (a, b) => (a - b) / b
-
-// crear una nueva instancia con la altura porcentual utilizando Bollinger Bands con una desviación estándar de 1.5
-// Las diferencias estarán basadas en (objetivo - lower) / (upper - lower). Esto arrojará un valor entre -1 y 1
-
-
-export const candleVectors = (main, index, size, {stdDev, patternSize, lag, scale, autoMinMax}) => {
+export const candleVectors = (main, index, size, {patternSize, lag, autoMinMax}) => {
 
     const { verticalOhlcv, instances, lastIndexReplace } = main
-    const calcSize = (di, bo) => classifyBoll(di, bo, scale, autoMinMax)
 
     if(index === 0)
     {
@@ -74,7 +66,7 @@ export const candleVectors = (main, index, size, {stdDev, patternSize, lag, scal
                 bodyVectors,
                 lookBackVectors,
                 keyNames,
-                bodyInstance: new FasterBollingerBands(size, stdDev),      
+                arrayChunk: {...Object.fromEntries(keyNames.map(v => [v, []]))}  
             }
         })
 
@@ -85,33 +77,19 @@ export const candleVectors = (main, index, size, {stdDev, patternSize, lag, scal
         
     }
 
-    if (index === 0) return true
-
-
-    const {bodyVectors, lookBackVectors, bodyInstance} = instances.candleVectors
-
-    let bodyBoll = null
-    const currOpen = verticalOhlcv.open[index]
-    const currClose = verticalOhlcv.close[index]
-    const bodySize = diff(currClose, currOpen)
-
-    // Update instances with current absolute values
-    bodyInstance.update(Math.abs(bodySize), lastIndexReplace)
-
-    try {
-        bodyBoll = bodyInstance.getResult()
-    } catch (err) {
-        // If there's not enough data, means remain null
-    }
-
+    const {bodyVectors, lookBackVectors, arrayChunk} = instances.candleVectors
 
     for(let x = 0; x < bodyVectors.length; x++)
     {
         const [k2, k1] = bodyVectors[x]
         const v2 = verticalOhlcv[k2][index]
         const v1 = verticalOhlcv[k1][index]
+        const key = `candle_body_${k2}_${k1}`
+        const difference = diff(v2, v1)
 
-        main.pushToMain({index, key: `candle_body_${k2}_${k1}`, value: calcSize(diff(v2, v1), bodyBoll)})
+        const zScore = calcZScore(arrayChunk, key, size, difference, lastIndexReplace)
+    
+        main.pushToMain({index, key, value: zScore})
     }
 
     for(let x = 0; x < patternSize; x++)
@@ -120,12 +98,18 @@ export const candleVectors = (main, index, size, {stdDev, patternSize, lag, scal
         {
             const currV = verticalOhlcv[currK][index]
             const prevV = verticalOhlcv[prevK][index-(x+1)]
+            const key = `candle_change_${x+1}_${currK}_${prevK}`
+
+            if(typeof prevV === 'undefined')
+            {
+                main.pushToMain({index, key, value: null})
+                continue
+            }
 
-            main.pushToMain({
-                index, 
-                key: `candle_change_${x+1}_${currK}_${prevK}`, 
-                value: (typeof prevV === 'undefined') ? null : calcSize(diff(currV, prevV), bodyBoll)
-            })
+            const difference = diff(currV, prevV)
+            const zScore = calcZScore(arrayChunk, key, size, difference, lastIndexReplace)
+    
+            main.pushToMain({index, key, value: zScore})
         }
     }
 
@@ -133,3 +117,29 @@ export const candleVectors = (main, index, size, {stdDev, patternSize, lag, scal
 }
 
 
+const calcZScore = (arrayChunk, key, size, difference, lastIndexReplace) => {
+
+    if(lastIndexReplace)
+    {
+        arrayChunk[key][arrayChunk[key].length - 1] = difference
+    }
+    else
+    {
+        arrayChunk[key].push(difference)
+    }
+    
+
+    if (arrayChunk[key].length > size) {
+        arrayChunk[key].shift();  // Removes the first element to maintain array size
+    }
+
+    if(arrayChunk.length < size) return null
+
+    const mean = arrayChunk[key].reduce((sum, value) => sum + value, 0) / size
+
+    const stdDev = Math.sqrt(
+        arrayChunk[key].reduce((sum, value) => sum + (value - mean) ** 2, 0) / size
+    )
+
+    return  (difference - mean) / stdDev
+}

package/src/utilities/pushToMain.js

@@ -1,19 +1,21 @@
 export const pushToMain = ({main, index, key, value}) => {
 
     const {precision, priceBased, minMaxRanges, verticalOhlcv, autoMinMaxKeys, precisionMultiplier} = main
-    let {invalidValueIndex } = main
 
     if(value === null || typeof value === 'undefined')
     {
-        invalidValueIndex = index
+        main.invalidValueIndex = index //do not use let for main.invalidValueIndex
 
-        for(let k in minMaxRanges)
+        for(const k of Object.keys(minMaxRanges))
         {
             minMaxRanges[k] = {min: Infinity, max: -Infinity}
         }
+
+        verticalOhlcv[key][index] = null
+        return false
     }
-    
-    verticalOhlcv[key][index] = value
+
+    verticalOhlcv[key][index] = value    
 
     if(typeof value === 'number' && !key.includes('_x_'))
     {
@@ -28,7 +30,7 @@ export const pushToMain = ({main, index, key, value}) => {
         }
         else if(key.startsWith('candle_') && keyInAutoMinMax)
         {
-            minMaxRanges[key] = { min: -1, max: 1}
+            minMaxRanges[key] = { min: -3, max: 3}
         }
         else if(key.includes('_range_') && keyInAutoMinMax)
         {