ohlcv-indicators 2.2.2 → 2.2.4

package/index.js

@@ -50,6 +50,8 @@ export default class OHLCV_INDICATORS {
             this.invalidValueIndex = index
         }
         
+
+        
         this.verticalOhlcv[key][index] = value
     }
 
@@ -66,8 +68,9 @@ export default class OHLCV_INDICATORS {
         } = this;
         const result = {};
         const shouldSlice = invalidValueIndex >= 0 && skipNull;
-        const sliceLength = len - invalidValueIndex;
+        const sliceLength = len - (invalidValueIndex + 1);
       
+
         for (const [key, arr] of Object.entries(verticalOhlcv)) {
           // If slicing is needed, create a sliced copy, otherwise re-use the array.
           let newArr = shouldSlice ? arr.slice(-sliceLength) : arr;
@@ -90,7 +93,6 @@ export default class OHLCV_INDICATORS {
 
         const {precisionMultiplier, priceBased, precision, verticalOhlcv, invalidValueIndex} = this
 
-
         return verticalToHorizontal(verticalOhlcv, skipNull, precision, precisionMultiplier, priceBased, invalidValueIndex)
     }
     
@@ -326,14 +328,19 @@ export default class OHLCV_INDICATORS {
             throw new Error('"size" must be a positive number in rsi.');
         }
 
-        const {scale = null, target = 'close'} = options
+        const {scale = null, target = 'close', lag = 0} = options
 
         if (typeof scale === 'number' && !validMagnitudeValues.includes(scale)) {
 
             throw new Error(`"scale" value in rsi must be any of the following numbers: ${validMagnitudeValues.join(', ')}`);
         }
 
-        this.inputParams.push({key: 'rsi', params: [size, {scale, target}]})
+        if (typeof lag !== 'number') {
+
+            throw new Error(`"lag" value in rsi must be a number in rsi.`);
+        }
+
+        this.inputParams.push({key: 'rsi', params: [size, {scale, target, lag}]})
 
         return this
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ohlcv-indicators",
-  "version": "2.2.2",
+  "version": "2.2.4",
   "description": "A JavaScript library featuring optimized trading indicators for OHLCV arrays [{open, high, low, close, value}]. This library is optimized for backtesting and trading bot development.",
   "main": "index.js",
   "type": "module",

package/src/oscillators/rsi.js

@@ -4,7 +4,7 @@ import { calcMagnitude } from '../utilities/numberUtilities.js';
 
 const defaultTarget = 'close';
 
-export const rsi = (main, index, size, { scale, target }) => {
+export const rsi = (main, index, size, { scale, target, lag }) => {
   const { verticalOhlcv, instances, lastIndexReplace } = main;
   const suffix = target === defaultTarget ? '' : `_${target}`;
   const rsiKey = `rsi_${size}${suffix}`;
@@ -29,6 +29,11 @@ export const rsi = (main, index, size, { scale, target }) => {
       [rsiKey]: [...nullArray],
       [rsiSmaKey]: [...nullArray],
     });
+
+    if(lag > 0)
+    {
+      main.lag([rsiKey, rsiSmaKey], lag)
+    }
   }
 
   const value = verticalOhlcv[target][index];

package/src/studies/candleStudies.js

@@ -10,13 +10,17 @@ export const candleStudies = (main, index, size, stdDev, {lag, scale}) => {
     if(index === 0)
     {
         const {nullArray} = main
-
-        const candleParts = ['candle_body', 'candle_top', 'candle_bottom']
-        const candleGaps = ['candle_gap']
-        const candleChanges = ['candle_change_close', 'candle_change_high', 'candle_change_low', 'candle_change_open']
-        const keyNames = [...candleParts, ...candleGaps, ...candleChanges]
-
-        Object.assign(verticalOhlcv, Object.fromEntries(keyNames.map(k => [k, nullArray])))
+        
+        Object.assign(verticalOhlcv, {
+            candle_body: [...nullArray],
+            candle_top: [...nullArray],
+            candle_bottom: [...nullArray],
+            candle_gap: [...nullArray],
+            candle_change_close: [...nullArray],
+            candle_change_high: [...nullArray],
+            candle_change_low: [...nullArray],
+            candle_change_open: [...nullArray],
+        })
 
         Object.assign(instances, {
             candleStudies: {

package/src/utilities/classification.js

@@ -21,6 +21,7 @@ import { calcMagnitude } from "./numberUtilities.js"
 
 
 export const classifyBoll = (value, bollingerBands, scale = 0.05) => {
+
   // Validate that value and bollingerBands are not null/undefined
   if (value == null || bollingerBands == null) return null
 

package/src/utilities/dataParsingUtilities.js

@@ -12,8 +12,8 @@ export const verticalToHorizontal = (
   const startIndex = skipNull && invalidValueIndex >= 0 ? invalidValueIndex + 1 : 0;
   const endIndex = obj[keys[0]].length;
   const len = endIndex - startIndex;
-  
   const result = new Array(len);
+
   
   for (let i = startIndex; i < endIndex; i++) {
     const row = {};
@@ -21,15 +21,10 @@ export const verticalToHorizontal = (
       const key = keys[j];
       const value = obj[key][i];
 
-      if(value === null || typeof value === 'undefined')
-      {
-        row[key] = null
-      }
-      else{
-        row[key] = (precision && priceBased.includes(key)) ? value / precisionMultiplier : value
-      }
+      row[key] = (precision && priceBased.includes(key)) ? value / precisionMultiplier : value
       
     }
+
     result[i - startIndex] = row;
   }