ohlcv-indicators 1.8.2 → 1.8.4

package/index.js

@@ -74,20 +74,19 @@ export default class OHLCV_INDICATORS {
     
     getLastValues(){
 
-        if(Object.keys(this.indicators).length > 0)
-        {
-            this.compute()
-        }
-
         return this.getData()[this.getData().length -1]
+    
     }
 
     compute() {
 
-        const indicators = this.indicators
+
+        if(Object.keys(this.indicators).length === 0) return this
+
+
         const addColumn = this.addColumn.bind(this)
 
-        for(const [key, arr] of Object.entries(indicators))
+        for(const [key, arr] of Object.entries( this.indicators))
         {
             if(!this.verticalOhlcv.hasOwnProperty(key))
             {
@@ -193,10 +192,10 @@ export default class OHLCV_INDICATORS {
         return this
 
     }
-    bollingerBands(size, times)
+    bollingerBands(size, times, bollingerBandsStudies)
     {
 
-        const result = bollingerBands(this, size, times)
+        const result = bollingerBands(this, size, times, bollingerBandsStudies)
         Object.assign(this.indicators, result)
 
         this.priceBased.push('bollinger_bands_middle', 'bollinger_bands_upper', 'bollinger_bands_lower')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ohlcv-indicators",
-  "version": "1.8.2",
+  "version": "1.8.4",
   "description": "A JavaScript library featuring optimized trading indicators for OHLCV arrays [{open, high, low, close, value}]. This library is optimized for backtesting and trading bot development.",
   "main": "index.js",
   "type": "module",

package/src/moving-averages/bollingerBands.js

@@ -2,30 +2,36 @@
 import {FasterBollingerBands, FasterSMA} from 'trading-signals';
 import { classifySize } from '../utilities/classification.js';
 
-export const bollingerBands = (main, size, times) => {
+export const bollingerBands = (main, size, times, bollingerBandsStudies) => {
 
   const {verticalOhlcv} = main
   const {close} = verticalOhlcv
 
-  const col = getBollingerBands(close, size, times)
+  const col = getBollingerBands(close, size, times, bollingerBandsStudies)
   return col
 }
 
-export const getBollingerBands = (data, size = 20, times = 2) => {
+export const getBollingerBands = (data, size = 20, times = 2, bollingerBandsStudies = false) => {
   
   const dataLength = data.length
   const bollinger_bands_upper =  Array(dataLength).fill(null)
   const bollinger_bands_middle =  Array(dataLength).fill(null)
   const bollinger_bands_lower =  Array(dataLength).fill(null)
-  const bollinger_bands_range =  Array(dataLength).fill(null)
-  const bollinger_bands_height =  Array(dataLength).fill(null)
 
 
-  const heightInstance = new FasterSMA(size)
-
+  let bollinger_bands_range
+  let bollinger_bands_height
+  let heightInstance
   let range = null
   let height = null
 
+  if(bollingerBandsStudies)
+  {
+    bollinger_bands_range =  Array(dataLength).fill(null)
+    bollinger_bands_height =  Array(dataLength).fill(null)
+    heightInstance = new FasterSMA(size)
+  }
+
   let getRange = (value, upper, lower) => ({
     range: ((value - lower) / (upper - lower)),
     height: upper-lower
@@ -52,6 +58,8 @@ export const getBollingerBands = (data, size = 20, times = 2) => {
     bollinger_bands_middle[x] = obj.middle;
     bollinger_bands_lower[x] = obj.lower;
 
+    if(bollingerBandsStudies === false) continue
+    
     if(hasNull)
     {
       bollinger_bands_range[x] = null
@@ -79,6 +87,13 @@ export const getBollingerBands = (data, size = 20, times = 2) => {
     bollinger_bands_height[x] = classifySize(height, heightMean, 1.5)
   }
 
-  return { bollinger_bands_upper, bollinger_bands_middle, bollinger_bands_lower, bollinger_bands_range, bollinger_bands_height }
+  let output = { bollinger_bands_upper, bollinger_bands_middle, bollinger_bands_lower }
+
+  if(bollingerBandsStudies)
+  {
+    output = {...output, bollinger_bands_range, bollinger_bands_height}
+  }
+
+  return output
 }
 

package/src/studies/findCrosses.js

@@ -202,7 +202,7 @@ export const crossPairs = (main, arr) => {
             }
 
         } else {
-            console.log(`Missing ohlcv properties for ${fast} or ${slow}`);
+            throw Error(`Missing ohlcv properties for ${fast} or ${slow}`);
         }
     }