ohlcv-indicators 1.0.4 → 1.0.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ohlcv-indicators",
-  "version": "1.0.4",
+  "version": "1.0.7",
   "description": "A JavaScript library featuring optimized trading indicators for OHLCV arrays [{open, high, low, close, value}], utilizing BigNumber precision for enhanced accuracy.",
   "main": "index.js",
   "type": "module",

package/src/studies/volumeProfile.js

@@ -1,4 +1,4 @@
-export const VolumeProfile = (BigNumber, ohlcv, numBins = 10) => {
+export const VolumeProfile = (BigNumber, ohlcv, numBins = 10, position) => {
   const { open, high, low, close, volume } = ohlcv;
 
   // Determine the range of prices
@@ -26,7 +26,8 @@ export const VolumeProfile = (BigNumber, ohlcv, numBins = 10) => {
   const inverseBinSize = BigNumber(1).dividedBy(binSize);
 
   // Distribute volume into bins
-  close.forEach((currentClose, i) => {
+  for (let i = 0; i < close.length; i++) {
+    const currentClose = close[i];
     const currentOpen = open[i];
     const currentHigh = high[i];
     const currentLow = low[i];
@@ -41,24 +42,43 @@ export const VolumeProfile = (BigNumber, ohlcv, numBins = 10) => {
     for (let j = lowIndex; j < highIndex; j++) {
       bins[j].upVolume = bins[j].upVolume.plus(upVolume);
       bins[j].downVolume = bins[j].downVolume.plus(downVolume);
-      bins[j].grossVolume = bins[j].upVolume.plus(bins[j].downVolume);    }
-  });
+      bins[j].grossVolume = bins[j].grossVolume.plus(upVolume.plus(downVolume));
+    }
+  }
 
   // Sum totals outside the loop
-  bins.forEach(({ upVolume, downVolume, grossVolume, netVolume }) => {
+  for (const { upVolume, downVolume, grossVolume } of bins) {
     totals.upVolume = totals.upVolume.plus(upVolume);
     totals.downVolume = totals.downVolume.plus(downVolume);
     totals.grossVolume = totals.grossVolume.plus(grossVolume);
-  });
+  }
+
+
+  const nodes = findVolumeNodes(bins)
+  return {bins, nodes};
+}
+
+
+const findVolumeNodes = bins => {
+  if (!bins || bins.length === 0) {
+    throw new Error('Bins array is empty or not provided');
+  }
+
+  let highestVolumeNode = bins[0];
+  let lowestVolumeNode = bins[0];
 
-  // Calculate percentage volumes
   bins.forEach(bin => {
-    Object.keys(totals).forEach(k => {
-      if (!totals[k].isZero()) {
-        bin[`${k}Percent`] = (bin[k].dividedBy(totals[k])).times(100);
-      }
-    });
+    if (bin.grossVolume.isGreaterThan(highestVolumeNode.grossVolume)) {
+      highestVolumeNode = bin;
+    }
+
+    if (bin.grossVolume.isLessThan(lowestVolumeNode.grossVolume)) {
+      lowestVolumeNode = bin;
+    }
   });
 
-  return bins;
-};
+  return {
+    highestVolumeNode,
+    lowestVolumeNode
+  }
+}