oh-skillhub 0.1.15 → 0.1.17

package/bin/oh-skillhub.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 
-const { main } = require("../src/cli");
+const { main, renderStatusLine } = require("../src/cli");
 
 main(process.argv.slice(2)).catch((error) => {
-  console.error(error.message);
+  process.stderr.write(`${renderStatusLine("failure", "INSTALL FAILED", error.message, process.stderr)}\n`);
   process.exitCode = 1;
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oh-skillhub",
-  "version": "0.1.15",
+  "version": "0.1.17",
   "description": "OpenHarmony Skills installer for Codex, Claude Code, and OpenCode.",
   "type": "commonjs",
   "bin": {

package/src/cli.js

@@ -29,6 +29,7 @@ const ANSI = {
   dim: "\x1b[2m",
   cyan: "\x1b[36m",
   green: "\x1b[32m",
+  red: "\x1b[31m",
   reverse: "\x1b[7m",
 };
 const AGENT_CHOICES = [
@@ -396,7 +397,7 @@ async function installInteractiveSelection(manifest, choices, agent, selectedInd
     ensureSkillSourceRootAsync(manifest, { env: process.env, skills }),
   );
   output.write(`${renderInstallForSkills(skills, { agent, scope: "user" }, sourceRoot)}\n`);
-  output.write(`${renderInteractiveCompletion(skills, { agent, scope: "user" })}\n`);
+  output.write(`${renderInteractiveCompletion(skills, { agent, scope: "user" }, output)}\n`);
 }
 
 async function withSpinner(output, message, task, options = {}) {
@@ -980,14 +981,24 @@ function renderInstallForSkills(skills, targetOptions, sourceRootOverride = null
   return renderInstallPlan("Install summary", plan);
 }
 
-function renderInteractiveCompletion(skills, targetOptions) {
+function renderInteractiveCompletion(skills, targetOptions, output = process.stdout) {
   return [
     "",
-    `Done. Installed ${skills.length} skill(s) for ${targetOptions.agent}:${targetOptions.scope}.`,
-    "You can close this terminal or start using the installed skills.",
+    renderStatusLine(
+      "success",
+      "INSTALL SUCCESS",
+      `Installed ${skills.length} skill(s) for ${targetOptions.agent}:${targetOptions.scope}.`,
+      output,
+    ),
   ].join("\n");
 }
 
+function renderStatusLine(kind, title, detail, output = process.stdout) {
+  const color = kind === "failure" ? ANSI.red : ANSI.green;
+  const heading = output.isTTY ? colorize(title, color, ANSI.bold) : title;
+  return detail ? `${heading}\n${detail}` : heading;
+}
+
 function renderInstallPlan(title, plan) {
   const lines = [title];
   for (const operation of plan.operations) {
@@ -1068,6 +1079,7 @@ module.exports = {
   renderInstall,
   renderList,
   renderTelemetry,
+  renderStatusLine,
   buildRepositoryChoices,
   renderAgentMenu,
   renderActionMenu,

package/src/source.js

@@ -4,6 +4,10 @@ const fs = require("node:fs");
 const os = require("node:os");
 const path = require("node:path");
 
+const DEFAULT_MOVE_RETRIES = 8;
+const DEFAULT_MOVE_DELAY_MS = 120;
+const RETRYABLE_MOVE_CODES = new Set(["EBUSY", "EPERM", "ENOTEMPTY"]);
+
 function ensureSkillSourceRoot(manifest, options = {}) {
   const env = options.env || process.env;
   if (env.OH_SKILLHUB_SOURCE_DIR) {
@@ -44,7 +48,7 @@ function ensureSkillSourceRoot(manifest, options = {}) {
     const detail = gitDetail(checkoutResult);
     throw new Error(`Failed to checkout selected skill source from ${source}#${ref}.${detail ? ` ${detail}` : ""}`);
   }
-  fs.renameSync(tempCheckout, checkout);
+  moveCheckoutIntoCache(tempCheckout, checkout);
   return checkout;
 }
 
@@ -99,10 +103,44 @@ async function ensureSkillSourceRootAsync(manifest, options = {}) {
     const detail = gitDetail(checkoutResult);
     throw new Error(`Failed to checkout selected skill source from ${source}#${ref}.${detail ? ` ${detail}` : ""}`);
   }
-  fs.renameSync(tempCheckout, checkout);
+  await moveCheckoutIntoCacheAsync(tempCheckout, checkout);
   return checkout;
 }
 
+function moveCheckoutIntoCache(tempCheckout, checkout, options = {}) {
+  const renameSync = options.renameSync || fs.renameSync;
+  const retries = options.retries ?? DEFAULT_MOVE_RETRIES;
+  const delayMs = options.delayMs ?? DEFAULT_MOVE_DELAY_MS;
+  for (let attempt = 0; attempt <= retries; attempt += 1) {
+    try {
+      renameSync(tempCheckout, checkout);
+      return;
+    } catch (error) {
+      if (!isRetryableMoveError(error) || attempt === retries) {
+        throw cacheMoveError(error, tempCheckout, checkout);
+      }
+      sleepSync(delayMs * (attempt + 1));
+    }
+  }
+}
+
+async function moveCheckoutIntoCacheAsync(tempCheckout, checkout, options = {}) {
+  const renameSync = options.renameSync || fs.renameSync;
+  const retries = options.retries ?? DEFAULT_MOVE_RETRIES;
+  const delayMs = options.delayMs ?? DEFAULT_MOVE_DELAY_MS;
+  for (let attempt = 0; attempt <= retries; attempt += 1) {
+    try {
+      renameSync(tempCheckout, checkout);
+      return;
+    } catch (error) {
+      if (!isRetryableMoveError(error) || attempt === retries) {
+        throw cacheMoveError(error, tempCheckout, checkout);
+      }
+      await sleep(delayMs * (attempt + 1));
+    }
+  }
+}
+
 function requireDirectory(value, label) {
   const dir = path.resolve(value);
   if (!fs.existsSync(dir) || !fs.statSync(dir).isDirectory()) {
@@ -163,7 +201,32 @@ function gitDetail(result) {
   return (result.stderr || result.stdout || "").trim();
 }
 
+function isRetryableMoveError(error) {
+  return RETRYABLE_MOVE_CODES.has(error && error.code);
+}
+
+function cacheMoveError(error, tempCheckout, checkout) {
+  const wrapped = new Error(
+    `Failed to finalize skill source cache because the checkout directory is busy or locked. ` +
+      `Close terminals/editors using the cache and retry. ${tempCheckout} -> ${checkout}. ${error.message}`,
+  );
+  wrapped.code = error.code;
+  wrapped.cause = error;
+  return wrapped;
+}
+
+function sleep(ms) {
+  return new Promise((resolve) => setTimeout(resolve, ms));
+}
+
+function sleepSync(ms) {
+  if (ms <= 0) return;
+  Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms);
+}
+
 module.exports = {
   ensureSkillSourceRoot,
   ensureSkillSourceRootAsync,
+  moveCheckoutIntoCache,
+  moveCheckoutIntoCacheAsync,
 };