oh-my-opencode 5.1.46 → 5.1.47

package/packages/shared-skills/skills/ulw-research/scripts/fact-pairs.test.ts

@@ -39,8 +39,8 @@ function filled(): { out: string; fillMap: { fact_id: string }[] } {
 }
 
 function pairs(): Pair[] {
-	const { out, fillMap } = filled()
-	return extractPairs(out, LEDGER, CLAIMS, fillMap) as Pair[]
+	const { out } = filled()
+	return extractPairs(out, LEDGER, CLAIMS) as Pair[]
 }
 
 describe("extractPairs: a filled report", () => {
@@ -110,14 +110,7 @@ describe("extractPairs: a filled report", () => {
 		expect(sentences.some((text) => text.includes("Bridge authority"))).toBe(false)
 	})
 
-	test("#given a fill map that omits a fact #when extracted #then that hand-typed fact yields no pair", () => {
-		const { out, fillMap } = filled()
-		const kept = fillMap.filter((entry) => entry.fact_id !== "F13")
-		const result = extractPairs(out, LEDGER, CLAIMS, kept) as Pair[]
-		expect(result.some((pair) => Array.isArray(pair.fact_ids) && (pair.fact_ids as string[]).includes("F13"))).toBe(false)
-	})
-
-	test("#given no fill map #when extracted #then every data-fact element counts as filled", () => {
+	test("#given the filled fixture #when extracted #then every data-fact element yields its pair", () => {
 		const { out } = filled()
 		expect((extractPairs(out, LEDGER, CLAIMS) as Pair[]).length).toBe(6)
 	})
@@ -125,20 +118,11 @@ describe("extractPairs: a filled report", () => {
 	test("#given a Hangul quote #when extracted #then source_lang is ko", () => {
 		const html = "<html><body><h2>Findings</h2><p>HBM revenue reached {{F21:hbm_rev}} [S5].</p></body></html>"
 		const result = fill(html, LEDGER, { format: "html" }) as { out: string; fillMap: { fact_id: string }[] }
-		const [pair] = extractPairs(result.out, LEDGER, CLAIMS, result.fillMap) as Pair[]
+		const [pair] = extractPairs(result.out, LEDGER, CLAIMS) as Pair[]
 		expect(pair).toMatchObject({ fact_ids: ["F21"], source_lang: "ko", report_lang: "en" })
 	})
 })
 
-describe("extractPairs: a fill map over translations", () => {
-	test("#given a fill map that omits the translated fact #when extracted #then no translation pair is emitted", () => {
-		const { out, fillMap } = filled()
-		const kept = fillMap.filter((entry) => entry.fact_id !== "Q7")
-		const result = extractPairs(out, LEDGER, CLAIMS, kept) as Pair[]
-		expect(result.some((pair) => pair.kind === "translation")).toBe(false)
-	})
-})
-
 describe("hasHedge: a month is not a hedge", () => {
 	test("#given a text that starts with the month May #when checked #then it does not count as hedged", () => {
 		expect(hasHedge("May 2024 sales rose.")).toBe(false)
@@ -152,9 +136,9 @@ describe("hasHedge: a month is not a hedge", () => {
 
 describe("extractPairs: determinism", () => {
 	test("#given the same filled report twice #when extracted #then both results are byte-for-byte equal", () => {
-		const { out, fillMap } = filled()
-		const first = JSON.stringify(extractPairs(out, LEDGER, CLAIMS, fillMap))
-		const second = JSON.stringify(extractPairs(out, LEDGER, CLAIMS, fillMap))
+		const { out } = filled()
+		const first = JSON.stringify(extractPairs(out, LEDGER, CLAIMS))
+		const second = JSON.stringify(extractPairs(out, LEDGER, CLAIMS))
 		expect(second).toBe(first)
 	})
 })

package/packages/shared-skills/skills/ulw-research/scripts/references-fences.test.ts

@@ -0,0 +1,25 @@
+// Every references/*.md must have balanced code fences: an unclosed fence renders prose as code
+// and flips every later fence in the file. md-lite is the parser the skill's own tools use.
+import { describe, expect, test } from "bun:test"
+import { readdirSync, readFileSync } from "node:fs"
+import { join } from "node:path"
+
+import { parseMarkdown } from "./md-lite.mjs"
+
+const REFERENCES = join(import.meta.dir, "..", "references")
+const FILES = readdirSync(REFERENCES).filter((name) => name.endsWith(".md")).sort()
+
+describe("references/*.md fence parity", () => {
+	test("#given the references directory #when listed #then it holds the reference pages", () => {
+		expect(FILES.length).toBeGreaterThan(0)
+	})
+
+	for (const name of FILES) {
+		test(`#given ${name} #when its fences are counted #then the count is even and md-lite reports no problem`, () => {
+			const text = readFileSync(join(REFERENCES, name), "utf8")
+			const fences = text.split("\n").filter((line) => /^ {0,3}(`{3,}|~{3,})/u.test(line))
+			expect(fences.length % 2, `${name} has ${fences.length} fence lines`).toBe(0)
+			expect(parseMarkdown(text).problems).toEqual([])
+		})
+	}
+})

package/packages/shared-skills/skills/ulw-research/scripts/report-tools.test.ts

@@ -8,6 +8,7 @@ import { PROMOTION } from "./fact-commands-meaning.mjs"
 import { writeFidelityRecord } from "./fidelity-records.mjs"
 import { PAIR_KINDS } from "./fact-pairs.mjs"
 import { VERDICT_SCHEMA } from "./meaning-check.mjs"
+import { POLISH_MARKUP_REASON } from "./polish-apply.mjs"
 import { COMMANDS, run } from "./report-tools.mjs"
 
 const SCRIPT = join(import.meta.dir, "report-tools.mjs")
@@ -503,6 +504,92 @@ describe("meaning verifier under node", () => {
 	})
 })
 
+type PolishJson = { data: { out: string; applied: number; rejected: number; unlocated: number }; defects: { code: string; index: number; reason?: string }[] }
+
+/** A filled session whose first finding names an acquirer and a target around F1. */
+function polishSession() {
+	const session = fidelitySession()
+	const { dir, s } = session
+	const source = readFileSync(join(dir, "report.src.html"), "utf8").replace("<p>The span length is", "<p>Acme acquired Bolt before the span length reached")
+	writeFileSync(join(dir, "report.src.html"), source)
+	nodeJson(["fact", "fill", join(dir, "report.src.html"), "--out", join(dir, "report.html"), ...s])
+	return session
+}
+
+function polishApply(dir: string, edits: string) {
+	const args = ["fact", "polish-apply", join(dir, "report.html"), "--edits", edits, "--ledger", join(dir, "fact-ledger.json"), "--out", join(dir, "report.polished.html")]
+	const proc = nodeJson(args)
+	return { ...proc, json: proc.json as unknown as PolishJson }
+}
+
+describe("polish wiring under node", () => {
+	test("#given the fixture edits #when fact polish-apply runs #then it exits 0, applies the wording edit, and rejects the numeral edit", () => {
+		const { dir } = polishSession()
+		const applied = polishApply(dir, join(FIDELITY, "polish-edits.json"))
+		const polished = readFileSync(join(dir, "report.polished.html"), "utf8")
+		expect(applied.code).toBe(0)
+		expect(applied.json.data).toMatchObject({ applied: 1, rejected: 1, unlocated: 0 })
+		expect(applied.json.defects.map((d) => [d.code, d.index])).toEqual([["polish_edit_rejected", 1]])
+		expect(polished).toContain("Collected from a single cited public page")
+		expect(polished).toContain("retrieved 2026-10-01")
+		expect(polished).not.toContain("2026-10-02")
+	})
+
+	test("#given an edit that adds an attribute #when polish-apply and polish-diff run #then apply refuses it as markup changed and diff exits 1", () => {
+		const { dir } = polishSession()
+		const html = readFileSync(join(dir, "report.html"), "utf8")
+		const edits = join(dir, "attribute.json")
+		writeFileSync(edits, JSON.stringify([{ before: "<h2>Findings</h2>", after: '<h2 id="findings">Findings</h2>', reason: "anchor" }]))
+		const applied = polishApply(dir, edits)
+		expect(applied.code).toBe(0)
+		expect(applied.json.data).toMatchObject({ applied: 0, rejected: 1, unlocated: 0 })
+		expect(applied.json.defects.map((d) => [d.code, d.index])).toEqual([["polish_edit_rejected", 0]])
+		expect(applied.json.defects[0]?.reason).toContain("markup changed")
+		expect(readFileSync(join(dir, "report.polished.html"), "utf8")).toBe(html)
+		writeFileSync(join(dir, "attribute.html"), html.replace("<h2>Findings</h2>", '<h2 id="findings">Findings</h2>'))
+		const diffed = nodeJson(["fact", "polish-diff", "--before", join(dir, "report.html"), "--after", join(dir, "attribute.html"), "--ledger", join(dir, "fact-ledger.json")])
+		expect(diffed.code).toBe(1)
+		expect(codesOf(diffed.json)).toContain("polish_diff_fail")
+		expect(JSON.stringify(diffed.json)).toContain("markup changed")
+	})
+
+	test("#given an edit whose before holds & #when fact polish-apply runs #then it prints polish-apply's own markup reason verbatim for that edit", () => {
+		const { dir } = polishSession()
+		const before = "Acme & Bolt"
+		const edits = join(dir, "ampersand.json")
+		writeFileSync(edits, JSON.stringify([{ before, after: "Acme and Bolt", reason: "ampersand" }]))
+		const applied = polishApply(dir, edits)
+		const line = `  rejected edit 0 ("${before}"): ${POLISH_MARKUP_REASON}`
+		expect(applied.code).toBe(0)
+		expect(applied.json.data).toMatchObject({ applied: 0, rejected: 1, unlocated: 0 })
+		expect(applied.json.defects.map((d) => [d.code, d.index, d.reason])).toEqual([["polish_edit_rejected", 0, POLISH_MARKUP_REASON]])
+		expect(applied.stderr.split("\n")).toContain(line)
+	})
+
+	test("#given a polished copy edited by hand #when fact polish-diff runs #then it exits 1 with polish_diff_fail", () => {
+		const { dir } = polishSession()
+		const html = readFileSync(join(dir, "report.html"), "utf8")
+		writeFileSync(join(dir, "hand.html"), html.replace("320 m", "321 m"))
+		const diffed = nodeJson(["fact", "polish-diff", "--before", join(dir, "report.html"), "--after", join(dir, "hand.html"), "--ledger", join(dir, "fact-ledger.json")])
+		expect(diffed.code).toBe(1)
+		expect(codesOf(diffed.json)).toContain("polish_diff_fail")
+	})
+
+	test("#given an accepted subject and object swap #when fact pairs runs with --changed-since #then only that sentence's pair is emitted, with the new text", () => {
+		const { dir, s } = polishSession()
+		const edits = join(dir, "swap.json")
+		writeFileSync(edits, JSON.stringify([{ before: "Acme acquired Bolt", after: "Bolt acquired Acme", reason: "word order" }]))
+		const applied = polishApply(dir, edits)
+		const map = join(dir, "report.html.fill-map.json")
+		const changed = nodeJson(["fact", "pairs", join(dir, "report.polished.html"), "--changed-since", map, "--out", join(dir, "pairs-changed.json"), ...s])
+		const written = JSON.parse(readFileSync(join(dir, "pairs-changed.json"), "utf8"))
+		expect(applied.json.data).toMatchObject({ applied: 1, rejected: 0 })
+		expect(changed.code).toBe(0)
+		expect(written.pairs.map((p: Pair) => [p.kind, p.fact_ids])).toEqual([["quote", ["F1"]]])
+		expect(written.pairs[0].sentence).toContain("Bolt acquired Acme")
+	})
+})
+
 describe("markdown editions under node", () => {
 	const MD = ["# Bridge", "", "## Findings", "", "The span length is {{F1:span_len}} [S4].", "", "The operator wrote {{Q1:completion}} [S4].", "", "## How this report was made", "", "Collected from one cited public page [S4].", "", "## Sources", "", "1. [S4] Bridge page, retrieved 2026-10-01.", ""].join("\n")
 

package/packages/shared-skills/skills/ulw-research/scripts/tests/fixtures/fidelity/polish-edits.json

@@ -0,0 +1,12 @@
+[
+	{
+		"before": "Collected from one cited public page [S4].",
+		"after": "Collected from a single cited public page [S4].",
+		"reason": "Smoother wording."
+	},
+	{
+		"before": "[S4] Bridge page, retrieved 2026-10-01.",
+		"after": "[S4] Bridge page, retrieved 2026-10-02.",
+		"reason": "Date typo."
+	}
+]