oh-my-opencode 5.1.3 → 5.1.4

package/packages/lsp-core/src/post-edit/index.ts

@@ -1 +1,3 @@
+export * from "./file-location.js";
+export * from "./not-installed-guidance.js";
 export * from "./orchestration.js";

package/packages/lsp-core/src/post-edit/not-installed-guidance.ts

@@ -0,0 +1,36 @@
+import type { PostEditFileLocation } from "./file-location.js";
+
+export interface PostEditNotInstalledOutcome {
+	readonly kind: "not_installed";
+	readonly serverId: string;
+	readonly installDecisionTool: boolean;
+	/** A recorded install decision; absent while the user has not decided. */
+	readonly decision?: "declined" | "allowed";
+	readonly text: string;
+}
+
+export interface NotInstalledGuidanceState {
+	readonly notInstalledServers: Set<string>;
+}
+
+/**
+ * Decides whether a missing-server nudge reaches the model.
+ *
+ * Recorded decisions keep their own text. Undecided nudges are skipped for files outside a project
+ * (no marked root, the agent's config dir, or a temp dir) because a repo-local install there would
+ * create a manifest in HOME or a temp dir. Without a decision tool nothing can be recorded, so a
+ * server is nudged at most once per session state.
+ */
+export function notInstalledGuidance(
+	filePath: string,
+	outcome: PostEditNotInstalledOutcome,
+	state: NotInstalledGuidanceState,
+	locateFile: ((filePath: string) => PostEditFileLocation) | undefined,
+): string | undefined {
+	if (outcome.decision !== undefined) return outcome.text;
+	if (locateFile !== undefined && locateFile(filePath) !== "project") return undefined;
+	if (outcome.installDecisionTool) return outcome.text;
+	if (state.notInstalledServers.has(outcome.serverId)) return undefined;
+	state.notInstalledServers.add(outcome.serverId);
+	return outcome.text;
+}

package/packages/lsp-core/src/post-edit/not-installed.test.ts

@@ -0,0 +1,199 @@
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, describe, expect, it } from "bun:test";
+
+import {
+	classifyPostEditFileLocation,
+	collectPostEditDiagnostics,
+	createPostEditNotConfiguredCache,
+	type PostEditDiagnosticsOutcome,
+	type PostEditFileLocation,
+	resetPostEditNotConfiguredCache,
+} from "./index.js";
+
+const tempDirectories: string[] = [];
+
+afterEach(() => {
+	for (const directory of tempDirectories.splice(0)) {
+		rmSync(directory, { recursive: true, force: true });
+	}
+});
+
+function tempRoot(prefix: string): string {
+	const root = mkdtempSync(join(tmpdir(), prefix));
+	tempDirectories.push(root);
+	return root;
+}
+
+function touch(path: string, text = ""): string {
+	mkdirSync(join(path, ".."), { recursive: true });
+	writeFileSync(path, text);
+	return path;
+}
+
+const FULL_NUDGE = [
+	"LSP server 'typescript' for .ts is NOT INSTALLED.",
+	"To install in THIS repository (preferred — no global install needed):",
+	"ACTION REQUIRED — ASK THE USER whether to install this LSP server.",
+].join("\n");
+
+function notInstalled(
+	serverId: string,
+	overrides: Partial<Extract<PostEditDiagnosticsOutcome, { kind: "not_installed" }>> = {},
+): PostEditDiagnosticsOutcome {
+	return {
+		kind: "not_installed",
+		serverId,
+		installDecisionTool: false,
+		text: `${FULL_NUDGE} (${serverId})`,
+		...overrides,
+	};
+}
+
+function at(location: PostEditFileLocation): () => PostEditFileLocation {
+	return () => location;
+}
+
+describe("classifyPostEditFileLocation", () => {
+	it("#given a file with no workspace marker above it #when classified #then it is outside any project", () => {
+		const root = tempRoot("lsp-postedit-noproject-");
+		const file = touch(join(root, "scratch", "note.mjs"));
+
+		expect(classifyPostEditFileLocation(file, { cwd: root, agentDirs: [], tempDirs: [] })).toBe("outside_project");
+	});
+
+	it("#given a file under the agent config dir inside a git repository #when classified #then the agent config dir wins", () => {
+		const root = tempRoot("lsp-postedit-agentdir-");
+		mkdirSync(join(root, ".git"));
+		const agentDir = join(root, ".omo", "agent");
+		const file = touch(join(agentDir, "models.json"), "{}\n");
+
+		expect(classifyPostEditFileLocation(file, { cwd: root, agentDirs: [agentDir], tempDirs: [] })).toBe(
+			"agent_config",
+		);
+	});
+
+	it("#given a temp dir holding a stray package.json #when a scratch file there is classified #then it is a temp file", () => {
+		const temp = tempRoot("lsp-postedit-temp-");
+		touch(join(temp, "package.json"), "{}\n");
+		const file = touch(join(temp, "rules_test.mjs"));
+
+		expect(classifyPostEditFileLocation(file, { cwd: temp, agentDirs: [], tempDirs: [temp] })).toBe("temp");
+	});
+
+	it("#given the default temp dirs #when an OS temp file is classified #then the canonical temp dir matches", () => {
+		const root = tempRoot("lsp-postedit-ostemp-");
+		const file = touch(join(root, "scratch.mjs"));
+
+		expect(classifyPostEditFileLocation(file, { cwd: root, agentDirs: [] })).toBe("temp");
+		if (process.platform !== "win32") {
+			const slashTmp = join("/tmp", `lsp-postedit-missing-${process.pid}`, "rules_test.mjs");
+			expect(classifyPostEditFileLocation(slashTmp, { cwd: root, agentDirs: [] })).toBe("temp");
+		}
+	});
+
+	it("#given a project with its own marker inside a temp dir #when classified #then it is a project", () => {
+		const temp = tempRoot("lsp-postedit-tempproject-");
+		const project = join(temp, "checkout");
+		touch(join(project, "package.json"), "{}\n");
+		const file = touch(join(project, "src", "a.ts"));
+
+		expect(classifyPostEditFileLocation(file, { cwd: project, agentDirs: [], tempDirs: [temp] })).toBe("project");
+		expect(classifyPostEditFileLocation("src/a.ts", { cwd: project, agentDirs: [], tempDirs: [temp] })).toBe(
+			"project",
+		);
+	});
+});
+
+describe("collectPostEditDiagnostics not-installed guidance", () => {
+	for (const location of ["outside_project", "agent_config", "temp"] as const) {
+		it(`#given a missing server for a ${location} file #when diagnostics run #then the install nudge is skipped`, async () => {
+			const result = await collectPostEditDiagnostics({
+				filePaths: ["file.ts"],
+				runDiagnostics: async () => notInstalled("typescript"),
+				locateFile: at(location),
+			});
+
+			expect(result.blocks).toEqual([]);
+			expect(result.observations).toEqual([{ filePath: "file.ts", kind: "not_installed" }]);
+		});
+	}
+
+	it("#given a missing server for a project file #when diagnostics run #then today's full guidance is kept", async () => {
+		const result = await collectPostEditDiagnostics({
+			filePaths: ["src/a.ts"],
+			runDiagnostics: async () => notInstalled("typescript"),
+			locateFile: at("project"),
+		});
+
+		expect(result.blocks).toEqual([{ filePath: "src/a.ts", diagnostics: `${FULL_NUDGE} (typescript)` }]);
+	});
+
+	it("#given no decision tool #when repeated edits hit missing servers #then each server is nudged once per session", async () => {
+		const cache = createPostEditNotConfiguredCache();
+		const serverFor = (filePath: string): string => (filePath.endsWith(".json") ? "biome" : "typescript");
+		const run = (filePaths: readonly string[]) =>
+			collectPostEditDiagnostics({
+				filePaths,
+				cache,
+				runDiagnostics: async (filePath) => notInstalled(serverFor(filePath)),
+				locateFile: at("project"),
+			});
+
+		const first = await run(["a.ts", "b.ts"]);
+		const second = await run(["c.ts", "d.json"]);
+		const third = await run(["e.json", "f.ts"]);
+
+		expect(first.blocks.map((block) => block.filePath)).toEqual(["a.ts"]);
+		expect(second.blocks.map((block) => block.filePath)).toEqual(["d.json"]);
+		expect(third.blocks).toEqual([]);
+
+		resetPostEditNotConfiguredCache(cache);
+		const afterReset = await run(["g.ts"]);
+		expect(afterReset.blocks.map((block) => block.filePath)).toEqual(["g.ts"]);
+	});
+
+	it("#given a decision tool #when repeated edits hit a missing server #then every edit keeps the guidance", async () => {
+		const cache = createPostEditNotConfiguredCache();
+		const run = (filePath: string) =>
+			collectPostEditDiagnostics({
+				filePaths: [filePath],
+				cache,
+				runDiagnostics: async () => notInstalled("typescript", { installDecisionTool: true }),
+				locateFile: at("project"),
+			});
+
+		expect((await run("a.ts")).blocks).toHaveLength(1);
+		expect((await run("b.ts")).blocks).toHaveLength(1);
+	});
+
+	for (const decision of ["declined", "allowed"] as const) {
+		it(`#given a recorded ${decision} decision #when edits repeat anywhere #then that branch's text is unchanged every time`, async () => {
+			const cache = createPostEditNotConfiguredCache();
+			const text = `LSP server 'typescript' ${decision} branch text`;
+			const outcomes: PostEditFileLocation[] = ["project", "outside_project", "project"];
+			const blocks: string[] = [];
+			for (const location of outcomes) {
+				const result = await collectPostEditDiagnostics({
+					filePaths: ["a.ts"],
+					cache,
+					runDiagnostics: async () => notInstalled("typescript", { decision, text }),
+					locateFile: at(location),
+				});
+				blocks.push(...result.blocks.map((block) => block.diagnostics));
+			}
+
+			expect(blocks).toEqual([text, text, text]);
+		});
+	}
+
+	it("#given no file locator #when a missing server is reported #then the full guidance is kept", async () => {
+		const result = await collectPostEditDiagnostics({
+			filePaths: ["a.ts"],
+			runDiagnostics: async () => notInstalled("typescript"),
+		});
+
+		expect(result.blocks).toEqual([{ filePath: "a.ts", diagnostics: `${FULL_NUDGE} (typescript)` }]);
+	});
+});

package/packages/lsp-core/src/post-edit/orchestration.ts

@@ -1,5 +1,8 @@
 import { extname } from "node:path";
 
+import type { PostEditFileLocation } from "./file-location.js";
+import { notInstalledGuidance, type PostEditNotInstalledOutcome } from "./not-installed-guidance.js";
+
 const DEFAULT_MAX_CONCURRENCY = 4;
 const CLEAN_DIAGNOSTICS_TEXT = "No diagnostics found";
 
@@ -8,7 +11,8 @@ export type PostEditDiagnosticsOutcome =
 	| {
 			readonly kind: "not_configured";
 			readonly extension: string;
-	  };
+	  }
+	| PostEditNotInstalledOutcome;
 
 export type DiagnosticsRunner = (filePath: string) => Promise<PostEditDiagnosticsOutcome>;
 
@@ -19,7 +23,7 @@ export interface PostEditDiagnosticsBlock {
 
 export interface PostEditDiagnosticsObservation {
 	readonly filePath: string;
-	readonly kind: "block" | "clean" | "not_configured";
+	readonly kind: "block" | "clean" | "not_configured" | "not_installed";
 }
 
 export interface PostEditDiagnosticsResult {
@@ -29,6 +33,7 @@ export interface PostEditDiagnosticsResult {
 
 export interface PostEditNotConfiguredCache {
 	readonly notConfiguredExtensions: Set<string>;
+	readonly notInstalledServers: Set<string>;
 }
 
 export interface CollectPostEditDiagnosticsInput {
@@ -36,6 +41,7 @@ export interface CollectPostEditDiagnosticsInput {
 	readonly runDiagnostics: DiagnosticsRunner;
 	readonly cache?: PostEditNotConfiguredCache;
 	readonly maxConcurrency?: number;
+	readonly locateFile?: (filePath: string) => PostEditFileLocation;
 }
 
 interface IndexedFilePath {
@@ -50,11 +56,12 @@ interface IndexedDiagnostics {
 }
 
 export function createPostEditNotConfiguredCache(): PostEditNotConfiguredCache {
-	return { notConfiguredExtensions: new Set() };
+	return { notConfiguredExtensions: new Set(), notInstalledServers: new Set() };
 }
 
 export function resetPostEditNotConfiguredCache(cache: PostEditNotConfiguredCache): void {
 	cache.notConfiguredExtensions.clear();
+	cache.notInstalledServers.clear();
 }
 
 export async function collectPostEditDiagnostics(
@@ -67,8 +74,15 @@ export async function collectPostEditDiagnostics(
 	const observations: PostEditDiagnosticsObservation[] = [];
 
 	for (const result of results) {
-		const classification = classifyDiagnostics(result.outcome);
+		const outcome = result.outcome;
+		const classification =
+			typeof outcome !== "string" && outcome.kind === "not_installed"
+				? classifyNotInstalled(notInstalledGuidance(result.filePath, outcome, cache, input.locateFile))
+				: classifyDiagnostics(outcome);
 		switch (classification.kind) {
+			case "not_installed":
+				observations.push({ filePath: result.filePath, kind: "not_installed" });
+				break;
 			case "clean":
 				observations.push({ filePath: result.filePath, kind: "clean" });
 				break;
@@ -146,9 +160,16 @@ async function collectFileDiagnostics(
 
 function normalizeDiagnosticsOutcome(outcome: PostEditDiagnosticsOutcome): PostEditDiagnosticsOutcome {
 	if (typeof outcome === "string") return normalizeDiagnosticsText(outcome);
+	if (outcome.kind === "not_installed") return { ...outcome, text: normalizeDiagnosticsText(outcome.text) };
 	return outcome;
 }
 
+function classifyNotInstalled(
+	guidance: string | undefined,
+): { readonly kind: "not_installed" } | { readonly kind: "block"; readonly diagnostics: string } {
+	return guidance === undefined ? { kind: "not_installed" } : { kind: "block", diagnostics: guidance };
+}
+
 function normalizeDiagnosticsText(text: string): string {
 	return text.trim();
 }
@@ -159,7 +180,7 @@ function formatDiagnosticsError(error: Error): string {
 }
 
 function classifyDiagnostics(
-	outcome: PostEditDiagnosticsOutcome,
+	outcome: Exclude<PostEditDiagnosticsOutcome, PostEditNotInstalledOutcome>,
 ):
 	| { readonly kind: "clean" }
 	| { readonly kind: "not_configured"; readonly extension: string }

package/packages/lsp-daemon/dist/cli.js

@@ -5350,7 +5350,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/lsp-daemon/dist/client.js

@@ -5586,7 +5586,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/lsp-daemon/dist/index.js

@@ -5581,7 +5581,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/lsp-tools-mcp/dist/cli.js

@@ -4919,7 +4919,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/lsp-tools-mcp/dist/mcp.js

@@ -4915,7 +4915,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/lsp-tools-mcp/dist/tools.js

@@ -4603,7 +4603,8 @@ function missingDependencyAvailability(error) {
         extensions: [...error.lookup.server.extensions],
         installHint: error.lookup.installHint,
         installDecisionTool: context.capabilities.installDecisionTool,
-        installDecisionsPath: context.installDecisionsPath
+        installDecisionsPath: context.installDecisionsPath,
+        decision: loadInstallDecision(error.lookup.server.id)?.decision ?? null
       };
     default: {
       const exhaustive = error.lookup;

package/packages/omo-codex/plugin/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "omo",
-  "version": "5.1.3",
+  "version": "5.1.4",
   "description": "One Codex plugin namespace for Yeongyu's local Codex components.",
   "author": {
     "name": "Yeongyu Kim",

package/packages/omo-codex/plugin/components/bootstrap/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"command": "node \"${PLUGIN_ROOT}/components/bootstrap/dist/cli.js\" hook session-start",
 						"commandWindows": "powershell -NoProfile -ExecutionPolicy Bypass -File \"${PLUGIN_ROOT}\\components\\bootstrap\\scripts\\bootstrap.ps1\"",
 						"timeout": 30,
-						"statusMessage": "(OmO 5.1.3) Checking Bootstrap Provisioning"
+						"statusMessage": "(OmO 5.1.4) Checking Bootstrap Provisioning"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/bootstrap/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sisyphuslabs/codex-bootstrap",
-	"version": "5.1.3",
+	"version": "5.1.4",
 	"description": "Codex SessionStart bootstrap component that provisions LazyCodex runtime dependencies from a detached worker.",
 	"type": "module",
 	"private": true,

package/packages/omo-codex/plugin/components/comment-checker/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-tool-use",
 						"timeout": 30,
-						"statusMessage": "(OmO 5.1.3) Checking Comments"
+						"statusMessage": "(OmO 5.1.4) Checking Comments"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/comment-checker/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@code-yeongyu/codex-comment-checker",
-	"version": "5.1.3",
+	"version": "5.1.4",
 	"description": "Codex plugin that runs comment-checker after edit-like PostToolUse hooks.",
 	"type": "module",
 	"packageManager": "npm@11.12.1",

package/packages/omo-codex/plugin/components/git-bash/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook pre-tool-use",
 						"timeout": 5,
-						"statusMessage": "(OmO 5.1.3) Recommending Git Bash MCP"
+						"statusMessage": "(OmO 5.1.4) Recommending Git Bash MCP"
 					}
 				]
 			}
@@ -20,7 +20,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-compact",
 						"timeout": 5,
-						"statusMessage": "(OmO 5.1.3) Resetting Git Bash MCP Reminder"
+						"statusMessage": "(OmO 5.1.4) Resetting Git Bash MCP Reminder"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/git-bash/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sisyphuslabs/codex-git-bash-hook",
-	"version": "5.1.3",
+	"version": "5.1.4",
 	"description": "Codex hook component that reminds Windows sessions to prefer the OMO git_bash MCP.",
 	"type": "module",
 	"private": true,

package/packages/omo-codex/plugin/components/lazycodex-executor-verify/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/components/lazycodex-executor-verify/dist/cli.js\" hook subagent-stop",
 						"timeout": 10,
-						"statusMessage": "(OmO 5.1.3) Verifying LazyCodex Executor Evidence"
+						"statusMessage": "(OmO 5.1.4) Verifying LazyCodex Executor Evidence"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/lazycodex-executor-verify/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@code-yeongyu/codex-lazycodex-executor-verify",
-	"version": "5.1.3",
+	"version": "5.1.4",
 	"description": "Codex SubagentStop evidence verifier for LazyCodex executor completions.",
 	"type": "module",
 	"packageManager": "npm@11.12.1",

package/packages/omo-codex/plugin/components/lsp/dist/.omo-runtime-manifest.json

@@ -1,7 +1,7 @@
 {
   "schemaVersion": 1,
-  "version": "5.1.3",
-  "inputDigest": "sha256:affd143b968dfe926241288a42ac81d6f67cd8a853569bd8d7bac0c9ee6ed75c",
+  "version": "5.1.4",
+  "inputDigest": "sha256:4b9c0202761e8abe92155e627fa7548e4252aadd31dd92f1412d6bf1e357ed23",
   "outputs": [
     {
       "path": "cli.d.ts",
@@ -9,7 +9,7 @@
     },
     {
       "path": "cli.js",
-      "sha256": "a0155ce31758825f26a35acbc894361e22a6531bab3fc47bc1f5c2ed054580ef"
+      "sha256": "d793d83fb82b1fafe52e619f545c5195398498d1f95f15d84904fe3d0a20befe"
     },
     {
       "path": "codex-hook-cli.d.ts",
@@ -41,7 +41,7 @@
     },
     {
       "path": "lsp-session-state.js",
-      "sha256": "d9c1f4bbace5a8a1fad3d0c3d225e4019700946b2391d1d5ae4d2362ca2e495f"
+      "sha256": "8c0e4fff28cb9deaca9c1b12ed2b0663a93fdf8532a8028f90a241b0607b8368"
     },
     {
       "path": "mutated-file-paths.d.ts",