oh-my-opencode 5.0.0-beta.9 → 5.0.0-beta.90

package/packages/shared-skills/skills/visual-qa/AGENTS.md

@@ -0,0 +1,58 @@
+# visual-qa — Bundled Visual-Evidence CLI
+
+**Generated:** 2026-08-24 (f3642fcda)
+
+## OVERVIEW
+
+The visual-QA skill's executable core: a zero-dependency Node CLI that produces machine evidence (`image-diff`, `tui-check`) plus the TypeScript sources it is bundled from. Earned this file: the only shared skill shipping a built bundle whose runtime and development sources must be kept in lockstep.
+
+## STRUCTURE
+
+```
+visual-qa/
+├── SKILL.md                      # reviewer workflow (dual oracle, evidence gates) — the prose contract
+├── references/browser-setup.md
+└── scripts/
+    ├── visual-qa.mjs             # SHIPPED RUNTIME: bun-build bundle of cli.ts (+ embedded modules)
+    ├── cli.ts                    # development source; dispatches image-diff / tui-check
+    ├── image-diff.ts             # diffImages — 8x8 grid cells, hotspots, rounded metrics
+    ├── tui-grid.ts               # checkTui — column overflow + border alignment verdicts
+    ├── east-asian-width.ts       # charWidth / stringWidth — CJK-aware width math
+    ├── ansi.ts                   # ANSI escape stripping (width must be escape-aware)
+    ├── png-decode.ts / png-crc.ts / png-synth.ts   # stdlib PNG codec (no deps)
+    ├── types.ts
+    └── *.test.ts                 # co-located bun tests for every module above
+```
+
+## BUNDLE/SOURCE DUALITY
+
+`visual-qa.mjs` is the artifact the skill's commands invoke (`node "$SKILL_DIR/scripts/visual-qa.mjs" …`); the `.ts` files exist for development and tests only. A behavior fix lands in the TS source AND the bundle is regenerated from `cli.ts` — editing one without the other makes tests and runtime disagree. Never hand-edit the `.mjs`.
+
+## SURFACE
+
+- Commands: `image-diff <reference.png> <actual.png>` and `tui-check <capture.txt> --cols <N>`; JSON verdict output (hotspot cells, overflow lines, wide-char columns, border alignment).
+- Module exports: `diffImages`, `checkTui`, `charWidth`/`stringWidth`, ANSI + PNG helpers. `cli.ts` owns `CliError`, `parseColumns`, `run`, `main`.
+
+## CONVENTIONS
+
+- Zero runtime dependencies — PNG decode/synthesis and ANSI handling are hand-rolled in `scripts/`; keep it that way (the bundle must stay require-free apart from `node:` builtins).
+- Width is never `String.length`: CJK wide characters and ANSI escapes are accounted for before any column math.
+- Tests are co-located `bun test scripts/*.test.ts`, given/when/then style per repo convention.
+
+## ANTI-PATTERNS
+
+- NEVER hand-edit `visual-qa.mjs`; regenerate from source.
+- Don't add an npm dependency to make PNG/diff easier — the no-dep bundle is the point.
+- Column math that ignores CJK width or ANSI escapes is wrong by construction; `tui-check` exists because text-diff tools get terminal grids wrong.
+- Skill-level rule worth repeating for code changes: `tmux capture-pane` is forbidden as a capture mechanism.
+
+## COMMANDS
+
+```bash
+# from packages/shared-skills/skills/visual-qa/
+node scripts/visual-qa.mjs image-diff <reference.png> <actual.png>
+node scripts/visual-qa.mjs tui-check <capture.txt> --cols 80
+bun test scripts/*.test.ts
+```
+
+- Parent: [`packages/shared-skills/AGENTS.md`](../../AGENTS.md).

package/packages/shared-skills/skills/visual-qa/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: visual-qa
-description: "MUST USE after building/changing any UI or when asked whether a page, component, or TUI looks right. Rigorous visual QA across web/page and terminal UIs. Prefer browser:control-in-app-browser for unauthenticated browser/page QA in Codex, then Playwright/agent-browser/dev-browser. Captures screenshot/TUI evidence with bundled diff scripts, runs design-system/functional and visual-fidelity/CJK reviewer passes, then synthesizes a good/bad verdict. Triggers: visual QA, screenshot/pixel diff, UI looks wrong, reference fidelity, design system check, responsive check, CJK text clipping, TUI alignment, box-drawing drift."
+description: "Runs rigorous visual QA across web, terminal, and paginated surfaces with screenshot evidence and a verdict. Use for any UI build or change, or when asked whether a page, component, or TUI looks right."
 ---
 
 # Visual QA - Dual-Oracle Web and TUI Verification
@@ -9,7 +9,7 @@ Verify a rendered UI against intent using objective script evidence plus two par
 
 ## Purpose and when to use
 
-- Use after you build or change any UI, before calling it done. Covers web/page UIs and TUI/terminal UIs.
+- Use after you build or change any UI, before calling it done. Covers web/page UIs, TUI/terminal UIs, and paginated documents.
 - Use when output must match a mock, a baseline, or a stated design intent; when you suspect a regression; when CJK (Korean/Japanese/Chinese) text may clip, misalign, or wrap awkwardly; when a claimed design system might actually be a flat image; when a terminal layout may overflow or its borders may break.
 - Skip when there is no rendered surface (pure backend or library logic with no visual or terminal output). For broad post-implementation review use review-work; this skill is the visual specialist.
 
@@ -19,6 +19,7 @@ In the commands below, `$SKILL_DIR` is this skill's own directory (the folder co
 
 - Web/page UI: renders in a browser (HTML/CSS/JS, components, canvas, SVG). Evidence is screenshots.
 - TUI/terminal UI: renders as text in a terminal (box-drawing, panes, status lines, REPL/TUI apps). Evidence is terminal captures.
+- Paginated document: renders as ordered pages (PDF report, printed HTML, exported deck). Evidence is every page rendered to an image - `pdftoppm -png -r 150 <file>.pdf <prefix>` or the pipeline's own renderer. Extracted text is not evidence here: layout is exactly what extraction discards, so a stranded block, a split table, or a near-empty page survives a clean text check.
 - Reference-fidelity UI: any web/page UI built from a concrete reference packet, including screenshots, generated Imagen/Stitch mockups, Figma exports, overview text, annotations, or source-site captures. Evidence is the full reference packet plus same-size actual captures.
 
 If the change touches both, run both capture tracks and feed both into the passes.
@@ -48,7 +49,7 @@ Before any reviewer sees an image, verify each capture yourself: the file signat
 ### Web
 
 1. Capture a REFERENCE image: the user's mock/target, generated page snapshot, Figma export, source-site capture, or known-good baseline. Save as PNG. If the user provided overview text or annotations, save them next to the image and treat them as part of the reference packet.
-2. Capture the ACTUAL rendered screenshot at the same viewport size. In Codex, when `browser:control-in-app-browser` is available and the page does not need an authenticated user browser session, use that Browser plugin first for navigation, page state inspection, and screenshots. If it is unavailable or lacks the needed capture action, use the project's configured browser tooling (the playwright, agent-browser, or dev-browser skill). Save as PNG. If none is configured or available, install [agent-browser](https://github.com/vercel-labs/agent-browser) (`npm install -g agent-browser && agent-browser install`) and capture with it — see `$SKILL_DIR/references/agent-browser-setup.md` for the full setup, including how to shoot a fixed-viewport screenshot.
+2. Capture the ACTUAL rendered screenshot at the reference viewport with omowright from js eval (the library is staged in the `browser` skill): the owned engine (`connectPipe` on a task-owned profile, viewport pinned with `emulate`, then `page.screenshot()`) for anything unauthenticated, or the attached engine (`connectBrowserSkill()` → `session.screenshot()`) when the page needs the user's login — never a clone of, or a launch against, the user's live profile. Save PNG and return its path; close the browser or stop the session. See `$SKILL_DIR/references/browser-setup.md` for fixed-viewport examples and prerequisites.
 3. Run the diff and keep the JSON:
 
 ```

package/packages/shared-skills/skills/visual-qa/references/browser-setup.md

@@ -0,0 +1,77 @@
+# Browser setup (Web capture)
+
+Capture with omowright from the js-eval kernel. The library is staged inside the `browser` skill;
+load it once per session:
+
+```js
+const { loadOmowright } = await import("<browser-skill-root>/scripts/omowright.mjs")
+const { omowright } = await loadOmowright()
+```
+
+## Owned engine (default for QA)
+
+A browser your code launches, with a task-owned profile, pinned viewport and no user state.
+`connectPipe` opens no listening port and reaps the process on `close()`.
+
+```js
+// js-eval cell; url and pngPath belong to this QA run.
+const { mkdtempSync, rmSync } = await import("node:fs")
+const profile = mkdtempSync(`${(await import("node:os")).tmpdir()}/visual-qa-`)
+const browser = await omowright.connectPipe({
+  browserPath: chromeBinary,                      // installed Chrome, Chromium, CloakBrowser or chrome-headless-shell
+  browserArgs: ["--headless", "--no-first-run", `--user-data-dir=${profile}`],
+  storageRoot: profile,
+})
+try {
+  const page = await browser.newTab("about:blank")
+  await omowright.emulate(page, { width: 1280, height: 720, deviceScaleFactor: 1, mobile: false, hasTouch: false })
+  await page.goto(url, { waitUntil: "load" })
+  await Bun.write(pngPath, await page.screenshot())
+  console.log(pngPath)
+} finally {
+  await browser.close()
+  rmSync(profile, { recursive: true, force: true })
+}
+```
+
+Chrome must already be installed; report an absent executable rather than downloading a managed
+browser. For bot-scored or WAF targets use `connectCloakProfile({ profileDir })` (CloakBrowser
+with a pinned fingerprint seed) — the `browser` skill's `references/owned-engine/README.md`
+covers it.
+
+## Attached engine (authenticated pages)
+
+When the capture needs the user's login, drive the browser they are signed into instead of
+cloning its profile:
+
+```js
+const session = await omowright.connectBrowserSkill({ name: "visual-qa capture", focused: false })
+try {
+  await session.navigate(url, { waitUntil: "load" })
+  await session.resize(1280, 720)
+  const shot = await session.screenshot()            // { buffer, width, height }
+  await Bun.write(pngPath, shot.buffer)
+} finally {
+  await session.stop()
+}
+```
+
+NEVER launch anything against, or clear cookies/cache/site data from, the user's live profile;
+the attached engine is the only sanctioned way to a signed-in page. If no extension is connected,
+run the `browser` skill's `scripts/browser-install.mjs` for the browser the user actually uses
+(from memory, or its detection; on `needsChoice` ask them and pass `--browser=<id>`), relay its
+one human step, and wait — do
+not fall back to the owned engine for an authenticated criterion.
+
+## Capture a screenshot at a fixed viewport
+
+Match CSS viewport AND PNG dimensions: pin `deviceScaleFactor` through `emulate` (owned) or
+`resize` (attached) instead of resizing the PNG to force a pass. Wait for the specific page state
+(a locator, a `waitForURL`, a `createNetworkSnoop(page).waitFor(...)`), not a sleep, then compare:
+
+```sh
+node "$SKILL_DIR/scripts/visual-qa.mjs" image-diff reference.png actual.png
+```
+
+Inspect `dimensionsMatch` and `diffRatio`, then inspect the image. Close every browser and session
+and the fixture server, even on a failed capture; remove the owned profile in the same `finally`.

package/postinstall.mjs

@@ -15,9 +15,12 @@ import { detectPlatformBinaryMismatch } from "./bin/version-mismatch.js";
 const require = createRequire(import.meta.url);
 
 const MIN_OPENCODE_VERSION = "1.4.0";
+const OPENCODE_VERSION_PROBE_TIMEOUT_MS = 3_000;
 const OPENCODE_PLUGIN_PACKAGES = ["oh-my-opencode", "oh-my-openagent"];
 const RENAME_NOTICE =
   "oh-my-openagent: the 'omo' command is now 'omo-agent-toolkit' (the old name was removed in this major release).";
+const NATIVE_NOTICE =
+  "oh-my-openagent: OmO Native (beta) is the same omo as one 'omo' command, with no OpenCode host: bun add -g omo-ai@beta";
 
 /**
  * Parse version string into numeric parts
@@ -62,6 +65,7 @@ function checkOpenCodeVersion() {
     const result = require("child_process").execSync("opencode --version", {
       encoding: "utf-8",
       stdio: ["pipe", "pipe", "ignore"],
+      timeout: OPENCODE_VERSION_PROBE_TIMEOUT_MS,
     });
     const version = result.trim();
     const ok = compareVersions(version, MIN_OPENCODE_VERSION);
@@ -141,6 +145,7 @@ function main() {
   // npm >= 7 hides lifecycle output unless --foreground-scripts, so this notice is
   // best-effort: the reliable migration surfaces are the CHANGELOG, docs, and README.
   console.log(RENAME_NOTICE);
+  console.log(NATIVE_NOTICE);
 
   invalidateOpenCodePluginCache();
 

package/script/qa/web-terminal-visual-qa.mjs

@@ -30,6 +30,8 @@ Inputs:
   --from-file <path>     Render an existing raw terminal byte stream through xterm.js (replay; no interaction).
   --input <token>        Scripted interaction, repeatable, applied in order THROUGH the browser terminal.
                          Literal text is typed; {Enter} {Tab} {Escape} {ArrowDown} {Ctrl+C} etc. are pressed as keys.
+                         {WheelUp} and {WheelDown} send real browser mouse-wheel input over the xterm viewport.
+                         {CtrlSlashByte} and {Ctrl7Byte} send their shared exact terminal control byte.
   --cwd <path>           Working directory for --command. Default: current directory.
   --cols <n> / --rows <n>  Terminal geometry. Default: 120 x 32.
   --dwell-ms <n>         Milliseconds to let the TUI settle after input before capture. Default: 1500.

package/script/qa/xterm-live-terminal.mjs

@@ -80,10 +80,26 @@ const NAMED_KEYS = new Set([
 // An `input` token wrapped in {Braces} is pressed as a named key; anything else
 // is typed literally. Both flow through the browser terminal (xterm onData ->
 // pty), so the interaction is genuinely driven in the web terminal.
-async function driveInput(page, inputs, keyDelayMs) {
+export async function driveInput(page, inputs, keyDelayMs) {
   for (const raw of inputs) {
     const match = /^\{(.+)\}$/.exec(raw);
-    if (match && NAMED_KEYS.has(match[1])) {
+    if (
+      match?.[1] === "CtrlSlashByte" ||
+      match?.[1] === "Ctrl7Byte"
+    ) {
+      await page.evaluate((data) => window.__ptyInput(data), "\u001f");
+    } else if (match && /^(WheelUp|WheelDown)$/.test(match[1])) {
+      const terminal = await page.$(".xterm-screen");
+      const bounds = await terminal?.boundingBox();
+      if (!bounds) throw new Error("xterm viewport unavailable for wheel input");
+      await page.mouse.move(
+        bounds.x + bounds.width / 2,
+        bounds.y + bounds.height / 2,
+      );
+      await page.mouse.wheel({
+        deltaY: match[1] === "WheelDown" ? 720 : -720,
+      });
+    } else if (match && NAMED_KEYS.has(match[1])) {
       await page.keyboard.press(match[1] === "Space" ? " " : match[1], { delay: 15 });
     } else if (match && /^Ctrl\+(.)$/i.test(match[1])) {
       const key = /^Ctrl\+(.)$/i.exec(match[1])[1];

package/.agents/skills/work-with-pr-workspace/evals/evals.json

@@ -1,76 +0,0 @@
-{
-  "skill_name": "work-with-pr",
-  "evals": [
-    {
-      "id": 1,
-      "prompt": "I need to add a `max_background_agents` config option to oh-my-opencode that limits how many background agents can run simultaneously. It should be in the plugin config schema with a default of 5. Add validation and make sure the background manager respects it. Create a PR for this.",
-      "expected_output": "Agent creates worktree, implements config option with schema validation, adds tests, creates PR, iterates through verification gates until merged",
-      "files": [],
-      "assertions": [
-        {"id": "worktree-isolation", "text": "Plan uses git worktree in a sibling directory (not main working directory)"},
-        {"id": "branch-from-dev", "text": "Branch is created from origin/dev (not master/main)"},
-        {"id": "atomic-commits", "text": "Plan specifies multiple atomic commits for multi-file changes"},
-        {"id": "local-validation", "text": "Runs bun run typecheck, bun test, and bun run build before pushing"},
-        {"id": "pr-targets-dev", "text": "PR is created targeting dev branch (not master)"},
-        {"id": "two-gates", "text": "Verification loop includes both gates: CI and Cubic"},
-        {"id": "gate-ordering", "text": "Gates are checked in order: CI first, then Cubic"},
-        {"id": "cubic-check-method", "text": "Cubic check uses gh api to check cubic-dev-ai[bot] reviews for 'No issues found'"},
-        {"id": "worktree-cleanup", "text": "Plan includes worktree cleanup after merge"},
-        {"id": "real-file-references", "text": "Code changes reference actual files in the codebase (config schema, background manager)"}
-      ]
-    },
-    {
-      "id": 2,
-      "prompt": "The atlas hook has a bug where it crashes when boulder.json is missing the worktree_path field. Fix it and land the fix as a PR. Make sure CI passes.",
-      "expected_output": "Agent creates worktree for the fix branch, adds null check and test for missing worktree_path, creates PR, iterates verification loop",
-      "files": [],
-      "assertions": [
-        {"id": "worktree-isolation", "text": "Plan uses git worktree in a sibling directory"},
-        {"id": "minimal-fix", "text": "Fix is minimal — adds null check, doesn't refactor unrelated code"},
-        {"id": "test-added", "text": "Test case added for the missing worktree_path scenario"},
-        {"id": "two-gates", "text": "Verification loop includes both gates: CI, Cubic"},
-        {"id": "real-atlas-files", "text": "References actual atlas hook files in src/hooks/atlas/"},
-        {"id": "fix-branch-naming", "text": "Branch name follows fix/ prefix convention"}
-      ]
-    },
-    {
-      "id": 3,
-      "prompt": "Refactor src/tools/delegate-task/constants.ts to split DEFAULT_CATEGORIES and CATEGORY_MODEL_REQUIREMENTS into separate files. Keep backward compatibility with the barrel export. Make a PR.",
-      "expected_output": "Agent creates worktree, splits file with atomic commits, ensures imports still work via barrel, creates PR, runs through all gates",
-      "files": [],
-      "assertions": [
-        {"id": "worktree-isolation", "text": "Plan uses git worktree in a sibling directory"},
-        {"id": "multiple-atomic-commits", "text": "Uses 2+ commits for the multi-file refactor"},
-        {"id": "barrel-export", "text": "Maintains backward compatibility via barrel re-export in constants.ts or index.ts"},
-        {"id": "three-gates", "text": "Verification loop includes all 3 gates"},
-        {"id": "real-constants-file", "text": "References actual src/tools/delegate-task/constants.ts file and its exports"}
-      ]
-    },
-    {
-      "id": 4,
-      "prompt": "implement issue #100 - we need to add a new built-in MCP for arxiv paper search. just the basic search endpoint, nothing fancy. pr it",
-      "expected_output": "Agent creates worktree, implements arxiv MCP following existing MCP patterns (websearch, context7, grep_app), creates PR with proper template, verification loop runs",
-      "files": [],
-      "assertions": [
-        {"id": "worktree-isolation", "text": "Plan uses git worktree in a sibling directory"},
-        {"id": "follows-mcp-pattern", "text": "New MCP follows existing pattern from src/mcp/ (websearch, context7, grep_app)"},
-        {"id": "three-gates", "text": "Verification loop includes all 3 gates"},
-        {"id": "pr-targets-dev", "text": "PR targets dev branch"},
-        {"id": "local-validation", "text": "Runs local checks before pushing"}
-      ]
-    },
-    {
-      "id": 5,
-      "prompt": "The comment-checker hook is too aggressive - it's flagging legitimate comments that happen to contain 'Note:' as AI slop. Relax the regex pattern and add test cases for the false positives. Work on a separate branch and make a PR.",
-      "expected_output": "Agent creates worktree, fixes regex, adds specific test cases for false positive scenarios, creates PR, all three gates pass",
-      "files": [],
-      "assertions": [
-        {"id": "worktree-isolation", "text": "Plan uses git worktree in a sibling directory"},
-        {"id": "real-comment-checker-files", "text": "References actual comment-checker hook files in the codebase"},
-        {"id": "regression-tests", "text": "Adds test cases specifically for 'Note:' false positive scenarios"},
-        {"id": "three-gates", "text": "Verification loop includes all 3 gates"},
-        {"id": "minimal-change", "text": "Only modifies regex and adds tests — no unrelated changes"}
-      ]
-    }
-  ]
-}

package/.agents/skills/work-with-pr-workspace/iteration-1/benchmark.json

@@ -1,138 +0,0 @@
-{
-  "skill_name": "work-with-pr",
-  "iteration": 1,
-  "summary": {
-    "with_skill": {
-      "pass_rate": 0.968,
-      "mean_duration_seconds": 340.2,
-      "stddev_duration_seconds": 169.3
-    },
-    "without_skill": {
-      "pass_rate": 0.516,
-      "mean_duration_seconds": 303.0,
-      "stddev_duration_seconds": 77.8
-    },
-    "delta": {
-      "pass_rate": 0.452,
-      "mean_duration_seconds": 37.2,
-      "stddev_duration_seconds": 91.5
-    }
-  },
-  "evals": [
-    {
-      "eval_name": "happy-path-feature-config-option",
-      "with_skill": {
-        "pass_rate": 1.0,
-        "passed": 10,
-        "total": 10,
-        "duration_seconds": 292,
-        "failed_assertions": []
-      },
-      "without_skill": {
-        "pass_rate": 0.4,
-        "passed": 4,
-        "total": 10,
-        "duration_seconds": 365,
-        "failed_assertions": [
-          {"assertion": "Plan uses git worktree in a sibling directory", "reason": "Uses git checkout -b, no worktree isolation"},
-          {"assertion": "Plan specifies multiple atomic commits for multi-file changes", "reason": "Steps listed sequentially but no atomic commit strategy mentioned"},
-          {"assertion": "Verification loop includes all 3 gates: CI, review-work, and Cubic", "reason": "Only mentions CI pipeline in step 6. No review-work or Cubic."},
-          {"assertion": "Gates are checked in order: CI first, then review-work, then Cubic", "reason": "No gate ordering - only CI mentioned"},
-          {"assertion": "Cubic check uses gh api to check cubic-dev-ai[bot] reviews", "reason": "No mention of Cubic at all"},
-          {"assertion": "Plan includes worktree cleanup after merge", "reason": "No worktree used, no cleanup needed"}
-        ]
-      }
-    },
-    {
-      "eval_name": "bugfix-atlas-null-check",
-      "with_skill": {
-        "pass_rate": 1.0,
-        "passed": 6,
-        "total": 6,
-        "duration_seconds": 506,
-        "failed_assertions": []
-      },
-      "without_skill": {
-        "pass_rate": 0.667,
-        "passed": 4,
-        "total": 6,
-        "duration_seconds": 325,
-        "failed_assertions": [
-          {"assertion": "Plan uses git worktree in a sibling directory", "reason": "No worktree. Steps go directly to creating branch and modifying files."},
-          {"assertion": "Verification loop includes all 3 gates", "reason": "Only mentions CI pipeline (step 5). No review-work or Cubic."}
-        ]
-      }
-    },
-    {
-      "eval_name": "refactor-split-constants",
-      "with_skill": {
-        "pass_rate": 1.0,
-        "passed": 5,
-        "total": 5,
-        "duration_seconds": 181,
-        "failed_assertions": []
-      },
-      "without_skill": {
-        "pass_rate": 0.4,
-        "passed": 2,
-        "total": 5,
-        "duration_seconds": 229,
-        "failed_assertions": [
-          {"assertion": "Plan uses git worktree in a sibling directory", "reason": "git checkout -b only, no worktree"},
-          {"assertion": "Uses 2+ commits for the multi-file refactor", "reason": "Single atomic commit: 'refactor: split delegate-task constants and category model requirements'"},
-          {"assertion": "Verification loop includes all 3 gates", "reason": "Only mentions typecheck/test/build. No review-work or Cubic."}
-        ]
-      }
-    },
-    {
-      "eval_name": "new-mcp-arxiv-casual",
-      "with_skill": {
-        "pass_rate": 1.0,
-        "passed": 5,
-        "total": 5,
-        "duration_seconds": 152,
-        "failed_assertions": []
-      },
-      "without_skill": {
-        "pass_rate": 0.6,
-        "passed": 3,
-        "total": 5,
-        "duration_seconds": 197,
-        "failed_assertions": [
-          {"assertion": "Verification loop includes all 3 gates", "reason": "Only mentions bun test/typecheck/build. No review-work or Cubic."}
-        ]
-      }
-    },
-    {
-      "eval_name": "regex-fix-false-positive",
-      "with_skill": {
-        "pass_rate": 0.8,
-        "passed": 4,
-        "total": 5,
-        "duration_seconds": 570,
-        "failed_assertions": [
-          {"assertion": "Only modifies regex and adds tests — no unrelated changes", "reason": "Also proposes config schema change (exclude_patterns) and Go binary update — goes beyond minimal fix"}
-        ]
-      },
-      "without_skill": {
-        "pass_rate": 0.6,
-        "passed": 3,
-        "total": 5,
-        "duration_seconds": 399,
-        "failed_assertions": [
-          {"assertion": "Plan uses git worktree in a sibling directory", "reason": "git checkout -b, no worktree"},
-          {"assertion": "Verification loop includes all 3 gates", "reason": "Only bun test and typecheck. No review-work or Cubic."}
-        ]
-      }
-    }
-  ],
-  "analyst_observations": [
-    "Three-gates assertion (CI + review-work + Cubic) is the strongest discriminator: 5/5 with-skill vs 0/5 without-skill. Without the skill, agents never know about Cubic or review-work gates.",
-    "Worktree isolation is nearly as discriminating (5/5 vs 1/5). One without-skill run (eval-4) independently chose worktree, suggesting some agents already know worktree patterns, but the skill makes it consistent.",
-    "The skill's only failure (eval-5 minimal-change) reveals a potential over-engineering tendency: the skill-guided agent proposed config schema changes and Go binary updates for what should have been a minimal regex fix. Consider adding explicit guidance for fix-type tasks to stay minimal.",
-    "Duration tradeoff: with-skill is 12% slower on average (340s vs 303s), driven mainly by eval-2 (bugfix) and eval-5 (regex fix) where the skill's thorough verification planning adds overhead. For eval-1 and eval-3-4, with-skill was actually faster.",
-    "Without-skill duration has lower variance (stddev 78s vs 169s), suggesting the skill introduces more variable execution paths depending on task complexity.",
-    "Non-discriminating assertions: 'References actual files', 'PR targets dev', 'Runs local checks' — these pass regardless of skill. They validate baseline agent competence, not skill value. Consider removing or downweighting in future iterations.",
-    "Atomic commits assertion discriminates moderately (2/2 with-skill tested vs 0/2 without-skill tested). Without the skill, agents default to single commits even for multi-file refactors."
-  ]
-}

package/.agents/skills/work-with-pr-workspace/iteration-1/benchmark.md

@@ -1,42 +0,0 @@
-# Benchmark: work-with-pr (Iteration 1)
-
-## Summary
-
-| Metric | With Skill | Without Skill | Delta |
-|--------|-----------|---------------|-------|
-| Pass Rate | 96.8% (30/31) | 51.6% (16/31) | +45.2% |
-| Mean Duration | 340.2s | 303.0s | +37.2s |
-| Duration Stddev | 169.3s | 77.8s | +91.5s |
-
-## Per-Eval Breakdown
-
-| Eval | With Skill | Without Skill | Delta |
-|------|-----------|---------------|-------|
-| happy-path-feature-config-option | 100% (10/10) | 40% (4/10) | +60% |
-| bugfix-atlas-null-check | 100% (6/6) | 67% (4/6) | +33% |
-| refactor-split-constants | 100% (5/5) | 40% (2/5) | +60% |
-| new-mcp-arxiv-casual | 100% (5/5) | 60% (3/5) | +40% |
-| regex-fix-false-positive | 80% (4/5) | 60% (3/5) | +20% |
-
-## Key Discriminators
-
-- **three-gates** (CI + review-work + Cubic): 5/5 vs 0/5 — strongest signal
-- **worktree-isolation**: 5/5 vs 1/5
-- **atomic-commits**: 2/2 vs 0/2
-- **cubic-check-method**: 1/1 vs 0/1
-
-## Non-Discriminating Assertions
-
-- References actual files: passes in both conditions
-- PR targets dev: passes in both conditions
-- Runs local checks before pushing: passes in both conditions
-
-## Only With-Skill Failure
-
-- **eval-5 minimal-change**: Skill-guided agent proposed config schema changes and Go binary update for a minimal regex fix. The skill may encourage over-engineering in fix scenarios.
-
-## Analyst Notes
-
-- The skill adds most value for procedural knowledge (verification gates, worktree workflow) that agents cannot infer from codebase alone.
-- Duration cost is modest (+12%) and acceptable given the +45% pass rate improvement.
-- Consider adding explicit "fix-type tasks: stay minimal" guidance in iteration 2.

package/.agents/skills/work-with-pr-workspace/iteration-1/eval-1/eval_metadata.json

@@ -1,57 +0,0 @@
-{
-  "eval_id": 1,
-  "eval_name": "happy-path-feature-config-option",
-  "prompt": "I need to add a `max_background_agents` config option to oh-my-opencode that limits how many background agents can run simultaneously. It should be in the plugin config schema with a default of 5. Add validation and make sure the background manager respects it. Create a PR for this.",
-  "assertions": [
-    {
-      "id": "worktree-isolation",
-      "text": "Plan uses git worktree in a sibling directory (not main working directory)",
-      "type": "manual"
-    },
-    {
-      "id": "branch-from-dev",
-      "text": "Branch is created from origin/dev (not master/main)",
-      "type": "manual"
-    },
-    {
-      "id": "atomic-commits",
-      "text": "Plan specifies multiple atomic commits for multi-file changes",
-      "type": "manual"
-    },
-    {
-      "id": "local-validation",
-      "text": "Runs bun run typecheck, bun test, and bun run build before pushing",
-      "type": "manual"
-    },
-    {
-      "id": "pr-targets-dev",
-      "text": "PR is created targeting dev branch (not master)",
-      "type": "manual"
-    },
-    {
-      "id": "three-gates",
-      "text": "Verification loop includes all 3 gates: CI, review-work, and Cubic",
-      "type": "manual"
-    },
-    {
-      "id": "gate-ordering",
-      "text": "Gates are checked in order: CI first, then review-work, then Cubic",
-      "type": "manual"
-    },
-    {
-      "id": "cubic-check-method",
-      "text": "Cubic check uses gh api to check cubic-dev-ai[bot] reviews for 'No issues found'",
-      "type": "manual"
-    },
-    {
-      "id": "worktree-cleanup",
-      "text": "Plan includes worktree cleanup after merge",
-      "type": "manual"
-    },
-    {
-      "id": "real-file-references",
-      "text": "Code changes reference actual files in the codebase (config schema, background manager)",
-      "type": "manual"
-    }
-  ]
-}

package/.agents/skills/work-with-pr-workspace/iteration-1/eval-1/with_skill/grading.json

@@ -1,15 +0,0 @@
-{
-  "run_id": "eval-1-with_skill",
-  "expectations": [
-    {"text": "Plan uses git worktree in a sibling directory", "passed": true, "evidence": "Uses ../omo-wt/feat-max-background-agents"},
-    {"text": "Branch is created from origin/dev", "passed": true, "evidence": "git checkout dev && git pull origin dev, then branch"},
-    {"text": "Plan specifies multiple atomic commits for multi-file changes", "passed": true, "evidence": "2 commits: schema+tests, then concurrency+manager"},
-    {"text": "Runs bun run typecheck, bun test, and bun run build before pushing", "passed": true, "evidence": "Explicit pre-push section with all 3 commands"},
-    {"text": "PR is created targeting dev branch", "passed": true, "evidence": "--base dev in gh pr create"},
-    {"text": "Verification loop includes all 3 gates: CI, review-work, and Cubic", "passed": true, "evidence": "Gate A (CI), Gate B (review-work 5 agents), Gate C (Cubic)"},
-    {"text": "Gates are checked in order: CI first, then review-work, then Cubic", "passed": true, "evidence": "Explicit ordering in verify loop pseudocode"},
-    {"text": "Cubic check uses gh api to check cubic-dev-ai[bot] reviews", "passed": true, "evidence": "Mentions cubic-dev-ai[bot] and 'No issues found' signal"},
-    {"text": "Plan includes worktree cleanup after merge", "passed": true, "evidence": "Phase 4: git worktree remove ../omo-wt/feat-max-background-agents"},
-    {"text": "Code changes reference actual files in the codebase", "passed": true, "evidence": "References src/config/schema/background-task.ts, src/features/background-agent/concurrency.ts, manager.ts"}
-  ]
-}