oh-my-opencode 5.0.0-beta.62 → 5.0.0-beta.64

package/packages/omo-codex/plugin/components/ulw-loop/src/sdk/manifest.ts

@@ -15,7 +15,12 @@ export type UlwLoopOperation = (typeof ULW_LOOP_OPERATIONS)[number];
 
 export interface ToolkitOperationManifest {
 	readonly name: UlwLoopOperation;
+	/** The camelCase method that runs this operation on every SDK surface. */
+	readonly method: string;
 	readonly mutating: boolean;
+	readonly description: string;
+	/** Argument field -> type notation; a trailing `?` marks an optional field. */
+	readonly args: Readonly<Record<string, string>>;
 }
 
 export interface ToolkitManifest {
@@ -24,19 +29,128 @@ export interface ToolkitManifest {
 	readonly operations: readonly ToolkitOperationManifest[];
 }
 
+const CRITERION_INPUT =
+	'{ scenario: string, expectedEvidence: string, userModel?: "happy" | "edge" | "regression" | "adversarial", essential?: boolean }';
+const STEER_KINDS =
+	'"add_subgoal" | "split_subgoal" | "reorder_pending" | "revise_pending_wording" | "revise_criterion" | "annotate_ledger" | "mark_blocked_superseded"';
+
 export const ULW_LOOP_MANIFEST = {
 	version: 1,
 	name: "ulw-loop",
 	operations: [
-		{ name: "help", mutating: false },
-		{ name: "create-goals", mutating: true },
-		{ name: "status", mutating: false },
-		{ name: "complete-goals", mutating: true },
-		{ name: "checkpoint", mutating: true },
-		{ name: "steer", mutating: true },
-		{ name: "add-goal", mutating: true },
-		{ name: "criteria", mutating: false },
-		{ name: "record-evidence", mutating: true },
-		{ name: "record-review-blockers", mutating: true },
+		{
+			name: "help",
+			method: "help",
+			mutating: false,
+			description: "Return this manifest: every operation with its method name, argument fields, and what it does.",
+			args: {},
+		},
+		{
+			name: "create-goals",
+			method: "createGoals",
+			mutating: true,
+			description:
+				"Create the session plan from a brief; one goal per bullet, each seeded with placeholder criteria until revised.",
+			args: {
+				brief: "string",
+				codexGoalMode: '"aggregate" | "per_story"?',
+				force: "boolean?",
+				validationBatchesJson: "string?",
+			},
+		},
+		{
+			name: "status",
+			method: "status",
+			mutating: false,
+			description:
+				"Read the plan, its summary, structured nextActions, the stable evidenceRoot, and the active goal's currentAttemptDir.",
+			args: {},
+		},
+		{
+			name: "complete-goals",
+			method: "completeGoals",
+			mutating: true,
+			description:
+				"Acquire the next eligible goal or resume the in-progress one; returns { done: true } once the aggregate is complete.",
+			args: { retryFailed: "boolean?" },
+		},
+		{
+			name: "checkpoint",
+			method: "checkpoint",
+			mutating: true,
+			description:
+				"Close the goal as complete, failed, or blocked with evidence; the final goal also needs the quality gate. printTemplate returns that gate's template instead.",
+			args: {
+				goalId: "string",
+				status: '"complete" | "failed" | "blocked"',
+				evidence: "string",
+				codexGoalJson: "string?",
+				qualityGateJson: "string?",
+				printTemplate: "true? (with goalId? only)",
+			},
+		},
+		{
+			name: "steer",
+			method: "steer",
+			mutating: true,
+			description:
+				"Propose an evidence-backed plan mutation; revise_criterion replaces a criterion's scenario, expectedEvidence, or userModel.",
+			args: {
+				kind: STEER_KINDS,
+				source: '"finding" | "user_prompt_submit" | "cli"',
+				evidence: "string",
+				rationale: "string",
+				goalId: "string?",
+				criterionId: "string? (revise_criterion)",
+				scenario: "string? (revise_criterion)",
+				expectedEvidence: "string? (revise_criterion)",
+				userModel: '"happy" | "edge" | "regression" | "adversarial"? (revise_criterion)',
+				title: "string? (add_subgoal)",
+				objective: "string? (add_subgoal)",
+				childGoals: "{ title: string, objective: string }[]? (split_subgoal)",
+				revisedTitle: "string? (revise_pending_wording)",
+				revisedObjective: "string? (revise_pending_wording)",
+				pendingOrder: "string[]? (reorder_pending)",
+				blockedReason: "string? (mark_blocked_superseded)",
+				idempotencyKey: "string?",
+			},
+		},
+		{
+			name: "add-goal",
+			method: "addGoal",
+			mutating: true,
+			description:
+				"Append a goal; pass successCriteria to define its criteria in the same call, otherwise placeholders name the revise call.",
+			args: { title: "string", objective: "string", successCriteria: `${CRITERION_INPUT}[]?` },
+		},
+		{
+			name: "criteria",
+			method: "criteria",
+			mutating: false,
+			description: "List one goal's success criteria with their status and captured evidence.",
+			args: { goalId: "string" },
+		},
+		{
+			name: "record-evidence",
+			method: "recordEvidence",
+			mutating: true,
+			description:
+				"Record a criterion's pass, fail, or blocked evidence; artifacts must exist (resolved against the session cwd) and are stored with the criterion and the ledger entry.",
+			args: {
+				goalId: "string",
+				criterionId: "string",
+				status: '"pass" | "fail" | "blocked"',
+				evidence: "string",
+				notes: "string?",
+				artifacts: "string[]?",
+			},
+		},
+		{
+			name: "record-review-blockers",
+			method: "recordReviewBlockers",
+			mutating: true,
+			description: "Mark the final goal review_blocked and append the blocker goal the reviewer verdict names.",
+			args: { goalId: "string", title: "string", objective: "string", evidence: "string", codexGoalJson: "string?" },
+		},
 	] satisfies readonly ToolkitOperationManifest[],
 } satisfies ToolkitManifest;

package/packages/omo-codex/plugin/components/ulw-loop/src/sdk/types.ts

@@ -63,12 +63,15 @@ export interface ToolkitFailure<Operation extends string = string> {
 	readonly ok: false;
 	readonly operation: Operation;
 	readonly error: ToolkitError;
+	readonly warnings?: readonly string[];
 }
 
 type StatusResult = {
 	readonly plan: UlwLoopPlan;
 	readonly summary: ReturnType<typeof summarizeUlwLoopPlan>;
 	readonly nextActions: readonly string[];
+	/** Plan-level evidence directory, stable for the whole run (relative to the session cwd). */
+	readonly evidenceRoot: string;
 	readonly currentAttemptDir?: string;
 };
 

package/packages/omo-codex/plugin/components/ulw-loop/src/spawn-budget-io.ts

@@ -0,0 +1,59 @@
+import { randomBytes } from "node:crypto";
+import { existsSync, readFileSync, renameSync, statSync, writeFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+
+export function readAdmissionBreaker(sessionId: string): string | null {
+	const dataDir = process.env["PLUGIN_DATA"];
+	if (typeof dataDir !== "string") return null;
+	try {
+		const value: unknown = JSON.parse(readFileSync(join(dataDir, "spawn-breaker", `${sessionId}.json`), "utf8"));
+		return typeof value === "object" && value !== null && "reason" in value && typeof value.reason === "string"
+			? value.reason
+			: "capacity limit";
+	} catch {
+		return null;
+	}
+}
+
+// These hook budget files are not plan/audit state and remain outside the log.
+export function atomicWriteJson(targetPath: string, data: unknown): void {
+	const tmp = join(dirname(targetPath), `.tmp-${randomBytes(6).toString("hex")}`);
+	writeFileSync(tmp, JSON.stringify(data));
+	renameSync(tmp, targetPath);
+}
+export function isNonEmptyFile(path: string): boolean {
+	try {
+		return existsSync(path) && statSync(path).size > 0;
+	} catch (error) {
+		if (error instanceof Error) return false;
+		throw error;
+	}
+}
+export function readCount(counterPath: string): number {
+	try {
+		const parsed: unknown = JSON.parse(readFileSync(counterPath, "utf8"));
+		return typeof parsed === "object" &&
+			parsed !== null &&
+			"count" in parsed &&
+			typeof parsed.count === "number" &&
+			parsed.count >= 0
+			? parsed.count
+			: 0;
+	} catch (error) {
+		if (error instanceof Error) return 0;
+		throw error;
+	}
+}
+export function readCounts(counterPath: string): Record<string, number> {
+	try {
+		const parsed: unknown = JSON.parse(readFileSync(counterPath, "utf8"));
+		if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) return {};
+		const counts: Record<string, number> = {};
+		for (const [key, value] of Object.entries(parsed))
+			if (typeof value === "number" && value >= 0) counts[key] = value;
+		return counts;
+	} catch (error) {
+		if (error instanceof Error) return {};
+		throw error;
+	}
+}

package/packages/omo-codex/plugin/components/ulw-loop/src/spawn-guard.ts

@@ -1,11 +1,12 @@
-import { randomBytes } from "node:crypto";
-import { existsSync, mkdirSync, readFileSync, renameSync, statSync, writeFileSync } from "node:fs";
-import { dirname, join } from "node:path";
+import { mkdirSync } from "node:fs";
+import { join } from "node:path";
 
 import type { PreToolUsePayload } from "./codex-hook.js";
 import { parsePreToolUsePayload } from "./codex-hook.js";
 import { isFinalRunCompletionCandidate } from "./goal-status.js";
 import { ulwLoopAttemptEvidenceDir, ulwLoopDir, ulwLoopStateLockPath } from "./paths.js";
+import { readUlwLoopPlanSync } from "./plan-io.js";
+import { atomicWriteJson, isNonEmptyFile, readAdmissionBreaker, readCount, readCounts } from "./spawn-budget-io.js";
 import { spawnRoleDenial } from "./spawn-role-guard.js";
 import { isStateLockTimeout, type StateLockOptions, withStateLockSync } from "./state-lock.js";
 import {
@@ -57,7 +58,7 @@ export function applySpawnBudgetGuards(payload: PreToolUsePayload, options: Spaw
 		);
 	const scope = { sessionId: payload.session_id } as const;
 	const stateDir = ulwLoopDir(payload.cwd, scope);
-	const plan = readPlan(join(stateDir, "goals.json"));
+	const plan = readPlan(payload.cwd, payload.session_id);
 	if (plan === null) return "";
 	const lockOptions: StateLockOptions =
 		options.lockTimeoutMs === undefined ? {} : { timeoutMs: options.lockTimeoutMs };
@@ -148,6 +149,7 @@ function peekFanOutBudget(stateDir: string): string | null {
 	return `ulw-loop spawn fan-out cap reached (${count}/${limit}). Consolidate work into the agents already running, or raise OMO_SPAWN_FANOUT_LIMIT if this volume is intentional.`;
 }
 
+// Hook budget counters are exempt from plan/audit commits.
 // Per-session spawn counter; depth/lineage tracking is descoped — this is a
 // total-volume backstop against fan-out explosions, not a recursion tracker.
 function consumeFanOutBudget(stateDir: string): string | null {
@@ -245,12 +247,6 @@ function activeSurfaceReviewerAlias(reviewer: string): string {
 	return reviewer;
 }
 
-function atomicWriteJson(targetPath: string, data: unknown): void {
-	const tmp = join(dirname(targetPath), `.tmp-${randomBytes(6).toString("hex")}`);
-	writeFileSync(tmp, JSON.stringify(data));
-	renameSync(tmp, targetPath);
-}
-
 function deny(reason: string): string {
 	return `${JSON.stringify({
 		hookSpecificOutput: {
@@ -262,19 +258,6 @@ function deny(reason: string): string {
 	})}\n`;
 }
 
-function readAdmissionBreaker(sessionId: string): string | null {
-	const dataDir = process.env["PLUGIN_DATA"];
-	if (typeof dataDir !== "string") return null;
-	try {
-		const value = JSON.parse(readFileSync(join(dataDir, "spawn-breaker", `${sessionId}.json`), "utf8")) as {
-			reason?: unknown;
-		};
-		return typeof value.reason === "string" ? value.reason : "capacity limit";
-	} catch {
-		return null;
-	}
-}
-
 function fanOutLimit(): number {
 	const raw = process.env["OMO_SPAWN_FANOUT_LIMIT"];
 	if (raw === undefined) return DEFAULT_FANOUT_LIMIT;
@@ -289,43 +272,9 @@ function reviewSpawnLimit(): number {
 	return Number.isFinite(parsed) && parsed > 0 ? parsed : DEFAULT_REVIEW_SPAWN_LIMIT;
 }
 
-function isNonEmptyFile(path: string): boolean {
-	try {
-		return existsSync(path) && statSync(path).size > 0;
-	} catch (error) {
-		if (error instanceof Error) return false;
-		throw error;
-	}
-}
-
-function readCount(counterPath: string): number {
-	try {
-		const parsed = JSON.parse(readFileSync(counterPath, "utf8")) as Record<string, unknown>;
-		return typeof parsed["count"] === "number" && parsed["count"] >= 0 ? parsed["count"] : 0;
-	} catch (error) {
-		if (error instanceof Error) return 0;
-		throw error;
-	}
-}
-
-function readCounts(counterPath: string): Record<string, number> {
-	try {
-		const parsed: unknown = JSON.parse(readFileSync(counterPath, "utf8"));
-		if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) return {};
-		const counts: Record<string, number> = {};
-		for (const [key, value] of Object.entries(parsed)) {
-			if (typeof value === "number" && value >= 0) counts[key] = value;
-		}
-		return counts;
-	} catch (error) {
-		if (error instanceof Error) return {};
-		throw error;
-	}
-}
-
-function readPlan(goalsPath: string): UlwLoopPlan | null {
+function readPlan(repoRoot: string, sessionId: string): UlwLoopPlan | null {
 	try {
-		return JSON.parse(readFileSync(goalsPath, "utf8")) as UlwLoopPlan;
+		return readUlwLoopPlanSync(repoRoot, { sessionId });
 	} catch (error) {
 		if (error instanceof Error) return null;
 		throw error;