oh-my-opencode 4.8.0 → 4.9.0

package/packages/omo-codex/plugin/test/auto-update-restart-notice.test.mjs

@@ -0,0 +1,194 @@
+import assert from "node:assert/strict";
+import { spawnSync } from "node:child_process";
+import { mkdtemp, readFile, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import test from "node:test";
+import { fileURLToPath } from "node:url";
+
+import { resolveAutoUpdatePlan, runAutoUpdateCheck } from "../scripts/auto-update.mjs";
+
+const SCRIPT_PATH = fileURLToPath(new URL("../scripts/auto-update.mjs", import.meta.url));
+const STARTED_NOTICE =
+	"[LazyCodex] Auto-update started in the background: v1.0.0 -> v1.0.1. Tell the user a new LazyCodex version is installing and that they should start a new Codex session after it completes to apply it.";
+const COMPLETED_NOTICE =
+	"[LazyCodex] Auto-update completed: v1.0.0 -> v1.0.1. This session is already running the new version. Tell the user the auto-update was applied.";
+
+function autoUpdateEnv(root, extra = {}) {
+	return {
+		CODEX_HOME: join(root, "codex-home"),
+		LAZYCODEX_CURRENT_VERSION: "1.0.0",
+		LAZYCODEX_LATEST_VERSION: "1.0.1",
+		LAZYCODEX_MODEL_CATALOG_STATE_PATH: join(root, "model-state.json"),
+		LAZYCODEX_AUTO_UPDATE_STATE_PATH: join(root, "state.json"),
+		LAZYCODEX_AUTO_UPDATE_LOG_PATH: join(root, "auto-update.log"),
+		...extra,
+	};
+}
+
+test("#given a newer version #when resolving auto update plan #then plan carries current and latest versions", () => {
+	const plan = resolveAutoUpdatePlan({
+		env: { LAZYCODEX_CURRENT_VERSION: "1.0.0", LAZYCODEX_LATEST_VERSION: "1.0.1" },
+		now: 90_000_000,
+		lastCheckedAt: 0,
+	});
+
+	assert.equal(plan.shouldRun, true);
+	assert.equal(plan.currentVersion, "1.0.0");
+	assert.equal(plan.latestVersion, "1.0.1");
+});
+
+test("#given a newer version #when waited update succeeds #then returns update-started notice and persists pendingNotice", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-started-"));
+	const env = autoUpdateEnv(root, {
+		LAZYCODEX_AUTO_UPDATE_INTERVAL_MS: "0",
+		LAZYCODEX_AUTO_UPDATE_COMMAND: process.execPath,
+		LAZYCODEX_AUTO_UPDATE_ARGS_JSON: JSON.stringify(["-e", "process.exit(0)"]),
+		LAZYCODEX_AUTO_UPDATE_WAIT: "1",
+	});
+
+	const result = await runAutoUpdateCheck({
+		env,
+		now: 123_456,
+	});
+
+	assert.equal(result.started, true);
+	assert.equal(result.status, 0);
+	assert.deepEqual(result.notices, [STARTED_NOTICE]);
+	const state = JSON.parse(await readFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, "utf8"));
+	assert.deepEqual(state.pendingNotice, {
+		fromVersion: "1.0.0",
+		toVersion: "1.0.1",
+		startedAt: 123_456,
+	});
+});
+
+test("#given completed pending update #when startup check is throttled #then emits completed notice and clears pendingNotice", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-completed-"));
+	const now = 90_000_000;
+	const env = autoUpdateEnv(root, {
+		LAZYCODEX_CURRENT_VERSION: "1.0.1",
+		LAZYCODEX_LATEST_VERSION: "1.0.1",
+	});
+	await writeFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, JSON.stringify({
+		lastCheckedAt: now - 1_000,
+		lastStatus: "success",
+		pendingNotice: { fromVersion: "1.0.0", toVersion: "1.0.1", startedAt: 1 },
+	}));
+
+	const result = await runAutoUpdateCheck({
+		env,
+		now,
+	});
+
+	assert.equal(result.started, false);
+	assert.equal(result.reason, "throttled");
+	assert.deepEqual(result.notices, [COMPLETED_NOTICE]);
+	assert.deepEqual(JSON.parse(await readFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, "utf8")), {
+		lastCheckedAt: now - 1_000,
+		lastStatus: "success",
+	});
+});
+
+test("#given incomplete pending update #when startup check runs #then no notice and pendingNotice retained", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-incomplete-"));
+	const now = 90_000_000;
+	const env = autoUpdateEnv(root);
+	await writeFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, JSON.stringify({
+		lastAttemptedAt: now - 60_000,
+		lastStatus: "started",
+		pendingNotice: { fromVersion: "1.0.0", toVersion: "1.0.1", startedAt: 1 },
+	}));
+
+	const result = await runAutoUpdateCheck({
+		env,
+		now,
+	});
+
+	assert.equal(result.started, false);
+	assert.equal(result.reason, "retry-throttled");
+	assert.deepEqual(result.notices, []);
+	const state = JSON.parse(await readFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, "utf8"));
+	assert.deepEqual(state.pendingNotice, {
+		fromVersion: "1.0.0",
+		toVersion: "1.0.1",
+		startedAt: 1,
+	});
+});
+
+test("#given waited update fails #then no notice and no pendingNotice", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-failed-"));
+	const env = autoUpdateEnv(root, {
+		LAZYCODEX_AUTO_UPDATE_INTERVAL_MS: "0",
+		LAZYCODEX_AUTO_UPDATE_COMMAND: process.execPath,
+		LAZYCODEX_AUTO_UPDATE_ARGS_JSON: JSON.stringify(["-e", "process.exit(1)"]),
+		LAZYCODEX_AUTO_UPDATE_WAIT: "1",
+	});
+
+	const result = await runAutoUpdateCheck({
+		env,
+		now: 123_456,
+	});
+
+	assert.equal(result.started, true);
+	assert.equal(result.status, 1);
+	assert.deepEqual(result.notices, []);
+	assert.deepEqual(JSON.parse(await readFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, "utf8")), {
+		lastAttemptedAt: 123_456,
+		lastStatus: "failed",
+	});
+});
+
+test("#given malformed pendingNotice toVersion #when check runs #then pendingNotice dropped silently", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-malformed-"));
+	const env = autoUpdateEnv(root, {
+		LAZYCODEX_CURRENT_VERSION: "1.0.1",
+		LAZYCODEX_LATEST_VERSION: "1.0.1",
+	});
+	await writeFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, JSON.stringify({
+		pendingNotice: { fromVersion: "1.0.0", toVersion: "not-a-version", startedAt: 1 },
+	}));
+
+	const result = await runAutoUpdateCheck({
+		env,
+		now: 123_456,
+	});
+
+	assert.deepEqual(result.notices, []);
+	const state = JSON.parse(await readFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, "utf8"));
+	assert.equal("pendingNotice" in state, false);
+});
+
+test("#given completed pending update #when hook session-start runs as CLI #then prints one SessionStart JSON line", async () => {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-restart-notice-cli-"));
+	const env = autoUpdateEnv(root, {
+		LAZYCODEX_CURRENT_VERSION: "1.0.1",
+		LAZYCODEX_LATEST_VERSION: "1.0.1",
+		LAZYCODEX_CONFIG_MIGRATION_DISABLED: "1",
+	});
+	await writeFile(env.LAZYCODEX_AUTO_UPDATE_STATE_PATH, JSON.stringify({
+		lastCheckedAt: Date.now() - 1_000,
+		lastStatus: "success",
+		pendingNotice: { fromVersion: "1.0.0", toVersion: "1.0.1", startedAt: 1 },
+	}));
+
+	const result = spawnSync(process.execPath, [SCRIPT_PATH, "hook", "session-start"], {
+		encoding: "utf8",
+		env: { ...process.env, ...env },
+	});
+
+	assert.equal(result.status, 0);
+	const lines = result.stdout.split("\n").filter((line) => line.length > 0);
+	assert.equal(lines.length, 1);
+	const parsed = JSON.parse(lines[0]);
+	assert.equal(parsed.hookSpecificOutput.hookEventName, "SessionStart");
+	assert.match(parsed.hookSpecificOutput.additionalContext, /v1\.0\.0 -> v1\.0\.1/);
+
+	const repeat = spawnSync(process.execPath, [SCRIPT_PATH, "hook", "session-start"], {
+		encoding: "utf8",
+		env: { ...process.env, ...env },
+	});
+
+	assert.equal(repeat.status, 0);
+	assert.equal(repeat.stdout, "");
+});

package/packages/omo-codex/plugin/test/auto-update.test.mjs

@@ -162,6 +162,11 @@ test("#given test command override #when running check #then records state and l
 		lastCheckedAt: 123_456,
 		lastAttemptedAt: 123_456,
 		lastStatus: "success",
+		pendingNotice: {
+			fromVersion: "1.0.0",
+			toVersion: "1.0.1",
+			startedAt: 123_456,
+		},
 	});
 	assert.equal(await readFile(logPath, "utf8"), "ok");
 	const updateLog = (await readFile(env.LAZYCODEX_AUTO_UPDATE_LOG_PATH, "utf8")).trim().split("\n").map((line) => JSON.parse(line));
@@ -177,6 +182,13 @@ test("#given test command override #when running check #then records state and l
 			event: "finished",
 			status: 0,
 		},
+		{
+			timestamp: "1970-01-01T00:02:03.456Z",
+			event: "notified",
+			kind: "update-started",
+			fromVersion: "1.0.0",
+			toVersion: "1.0.1",
+		},
 	]);
 	assert.match(await readFile(join(env.CODEX_HOME, "config.toml"), "utf8"), /model = "gpt-5\.5"/);
 });
@@ -262,6 +274,11 @@ test("#given stale lock #when running check #then removes lock and runs update",
 		lastCheckedAt: 1_000_000,
 		lastAttemptedAt: 1_000_000,
 		lastStatus: "success",
+		pendingNotice: {
+			fromVersion: "1.0.0",
+			toVersion: "1.0.1",
+			startedAt: 1_000_000,
+		},
 	});
 });
 

package/packages/omo-codex/plugin/test/lcx-bug-skills.test.mjs

@@ -16,22 +16,6 @@ test("#given synced lcx-report-bug skill #when inspected #then it files LazyCode
 
 	// then
 	assert.match(skill, /^---\r?\nname: lcx-report-bug\r?\n/m);
-	assert.match(skill, /code-yeongyu\/lazycodex/);
-	assert.match(skill, /openai\/codex/);
-	assert.match(skill, /\/tmp\/openai-codex-source/);
-	assert.match(skill, /\$omo:debugging/);
-	assert.match(skill, /Repository Decision/);
-	assert.match(skill, /TARGET_REPO="code-yeongyu\/lazycodex" # or openai\/codex/);
-	assert.match(skill, /LABEL_ARGS=\(\)/);
-	assert.match(skill, /gh label create lazycodex-generated.*--force/);
-	assert.match(skill, /gh issue create --repo "\$TARGET_REPO".*"\$\{LABEL_ARGS\[@\]\}"/);
-	assert.match(skill, /gh pr create --repo "\$TARGET_REPO".*"\$\{LABEL_ARGS\[@\]\}"/);
-	assert.match(skill, /lazycodex-generated/);
-	assert.match(skill, /This issue or PR was generated by LazyCodex/);
-	assert.match(skill, /Tag: lazycodex-generated/);
-	assert.match(skill, /Browser use fallback/);
-	assert.match(skill, /Computer use fallback/);
-	assert.match(skill, /## Issue Body Template/);
 	assert.match(interfaceMetadata, /display_name: "lcx-report-bug \(omo\)"/);
 	assert.match(interfaceMetadata, /- "lazycodex bug"/);
 	assert.match(interfaceMetadata, /- "openai codex bug"/);
@@ -44,38 +28,25 @@ test("#given synced lcx-contribute-bug-fix skill #when inspected #then it contri
 	// when
 	const skill = await readFile(join(skillRoot, "SKILL.md"), "utf8");
 	const interfaceMetadata = await readFile(join(skillRoot, "agents", "openai.yaml"), "utf8");
-	const script = await readFile(join(skillRoot, "scripts", "create-pr-body.mjs"), "utf8");
 
 	// then
 	assert.match(skill, /^---\r?\nname: lcx-contribute-bug-fix\r?\n/m);
-	assert.match(skill, /Contribute a verified bug-fix PR/);
-	assert.match(skill, /fresh `\/tmp` clone\/worktree/);
-	assert.match(skill, /\/tmp\/lazycodex-fix-/);
-	assert.match(skill, /git worktree add/);
-	assert.match(skill, /apply `lazycodex-generated` when label management is available/);
-	assert.match(skill, /git add -A/);
-	assert.match(skill, /git commit -m/);
-	assert.match(skill, /git log --oneline "origin\/\$BASE_BRANCH\.\.HEAD"/);
-	assert.match(skill, /gh repo fork "\$TARGET_REPO" --remote --remote-name fork/);
-	assert.match(skill, /PUSH_REMOTE/);
-	assert.match(skill, /lazycodex-generated/);
-	assert.match(skill, /LABEL_ARGS=\(\)/);
-	assert.match(skill, /gh label create lazycodex-generated.*--force/);
-	assert.match(skill, /gh pr create --repo "\$TARGET_REPO".*"\$\{LABEL_ARGS\[@\]\}"/);
-	assert.match(skill, /--head "\$PR_HEAD"/);
-	assert.doesNotMatch(skill, /a PR without the `lazycodex-generated` label/);
-	assert.match(skill, /scripts\/create-pr-body\.mjs/);
-	assert.match(skill, /## Problem Situation/);
-	assert.match(skill, /## Reproduction Logs/);
-	assert.match(skill, /## Approach/);
-	assert.match(skill, /## Why I Am Confident/);
-	assert.match(skill, /## Risks/);
-	assert.match(skill, /## User-Visible Behavior Changes/);
-	assert.match(skill, /Clean up/);
 	assert.match(interfaceMetadata, /display_name: "lcx-contribute-bug-fix \(omo\)"/);
 	assert.match(interfaceMetadata, /- "contribute a bug fix"/);
 	assert.match(interfaceMetadata, /- "fix bug pr"/);
-	assert.match(script, /createLazyCodexBugFixPrBody/);
-	assert.match(script, /Problem Situation/);
-	assert.match(script, /Why I Am Confident/);
+});
+
+test("#given synced lcx-doctor skill #when inspected #then it diagnoses installs against latest /tmp sources without mutating them", async () => {
+	// given
+	const skillRoot = join(root, "skills", "lcx-doctor");
+
+	// when
+	const skill = await readFile(join(skillRoot, "SKILL.md"), "utf8");
+	const interfaceMetadata = await readFile(join(skillRoot, "agents", "openai.yaml"), "utf8");
+
+	// then
+	assert.match(skill, /^---\r?\nname: lcx-doctor\r?\n/m);
+	assert.match(interfaceMetadata, /display_name: "lcx-doctor \(omo\)"/);
+	assert.match(interfaceMetadata, /- "lazycodex doctor"/);
+	assert.match(interfaceMetadata, /- "lazycodex health check"/);
 });

package/packages/omo-codex/plugin/test/lsp-prebuild-layouts.test.mjs

@@ -0,0 +1,140 @@
+import assert from "node:assert/strict";
+import { execFileSync } from "node:child_process";
+import { copyFile, mkdir, mkdtemp, rm, utimes, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import test from "node:test";
+import { fileURLToPath } from "node:url";
+
+const REPO_SCRIPTS = fileURLToPath(new URL("../components/lsp/scripts", import.meta.url));
+const BUILD_LSP_TOOLS = join(REPO_SCRIPTS, "build-lsp-tools.mjs");
+const BUILD_LSP_DAEMON = join(REPO_SCRIPTS, "build-lsp-daemon.mjs");
+
+// Run a copied script (built from HEAD sources) and return { status, stdout, stderr }.
+// execFileSync throws on non-zero exit; we capture the SpawnError fields instead.
+function runScript(script, cwd) {
+	try {
+		const stdout = execFileSync(process.execPath, [script], { cwd, encoding: "utf8" });
+		return { status: 0, stdout, stderr: "" };
+	} catch (err) {
+		return {
+			status: typeof err.status === "number" ? err.status : 1,
+			stdout: err.stdout ?? "",
+			stderr: err.stderr ?? "",
+		};
+	}
+}
+
+// Escape a string for use in a RegExp literal.
+function escapeRegex(str) {
+	return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+
+test("#given the installed cache layout #when running build-lsp-tools #then uses the bundled dist and exits 0", async () => {
+	// given — mirror the installed plugin cache: scripts 2-up from components/lsp-tools-mcp/dist
+	const root = await mkdtemp(join(tmpdir(), "lsp-prebuild-cache-tools-"));
+	try {
+		const scriptsDir = join(root, "components", "lsp", "scripts");
+		await mkdir(scriptsDir, { recursive: true });
+		await copyFile(BUILD_LSP_TOOLS, join(scriptsDir, "build-lsp-tools.mjs"));
+
+		await mkdir(join(root, "components", "lsp-tools-mcp", "dist", "lsp"), { recursive: true });
+		await writeFile(join(root, "components", "lsp-tools-mcp", "dist", "cli.js"), "");
+		await writeFile(join(root, "components", "lsp-tools-mcp", "dist", "tools.js"), "");
+		await writeFile(join(root, "components", "lsp-tools-mcp", "dist", "lsp", "manager.js"), "");
+
+		// when
+		const result = runScript(join(scriptsDir, "build-lsp-tools.mjs"), root);
+
+		// then
+		assert.equal(result.status, 0, `expected exit 0; stderr: ${result.stderr}`);
+		assert.match(result.stdout, /Using bundled lsp-tools-mcp dist/);
+	} finally {
+		await rm(root, { recursive: true, force: true });
+	}
+});
+
+test("#given the installed cache layout #when running build-lsp-daemon #then uses the bundled dist and exits 0", async () => {
+	// given — mirror the installed plugin cache: scripts 2-up from components/lsp-daemon/dist
+	const root = await mkdtemp(join(tmpdir(), "lsp-prebuild-cache-daemon-"));
+	try {
+		const scriptsDir = join(root, "components", "lsp", "scripts");
+		await mkdir(scriptsDir, { recursive: true });
+		await copyFile(BUILD_LSP_DAEMON, join(scriptsDir, "build-lsp-daemon.mjs"));
+
+		await mkdir(join(root, "components", "lsp-daemon", "dist"), { recursive: true });
+		await writeFile(join(root, "components", "lsp-daemon", "dist", "cli.js"), "");
+		await writeFile(join(root, "components", "lsp-daemon", "dist", "index.js"), "");
+		await writeFile(join(root, "components", "lsp-daemon", "dist", "index.d.ts"), "");
+
+		// when
+		const result = runScript(join(scriptsDir, "build-lsp-daemon.mjs"), root);
+
+		// then
+		assert.equal(result.status, 0, `expected exit 0; stderr: ${result.stderr}`);
+		assert.match(result.stdout, /Using bundled lsp-daemon dist/);
+	} finally {
+		await rm(root, { recursive: true, force: true });
+	}
+});
+
+test("#given neither layout #when running build-lsp-tools #then fails listing every probed path", async () => {
+	// given — bare layout: only the script, no package.json anywhere, no dist outputs
+	const root = await mkdtemp(join(tmpdir(), "lsp-prebuild-none-"));
+	try {
+		const scriptsDir = join(root, "components", "lsp", "scripts");
+		await mkdir(scriptsDir, { recursive: true });
+		await copyFile(BUILD_LSP_TOOLS, join(scriptsDir, "build-lsp-tools.mjs"));
+
+		// when
+		const result = runScript(join(scriptsDir, "build-lsp-tools.mjs"), root);
+
+		// then — exit 1, stderr enumerates BOTH probed package.json paths
+		// candidate 1: 5-up repo sibling (resolves outside the temp tree)
+		const candidate1PkgJson = join(scriptsDir, "..", "..", "..", "..", "..", "lsp-tools-mcp", "package.json");
+		// candidate 2: 2-up components sibling (inside the temp tree)
+		const candidate2PkgJson = join(root, "components", "lsp-tools-mcp", "package.json");
+
+		assert.equal(result.status, 1);
+		assert.match(result.stderr, new RegExp(escapeRegex(candidate1PkgJson)));
+		assert.match(result.stderr, new RegExp(escapeRegex(candidate2PkgJson)));
+	} finally {
+		await rm(root, { recursive: true, force: true });
+	}
+});
+
+test("#given the repo sibling layout with fresh outputs #when running build-lsp-tools #then exits 0 without building", async () => {
+	// given — simulate the repo layout: script at d1/d2/d3/components/lsp/scripts/,
+	// lsp-tools-mcp at d1/ (5-up from the scripts dir), outputs newer than package.json
+	const root = await mkdtemp(join(tmpdir(), "lsp-prebuild-repo-"));
+	try {
+		const scriptsDir = join(root, "d1", "d2", "d3", "components", "lsp", "scripts");
+		await mkdir(scriptsDir, { recursive: true });
+		await copyFile(BUILD_LSP_TOOLS, join(scriptsDir, "build-lsp-tools.mjs"));
+
+		// 5-up from scriptsDir lands on join(root, "d1")
+		const lspToolsDir = join(root, "d1", "lsp-tools-mcp");
+		await mkdir(join(lspToolsDir, "dist", "lsp"), { recursive: true });
+
+		// package.json gets an older mtime
+		await writeFile(join(lspToolsDir, "package.json"), "{}");
+		const older = new Date("2025-01-01T00:00:00.000Z");
+		await utimes(join(lspToolsDir, "package.json"), older, older);
+
+		// outputs get a newer mtime — isBuildFresh returns true
+		const newer = new Date("2025-01-02T00:00:00.000Z");
+		for (const rel of ["dist/cli.js", "dist/tools.js", "dist/lsp/manager.js"]) {
+			await writeFile(join(lspToolsDir, rel), "");
+			await utimes(join(lspToolsDir, rel), newer, newer);
+		}
+
+		// when
+		const result = runScript(join(scriptsDir, "build-lsp-tools.mjs"), root);
+
+		// then — exits 0 immediately (fresh build), no npm invocation
+		assert.equal(result.status, 0, `expected exit 0; stderr: ${result.stderr}`);
+		assert.doesNotMatch(result.stdout, /Installing/);
+	} finally {
+		await rm(root, { recursive: true, force: true });
+	}
+});