oh-my-opencode 4.7.4 → 4.8.0

package/packages/omo-codex/plugin/components/start-work-continuation/test/codex-hook.test.ts

@@ -22,6 +22,21 @@ describe("start-work Stop hook", () => {
 		expect(output).toBe("");
 	});
 
+	it("#given no boulder state and start work prompt #when stop hook runs #then it stays quiet", () => {
+		// given
+		const fs = createMemoryFs();
+		const input = {
+			...createStopInput(),
+			last_assistant_message: "I'll start work on this plan now.",
+		};
+
+		// when
+		const output = runStopHook(input, fs);
+
+		// then
+		expect(output).toBe("");
+	});
+
 	it("#given active codex work with remaining top-level tasks #when hook runs #then returns block JSON", () => {
 		// given
 		const fs = createMemoryFs({
@@ -49,6 +64,38 @@ describe("start-work Stop hook", () => {
 		expect(parsed.reason).toContain("- Your session id in boulder.json: `codex:sess_abc`");
 	});
 
+	it("#given context-window pressure in transcript #when hook runs #then it does not inject continuation text", () => {
+		// given
+		const transcriptPath = "/repo/transcript.jsonl";
+		const fs = createMemoryFs({
+			[BOULDER_PATH]: createBoulderJson({
+				sessionIds: ["codex:sess_abc"],
+				status: "active",
+			}),
+			[PLAN_PATH]: ["# Plan", "", "## TODOs", "- [ ] First"].join("\n"),
+			[transcriptPath]: [
+				JSON.stringify({
+					type: "message",
+					payload: {
+						content: {
+							error: {
+								code: "context_too_large",
+							},
+						},
+					},
+				}),
+				"Your input exceeds the context window of this model.",
+				"",
+			].join("\n"),
+		});
+
+		// when
+		const output = runStopHook({ ...createStopInput(), transcript_path: transcriptPath }, fs);
+
+		// then
+		expect(output).toBe("");
+	});
+
 	it("#given active codex work #when continuation directive is emitted #then subagent guidance is reliable", () => {
 		// given
 		const fs = createMemoryFs({
@@ -66,9 +113,11 @@ describe("start-work Stop hook", () => {
 		const parsed = parseBlockOutput(output);
 		expect(parsed.reason).toMatch(/TASK:/);
 		expect(parsed.reason).toMatch(/fork_turns:\s*"none"/);
-		expect(parsed.reason).toMatch(/wait_agent.*signal, not proof/);
-		expect(parsed.reason).toMatch(/one targeted followup/);
+		expect(parsed.reason).toMatch(/wait_agent.*mailbox signals/);
+		expect(parsed.reason).toMatch(/TASK STILL ACTIVE/);
 		expect(parsed.reason).toMatch(/respawn.*smaller/);
+		expect(parsed.reason).toMatch(/WORKING:/);
+		expect(parsed.reason).toMatch(/single `list_agents`/);
 	});
 
 	it("#given active work belongs to another harness #when hook runs #then returns empty output", () => {
@@ -113,6 +162,19 @@ describe("start-work Stop hook", () => {
 		expect(output).toBe("");
 	});
 
+	it("#given malformed boulder JSON #when hook runs #then returns empty output", () => {
+		// given
+		const fs = createMemoryFs({
+			[BOULDER_PATH]: "{",
+		});
+
+		// when
+		const output = runStopHook(createStopInput(), fs);
+
+		// then
+		expect(output).toBe("");
+	});
+
 	it("#given malformed input #when hook runs #then returns empty output", () => {
 		// given
 		const fs = createMemoryFs();

package/packages/omo-codex/plugin/components/telemetry/README.md

@@ -76,7 +76,17 @@ containing `{ "lastActiveDayUTC": "YYYY-MM-DD" }`. If the stored day matches tod
 
 ## Failure Behavior
 
-Every telemetry path is wrapped in `try`/`catch`. The hook always exits 0 with no stdout output, even when PostHog construction, capture, or shutdown fails. Codex session startup is never blocked or slowed by telemetry failures.
+Every telemetry path is wrapped in `try`/`catch`. The hook always exits 0 with no stdout or stderr output, even when PostHog construction, capture, or shutdown fails. Codex session startup is never blocked or slowed by telemetry failures.
+
+Handled telemetry failures are written only to a local diagnostics file:
+
+```
+$XDG_DATA_HOME/omo-codex/telemetry-diagnostics.jsonl
+# or, when XDG_DATA_HOME is unset:
+~/.local/share/omo-codex/telemetry-diagnostics.jsonl
+```
+
+The diagnostics file keeps JSONL rows for recent telemetry failures, prunes stale rows during writes, and caps itself at 256 KiB by dropping the oldest complete rows. Diagnostics are never sent to PostHog and do not include prompt contents, transcript contents, raw hostnames, API keys, tokens, or full hook payloads.
 
 ## Endpoint Overrides
 

package/packages/omo-codex/plugin/components/telemetry/biome.json

@@ -34,6 +34,18 @@
 		"includes": ["src/**/*.ts", "test/**/*.ts", "vitest.config.ts", "!**/node_modules/**/*", "!**/dist/**/*"]
 	},
 	"overrides": [
+		{
+			"includes": [
+				"src/atomic-write.ts",
+				"src/data-path.ts",
+				"src/diagnostics.ts",
+				"src/env-flags.ts",
+				"src/posthog-activity-state.ts"
+			],
+			"formatter": {
+				"enabled": false
+			}
+		},
 		{
 			"includes": ["vitest.config.ts"],
 			"linter": {

package/packages/omo-codex/plugin/components/telemetry/src/codex-hook.ts

@@ -1,3 +1,8 @@
+import {
+	type TelemetryDiagnosticErrorKind,
+	type TelemetryDiagnosticEvent,
+	writeTelemetryDiagnostic,
+} from "./diagnostics.js";
 import {
 	createPluginPostHog,
 	getPostHogDistinctId,
@@ -22,6 +27,19 @@ export type CodexTelemetryHookOptions = {
 
 const SESSION_START_REASON: PostHogActivityReason = "session_start";
 
+function writeHookDiagnostic(
+	event: TelemetryDiagnosticEvent,
+	error: unknown,
+	errorKind: TelemetryDiagnosticErrorKind,
+): void {
+	writeTelemetryDiagnostic({
+		event,
+		source: "plugin",
+		error,
+		errorKind,
+	});
+}
+
 export async function runSessionStartHook(
 	_input: CodexSessionStartInput,
 	options: CodexTelemetryHookOptions = {},
@@ -29,10 +47,18 @@ export async function runSessionStartHook(
 	const createClient = options.createClient ?? createPluginPostHog;
 	const getDistinctId = options.getDistinctId ?? getPostHogDistinctId;
 
-	const client = await createClient();
+	let client: PostHogClient;
+	try {
+		client = await createClient();
+	} catch (error) {
+		writeHookDiagnostic("telemetry_posthog_init_failed", error, error instanceof Error ? "error" : "non_error");
+		return "";
+	}
+
 	try {
 		client.trackActive(getDistinctId(), SESSION_START_REASON);
-	} catch {
+	} catch (error) {
+		writeHookDiagnostic("telemetry_capture_failed", error, error instanceof Error ? "error" : "non_error");
 		await safeShutdown(client);
 		return "";
 	}
@@ -43,7 +69,8 @@ export async function runSessionStartHook(
 async function safeShutdown(client: PostHogClient): Promise<void> {
 	try {
 		await client.shutdown();
-	} catch {
+	} catch (error) {
+		writeHookDiagnostic("telemetry_shutdown_failed", error, error instanceof Error ? "error" : "non_error");
 		return;
 	}
 }

package/packages/omo-codex/plugin/components/telemetry/src/diagnostics.ts

@@ -0,0 +1,154 @@
+import { appendFileSync, existsSync, mkdirSync, readFileSync } from "node:fs"
+import { join } from "node:path"
+
+import { writeFileAtomically } from "./atomic-write.js"
+import { getActivityStateDir } from "./data-path.js"
+
+export type TelemetryDiagnosticEvent =
+  | "telemetry_activity_state_read_failed"
+  | "telemetry_activity_state_write_failed"
+  | "telemetry_capture_failed"
+  | "telemetry_cpu_info_unavailable"
+  | "telemetry_posthog_import_failed"
+  | "telemetry_posthog_init_failed"
+  | "telemetry_shutdown_failed"
+
+export type TelemetryDiagnosticSource = "cli" | "install" | "plugin" | "shared"
+
+export type TelemetryDiagnosticErrorKind = "error" | "non_error"
+
+export type TelemetryDiagnosticInput = {
+  readonly event: TelemetryDiagnosticEvent
+  readonly source: TelemetryDiagnosticSource
+  readonly error?: unknown
+  readonly errorKind?: TelemetryDiagnosticErrorKind
+}
+
+const DIAGNOSTICS_FILE_NAME = "telemetry-diagnostics.jsonl"
+const DIAGNOSTICS_RETENTION_MS = 7 * 24 * 60 * 60 * 1000
+const DIAGNOSTICS_MAX_BYTES = 256 * 1024
+
+export function getTelemetryDiagnosticsFilePath(): string {
+  return join(getActivityStateDir(), DIAGNOSTICS_FILE_NAME)
+}
+
+export function writeTelemetryDiagnostic(input: TelemetryDiagnosticInput, now: Date = new Date()): void {
+  try {
+    cleanupTelemetryDiagnostics(now)
+    mkdirSync(getActivityStateDir(), { recursive: true })
+    appendFileSync(getTelemetryDiagnosticsFilePath(), `${JSON.stringify(toDiagnosticRecord(input, now))}\n`, "utf-8")
+  } catch {
+    return
+  }
+}
+
+export function cleanupTelemetryDiagnostics(now: Date = new Date()): void {
+  const diagnosticsFilePath = getTelemetryDiagnosticsFilePath()
+  if (!existsSync(diagnosticsFilePath)) {
+    return
+  }
+
+  try {
+    const cutoffMs = now.getTime() - DIAGNOSTICS_RETENTION_MS
+    const retainedLines = trimToMaxBytes(
+      readFileSync(diagnosticsFilePath, "utf-8")
+        .split("\n")
+        .filter((line) => shouldRetainLine(line, cutoffMs)),
+    )
+    writeFileAtomically(diagnosticsFilePath, retainedLines.length === 0 ? "" : `${retainedLines.join("\n")}\n`)
+  } catch {
+    return
+  }
+}
+
+function toDiagnosticRecord(
+  input: TelemetryDiagnosticInput,
+  now: Date,
+): Record<string, string> {
+  return {
+    timestamp: now.toISOString(),
+    event: input.event,
+    source: input.source,
+    ...serializeError(input.error, input.errorKind),
+  }
+}
+
+function serializeError(
+  error: unknown,
+  errorKind?: TelemetryDiagnosticErrorKind,
+): Record<string, string> {
+  if (error instanceof Error) {
+    return {
+      error_kind: errorKind ?? "error",
+      error_name: error.name,
+      error_message: error.message,
+    }
+  }
+
+  if (error === undefined) {
+    return {}
+  }
+
+  return {
+    error_kind: errorKind ?? "non_error",
+    error_name: typeof error,
+    error_message: String(error),
+  }
+}
+
+function shouldRetainLine(line: string, cutoffMs: number): boolean {
+  if (line.length === 0) {
+    return false
+  }
+
+  const parsed = parseDiagnosticLine(line)
+  if (parsed === null) {
+    return false
+  }
+
+  const timestamp = parsed["timestamp"]
+  if (typeof timestamp !== "string") {
+    return false
+  }
+
+  const timestampMs = Date.parse(timestamp)
+  return Number.isFinite(timestampMs) && timestampMs >= cutoffMs
+}
+
+function parseDiagnosticLine(line: string): Record<string, unknown> | null {
+  try {
+    const parsed: unknown = JSON.parse(line)
+    if (!isRecord(parsed)) {
+      return null
+    }
+    return parsed
+  } catch {
+    return null
+  }
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return value !== null && typeof value === "object" && !Array.isArray(value)
+}
+
+function trimToMaxBytes(lines: ReadonlyArray<string>): ReadonlyArray<string> {
+  const retained: string[] = []
+  let totalBytes = 0
+
+  for (let index = lines.length - 1; index >= 0; index -= 1) {
+    const line = lines[index]
+    if (line === undefined) {
+      continue
+    }
+
+    const lineBytes = Buffer.byteLength(`${line}\n`, "utf-8")
+    if (totalBytes + lineBytes > DIAGNOSTICS_MAX_BYTES) {
+      break
+    }
+
+    retained.unshift(line)
+    totalBytes += lineBytes
+  }
+
+  return retained
+}

package/packages/omo-codex/plugin/components/telemetry/src/posthog-activity-state.ts

@@ -3,6 +3,7 @@ import { join } from "node:path"
 
 import { writeFileAtomically } from "./atomic-write.js"
 import { getActivityStateDir } from "./data-path.js"
+import { type TelemetryDiagnosticErrorKind, type TelemetryDiagnosticEvent, writeTelemetryDiagnostic } from "./diagnostics.js"
 
 export type PostHogActivityState = {
   readonly lastActiveDayUTC?: string
@@ -27,6 +28,19 @@ function isPostHogActivityState(value: unknown): value is PostHogActivityState {
   return value !== null && typeof value === "object" && !Array.isArray(value)
 }
 
+function writeActivityStateDiagnostic(
+  event: TelemetryDiagnosticEvent,
+  error: unknown,
+  errorKind: TelemetryDiagnosticErrorKind,
+): void {
+  writeTelemetryDiagnostic({
+    event,
+    source: "shared",
+    error,
+    errorKind,
+  })
+}
+
 function readPostHogActivityState(): PostHogActivityState {
   const stateFilePath = getPostHogActivityStateFilePath()
 
@@ -43,7 +57,8 @@ function readPostHogActivityState(): PostHogActivityState {
     }
 
     return stateJson
-  } catch {
+  } catch (error) {
+    writeActivityStateDiagnostic("telemetry_activity_state_read_failed", error, error instanceof Error ? "error" : "non_error")
     return {}
   }
 }
@@ -55,7 +70,8 @@ function writePostHogActivityState(nextState: PostHogActivityState): void {
   try {
     mkdirSync(stateDir, { recursive: true })
     writeFileAtomically(stateFilePath, `${JSON.stringify(nextState, null, 2)}\n`)
-  } catch {
+  } catch (error) {
+    writeActivityStateDiagnostic("telemetry_activity_state_write_failed", error, error instanceof Error ? "error" : "non_error")
     return
   }
 }

package/packages/omo-codex/plugin/components/telemetry/src/posthog.ts

@@ -3,6 +3,12 @@ import os from "node:os";
 
 import type { PostHog } from "posthog-node";
 
+import {
+	type TelemetryDiagnosticErrorKind,
+	type TelemetryDiagnosticEvent,
+	type TelemetryDiagnosticSource,
+	writeTelemetryDiagnostic,
+} from "./diagnostics.js";
 import { getPostHogApiKey, getPostHogHost, hasPostHogApiKey, shouldDisablePostHog } from "./env-flags.js";
 import { getPostHogActivityCaptureState } from "./posthog-activity-state.js";
 import {
@@ -44,6 +50,15 @@ function resolveActivityStateProvider(): ActivityStateProvider {
 	return activityStateProviderOverride ?? getPostHogActivityCaptureState;
 }
 
+function writePostHogDiagnostic(
+	event: TelemetryDiagnosticEvent,
+	source: TelemetryDiagnosticSource,
+	error: unknown,
+	errorKind: TelemetryDiagnosticErrorKind,
+): void {
+	writeTelemetryDiagnostic({ event, source, error, errorKind });
+}
+
 function getSafeCpuInfo(): { readonly count: number; readonly model: string | undefined } {
 	try {
 		const cpuInfo = resolveOsProvider().cpus();
@@ -51,7 +66,13 @@ function getSafeCpuInfo(): { readonly count: number; readonly model: string | un
 			count: cpuInfo.length,
 			model: cpuInfo[0]?.model,
 		};
-	} catch {
+	} catch (error) {
+		writePostHogDiagnostic(
+			"telemetry_cpu_info_unavailable",
+			"plugin",
+			error,
+			error instanceof Error ? "error" : "non_error",
+		);
 		return {
 			count: 0,
 			model: undefined,
@@ -96,8 +117,13 @@ export async function createPluginPostHog(): Promise<PostHogClient> {
 		const module = await import("posthog-node");
 		PostHogClientConstructor = module.PostHog;
 	} catch (error) {
-		if (error instanceof Error) return NO_OP_POSTHOG;
-		throw error;
+		writePostHogDiagnostic(
+			"telemetry_posthog_import_failed",
+			"plugin",
+			error,
+			error instanceof Error ? "error" : "non_error",
+		);
+		return NO_OP_POSTHOG;
 	}
 
 	let client: PostHog;
@@ -112,7 +138,13 @@ export async function createPluginPostHog(): Promise<PostHogClient> {
 			host: getPostHogHost(),
 			disableGeoip: false,
 		});
-	} catch {
+	} catch (error) {
+		writePostHogDiagnostic(
+			"telemetry_posthog_init_failed",
+			"plugin",
+			error,
+			error instanceof Error ? "error" : "non_error",
+		);
 		return NO_OP_POSTHOG;
 	}
 

package/packages/omo-codex/plugin/components/telemetry/test/codex-hook-diagnostics.test.ts

@@ -0,0 +1,115 @@
+import { mkdtempSync, readFileSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
+import { afterEach, describe, expect, it } from "vitest";
+
+import { type CodexSessionStartInput, runSessionStartHook } from "../src/codex-hook.js";
+import { getTelemetryDiagnosticsFilePath } from "../src/diagnostics.js";
+import type { PostHogClient } from "../src/posthog.js";
+
+const tempDirectories: string[] = [];
+const originalXdgDataHome = process.env["XDG_DATA_HOME"];
+
+afterEach(() => {
+	if (originalXdgDataHome === undefined) {
+		delete process.env["XDG_DATA_HOME"];
+	} else {
+		process.env["XDG_DATA_HOME"] = originalXdgDataHome;
+	}
+
+	for (const directory of tempDirectories.splice(0)) {
+		rmSync(directory, { recursive: true, force: true });
+	}
+});
+
+function makeSessionStartInput(overrides: Partial<CodexSessionStartInput> = {}): CodexSessionStartInput {
+	return {
+		session_id: "session-123",
+		transcript_path: null,
+		cwd: "/tmp/project",
+		hook_event_name: "SessionStart",
+		model: "gpt-5.5",
+		permission_mode: "default",
+		source: "startup",
+		...overrides,
+	};
+}
+
+function createDiagnosticsDataDir(): string {
+	const dataDir = mkdtempSync(path.join(tmpdir(), "codex-telemetry-diagnostics-"));
+	tempDirectories.push(dataDir);
+	process.env["XDG_DATA_HOME"] = dataDir;
+	return dataDir;
+}
+
+describe("runSessionStartHook diagnostics", () => {
+	describe("#given a client whose trackActive throws", () => {
+		it("#when invoked #then swallows the error, writes diagnostics, still shuts down, and returns empty string", async () => {
+			let shutdownCalls = 0;
+			createDiagnosticsDataDir();
+			const throwingClient: PostHogClient = {
+				trackActive: () => {
+					throw new Error("trackActive failed");
+				},
+				shutdown: async () => {
+					shutdownCalls += 1;
+				},
+			};
+
+			const output = await runSessionStartHook(makeSessionStartInput(), {
+				createClient: () => throwingClient,
+				getDistinctId: () => "distinct-id-abc",
+			});
+
+			expect(output).toBe("");
+			expect(shutdownCalls).toBe(1);
+			const diagnostics = readFileSync(getTelemetryDiagnosticsFilePath(), "utf-8");
+			expect(diagnostics).toContain('"event":"telemetry_capture_failed"');
+			expect(diagnostics).toContain('"error_message":"trackActive failed"');
+		});
+
+		it("#when invoked with a non-Error throw #then writes diagnostics and still returns empty string", async () => {
+			let shutdownCalls = 0;
+			const failure = Symbol("trackActive failed");
+			createDiagnosticsDataDir();
+			const throwingClient: PostHogClient = {
+				trackActive: () => {
+					throw failure;
+				},
+				shutdown: async () => {
+					shutdownCalls += 1;
+				},
+			};
+
+			const output = await runSessionStartHook(makeSessionStartInput(), {
+				createClient: () => throwingClient,
+				getDistinctId: () => "distinct-id-abc",
+			});
+
+			expect(output).toBe("");
+			expect(shutdownCalls).toBe(1);
+			const diagnostics = readFileSync(getTelemetryDiagnosticsFilePath(), "utf-8");
+			expect(diagnostics).toContain('"event":"telemetry_capture_failed"');
+			expect(diagnostics).toContain('"error_name":"symbol"');
+			expect(diagnostics).toContain('"error_message":"Symbol(trackActive failed)"');
+		});
+	});
+
+	describe("#given a client whose shutdown rejects", () => {
+		it("#when invoked #then swallows the rejection and returns empty string", async () => {
+			const rejectingClient: PostHogClient = {
+				trackActive: () => undefined,
+				shutdown: async () => {
+					throw new Error("shutdown failed");
+				},
+			};
+
+			const output = await runSessionStartHook(makeSessionStartInput(), {
+				createClient: () => rejectingClient,
+				getDistinctId: () => "distinct-id-abc",
+			});
+
+			expect(output).toBe("");
+		});
+	});
+});

package/packages/omo-codex/plugin/components/telemetry/test/codex-hook.test.ts

@@ -22,8 +22,15 @@ type CliResult = {
 };
 
 const tempDirectories: string[] = [];
+const originalXdgDataHome = process.env["XDG_DATA_HOME"];
 
 afterEach(() => {
+	if (originalXdgDataHome === undefined) {
+		delete process.env["XDG_DATA_HOME"];
+	} else {
+		process.env["XDG_DATA_HOME"] = originalXdgDataHome;
+	}
+
 	for (const directory of tempDirectories.splice(0)) {
 		rmSync(directory, { recursive: true, force: true });
 	}
@@ -116,39 +123,23 @@ describe("runSessionStartHook", () => {
 		});
 	});
 
-	describe("#given a client whose trackActive throws", () => {
-		it("#when invoked #then swallows the error, still shuts down, and returns empty string", async () => {
-			let shutdownCalls = 0;
-			const throwingClient: PostHogClient = {
-				trackActive: () => {
-					throw new Error("trackActive failed");
-				},
-				shutdown: async () => {
-					shutdownCalls += 1;
-				},
-			};
-
+	describe("#given PostHog client creation fails", () => {
+		it("#when createClient throws #then hook resolves with empty output", async () => {
 			const output = await runSessionStartHook(makeSessionStartInput(), {
-				createClient: () => throwingClient,
+				createClient: () => {
+					throw new Error("posthog unavailable");
+				},
 				getDistinctId: () => "distinct-id-abc",
 			});
 
 			expect(output).toBe("");
-			expect(shutdownCalls).toBe(1);
 		});
-	});
-
-	describe("#given a client whose shutdown rejects", () => {
-		it("#when invoked #then swallows the rejection and returns empty string", async () => {
-			const rejectingClient: PostHogClient = {
-				trackActive: () => undefined,
-				shutdown: async () => {
-					throw new Error("shutdown failed");
-				},
-			};
 
+		it("#when createClient rejects #then hook resolves with empty output", async () => {
 			const output = await runSessionStartHook(makeSessionStartInput(), {
-				createClient: () => rejectingClient,
+				createClient: async () => {
+					throw new Error("posthog unavailable");
+				},
 				getDistinctId: () => "distinct-id-abc",
 			});