oh-my-opencode 4.5.1 → 4.5.12

package/packages/omo-codex/plugin/components/comment-checker/test/package-smoke.test.ts

@@ -0,0 +1,93 @@
+import { readFileSync } from "node:fs";
+import { describe, expect, it } from "vitest";
+
+type PackageJson = {
+	readonly type: string;
+	readonly packageManager: string;
+	readonly bin: Record<string, string>;
+	readonly dependencies?: Record<string, unknown>;
+	readonly optionalDependencies: Record<string, string>;
+};
+
+type HookCommand = {
+	readonly command: string;
+};
+
+type HookEntry = {
+	readonly hooks: readonly HookCommand[];
+};
+
+type HooksJson = {
+	readonly hooks: Record<string, readonly HookEntry[]>;
+};
+
+function readPackageJson(path: string): PackageJson {
+	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
+	if (!isPackageJson(parsed)) throw new TypeError(`Invalid package metadata: ${path}`);
+	return parsed;
+}
+
+function readHooksJson(path: string): HooksJson {
+	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
+	if (!isHooksJson(parsed)) throw new TypeError(`Invalid hooks metadata: ${path}`);
+	return parsed;
+}
+
+describe("plugin package metadata", () => {
+	it("#given packaged plugin files #when validating entrypoints #then hook command uses portable plugin root interpolation", () => {
+		// given
+		const packageJson = readPackageJson("package.json");
+		const hooksJson = readHooksJson("hooks/hooks.json");
+		const cliSource = readFileSync("src/cli.ts", "utf8");
+
+		// when
+		const command = hooksJson.hooks["PostToolUse"]?.[0]?.hooks[0]?.command;
+		const pluginRoot = ["$", "{PLUGIN_ROOT}"].join("");
+
+		// then
+		expect(packageJson.type).toBe("module");
+		expect(packageJson.packageManager).toBe("npm@11.12.1");
+		expect(packageJson.dependencies ?? {}).not.toHaveProperty("@code-yeongyu/comment-checker");
+		expect(packageJson.optionalDependencies).toHaveProperty("@code-yeongyu/comment-checker");
+		expect(packageJson.bin["omo-comment-checker"]).toBe("./dist/cli.js");
+		expect(cliSource.startsWith("#!/usr/bin/env node")).toBe(true);
+		expect(command).toBe(`node "${pluginRoot}/dist/cli.js" hook post-tool-use`);
+	});
+});
+
+function isPackageJson(value: unknown): value is PackageJson {
+	if (!isRecord(value)) return false;
+	const dependencies = value["dependencies"];
+	return (
+		value["type"] === "module" &&
+		value["packageManager"] === "npm@11.12.1" &&
+		isStringRecord(value["bin"]) &&
+		isStringRecord(value["optionalDependencies"]) &&
+		(dependencies === undefined || isRecord(dependencies))
+	);
+}
+
+function isHooksJson(value: unknown): value is HooksJson {
+	if (!isRecord(value) || !isRecord(value["hooks"])) return false;
+	return Object.values(value["hooks"]).every(isHookEntries);
+}
+
+function isHookEntries(value: unknown): value is readonly HookEntry[] {
+	return Array.isArray(value) && value.every(isHookEntry);
+}
+
+function isHookEntry(value: unknown): value is HookEntry {
+	return isRecord(value) && Array.isArray(value["hooks"]) && value["hooks"].every(isHookCommand);
+}
+
+function isHookCommand(value: unknown): value is HookCommand {
+	return isRecord(value) && typeof value["command"] === "string";
+}
+
+function isStringRecord(value: unknown): value is Record<string, string> {
+	return isRecord(value) && Object.values(value).every((item) => typeof item === "string");
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+	return typeof value === "object" && value !== null && !Array.isArray(value);
+}

package/packages/omo-codex/plugin/components/comment-checker/test/runner.test.ts

@@ -0,0 +1,66 @@
+import { existsSync } from "node:fs";
+import { describe, expect, it } from "vitest";
+
+import {
+	MAX_PROCESS_OUTPUT_BYTES,
+	resolveCommentCheckerBinary,
+	runCommentChecker,
+	spawnProcess,
+} from "../src/runner.js";
+
+describe("spawnProcess", () => {
+	it("#given noisy checker process #when output exceeds cap #then stderr is bounded", async () => {
+		// given
+		const maxOutputBytes = 16;
+
+		// when
+		const result = await spawnProcess(
+			process.execPath,
+			["-e", "process.stderr.write('x'.repeat(40)); process.exit(2);"],
+			"",
+			maxOutputBytes,
+		);
+
+		// then
+		expect(MAX_PROCESS_OUTPUT_BYTES).toBeGreaterThan(maxOutputBytes);
+		expect(result.exitCode).toBe(2);
+		expect(result.stderr).toBe(`${"x".repeat(maxOutputBytes)}\n[stderr truncated after 16 bytes]`);
+	});
+});
+
+describe("resolveCommentCheckerBinary", () => {
+	it("#given installed checker package #when resolving binary #then returns existing checker binary", () => {
+		// given / when
+		const binaryPath = resolveCommentCheckerBinary();
+
+		// then
+		expect(binaryPath).toBeDefined();
+		expect(binaryPath ?? "").toContain("comment-checker");
+		expect(existsSync(binaryPath ?? "")).toBe(true);
+	});
+});
+
+describe("runCommentChecker", () => {
+	it("#given missing checker binary #when runner starts #then returns missing result", async () => {
+		// given / when
+		const result = await runCommentChecker(
+			{
+				session_id: "session-1",
+				tool_name: "Write",
+				transcript_path: "",
+				cwd: "/repo",
+				hook_event_name: "PostToolUse",
+				tool_input: {
+					file_path: "src/example.ts",
+					content: "const value = 1;\n",
+				},
+			},
+			{
+				resolveBinary: () => undefined,
+			},
+		);
+
+		// then
+		expect(result.status).toBe("missing");
+	});
+});

package/packages/omo-codex/plugin/components/comment-checker/tsconfig.build.json

@@ -0,0 +1,12 @@
+{
+	"extends": "./tsconfig.json",
+	"compilerOptions": {
+		"allowImportingTsExtensions": false,
+		"declaration": true,
+		"outDir": "dist",
+		"rootDir": "src",
+		"noEmit": false
+	},
+	"include": ["src/**/*"],
+	"exclude": ["test/**/*"]
+}

package/packages/omo-codex/plugin/components/comment-checker/tsconfig.json

@@ -0,0 +1,27 @@
+{
+	"compilerOptions": {
+		"target": "ES2022",
+		"module": "Node16",
+		"moduleResolution": "Node16",
+		"lib": ["ES2022"],
+		"strict": true,
+		"exactOptionalPropertyTypes": true,
+		"noUncheckedIndexedAccess": true,
+		"noPropertyAccessFromIndexSignature": true,
+		"verbatimModuleSyntax": true,
+		"noImplicitOverride": true,
+		"noImplicitReturns": true,
+		"noFallthroughCasesInSwitch": true,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
+		"esModuleInterop": true,
+		"allowImportingTsExtensions": true,
+		"skipLibCheck": true,
+		"forceConsistentCasingInFileNames": true,
+		"resolveJsonModule": true,
+		"useDefineForClassFields": false,
+		"types": ["node"],
+		"noEmit": true
+	},
+	"include": ["src/**/*", "test/**/*"]
+}

package/packages/omo-codex/plugin/components/comment-checker/vitest.config.ts

@@ -0,0 +1,9 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+	test: {
+		include: ["test/**/*.test.ts"],
+		environment: "node",
+		pool: "threads",
+	},
+});

package/packages/omo-codex/plugin/components/lsp/.gitattributes

@@ -0,0 +1,13 @@
+# Normalize line endings: store LF in git, check out LF on every platform.
+# Required so biome's --check passes on Windows (default core.autocrlf=true).
+* text=auto eol=lf
+
+# Explicit binary types
+*.png binary
+*.jpg binary
+*.jpeg binary
+*.gif binary
+*.ico binary
+*.zip binary
+*.tgz binary
+*.gz binary

package/packages/omo-codex/plugin/components/lsp/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @code-yeongyu

package/packages/omo-codex/plugin/components/lsp/.github/ISSUE_TEMPLATE/bug.yml

@@ -0,0 +1,26 @@
+name: Bug report
+description: Report a reproducible codex-lsp bug.
+title: "[bug]: "
+labels: ["bug"]
+body:
+  - type: textarea
+    id: summary
+    attributes:
+      label: Summary
+      description: What happened?
+    validations:
+      required: true
+  - type: textarea
+    id: reproduction
+    attributes:
+      label: Reproduction
+      description: Exact steps, config, command output, and affected language server.
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Version
+      placeholder: 0.1.0
+    validations:
+      required: true

package/packages/omo-codex/plugin/components/lsp/.github/ISSUE_TEMPLATE/feature.yml

@@ -0,0 +1,19 @@
+name: Feature request
+description: Propose a focused codex-lsp improvement.
+title: "[feature]: "
+labels: ["enhancement"]
+body:
+  - type: textarea
+    id: problem
+    attributes:
+      label: Problem
+      description: What workflow should improve?
+    validations:
+      required: true
+  - type: textarea
+    id: proposal
+    attributes:
+      label: Proposal
+      description: What should codex-lsp do?
+    validations:
+      required: true

package/packages/omo-codex/plugin/components/lsp/.github/branch-ruleset.json

@@ -0,0 +1,45 @@
+{
+	"name": "main protection",
+	"target": "branch",
+	"enforcement": "active",
+	"conditions": {
+		"ref_name": {
+			"include": ["~DEFAULT_BRANCH"],
+			"exclude": []
+		}
+	},
+	"rules": [
+		{ "type": "deletion" },
+		{ "type": "non_fast_forward" },
+		{ "type": "required_linear_history" },
+		{
+			"type": "pull_request",
+			"parameters": {
+				"required_approving_review_count": 1,
+				"dismiss_stale_reviews_on_push": true,
+				"require_code_owner_review": true,
+				"require_last_push_approval": false,
+				"required_review_thread_resolution": true
+			}
+		},
+		{
+			"type": "required_status_checks",
+			"parameters": {
+				"strict_required_status_checks_policy": true,
+				"required_status_checks": [
+					{ "context": "test (ubuntu-latest · node 20)" },
+					{ "context": "test (ubuntu-latest · node 22)" },
+					{ "context": "test (macos-latest · node 20)" },
+					{ "context": "test (macos-latest · node 22)" }
+				]
+			}
+		}
+	],
+	"bypass_actors": [
+		{
+			"actor_id": 5,
+			"actor_type": "RepositoryRole",
+			"bypass_mode": "always"
+		}
+	]
+}

package/packages/omo-codex/plugin/components/lsp/.github/dependabot.yml

@@ -0,0 +1,11 @@
+version: 2
+updates:
+  - package-ecosystem: npm
+    directory: /
+    schedule:
+      interval: weekly
+    open-pull-requests-limit: 5
+  - package-ecosystem: github-actions
+    directory: /
+    schedule:
+      interval: weekly

package/packages/omo-codex/plugin/components/lsp/.github/pull_request_template.md

@@ -0,0 +1,11 @@
+## Summary
+
+-
+
+## Validation
+
+-
+
+## Notes
+
+-

package/packages/omo-codex/plugin/components/lsp/.github/workflows/ci.yml

@@ -0,0 +1,56 @@
+name: ci
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    name: test (${{ matrix.os }} · node ${{ matrix.node }})
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: 15
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        node: ["20", "22"]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          submodules: recursive
+
+      - name: Setup Node ${{ matrix.node }}
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ matrix.node }}
+          cache: npm
+
+      - name: Bootstrap lsp-tools-mcp submodule
+        shell: bash
+        run: |
+          cd packages/lsp-tools-mcp
+          npm ci
+          npm run build
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Check
+        run: npm run check
+
+      - name: Unit tests
+        run: npm test
+
+      - name: Package smoke
+        run: npm pack --dry-run

package/packages/omo-codex/plugin/components/lsp/.github/workflows/publish.yml

@@ -0,0 +1,60 @@
+name: publish
+
+on:
+  release:
+    types: [published]
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: false
+
+permissions:
+  contents: read
+  id-token: write
+
+jobs:
+  publish:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          submodules: recursive
+
+      - name: Setup Node 22
+        uses: actions/setup-node@v6
+        with:
+          node-version: "22"
+          registry-url: https://registry.npmjs.org
+          cache: npm
+
+      - name: Bootstrap lsp-tools-mcp submodule
+        shell: bash
+        run: |
+          cd packages/lsp-tools-mcp
+          npm ci
+          npm run build
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Check
+        run: npm run check
+
+      - name: Unit tests
+        run: npm test
+
+      - name: Package smoke
+        run: npm pack --dry-run
+
+      - name: Publish to npm
+        run: |
+          if [ -z "$NODE_AUTH_TOKEN" ]; then
+            echo "NODE_AUTH_TOKEN is not configured; skipping npm publish."
+            exit 0
+          fi
+          npm publish --access public --provenance
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}

package/packages/omo-codex/plugin/components/lsp/.mcp.json

@@ -0,0 +1,9 @@
+{
+	"mcpServers": {
+		"lsp": {
+			"command": "node",
+			"args": ["../../../../lsp-tools-mcp/dist/cli.js", "mcp"],
+			"cwd": "."
+		}
+	}
+}

package/packages/omo-codex/plugin/components/lsp/AGENTS.md

@@ -0,0 +1,25 @@
+# Repository Conventions
+
+Conventions for humans and agents working on this repository.
+
+## Style
+
+- TypeScript strict mode. No `any`, `@ts-ignore`, `@ts-expect-error`, or enums.
+- ESM modules with `.js` suffix in import paths.
+- Tabs for indentation. Double quotes for strings.
+- Runtime is Node only.
+- Tests use vitest and should exercise Codex hook/MCP behavior before implementation changes.
+
+## Commands
+
+- `npm install` installs dependencies.
+- `npm test` runs the test suite once.
+- `npm run typecheck` runs strict TypeScript checking.
+- `npm run check` runs typecheck, Biome, and build.
+
+## LSP Constraints
+
+- LSP server processes are owned by `LspManager`.
+- Tool execution acquires clients through `withLspClient(...)` unless it only reports static status.
+- `lsp.rename` mutates files by applying workspace edits; keep it sequential at the MCP caller level.
+- Do not add pi-coding-agent or omo source dependencies. This package is standalone.

package/packages/omo-codex/plugin/components/lsp/CHANGELOG.md

@@ -0,0 +1,25 @@
+# Changelog
+
+## Unreleased
+
+- Reuse the repository-level `packages/lsp-tools-mcp` package instead of carrying a second copy under `components/lsp/packages`.
+
+## 0.2.0
+
+- Extracted the LSP runtime and MCP server into [`@code-yeongyu/lsp-tools-mcp`](https://github.com/code-yeongyu/lsp-tools-mcp).
+- codex-lsp now consumes that runtime as a git submodule at `packages/lsp-tools-mcp`.
+- Kept the Codex-specific PostToolUse hook in this package and routed MCP serving through the upstream CLI.
+
+- Extract LSP runtime to `lsp-tools-mcp` upstream and consume it via git submodule at `packages/lsp-tools-mcp`.
+- Renamed the MCP server namespace to `lsp` and exposed shorter tool names such as `lsp.diagnostics`.
+- Use portable Codex hook interpolation and add package smoke coverage for hook/MCP entrypoints.
+- Spawn language servers without shell mode; Windows `.cmd` and `.bat` shims are routed through `cmd.exe` with explicit arguments.
+- Cap directory diagnostics file traversal and run CI on Windows in addition to Ubuntu and macOS.
+- Replace the external JSON-RPC runtime dependency with an internal LSP framing layer so clean Codex plugin installs run without `node_modules`.
+
+## 0.1.0
+
+- Ported the standalone LSP client, server resolution, diagnostics aggregation, and workspace edit runtime from `pi-lsp-client`.
+- Added Codex `PostToolUse` diagnostics for edit-style tools.
+- Added MCP tools for status, diagnostics, definitions, references, symbols, prepare rename, and rename.
+- Added Codex plugin metadata, skill docs, CI, and release automation.

package/packages/omo-codex/plugin/components/lsp/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Yeongyu Kim
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/packages/omo-codex/plugin/components/lsp/NOTICE

@@ -0,0 +1,3 @@
+codex-lsp ports the standalone LSP runtime from pi-lsp-client into a Codex plugin.
+
+The package includes adapted code originally developed for pi-lsp-client.