oh-my-opencode 4.19.4 → 5.0.0-beta.2

package/packages/omo-codex/plugin/test/bootstrap-binlinks.test.mjs

@@ -12,9 +12,9 @@ const { runBootstrapWorker, runWorkerSetup } = await import(CLI_URL.href);
 const MARKETPLACE_SOURCE_LINE = 'source = "https://github.com/code-yeongyu/lazycodex.git"';
 const COMPONENT_BIN_NAME = "omo-toolbox";
 const execFileAsync = promisify(execFile);
-const OMO_CLI_DEGRADED_ENTRY = {
-	component: "omo-cli",
-	hint: "use npx lazycodex-ai for the omo CLI",
+const OMO_AGENT_TOOLKIT_DEGRADED_ENTRY = {
+	component: "omo-agent-toolkit",
+	hint: "use npx lazycodex-ai for the omo-agent-toolkit CLI",
 	reason: "marketplace payload has no dist/cli",
 };
 
@@ -205,7 +205,7 @@ test("#given a completed v1 marker #when the worker runs against a v2 root #then
 	});
 });
 
-test("#given platform win32 #when the worker setup links bins #then component bins become .cmd shims and the omo wrapper is omo.cmd", async () => {
+test("#given platform win32 #when the worker setup links bins #then component bins become .cmd shims and the canonical wrapper is omo-agent-toolkit.cmd", async () => {
 	await withBinLinkFixture(async (fixture) => {
 		const bashPath = "C:\\Tools\\Git\\bin\\bash.exe";
 		const pluginRoot = await writeVersionedRoot(fixture.root, "1.0.0", { withRuntimeCli: true });
@@ -226,19 +226,19 @@ test("#given platform win32 #when the worker setup links bins #then component bi
 		assert.match(shim, /"%OMO_NODE_BINARY%"/);
 		assert.match(shim, new RegExp(`"${escapeRegExp(componentEntrypoint)}" %\\*`));
 		assert.doesNotMatch(shim, new RegExp(`node "${escapeRegExp(componentEntrypoint)}" %\\*`));
-		const wrapper = await readFile(join(fixture.binDir, "omo.cmd"), "utf8");
+		const wrapper = await readFile(join(fixture.binDir, "omo-agent-toolkit.cmd"), "utf8");
 		assert.ok(wrapper.includes(join(pluginRoot, "dist", "cli", "index.js")));
 		await assert.rejects(() => lstat(join(fixture.binDir, COMPONENT_BIN_NAME)), "win32 must not leave posix symlinks behind");
 	});
 });
 
-test("#given a legacy payload without root CLI dist #when the worker setup runs #then it records degraded omo-cli and leaves no broken link", async () => {
+test("#given a legacy payload without root CLI dist #when the worker setup runs #then it records degraded omo-agent-toolkit and leaves no broken link", async () => {
 	await withBinLinkFixture(async (fixture) => {
 		const pluginRoot = await writeVersionedRoot(fixture.root, "1.0.0");
 
 		const outcome = await runWorkerSetup(setupOptions(fixture, pluginRoot, { now: 7_000, platform: process.platform }));
 
-		assert.deepEqual(outcome.degraded, [OMO_CLI_DEGRADED_ENTRY]);
+		assert.deepEqual(outcome.degraded, [OMO_AGENT_TOOLKIT_DEGRADED_ENTRY]);
 		await assert.rejects(() => lstat(join(fixture.binDir, "omo")), "no omo wrapper may be written without dist/cli");
 		await assert.rejects(() => lstat(join(fixture.binDir, "omo.cmd")), "no Windows omo wrapper may be written without dist/cli");
 		await assertNoDanglingEntries(fixture.binDir);
@@ -246,15 +246,15 @@ test("#given a legacy payload without root CLI dist #when the worker setup runs
 		const warning = JSON.parse(log)["warning"];
 		assert.equal(typeof warning, "string", `bootstrap.log warning must be a string, got: ${log}`);
 		assert.ok(
-			warning.includes("skipped the omo runtime wrapper because ") &&
+			warning.includes("skipped the omo-agent-toolkit runtime wrapper because ") &&
 				warning.includes(`${join("dist", "cli", "index.js")} is missing; `) &&
-				warning.includes("omo ulw-loop commands will be unavailable until a package shipping dist/cli is installed"),
+				warning.includes("omo-agent-toolkit ulw-loop commands will be unavailable until a package shipping dist/cli is installed"),
 			`bootstrap.log must carry the install-local warning text, got: ${log}`,
 		);
 	});
 });
 
-test("#given a payload shipping dist/cli #when the worker setup runs with no bin-dir override #then the omo wrapper lands in <codexHome>/bin without a degraded entry", async () => {
+test("#given a payload shipping dist/cli #when the worker setup runs with no bin-dir override #then the omo-agent-toolkit wrapper lands in <codexHome>/bin without a degraded entry", async () => {
 	await withBinLinkFixture(async (fixture) => {
 		const pluginRoot = await writeVersionedRoot(fixture.root, "1.0.0", { withRuntimeCli: true });
 
@@ -262,12 +262,12 @@ test("#given a payload shipping dist/cli #when the worker setup runs with no bin
 
 		assert.deepEqual(outcome.degraded, []);
 		const defaultBinDir = join(fixture.codexHome, "bin");
-		const wrapperName = process.platform === "win32" ? "omo.cmd" : "omo";
+		const wrapperName = process.platform === "win32" ? "omo-agent-toolkit.cmd" : "omo-agent-toolkit";
 		const wrapperPath = join(defaultBinDir, wrapperName);
 		const wrapper = await readFile(wrapperPath, "utf8");
 		assert.ok(wrapper.includes(join(pluginRoot, "dist", "cli", "index.js")));
 		if (process.platform !== "win32") {
-			assert.ok((await stat(wrapperPath)).mode & 0o111, "the posix omo wrapper must be executable");
+			assert.ok((await stat(wrapperPath)).mode & 0o111, "the posix omo-agent-toolkit wrapper must be executable");
 			assert.equal(
 				await readlink(join(defaultBinDir, COMPONENT_BIN_NAME)),
 				join(pluginRoot, "components", "toolbox", "dist", "cli.js"),

package/packages/omo-codex/plugin/test/bootstrap-orchestration.test.mjs

@@ -321,7 +321,7 @@ test("#given a completed marker #when the worker runs with --once #then the mark
 	});
 });
 
-test("#given --only sg #when the worker runs #then only the matching step executes", async () => {
+test("#given --only names an injected custom step #when the worker runs #then only the matching step executes", async () => {
 	await withFixture(async (fixture) => {
 		const ran = [];
 		const step = (name) => ({
@@ -333,13 +333,45 @@ test("#given --only sg #when the worker runs #then only the matching step execut
 		});
 
 		const result = await runBootstrapWorker({
-			argv: ["--only", "sg"],
+			argv: ["--only", "custom"],
 			env: fixture.env,
-			steps: [step("setup"), step("sg")],
+			steps: [step("other"), step("custom")],
 		});
 
 		assert.equal(result.ran, true);
-		assert.deepEqual(ran, ["sg"]);
+		assert.deepEqual(ran, ["custom"]);
+	});
+});
+
+test("#given an unknown --only value #when the worker starts #then it rejects before steps or bootstrap artifacts", async () => {
+	await withFixture(async (fixture) => {
+		let stepRuns = 0;
+
+		await assert.rejects(
+			() =>
+				runBootstrapWorker({
+					argv: ["--only", "bogus"],
+					env: fixture.env,
+					steps: [
+						{
+							name: "custom",
+							run: async () => {
+								stepRuns += 1;
+								return { degraded: [] };
+							},
+						},
+					],
+				}),
+			/unknown --only flag value: bogus/,
+		);
+		assert.equal(stepRuns, 0);
+		await assert.rejects(() => stat(join(fixture.pluginData, "bootstrap")));
+		await Promise.all([
+			assert.rejects(() => stat(join(fixture.pluginData, "bootstrap", "state.json"))),
+			assert.rejects(() => stat(join(fixture.pluginData, "bootstrap", "bootstrap.log"))),
+			assert.rejects(() => stat(join(fixture.pluginData, "bootstrap", "state.json.lock"))),
+			assert.rejects(() => stat(join(fixture.pluginData, "auto-update.json.lock"))),
+		]);
 	});
 });
 

package/packages/omo-codex/plugin/test/sync-skills-orchestration.test.mjs

@@ -261,7 +261,7 @@ test("#given start-work skill #when synced for Codex #then the difficulty-tier d
 	const content = await readSkill("start-work");
 
 	assert.match(content, /lazycodex-worker-medium/);
-	assert.match(content, /Delegation by difficulty/);
+	assert.match(content, /Codex tier mapping for the delegation router/);
 	assert.match(content, /Global Review and Debugging Gate/);
 	assert.match(content, /full commit SHA/);
 	assert.match(content, /re-read the ledger record/);

package/packages/omo-codex/plugin/test/sync-skills-test-support.mjs

@@ -90,9 +90,9 @@ const startWorkCodexCompletion = `When all top-level checkboxes in \`## TODOs\`
 4. Remove or mark the Boulder work as completed.
 5. Print an \`ORCHESTRATION COMPLETE\` block with the plan path, verification commands, Global Review and Debugging Gate verdict, artifacts, and cleanup receipts.`;
 
-const startWorkOriginalHardRule = "- No completion claim while an applicable ultraqa adversarial class was never probed. Each applicable class needs a captured observable result; each skipped class needs a one-line not-applicable reason in the ledger.\n- No PR/branch implementation, review, or merge in the main worktree; use the task-owned git worktree.\n- No unprefixed session ids in Boulder state. Codex sessions are always `codex:<session_id>`.";
+const startWorkOriginalHardRule = "- No completion claim while an applicable ultraqa adversarial class was never probed. Each applicable class needs a captured observable result; each skipped class needs a one-line not-applicable reason in the ledger.\n- No PR/branch implementation, review, or merge in the main worktree; use the task-owned git worktree.\n- No unprefixed session ids in Boulder state. Sessions are always recorded as `codex:<session_id>`.";
 
-const startWorkCodexHardRule = "- No completion claim while an applicable ultraqa adversarial class was never probed. Each applicable class needs a captured observable result; each skipped class needs a one-line not-applicable reason in the ledger.\n- No `ORCHESTRATION COMPLETE`, final response, PR creation, PR handoff, or merge before the Global Review and Debugging Gate passes with recorded evidence.\n- No PR/branch implementation or review in the main worktree; create or use a task-owned git worktree first.\n- No unprefixed session ids in Boulder state. Codex sessions are always `codex:<session_id>`.";
+const startWorkCodexHardRule = "- No completion claim while an applicable ultraqa adversarial class was never probed. Each applicable class needs a captured observable result; each skipped class needs a one-line not-applicable reason in the ledger.\n- No `ORCHESTRATION COMPLETE`, final response, PR creation, PR handoff, or merge before the Global Review and Debugging Gate passes with recorded evidence.\n- No PR/branch implementation or review in the main worktree; create or use a task-owned git worktree first.\n- No unprefixed session ids in Boulder state. Sessions are always recorded as `codex:<session_id>`.";
 
 const reviewWorkCodexGate = `
 When \`review-work\` is used as a final implementation, PR, or \`$start-work\`
@@ -127,8 +127,8 @@ prefixes when identity is needed.
 `;
 const reviewWorkCodexGatePattern = new RegExp(reviewWorkCodexGate.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"));
 
-const ulwResearchOriginalDeliveryGates = "### The delivery gates \u2014 every gate must PASS, in order\n\nNothing reaches the user until the gates pass:\n\n1. **Visual QA (always).** Render the produced artifact back to images \u2014 PDF pages to PNG, the HTML in a real browser \u2014 and look at them: missing or broken figures, clipped tables, overflowing CJK text, blank pages, unreadable chart labels, wrong page breaks. Fix and re-render until the pages are clean. Reading the source markup is not visual QA; inspect the pixels.\n2. **Proofread gate \u2014 `task(category=\"writing\", ...)`.** Hand the final text to a dedicated `writing` worker whose only job is language: grammar, spelling, punctuation, terminology consistency, and whether the prose reads NATIVELY in the report's own language. It returns a defect list; fix every item and re-run the gate on the delta. Deliver only on a clean pass \u2014 this gate runs BEFORE the first delivery, not after the user finds the typo.";
-const ulwResearchCodexDeliveryGate = "### The delivery gate \u2014 visual QA must PASS\n\nNothing reaches the user until the gate passes:\n\n**Visual QA (always).** Render the produced artifact back to images \u2014 PDF pages to PNG, the HTML in a real browser \u2014 and look at them: missing or broken figures, clipped tables, overflowing CJK text, blank pages, unreadable chart labels, wrong page breaks. Fix and re-render until the pages are clean. Reading the source markup is not visual QA; inspect the pixels.";
+const ulwResearchOriginalDeliveryGates = "### The delivery gates \u2014 every gate must PASS, in order\n\nNothing reaches the user until the gates pass:\n\n1. **Visual QA (always).** Render the produced artifact back to images \u2014 PDF pages to PNG, the HTML in a real browser \u2014 and look at them: missing or broken figures, images stretched or spilling their containers, diagram or chart text rendered off the spec's font or palette, clipped tables, overflowing CJK text, blank pages, unlabeled chart values, wrong page breaks. Fix and re-render until the pages are clean. Reading the source markup is not visual QA; inspect the pixels.\n2. **Proofread gate \u2014 `task(category=\"writing\", ...)`.** Hand the final text to a dedicated `writing` worker whose only job is language: grammar, spelling, punctuation, terminology consistency, and whether the prose reads NATIVELY in the report's own language. It returns a defect list; fix every item and re-run the gate on the delta. Deliver only on a clean pass \u2014 this gate runs BEFORE the first delivery, not after the user finds the typo.";
+const ulwResearchCodexDeliveryGate = "### The delivery gate \u2014 visual QA must PASS\n\nNothing reaches the user until the gate passes:\n\n**Visual QA (always).** Render the produced artifact back to images \u2014 PDF pages to PNG, the HTML in a real browser \u2014 and look at them: missing or broken figures, images stretched or spilling their containers, diagram or chart text rendered off the spec's font or palette, clipped tables, overflowing CJK text, blank pages, unlabeled chart values, wrong page breaks. Fix and re-render until the pages are clean. Reading the source markup is not visual QA; inspect the pixels.";
 
 export function removeCodexSkillOverlays(skillName, content) {
 	if (skillName === "ulw-research") {

package/packages/omo-codex/scripts/install-bin-links.test.mjs

@@ -26,14 +26,61 @@ async function writeRuntimeWrapperFixture({ withNodeCli = false } = {}) {
 	}
 	await mkdir(homeDir, { recursive: true });
 	const link = await linkRootRuntimeBin({ binDir, codexHome, repoRoot, platform: "linux" });
-	return { homeDir, link, repoRoot };
+	return { binDir, codexHome, homeDir, link, repoRoot };
 }
 
 function runtimeWrapperEnv(homeDir) {
 	return { PATH: `${dirname(process.execPath)}:/usr/bin:/bin`, HOME: homeDir };
 }
 
-test("#given bun absent from PATH but present in ~/.bun/bin #when running the omo runtime wrapper #then resolves the bun fallback", async (t) => {
+test("#given the generated installer #when linking the root runtime #then writes only the canonical wrapper with marker and edition exports", async () => {
+	const { binDir, link } = await writeRuntimeWrapperFixture();
+
+	assert.equal(link.name, "omo-agent-toolkit");
+	assert.equal(link.path, join(binDir, "omo-agent-toolkit"));
+	const wrapper = await readFile(link.path, "utf8");
+	assert.match(wrapper, /OMO_GENERATED_RUNTIME_WRAPPER/);
+	assert.match(wrapper, /export OMO_INVOCATION_NAME=omo-agent-toolkit/);
+	assert.match(wrapper, /export OMO_EDITION=codex/);
+	await assert.rejects(lstat(join(binDir, "omo")));
+});
+
+test("#given a marker-bearing legacy omo #when linking the root runtime #then deletes it", async () => {
+	const root = await makeTempDir();
+	const repoRoot = join(root, "repo");
+	const binDir = join(root, "bin");
+	await mkdir(join(repoRoot, "dist", "cli"), { recursive: true });
+	await mkdir(binDir, { recursive: true });
+	await writeFile(join(repoRoot, "dist", "cli", "index.js"), "");
+	await writeFile(join(binDir, "omo"), "#!/bin/sh\n# OMO_GENERATED_RUNTIME_WRAPPER\n");
+
+	await linkRootRuntimeBin({ binDir, codexHome: join(root, "codex"), repoRoot, platform: "linux" });
+
+	await assert.rejects(lstat(join(binDir, "omo")));
+	assert.match(await readFile(join(binDir, "omo-agent-toolkit"), "utf8"), /OMO_GENERATED_RUNTIME_WRAPPER/);
+});
+
+test("#given an unmarked user-owned omo #when linking twice #then preserves it byte-identical and remains idempotent", async () => {
+	const root = await makeTempDir();
+	const repoRoot = join(root, "repo");
+	const binDir = join(root, "bin");
+	const legacyPath = join(binDir, "omo");
+	const canonicalPath = join(binDir, "omo-agent-toolkit");
+	const userContent = Buffer.from("#!/bin/sh\necho user-owned\n");
+	await mkdir(join(repoRoot, "dist", "cli"), { recursive: true });
+	await mkdir(binDir, { recursive: true });
+	await writeFile(join(repoRoot, "dist", "cli", "index.js"), "");
+	await writeFile(legacyPath, userContent);
+
+	await linkRootRuntimeBin({ binDir, codexHome: join(root, "codex"), repoRoot, platform: "linux" });
+	const firstCanonical = await readFile(canonicalPath);
+	await linkRootRuntimeBin({ binDir, codexHome: join(root, "codex"), repoRoot, platform: "linux" });
+
+	assert.deepEqual(await readFile(legacyPath), userContent);
+	assert.deepEqual(await readFile(canonicalPath), firstCanonical);
+});
+
+test("#given bun absent from PATH but present in ~/.bun/bin #when running the omo-agent-toolkit runtime wrapper #then resolves the bun fallback", async (t) => {
 	if (process.platform === "win32") return t.skip("posix wrapper execution");
 	const { homeDir, link } = await writeRuntimeWrapperFixture();
 	await mkdir(join(homeDir, ".bun", "bin"), { recursive: true });
@@ -114,7 +161,12 @@ test("#given Windows platform #when writing the omo runtime wrapper #then embeds
 
 	const link = await linkRootRuntimeBin({ binDir, codexHome: join(root, "codex"), repoRoot, platform: "win32" });
 
+	assert.equal(link.name, "omo-agent-toolkit");
+	assert.equal(link.path, join(binDir, "omo-agent-toolkit.cmd"));
 	const wrapper = await readFile(link.path, "utf8");
+	assert.match(wrapper, /OMO_GENERATED_RUNTIME_WRAPPER/);
+	assert.match(wrapper, /set "OMO_INVOCATION_NAME=omo-agent-toolkit"/);
+	assert.match(wrapper, /set "OMO_EDITION=codex"/);
 	assert.match(wrapper, /OMO_RUNTIME/);
 	assert.match(wrapper, /dist[\\/]cli-node[\\/]index\.js/);
 	assert.ok(wrapper.indexOf("OMO_RUNTIME") < wrapper.indexOf("where bun"), "node override must precede bun discovery");
@@ -246,6 +298,7 @@ test("#given nested component declares reserved omo bin #when linking bins #then
 		name: "@example/ulw-loop",
 		bin: {
 			omo: "./dist/cli.js",
+			"omo-agent-toolkit": "./dist/cli.js",
 			"omo-ulw-loop": "./dist/cli.js",
 			ulw: "./dist/cli.js",
 			"ulw-loop": "./dist/cli.js",
@@ -261,6 +314,7 @@ test("#given nested component declares reserved omo bin #when linking bins #then
 		{ name: "ulw-loop", path: join(binDir, "ulw-loop"), target: join(componentRoot, "dist", "cli.js") },
 	]);
 	await assert.rejects(readlink(join(binDir, "omo")));
+	await assert.rejects(readlink(join(binDir, "omo-agent-toolkit")));
 	assert.equal(await readlink(join(binDir, "omo-ulw-loop")), join(componentRoot, "dist", "cli.js"));
 	assert.equal(await readlink(join(binDir, "ulw")), join(componentRoot, "dist", "cli.js"));
 	assert.equal(await readlink(join(binDir, "ulw-loop")), join(componentRoot, "dist", "cli.js"));

package/packages/omo-codex/scripts/install-delegated-command.test.mjs

@@ -3,7 +3,7 @@ import test from "node:test";
 
 import { buildDelegatedOmoInvocation, runDelegatedOmoCommand } from "./install-local.mjs";
 
-test("#given a lazycodex passthrough command #when delegating to omo #then resets OMO_INVOCATION_NAME so the delegate does not re-enter the lazycodex path", async () => {
+test("#given a lazycodex passthrough command #when delegating to omo-agent-toolkit #then resets OMO_INVOCATION_NAME so the delegate does not re-enter the lazycodex path", async () => {
 	// given
 	const parsed = { kind: "command", command: "boulder", args: [] };
 	let received;
@@ -25,12 +25,12 @@ test("#given a lazycodex passthrough command #when delegating to omo #then reset
 	assert.equal(received.runOptions.cwd, "/tmp/project");
 	assert.equal(
 		received.runOptions.env?.OMO_INVOCATION_NAME,
-		"omo",
-		"delegated omo command must run with OMO_INVOCATION_NAME=omo to avoid infinite recursion",
+		"omo-agent-toolkit",
+		"delegated command must run with OMO_INVOCATION_NAME=omo-agent-toolkit to avoid infinite recursion",
 	);
 });
 
-test("#given OMO_INVOCATION_NAME=lazycodex in the parent env #when delegating a cleanup passthrough #then the child env overrides it to omo", async () => {
+test("#given OMO_INVOCATION_NAME=lazycodex in the parent env #when delegating a cleanup passthrough #then the child env overrides it to omo-agent-toolkit", async () => {
 	// given
 	const previous = process.env.OMO_INVOCATION_NAME;
 	process.env.OMO_INVOCATION_NAME = "lazycodex";
@@ -52,7 +52,7 @@ test("#given OMO_INVOCATION_NAME=lazycodex in the parent env #when delegating a
 	}
 
 	// then
-	assert.equal(received.env.OMO_INVOCATION_NAME, "omo");
+	assert.equal(received.env.OMO_INVOCATION_NAME, "omo-agent-toolkit");
 });
 
 test("#given a dry-run doctor #when delegating #then routes to the Codex LazyCodex doctor workflow", async () => {
@@ -239,5 +239,5 @@ test("#given dry-run args with shell metacharacters #when delegating #then logs
 	});
 
 	// then
-	assert.equal(logged, "npx --yes --package oh-my-openagent omo cleanup --platform=codex --project '/tmp/lazy codex'\\''s qa'");
+	assert.equal(logged, "npx --yes --package oh-my-openagent omo-agent-toolkit cleanup --platform=codex --project '/tmp/lazy codex'\\''s qa'");
 });