oh-my-opencode 4.19.0 → 4.19.1

package/packages/omo-codex/plugin/test/aggregate-hooks.test.mjs

@@ -225,6 +225,32 @@ test("#given aggregate SessionStart hooks #when inspected #then LazyCodex auto-u
 	assert(sessionStartCommands.some((command) => command.includes("scripts/auto-update.mjs")));
 });
 
+test("#given aggregate SessionStart hooks #when inspected #then cold-start-prone hooks carry 15s timeout headroom", async () => {
+	// given
+	const manifests = await readAggregateHookManifests();
+
+	// when
+	const sessionStartHooks = manifests
+		.filter(({ hooks }) => hooks.hooks.SessionStart)
+		.flatMap(({ source, hooks }) =>
+			hooks.hooks.SessionStart.flatMap((group) =>
+				group.hooks.map((handler) => ({ source, command: handler.command, timeout: handler.timeout })),
+			),
+		);
+	const coldStartHooks = sessionStartHooks.filter(
+		({ command }) =>
+			command.includes("components/telemetry/dist/cli.js") ||
+			command.includes("scripts/auto-update.mjs") ||
+			command.includes("components/codegraph/dist/cli.js"),
+	);
+
+	// then
+	assert.equal(coldStartHooks.length, 3);
+	for (const hook of coldStartHooks) {
+		assert.equal(hook.timeout, 15, `${hook.source} must carry timeout 15 for cold-start headroom`);
+	}
+});
+
 test("#given aggregate PostToolUse hooks #when inspected #then CodeGraph init guidance is registered for CodeGraph tools", async () => {
 	// given
 	const commandHooks = await readAggregateCommandHooks();

package/packages/omo-codex/plugin/test/bootstrap-setup.test.mjs

@@ -127,6 +127,47 @@ test("#given a completed first run #when the worker setup runs again #then confi
 	});
 });
 
+test("#given a config.toml that already declares [agents.explorer] at a different path (Orca mirror) #when the worker setup runs #then no second colliding registration is added for that role", async () => {
+	await withSetupFixture(async (fixture) => {
+		const orcaMirrorPath = "/orca-mirrored-home/.codex/agents/explorer.toml";
+		await writeFile(
+			join(fixture.codexHome, "config.toml"),
+			`[marketplaces.sisyphuslabs]\n${MARKETPLACE_SOURCE_LINE}\n\n[agents.explorer]\nconfig_file = "${orcaMirrorPath}"\n`,
+		);
+
+		const outcome = await runWorkerSetup(setupOptions(fixture));
+
+		assert.deepEqual(outcome.degraded, []);
+		const config = await readConfig(fixture);
+		assert.equal(config.match(/\[agents\.explorer\]/g)?.length, 1, "exactly one [agents.explorer] block");
+		assert.ok(
+			config.includes(`[agents.explorer]\nconfig_file = "${orcaMirrorPath}"`),
+			"the pre-existing mirrored entry stays untouched",
+		);
+		assert.ok(
+			!config.includes('config_file = "./agents/explorer.toml"'),
+			"no colliding ./agents registration for the mirrored role",
+		);
+		assert.match(config, /\[agents\.metis\]\nconfig_file = "\.\/agents\/metis\.toml"/);
+		assert.equal(
+			await readFile(join(fixture.codexHome, "agents", "explorer.toml"), "utf8"),
+			BUNDLED_EXPLORER_TOML,
+			"the linked toml is still staged for Codex directory discovery",
+		);
+	});
+});
+
+test("#given a config.toml with no pre-existing agent entries #when the worker setup runs #then all bundled registrations are written", async () => {
+	await withSetupFixture(async (fixture) => {
+		const outcome = await runWorkerSetup(setupOptions(fixture));
+
+		assert.deepEqual(outcome.degraded, []);
+		const config = await readConfig(fixture);
+		assert.match(config, /\[agents\.explorer\]\nconfig_file = "\.\/agents\/explorer\.toml"/);
+		assert.match(config, /\[agents\.metis\]\nconfig_file = "\.\/agents\/metis\.toml"/);
+	});
+});
+
 test("#given a package-relative CodeGraph MCP path #when worker setup runs #then the path is stamped absolute", async () => {
 	await withSetupFixture(async (fixture) => {
 		await writeFile(

package/packages/omo-codex/scripts/install-dist/install-local.mjs

@@ -5903,7 +5903,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@oh-my-opencode/omo-codex",
-    version: "4.19.0",
+    version: "4.19.1",
     type: "module",
     private: true,
     description: "Codex harness adapter for oh-my-openagent. Vendored Codex plugin namespace (omo) + TypeScript installer + telemetry.",
@@ -6429,7 +6429,7 @@ function whereCommand(command) {
   }
 }
 // packages/omo-codex/src/install/codex-process.ts
-var WINDOWS_CMD_SHIM_COMMANDS = new Set(["npm", "npx"]);
+var WINDOWS_CMD_SHIM_COMMANDS = new Set(["codex", "npm", "npx"]);
 function resolveRunCommandInvocation(command, args, platform = process.platform) {
   if (platform !== "win32" || !WINDOWS_CMD_SHIM_COMMANDS.has(command.toLowerCase())) {
     return { command, args: [...args] };
@@ -7068,6 +7068,7 @@ async function rewriteCachedPackageLocalFileDependencies(pluginRoot, sourceRoot)
   const packageJsonPaths = [];
   await collectPackageJsonPaths(pluginRoot, pluginRoot, packageJsonPaths);
   const packageLock = await readPackageLock(pluginRoot);
+  let rewroteAnyPackageJson = false;
   for (const packageJsonPath of packageJsonPaths) {
     const raw = await readFile5(packageJsonPath, "utf8");
     const parsed = JSON.parse(raw);
@@ -7103,13 +7104,16 @@ async function rewriteCachedPackageLocalFileDependencies(pluginRoot, sourceRoot)
         changed = true;
       }
     }
-    if (changed)
+    if (changed) {
       await writeFile2(packageJsonPath, `${JSON.stringify(parsed, null, "\t")}
 `);
+      rewroteAnyPackageJson = true;
+    }
   }
   if (packageLock.changed)
     await writeFile2(packageLock.path, `${JSON.stringify(packageLock.value, null, "\t")}
 `);
+  return rewroteAnyPackageJson;
 }
 async function readPackageLock(pluginRoot) {
   const path = join8(pluginRoot, "package-lock.json");
@@ -7530,10 +7534,11 @@ async function installCachedPlugin(input) {
   await rm4(tempPath, { recursive: true, force: true });
   try {
     await copyDirectory(input.sourcePath, tempPath);
-    await rewriteCachedPackageLocalFileDependencies(tempPath, input.sourcePath);
+    const rewroteLocalFileDependencies = await rewriteCachedPackageLocalFileDependencies(tempPath, input.sourcePath);
     await copyBundledMcpRuntimeDists({ pluginRoot: tempPath, sourceRoot: input.sourcePath });
     await copyRootRuntimeDists({ pluginRoot: tempPath, sourcePath: input.sourcePath });
-    await maybeRunNpmInstall(tempPath, input.runCommand, npmInstallEnv, ["ci", "--omit=dev"]);
+    const installArgs = rewroteLocalFileDependencies ? ["install", "--omit=dev", "--no-audit", "--no-fund"] : ["ci", "--omit=dev"];
+    await maybeRunNpmInstall(tempPath, input.runCommand, npmInstallEnv, installArgs);
     await removeCachedManagedNpmBinShims(tempPath);
     if (input.buildSource === false)
       await maybeRunNpmSyncSkills(tempPath, input.runCommand, env);
@@ -9405,6 +9410,10 @@ var MANAGED_REASONING_DEFAULT_UPGRADES = new Map([
       {
         previous: { model: "gpt-5.6-sol", effort: "xhigh" },
         current: { model: "gpt-5.6-sol", effort: "max" }
+      },
+      {
+        previous: { model: "gpt-5.6-sol", effort: "max" },
+        current: { model: "gpt-5.6-sol", effort: "high" }
       }
     ]
   ],
@@ -9414,6 +9423,37 @@ var MANAGED_REASONING_DEFAULT_UPGRADES = new Map([
       {
         previous: { model: "gpt-5.6-sol", effort: "high" },
         current: { model: "gpt-5.6-luna", effort: "max" }
+      },
+      {
+        previous: { model: "gpt-5.6-luna", effort: "max" },
+        current: { model: "gpt-5.6-terra", effort: "high" }
+      }
+    ]
+  ],
+  [
+    "lazycodex-worker-high",
+    [
+      {
+        previous: { model: "gpt-5.6-sol", effort: "max" },
+        current: { model: "gpt-5.6-sol", effort: "medium" }
+      }
+    ]
+  ],
+  [
+    "lazycodex-code-reviewer",
+    [
+      {
+        previous: { model: "gpt-5.6-sol", effort: "xhigh" },
+        current: { model: "gpt-5.6-terra", effort: "medium" }
+      }
+    ]
+  ],
+  [
+    "lazycodex-clone-fidelity-reviewer",
+    [
+      {
+        previous: { model: "gpt-5.6-sol", effort: "xhigh" },
+        current: { model: "gpt-5.6-terra", effort: "high" }
       }
     ]
   ],
@@ -9432,6 +9472,10 @@ var MANAGED_REASONING_DEFAULT_UPGRADES = new Map([
       {
         previous: { model: "gpt-5.6-sol", effort: "xhigh" },
         current: { model: "gpt-5.6-sol", effort: "high" }
+      },
+      {
+        previous: { model: "gpt-5.6-sol", effort: "high" },
+        current: { model: "gpt-5.6-sol", effort: "low" }
       }
     ]
   ]

package/packages/omo-codex/scripts/install-marketplace-cache.test.mjs

@@ -94,7 +94,10 @@ test("#given local marketplace #when installing #then copies versioned plugins a
 		["npm", "run build", pluginRoot],
 	]);
 	assert.equal(commandLog[2][0], "npm");
-	assert.equal(commandLog[2][1], "ci --omit=dev");
+	// The @example/shared-lsp file: dep points outside the plugin, so the cache
+	// installer rewrites package.json and switches to `npm install` to avoid the
+	// npm ci lock-desync (lazycodex#137).
+	assert.equal(commandLog[2][1], "install --omit=dev --no-audit --no-fund");
 	assert.equal(commandLog[2][2].startsWith(join(codexHome, "plugins", "cache", "debug-marketplace", "alpha", ".tmp-1.2.3-")), true);
 
 	const config = await readFile(join(codexHome, "config.toml"), "utf8");

package/packages/shared-skills/skills/programming/scripts/typescript/check-no-excuse-rules.test.ts

@@ -0,0 +1,87 @@
+import { afterAll, beforeAll, describe, expect, test } from "bun:test"
+import { spawnSync } from "node:child_process"
+import { copyFileSync, mkdirSync, mkdtempSync, rmSync, symlinkSync, writeFileSync } from "node:fs"
+import { createRequire } from "node:module"
+import { tmpdir } from "node:os"
+import { dirname, join } from "node:path"
+
+// Regression for lazycodex#111: the script must resolve `typescript` from the
+// caller project (cwd), not from the script's own location, so it works when
+// executed from an installed `~/.codex/...` skill cache.
+
+const scriptSource = join(import.meta.dir, "check-no-excuse-rules.ts")
+const repoRequire = createRequire(import.meta.url)
+const typescriptPackageDir = dirname(repoRequire.resolve("typescript/package.json"))
+
+let tempRoot = ""
+let cachedScript = ""
+let callerDir = ""
+let callerWithoutTypescriptDir = ""
+
+function runNoExcuse(cwd: string, target: string) {
+	return spawnSync(process.execPath, ["--no-install", cachedScript, target], {
+		cwd,
+		encoding: "utf8",
+		timeout: 60_000,
+	})
+}
+
+describe("#given the no-excuse script is executed from an installed ~/.codex-style skill cache", () => {
+	beforeAll(() => {
+		// given a cache copy of the script outside any project, and two caller projects:
+		// one providing node_modules/typescript, one without typescript at all
+		tempRoot = mkdtempSync(join(tmpdir(), "no-excuse-cache-repro-"))
+		const cacheDir = join(tempRoot, ".codex", "skills", "programming", "scripts", "typescript")
+		mkdirSync(cacheDir, { recursive: true })
+		cachedScript = join(cacheDir, "check-no-excuse-rules.ts")
+		copyFileSync(scriptSource, cachedScript)
+
+		callerDir = join(tempRoot, "caller-project")
+		mkdirSync(join(callerDir, "node_modules"), { recursive: true })
+		symlinkSync(typescriptPackageDir, join(callerDir, "node_modules", "typescript"), "junction")
+		writeFileSync(join(callerDir, "clean.ts"), "export const answer: number = 42\n")
+		writeFileSync(join(callerDir, "violating.ts"), "const x = foo as any\nexport default x\n")
+
+		callerWithoutTypescriptDir = join(tempRoot, "caller-without-typescript")
+		mkdirSync(callerWithoutTypescriptDir, { recursive: true })
+		writeFileSync(join(callerWithoutTypescriptDir, "clean.ts"), "export const answer: number = 42\n")
+	})
+
+	afterAll(() => {
+		rmSync(tempRoot, { recursive: true, force: true })
+	})
+
+	// A generous timeout: the first run does a cold TypeScript program load in a
+	// spawned subprocess, which can exceed bun test's 5s default on a cold cache
+	// (matches the 60s spawnSync ceiling). This bounds the subprocess, it does not
+	// wait on wall-clock time as behavior.
+	test("#when the caller project provides typescript #then it resolves the caller's typescript and exits 0", () => {
+		// when no-excuse runs from the cache copy against the caller project
+		const result = runNoExcuse(callerDir, "clean.ts")
+
+		// then the caller's own typescript is used and the clean file passes
+		expect(result.error).toBeUndefined()
+		expect(result.status).toBe(0)
+		expect(result.stdout).toContain("No violations in 1 file(s).")
+	}, 60_000)
+
+	test("#when a checked file violates the rules #then violations are still reported with exit 1", () => {
+		// when no-excuse runs against a file containing `as any`
+		const result = runNoExcuse(callerDir, "violating.ts")
+
+		// then the existing CLI behavior is unchanged
+		expect(result.error).toBeUndefined()
+		expect(result.status).toBe(1)
+		expect(result.stderr).toContain("[no-any-assertion]")
+	}, 60_000)
+
+	test("#when the caller project genuinely lacks typescript #then it fails with a clear error and exit 2", () => {
+		// when no-excuse runs from a caller project with no local typescript
+		const result = runNoExcuse(callerWithoutTypescriptDir, "clean.ts")
+
+		// then it reports the resolution problem instead of crashing mid-analysis
+		expect(result.error).toBeUndefined()
+		expect(result.status).toBe(2)
+		expect(result.stderr).toContain('cannot resolve "typescript" from the caller project')
+	}, 60_000)
+})

package/packages/shared-skills/skills/programming/scripts/typescript/check-no-excuse-rules.ts

@@ -19,6 +19,10 @@
  * Usage:
  *   bun run scripts/check-no-excuse-rules.ts <file-or-dir>...
  *
+ * The `typescript` package is resolved from the caller project (process.cwd()),
+ * not from this script's location, so the script works when executed from an
+ * installed skill-cache path (e.g. ~/.codex/...) against a project checkout.
+ *
  * Exit codes:
  *   0 - no violations
  *   1 - violations found
@@ -26,9 +30,35 @@
  */
 
 import fs from "node:fs"
+import { createRequire } from "node:module"
 import path from "node:path"
 import process from "node:process"
-import ts from "typescript"
+import type * as tsTypes from "typescript"
+
+type TsModule = typeof import("typescript")
+
+function loadTypescriptFromCaller(): TsModule {
+  // A static `import ts from "typescript"` resolves from this script's location —
+  // an installed skill-cache path (e.g. ~/.codex/...) with no node_modules of its
+  // own — and fails even when the checked project has typescript. Resolve from the
+  // caller project (cwd) instead. When the caller has no local typescript, Bun
+  // falls back to a version-only stub from its global install cache instead of
+  // throwing, so the loaded module's API shape is verified as well.
+  const callerRequire = createRequire(path.join(process.cwd(), "no-excuse-anchor.cjs"))
+  try {
+    const loaded: Partial<TsModule> = callerRequire("typescript")
+    if (typeof loaded.createSourceFile === "function") return loaded as TsModule
+  } catch { // no-excuse-ok: catch
+    // fall through to the clear error below
+  }
+  console.error(
+    `error: cannot resolve "typescript" from the caller project (${process.cwd()}). ` +
+      "Install it in the project being checked (e.g. `bun add -d typescript`) and re-run.",
+  )
+  process.exit(2)
+}
+
+const ts: TsModule = loadTypescriptFromCaller()
 
 type RuleId =
   | "no-any-assertion"
@@ -95,7 +125,7 @@ function discoverFiles(inputs: string[]): string[] {
   return files
 }
 
-function getLineText(sourceFile: ts.SourceFile, line: number): string {
+function getLineText(sourceFile: tsTypes.SourceFile, line: number): string {
   const lineStarts = sourceFile.getLineStarts()
   const start = lineStarts[line]
   const end = line + 1 < lineStarts.length ? lineStarts[line + 1] : sourceFile.getEnd()
@@ -107,17 +137,17 @@ function analyzeFile(filePath: string): Violation[] {
   const sourceFile = ts.createSourceFile(filePath, source, ts.ScriptTarget.Latest, true)
   const violations: Violation[] = []
 
-  function pos(node: ts.Node): { line: number; column: number } {
+  function pos(node: tsTypes.Node): { line: number; column: number } {
     const { line, character } = sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile))
     return { line: line + 1, column: character + 1 }
   }
 
-  function lineHasOptOut(node: ts.Node): boolean {
+  function lineHasOptOut(node: tsTypes.Node): boolean {
     const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile))
     return OPT_OUT_RE.test(getLineText(sourceFile, line))
   }
 
-  function visit(node: ts.Node): void {
+  function visit(node: tsTypes.Node): void {
     // ── as any / as unknown ──
     if (ts.isAsExpression(node)) {
       const typeText = node.type.getText(sourceFile)

package/packages/shared-skills/skills/ulw-plan/SKILL.md

@@ -13,11 +13,30 @@ You are **Prometheus**, a planning consultant. You turn a vague or large request
 
 Outcome-first: explore a lot, ask few sharp questions - or none, when the intent is fuzzy (see routing) - and stop the moment the plan is done.
 
+## MANDATORY OPENING ANNOUNCEMENT
+
+The FIRST user-visible line of the turn that activates this skill MUST be exactly:
+
+`ULW-PLAN MODE ENABLED!`
+
+If another active mode mandates its own first line (ultrawork does), print that line first and this marker on the next line - both contracts stay satisfied.
+
+Directly under the marker, before any exploration, state the working contract once, in your own words, carrying ALL of these commitments:
+
+1. **Persona + no-implementation pledge** - from now on you work as Prometheus, a planning consultant, and you will never start implementation - no product-code edits, no implementer subagents - until the user explicitly says okay; even then, approval authorizes writing the plan only, and execution starts in a separate worker session (e.g. `$start-work`).
+2. **Workflow preview** - the order of what happens next: parallel read-only exploration (plus outside research when the repo cannot answer) until the open unknowns are resolved; the intent verdict from INTENT ROUTING, announced; questions to the user ONLY when a genuine owner-decision survives exploration - or when exploration and research both come back empty on a fork the plan cannot proceed without; then the approval brief, and the plan is written only after the explicit okay.
+
+Example opening (adapt the wording, keep every commitment):
+
+> ULW-PLAN MODE ENABLED!
+> From now on I am working as Prometheus, a planning consultant. I will not start any implementation until you explicitly say okay - and approval authorizes writing the plan only; execution starts separately (e.g. `$start-work`).
+> Next, in order: (1) parallel read-only exploration and research, (2) intent verdict announced (CLEAR or UNCLEAR, plus whether high-accuracy review is required), (3) questions only for the forks exploration cannot settle - or where research finds nothing on a blocking decision, (4) approval brief, then (5) the plan is written after your okay.
+
 ## INTENT ROUTING - pick ONE intent reference
 
 **Review modifiers are a gate trigger, not a style cue.** If the user says "high accuracy", "ultra high accuracy", "고정밀", "deep review", or equivalent - in ANY turn, even appended to a follow-up question and even after the plan already exists - set `review_required: true` in the draft: the dual high-accuracy review (native `momus` + the independent Oracle review) is now REQUIRED before handoff, and if the plan already exists you run it this same turn. Answering the current question more carefully does NOT satisfy it. This does NOT choose CLEAR/UNCLEAR and does NOT suppress interview.
 
-After grounding, make ONE judgment, record `intent: clear|unclear` plus `review_required`, **ANNOUNCE both to the user in one line**, then load ONE intent reference (you ALSO read `references/full-workflow.md` for the shared mechanics - see below). The test keys on whether the desired **OUTCOME** is clear, NOT on request length. The announcement is the user's first signal of whether they will be interviewed and whether high-accuracy review is already requested - never skip it.
+After grounding, make ONE judgment, record `intent: clear|unclear` plus `review_required`, **ANNOUNCE both to the user in one line**, then load ONE intent reference (you ALSO read `references/full-workflow.md` for the shared mechanics - see below). The test keys on whether the desired **OUTCOME** is clear, NOT on request length. This verdict line and the opening announcement above are the two mandatory user-visible signals of a planning session - it tells the user whether they will be interviewed and whether high-accuracy review is already requested; never skip either.
 
 > "Intent: **CLEAR**, review required - you specified the endpoint and asked for high accuracy. I will ask only the genuine forks, then run the high-accuracy review after approval."
 > "Intent: **UNCLEAR**, review required - 'make auth better' is open-ended and you asked for high accuracy. I will choose best-practice defaults, then run the high-accuracy review automatically."