oh-my-opencode 4.14.0 → 4.14.1

package/packages/omo-codex/plugin/components/rules/src/sparkshell-awareness.ts

@@ -1,106 +0,0 @@
-import { existsSync } from "node:fs";
-import { join } from "node:path";
-
-type RuntimeEnv = Readonly<Record<string, string | undefined>>;
-
-interface OmoResolutionDeps {
-	readonly fileExists?: (path: string) => boolean;
-	readonly platform?: NodeJS.Platform;
-}
-
-const SPARKSHELL_AWARENESS_MARKER = "## Sparkshell Runtime";
-
-export const SPARKSHELL_AWARENESS_DEDUP_KEY = "__omo_sparkshell_awareness__";
-
-export function isCodexAppServerActive(env: RuntimeEnv = process.env): boolean {
-	const originator = env["CODEX_INTERNAL_ORIGINATOR_OVERRIDE"]?.toLowerCase() ?? "";
-	const bundleIdentifier = env["__CFBundleIdentifier"]?.toLowerCase() ?? "";
-	const shellActive = isTruthy(env["CODEX_SHELL"]);
-
-	return (
-		shellActive &&
-		(originator.includes("codex desktop") ||
-			originator.includes("codex app") ||
-			bundleIdentifier === "com.openai.codex")
-	);
-}
-
-function isSparkShellAppServerConfigured(env: RuntimeEnv = process.env): boolean {
-	const codexSocketPath = env["CODEX_APP_SERVER_SOCKET"]?.trim() ?? "";
-	const omoSocketPath = env["OMO_SPARKSHELL_APP_SERVER_SOCKET"]?.trim() ?? "";
-	return codexSocketPath.length > 0 || omoSocketPath.length > 0;
-}
-
-export function resolveOmoInvocation(env: RuntimeEnv = process.env, deps: OmoResolutionDeps = {}): string | null {
-	const fileExists = deps.fileExists ?? existsSync;
-	const platform = deps.platform ?? process.platform;
-	const binNames = platform === "win32" ? ["omo.cmd", "omo.exe", "omo"] : ["omo"];
-	const pathDelimiter = platform === "win32" ? ";" : ":";
-	const pathEntries = (env["PATH"] ?? "").split(pathDelimiter).filter((entry) => entry.trim().length > 0);
-	for (const pathEntry of pathEntries) {
-		for (const binName of binNames) {
-			if (fileExists(join(pathEntry, binName))) return "omo";
-		}
-	}
-	for (const candidateDir of omoCandidateBinDirs(env)) {
-		for (const binName of binNames) {
-			const candidate = join(candidateDir, binName);
-			if (fileExists(candidate)) return candidate;
-		}
-	}
-	return null;
-}
-
-function omoCandidateBinDirs(env: RuntimeEnv): readonly string[] {
-	const dirs: string[] = [];
-	const localBinDir = env["CODEX_LOCAL_BIN_DIR"]?.trim() ?? "";
-	if (localBinDir.length > 0) dirs.push(localBinDir);
-	const home = env["HOME"]?.trim() || env["USERPROFILE"]?.trim() || "";
-	const codexHome = env["CODEX_HOME"]?.trim() || (home.length > 0 ? join(home, ".codex") : "");
-	if (codexHome.length > 0) dirs.push(join(codexHome, "bin"));
-	if (home.length > 0) dirs.push(join(home, ".local", "bin"));
-	return dirs;
-}
-
-export function getSparkShellRuntimeAwareness(env: RuntimeEnv = process.env, deps: OmoResolutionDeps = {}): string {
-	const override = env["OMO_SPARKSHELL_AWARENESS"] ?? env["LAZYCODEX_SPARKSHELL_AWARENESS"];
-	if (isFalsy(override)) {
-		return "";
-	}
-	if (!isTruthy(override) && !isCodexAppServerActive(env) && !isSparkShellAppServerConfigured(env)) {
-		return "";
-	}
-
-	const resolved = resolveOmoInvocation(env, deps);
-	const invocation = resolved ?? (isTruthy(override) ? "omo" : null);
-	if (invocation === null) {
-		return "";
-	}
-	const command = /\s/.test(invocation) ? `"${invocation}"` : invocation;
-
-	return [
-		SPARKSHELL_AWARENESS_MARKER,
-		"",
-		`- Use \`${command} sparkshell <command> [args...]\` first for repo inspection, CLI smoke tests, git/history checks, and bounded command output. Pass ordinary commands as executable and arguments in separate argv tokens, for example \`${command} sparkshell rg --files\`; not \`${command} sparkshell 'rg --files'\`, because the quoted string is treated as one executable name. Raw \`rg\`/\`grep\`/\`cat\`/\`git\` are fallbacks when Sparkshell is unavailable or too narrow for the task.`,
-		`- Use \`${command} sparkshell --shell '<command>'\` only for shell syntax such as metacharacters, pipelines, redirects, command substitution, or variable expansion.`,
-		`- Use \`${command} sparkshell --tmux-pane <pane-id> --tail-lines 400\` only to inspect an existing pane, never to launch ordinary commands. Tail lines must stay between 100 and 1000.`,
-		"- When no native sidecar or appserver is available, Sparkshell silently falls back to raw command execution. `OMO_SPARKSHELL_BIN` selects a native sidecar path.",
-		"- When `CODEX_THREAD_ID` identifies a Codex session, Sparkshell feeds recent session context (first/latest user request + last 5 conversation messages) into oversized-output condensation for relevance ranking, but never appends that context to command output. `OMO_SPARKSHELL_SESSION_CONTEXT=0` disables the lookup.",
-		`- Route potentially huge output (full log files, big diffs, \`cat\`/\`grep\` over large artifacts) through \`${command} sparkshell\` instead of reading it raw: oversized output is condensed to a budget while preserving error signatures, repeated patterns, session-goal-relevant lines, and head/tail. Tune with \`--budget <chars>\`; disable with \`OMO_SPARKSHELL_CONDENSE=0\`.`,
-		"- Oversized output is first summarized by the spark model (`codex exec`, default `gpt-5.3-codex-spark`) fed with the shell output plus session context: the summary keeps selected output as-is (no masking) and ends with a `[sparkshell caption]` line describing what ran, what the full output contained, and which lines were omitted. `OMO_SPARKSHELL_SPARK=0` skips the model and uses deterministic condensation directly.",
-	].join("\n");
-}
-
-function isTruthy(value: string | undefined): boolean {
-	if (value === undefined) {
-		return false;
-	}
-	return ["1", "true", "yes", "on"].includes(value.trim().toLowerCase());
-}
-
-function isFalsy(value: string | undefined): boolean {
-	if (value === undefined) {
-		return false;
-	}
-	return ["0", "false", "no", "off"].includes(value.trim().toLowerCase());
-}

package/packages/omo-codex/plugin/components/rules/test/sparkshell-awareness.test.ts

@@ -1,355 +0,0 @@
-// allow: SIZE_OK - rules sparkshell-awareness coverage validates one injected guidance contract; this release adds narrow prompt cases and future growth should split by guidance surface.
-
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { afterAll, describe, expect, it } from "vitest";
-
-import { runSessionStartHook, runUserPromptSubmitHook } from "../src/codex-hook.js";
-import { formatAdditionalContextOutput } from "../src/hook-output.js";
-
-type HookOutput = {
-	readonly hookSpecificOutput?: {
-		readonly additionalContext?: string;
-	};
-};
-
-function parseAdditionalContext(output: string): string {
-	expect(output.trim().length).toBeGreaterThan(0);
-	const parsed = parseHookOutput(JSON.parse(output));
-	return parsed.hookSpecificOutput?.additionalContext ?? "";
-}
-
-function normalizeGuidance(value: string): string {
-	return value.toLowerCase().replace(/\s+/g, " ").trim();
-}
-
-function expectSparkshellFirstContract(value: string): void {
-	const guidance = normalizeGuidance(value);
-
-	expect(value).toContain("`omo sparkshell <command> [args...]`");
-	expect(guidance).toMatch(/`omo sparkshell <command> \[args\.\.\.\]`[^.]*\bfirst\b/);
-	expect(guidance).toMatch(/\brepo inspection\b/);
-	expect(guidance).toMatch(/\bcli smoke tests\b/);
-	expect(guidance).toMatch(/\bgit\/history checks\b/);
-	expect(guidance).toMatch(/\bbounded command output\b/);
-	expect(guidance).toMatch(/\braw\b[^.]*`rg`\/`grep`\/`cat`\/`git`[^.]*\bfallbacks?\b/);
-	expect(guidance).toMatch(/\bsparkshell is unavailable\b/);
-	expect(guidance).toMatch(/\btoo narrow\b/);
-	expect(value).toContain("`omo sparkshell rg --files`");
-	expect(guidance).toMatch(/\bseparate argv tokens\b/);
-	expect(value).toContain("not `omo sparkshell 'rg --files'`");
-	expect(guidance).toMatch(/\bone executable name\b/);
-	expect(guidance).toMatch(/`omo sparkshell --shell '<command>'`[^.]*\bmetacharacters\b[^.]*\bpipelines\b/);
-	expect(guidance).toMatch(
-		/`omo sparkshell --tmux-pane <pane-id> --tail-lines 400`[^.]*\bonly\b[^.]*\binspect\b[^.]*\bexisting pane\b/,
-	);
-	expect(guidance).toMatch(
-		/`omo sparkshell --tmux-pane <pane-id> --tail-lines 400`[^.]*\bnever\b[^.]*\blaunch ordinary commands\b/,
-	);
-	expect(guidance).not.toMatch(/\bprefer\b[^.]*\bbefore raw shell commands\b/);
-}
-
-function parseHookOutput(value: unknown): HookOutput {
-	if (typeof value !== "object" || value === null) {
-		return {};
-	}
-	const record = value;
-	if (!("hookSpecificOutput" in record)) {
-		return {};
-	}
-	const hookSpecificOutput = record.hookSpecificOutput;
-	if (typeof hookSpecificOutput !== "object" || hookSpecificOutput === null) {
-		return {};
-	}
-	if (!("additionalContext" in hookSpecificOutput)) {
-		return { hookSpecificOutput: {} };
-	}
-	const additionalContext = hookSpecificOutput.additionalContext;
-	if (typeof additionalContext !== "string") {
-		return { hookSpecificOutput: {} };
-	}
-	return {
-		hookSpecificOutput: {
-			additionalContext,
-		},
-	};
-}
-
-const fixtureRoot = mkdtempSync(join(tmpdir(), "codex-sparkshell-omo-bin-"));
-const omoOnPathDir = join(fixtureRoot, "path-bin");
-const emptyHomeDir = join(fixtureRoot, "empty-home");
-const localBinHomeDir = join(fixtureRoot, "local-bin-home");
-mkdirSync(omoOnPathDir, { recursive: true });
-mkdirSync(emptyHomeDir, { recursive: true });
-mkdirSync(join(localBinHomeDir, ".local", "bin"), { recursive: true });
-writeFileSync(join(omoOnPathDir, "omo"), "#!/bin/sh\n");
-writeFileSync(join(localBinHomeDir, ".local", "bin", "omo"), "#!/bin/sh\n");
-
-describe("Codex Sparkshell awareness", () => {
-	afterAll(() => {
-		rmSync(fixtureRoot, { recursive: true, force: true });
-	});
-
-	it("#given active Codex app server env with omo on PATH #when SessionStart runs #then emits Sparkshell guidance", async () => {
-		// given
-		const env = {
-			CODEX_INTERNAL_ORIGINATOR_OVERRIDE: "Codex Desktop",
-			CODEX_SHELL: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-			PATH: omoOnPathDir,
-			HOME: emptyHomeDir,
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-active",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		const context = parseAdditionalContext(output);
-		expectSparkshellFirstContract(context);
-		expect(context).toContain("OMO_SPARKSHELL_SESSION_CONTEXT");
-		expect(context).toContain("OMO_SPARKSHELL_CONDENSE");
-		expect(context).toContain("OMO_SPARKSHELL_SPARK");
-		expect(context).toContain("[sparkshell caption]");
-		expect(context).toContain("never appends that context to command output");
-		expect(context).toContain("what the full output contained");
-		expect(context).not.toContain("[REDACTED]");
-		expect(context).not.toContain("appends recent session context");
-	});
-
-	it("#given inactive env #when SessionStart runs #then emits no Sparkshell guidance", async () => {
-		// given
-		const env = {
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-inactive",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		expect(output).toBe("");
-	});
-
-	it("#given Codex CLI appserver socket env #when SessionStart runs #then emits Sparkshell guidance", async () => {
-		// given
-		const env = {
-			OMO_SPARKSHELL_APP_SERVER_SOCKET: "/tmp/app-server-control.sock",
-			CODEX_THREAD_ID: "thread-sparkshell-cli",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-			PATH: omoOnPathDir,
-			HOME: emptyHomeDir,
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-cli-wrapper",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		expect(parseAdditionalContext(output)).toContain("omo sparkshell <command>");
-	});
-
-	it("#given active Codex app env without a resolvable omo command #when SessionStart runs #then emits no Sparkshell guidance", async () => {
-		// given
-		const env = {
-			CODEX_INTERNAL_ORIGINATOR_OVERRIDE: "Codex Desktop",
-			CODEX_SHELL: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-			PATH: join(fixtureRoot, "missing-path-entry"),
-			HOME: emptyHomeDir,
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-unresolvable",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		expect(output).toBe("");
-	});
-
-	it("#given omo only under HOME/.local/bin #when SessionStart runs #then emits guidance with the absolute omo path", async () => {
-		// given
-		const env = {
-			CODEX_INTERNAL_ORIGINATOR_OVERRIDE: "Codex Desktop",
-			CODEX_SHELL: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-			PATH: join(fixtureRoot, "missing-path-entry"),
-			HOME: localBinHomeDir,
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-local-bin",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		const context = parseAdditionalContext(output);
-		expect(context).toContain(`${join(localBinHomeDir, ".local", "bin", "omo")} sparkshell <command>`);
-		expect(context).not.toContain("`omo sparkshell <command>`");
-	});
-
-	it("#given explicit force-on env #when SessionStart runs #then emits Sparkshell guidance", async () => {
-		// given
-		const env = {
-			OMO_SPARKSHELL_AWARENESS: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-force-on",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		expect(parseAdditionalContext(output)).toContain("omo sparkshell <command>");
-	});
-
-	it("#given explicit force-off env with active Codex app context #when SessionStart runs #then emits no Sparkshell guidance", async () => {
-		// given
-		const env = {
-			OMO_SPARKSHELL_AWARENESS: "0",
-			CODEX_INTERNAL_ORIGINATOR_OVERRIDE: "Codex Desktop",
-			CODEX_SHELL: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-		};
-
-		// when
-		const output = await runSessionStartHook(
-			{
-				session_id: "session-sparkshell-force-off",
-				transcript_path: null,
-				cwd: process.cwd(),
-				hook_event_name: "SessionStart",
-				model: "gpt-5.5",
-				permission_mode: "default",
-				source: "startup",
-			},
-			{ env },
-		);
-
-		// then
-		expect(output).toBe("");
-	});
-
-	it("#given Sparkshell awareness already emitted for a session #when UserPromptSubmit runs #then emits no duplicate guidance", async () => {
-		// given
-		const pluginDataRoot = mkdtempSync(join(tmpdir(), "codex-sparkshell-awareness-"));
-		const env = {
-			CODEX_INTERNAL_ORIGINATOR_OVERRIDE: "Codex Desktop",
-			CODEX_SHELL: "1",
-			CODEX_RULES_ENABLED_SOURCES: ".omo/rules",
-			PATH: omoOnPathDir,
-			HOME: emptyHomeDir,
-		};
-		try {
-			const firstOutput = await runSessionStartHook(
-				{
-					session_id: "session-sparkshell-dedupe",
-					transcript_path: null,
-					cwd: process.cwd(),
-					hook_event_name: "SessionStart",
-					model: "gpt-5.5",
-					permission_mode: "default",
-					source: "startup",
-				},
-				{ env, pluginDataRoot },
-			);
-			expect(parseAdditionalContext(firstOutput)).toContain("omo sparkshell <command>");
-
-			// when
-			const secondOutput = await runUserPromptSubmitHook(
-				{
-					session_id: "session-sparkshell-dedupe",
-					turn_id: "turn-1",
-					transcript_path: null,
-					cwd: process.cwd(),
-					hook_event_name: "UserPromptSubmit",
-					model: "gpt-5.5",
-					permission_mode: "default",
-					prompt: "continue",
-				},
-				{ env, pluginDataRoot },
-			);
-
-			// then
-			expect(secondOutput).toBe("");
-		} finally {
-			rmSync(pluginDataRoot, { recursive: true, force: true });
-		}
-	});
-
-	it("#given explicit force-on env #when hook output is formatted #then awareness remains valid hook JSON", () => {
-		// given
-		const context = [
-			"## Sparkshell Runtime",
-			"",
-			"- Prefer `omo sparkshell <command>` for shell-native inspection.",
-		].join("\n");
-
-		// when
-		const output = formatAdditionalContextOutput("SessionStart", context);
-
-		// then
-		expect(parseAdditionalContext(output)).toContain("## Sparkshell Runtime");
-	});
-});