oh-my-opencode 4.13.0 → 4.14.0

package/packages/omo-codex/scripts/install-config.test.mjs

@@ -1,3 +1,5 @@
+// allow: SIZE_OK - Node installer config tests mirror the source installer matrix with one filesystem fixture; this release adds config cases and future edits should split by installer concern.
+
 import assert from "node:assert/strict";
 import { lstat, mkdtemp, readFile, symlink, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
@@ -6,7 +8,7 @@ import test from "node:test";
 
 import { updateCodexConfig } from "./install-dist/install-local.mjs";
 
-test("#given empty Codex config #when script installer updates config #then enables MultiAgentV2 with ten thousand session threads", async () => {
+test("#given empty Codex config #when script installer updates config #then sets subagent thread limits without forcing MultiAgentV2", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-"));
 	const configPath = join(root, "config.toml");
@@ -22,9 +24,70 @@ test("#given empty Codex config #when script installer updates config #then enab
 
 	// then
 	const config = await readFile(configPath, "utf8");
+	assert.doesNotMatch(config, /^\s*multi_agent_mode\s*=/m);
+	assert.match(config, /\[agents\]/);
+	assert.match(config, /max_threads = 1000/);
 	assert.match(config, /\[features\.multi_agent_v2\]/);
-	assert.match(config, /enabled = true/);
-	assert.match(config, /max_concurrent_threads_per_session = 10000/);
+const v2Section = multiAgentV2Section(config);
+	assert.doesNotMatch(v2Section, /^enabled\s*=/m);
+	assert.match(v2Section, /max_concurrent_threads_per_session = 1000/);
+});
+
+test("#given queue multi-agent mode #when script installer updates config #then removes unsupported root key", async () => {
+	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-mode-"));
+	const configPath = join(root, "config.toml");
+	await writeFile(
+		configPath,
+		[
+			'multi_agent_mode = "queue"',
+			"",
+			"[features]",
+			"multi_agent = true",
+			"",
+		].join("\n"),
+	);
+
+	await updateCodexConfig({
+		configPath,
+		repoRoot: "/repo/packages/omo-codex",
+		marketplaceName: "debug",
+		marketplaceSource: { sourceType: "local", source: "/repo/packages/omo-codex" },
+		pluginNames: ["omo"],
+	});
+
+	const config = await readFile(configPath, "utf8");
+	assert.doesNotMatch(config, /^\s*multi_agent_mode\s*=/m);
+	assert.doesNotMatch(config, /multi_agent_mode = "queue"/);
+});
+
+test("#given indented steering mode and inline-comment features table #when script installer updates config #then removes root key and keeps one features table", async () => {
+	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-toml-root-regression-"));
+	const configPath = join(root, "config.toml");
+	await writeFile(
+		configPath,
+		[
+			'  multi_agent_mode = "steering"',
+			"",
+			"[features] # keep comment",
+			"plugins = false",
+			"",
+		].join("\n"),
+	);
+
+	await updateCodexConfig({
+		configPath,
+		repoRoot: "/repo/packages/omo-codex",
+		marketplaceName: "debug",
+		marketplaceSource: { sourceType: "local", source: "/repo/packages/omo-codex" },
+		pluginNames: ["omo"],
+	});
+
+	const config = await readFile(configPath, "utf8");
+	assert.equal(config.match(/^\s*multi_agent_mode\s*=/gm)?.length ?? 0, 0);
+	assert.equal(config.match(/^\s*\[features\](?:\s*#.*)?$/gm)?.length, 1);
+	assert.match(config, /^\[features\] # keep comment$/m);
+	assert.doesNotMatch(config, /multi_agent_mode = "queue"/);
+	assert.doesNotMatch(config, /multi_agent_mode = "steering"/);
 });
 
 test("#given empty Codex config #when script installer updates config #then leaves Context7 to the plugin MCP manifest", async () => {
@@ -78,7 +141,7 @@ test("#given existing Context7 MCP config #when script installer updates config
 	await writeFile(
 		configPath,
 		[
-			"[mcp_servers.context7]",
+			"[mcp_servers.context7] # stale npx package from old docs",
 			'command = "node"',
 			'args = ["/opt/context7/server.js"]',
 			'startup_timeout_sec = 40',
@@ -104,6 +167,70 @@ test("#given existing Context7 MCP config #when script installer updates config
 	assert.doesNotMatch(config, /YOUR_API_KEY/);
 });
 
+test("#given real Context7 API key and placeholder comment #when script installer updates config #then preserves user setup", async () => {
+	// given
+	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-context7-real-key-"));
+	const configPath = join(root, "config.toml");
+	await writeFile(
+		configPath,
+		[
+			"[mcp_servers.context7]",
+			'command = "npx"',
+			'args = ["-y", "@upstash/context7-mcp", "--api-key", "ctx7sk_live_example"] # replace YOUR_API_KEY in docs only',
+			"startup_timeout_sec = 20",
+			"",
+		].join("\n"),
+	);
+
+	// when
+	await updateCodexConfig({
+		configPath,
+		repoRoot: "/repo/packages/omo-codex",
+		marketplaceName: "sisyphuslabs",
+		marketplaceSource: { sourceType: "local", source: "/repo/packages/omo-codex/cache/sisyphuslabs" },
+		pluginNames: ["omo"],
+	});
+
+	// then
+	const config = await readFile(configPath, "utf8");
+	assert.match(config, /\[mcp_servers\.context7\]/);
+	assert.match(config, /ctx7sk_live_example/);
+	assert.match(config, /replace YOUR_API_KEY in docs only/);
+	assert.match(config, /\[plugins\."omo@sisyphuslabs"\.mcp_servers\.context7\]/);
+});
+
+test("#given stale Context7 placeholder MCP config #when script installer updates config #then removes it for plugin MCP", async () => {
+	// given
+	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-context7-placeholder-"));
+	const configPath = join(root, "config.toml");
+	await writeFile(
+		configPath,
+		[
+			"[mcp_servers.context7]",
+			'command = "npx"',
+			'args = ["-y", "@upstash/context7-mcp", "--api-key", "YOUR_API_KEY"]',
+			"startup_timeout_sec = 20",
+			"",
+		].join("\n"),
+	);
+
+	// when
+	await updateCodexConfig({
+		configPath,
+		repoRoot: "/repo/packages/omo-codex",
+		marketplaceName: "sisyphuslabs",
+		marketplaceSource: { sourceType: "local", source: "/repo/packages/omo-codex/cache/sisyphuslabs" },
+		pluginNames: ["omo"],
+	});
+
+	// then
+	const config = await readFile(configPath, "utf8");
+	assert.match(config, /\[plugins\."omo@sisyphuslabs"\.mcp_servers\.context7\]/);
+	assert.doesNotMatch(config, /\[mcp_servers\.context7\]/);
+	assert.doesNotMatch(config, /@upstash\/context7-mcp/);
+	assert.doesNotMatch(config, /YOUR_API_KEY/);
+});
+
 test("#given Codex config is a symlink #when script installer updates config #then writes through the target", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-symlink-"));
@@ -152,7 +279,7 @@ test("#given sisyphuslabs config without explicit source #when script installer
 	assert.doesNotMatch(config, /ref = "main"/);
 });
 
-test("#given existing MultiAgentV2 table #when script installer updates config #then preserves unrelated tuning while setting ten thousand session threads", async () => {
+test("#given existing MultiAgentV2 table #when script installer updates config #then preserves unrelated tuning while setting subagent thread limits", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-existing-"));
 	const configPath = join(root, "config.toml");
@@ -179,9 +306,9 @@ test("#given existing MultiAgentV2 table #when script installer updates config #
 	// then
 	const config = await readFile(configPath, "utf8");
 	assert.match(config, /\[features\.multi_agent_v2\]/);
-	assert.match(config, /enabled = true/);
+	assert.doesNotMatch(sectionText(config, "[features.multi_agent_v2]"), /enabled = true/);
 	assert.match(config, /usage_hint_enabled = false/);
-	assert.match(config, /max_concurrent_threads_per_session = 10000/);
+	assert.match(config, /max_concurrent_threads_per_session = 1000/);
 	assert.doesNotMatch(config, /max_concurrent_threads_per_session = 4/);
 });
 
@@ -202,7 +329,8 @@ test("#given empty Codex config #when script installer updates config #then sets
 	// then
 	const config = await readFile(configPath, "utf8");
 	const v2Section = config.slice(config.indexOf("[features.multi_agent_v2]"));
-	assert.match(v2Section, /max_concurrent_threads_per_session = 10000/);
+	assert.match(config, /\[agents\][\s\S]*?max_threads = 1000/);
+	assert.match(v2Section, /max_concurrent_threads_per_session = 1000/);
 	assert.doesNotMatch(v2Section, /hide_spawn_agent_metadata/);
 });
 
@@ -266,12 +394,45 @@ test("#given legacy boolean MultiAgentV2 flag and table #when script installer u
 	const config = await readFile(configPath, "utf8");
 	assert.doesNotMatch(config, /^multi_agent_v2\s*=/m);
 	assert.match(config, /\[features\.multi_agent_v2\]/);
-	assert.match(config, /enabled = true/);
-	assert.match(config, /usage_hint_enabled = false/);
-	assert.match(config, /max_concurrent_threads_per_session = 10000/);
+const v2Section = multiAgentV2Section(config);
+	assert.doesNotMatch(v2Section, /^enabled\s*=/m);
+	assert.match(v2Section, /usage_hint_enabled = false/);
+	assert.match(v2Section, /max_concurrent_threads_per_session = 1000/);
 });
 
-test("#given legacy agents max_threads #when script installer updates config #then removes the conflicting legacy thread cap", async () => {
+test("#given legacy boolean MultiAgentV2 flag false #when script installer updates config #then normalizes to a disabled table config", async () => {
+	// given
+	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-legacy-false-"));
+	const configPath = join(root, "config.toml");
+	await writeFile(
+		configPath,
+		[
+			"[features]",
+			"multi_agent_v2 = false",
+			"plugins = false",
+			"",
+		].join("\n"),
+	);
+
+	// when
+	await updateCodexConfig({
+		configPath,
+		repoRoot: "/repo/packages/omo-codex",
+		marketplaceName: "debug",
+		marketplaceSource: { sourceType: "local", source: "/repo/packages/omo-codex" },
+		pluginNames: ["omo"],
+	});
+
+	// then
+	const config = await readFile(configPath, "utf8");
+	assert.doesNotMatch(config, /^multi_agent_v2\s*=/m);
+	assert.match(config, /\[features\.multi_agent_v2\]/);
+	const disabledV2Section = multiAgentV2Section(config);
+	assert.match(disabledV2Section, /^enabled = false$/m);
+	assert.match(disabledV2Section, /^max_concurrent_threads_per_session = 1000$/m);
+});
+
+test("#given legacy agents max_threads #when script installer updates config #then raises the root subagent thread cap", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-legacy-threads-"));
 	const configPath = join(root, "config.toml");
@@ -298,15 +459,17 @@ test("#given legacy agents max_threads #when script installer updates config #th
 	// then
 	const config = await readFile(configPath, "utf8");
 	assert.match(config, /\[features\.multi_agent_v2\]/);
-	assert.match(config, /enabled = true/);
-	assert.match(config, /max_concurrent_threads_per_session = 10000/);
+const v2Section = multiAgentV2Section(config);
+	assert.doesNotMatch(v2Section, /^enabled\s*=/m);
+	assert.match(v2Section, /max_concurrent_threads_per_session = 1000/);
 	assert.match(config, /\[agents\]/);
-	assert.doesNotMatch(config, /^max_threads\s*=/m);
+	assert.match(config, /max_threads = 1000/);
+	assert.doesNotMatch(config, /max_threads = 16/);
 	assert.match(config, /max_depth = 4/);
 	assert.match(config, /job_max_runtime_seconds = 3600/);
 });
 
-test("#given managed agent role sections #when script installer updates config #then preserves role config while removing only root agents max_threads", async () => {
+test("#given managed agent role sections #when script installer updates config #then preserves role config while raising only root agents max_threads", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-multi-agent-role-section-"));
 	const configPath = join(root, "config.toml");
@@ -335,12 +498,21 @@ test("#given managed agent role sections #when script installer updates config #
 
 	// then
 	const config = await readFile(configPath, "utf8");
-	assert.doesNotMatch(config, /^max_threads\s*=/m);
+	assert.match(config, /max_threads = 1000/);
+	assert.doesNotMatch(config, /max_threads = 16/);
 	assert.match(config, /\[agents\.explorer\]/);
 	assert.match(config, /description = "read-only explorer"/);
 	assert.match(config, /config_file = "\.\/agents\/explorer\.toml"/);
 });
 
+function sectionText(config, header) {
+	const start = config.indexOf(header);
+	if (start === -1) return "";
+	const afterStart = config.slice(start + header.length);
+	const nextSectionOffset = afterStart.search(/\n\[/);
+	return nextSectionOffset === -1 ? config.slice(start) : config.slice(start, start + header.length + nextSectionOffset);
+}
+
 test("#given existing trust and lsp blocks #when updating config #then existing blocks are preserved", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-config-baseline-"));
@@ -377,3 +549,12 @@ test("#given existing trust and lsp blocks #when updating config #then existing
 	assert.match(content, /\[hooks\.state\."omo@sisyphuslabs:hooks\/hooks\.json:post_tool_use:0:0"\]/);
 	assert.match(content, /trusted_hash = "sha256:keep"/);
 });
+
+function multiAgentV2Section(config) {
+	const header = "[features.multi_agent_v2]";
+	const start = config.indexOf(header);
+	assert.notEqual(start, -1);
+	const rest = config.slice(start);
+	const nextHeader = rest.slice(1).search(/^\[/m);
+	return nextHeader === -1 ? rest : rest.slice(0, nextHeader + 1);
+}