oh-my-opencode 4.11.1 → 4.12.1

package/packages/omo-codex/plugin/components/comment-checker/test/package-smoke.test.ts

@@ -1,44 +1,12 @@
-import { readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
-
-type PackageJson = {
-	readonly type: string;
-	readonly packageManager: string;
-	readonly bin: Record<string, string>;
-	readonly dependencies?: Record<string, unknown>;
-	readonly optionalDependencies: Record<string, string>;
-};
-
-type HookCommand = {
-	readonly command: string;
-};
-
-type HookEntry = {
-	readonly hooks: readonly HookCommand[];
-};
-
-type HooksJson = {
-	readonly hooks: Record<string, readonly HookEntry[]>;
-};
-
-function readPackageJson(path: string): PackageJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isPackageJson(parsed)) throw new TypeError(`Invalid package metadata: ${path}`);
-	return parsed;
-}
-
-function readHooksJson(path: string): HooksJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isHooksJson(parsed)) throw new TypeError(`Invalid hooks metadata: ${path}`);
-	return parsed;
-}
+import { readHooksJson, readPackageJson, readTextFile } from "../../test-support/package-smoke-fixture.js";
 
 describe("plugin package metadata", () => {
 	it("#given packaged plugin files #when validating entrypoints #then hook command uses portable plugin root interpolation", () => {
 		// given
 		const packageJson = readPackageJson("package.json");
 		const hooksJson = readHooksJson("hooks/hooks.json");
-		const cliSource = readFileSync("src/cli.ts", "utf8");
+		const cliSource = readTextFile("src/cli.ts");
 
 		// when
 		const command = hooksJson.hooks["PostToolUse"]?.[0]?.hooks[0]?.command;
@@ -54,40 +22,3 @@ describe("plugin package metadata", () => {
 		expect(command).toBe(`node "${pluginRoot}/dist/cli.js" hook post-tool-use`);
 	});
 });
-
-function isPackageJson(value: unknown): value is PackageJson {
-	if (!isRecord(value)) return false;
-	const dependencies = value["dependencies"];
-	return (
-		value["type"] === "module" &&
-		value["packageManager"] === "npm@11.12.1" &&
-		isStringRecord(value["bin"]) &&
-		isStringRecord(value["optionalDependencies"]) &&
-		(dependencies === undefined || isRecord(dependencies))
-	);
-}
-
-function isHooksJson(value: unknown): value is HooksJson {
-	if (!isRecord(value) || !isRecord(value["hooks"])) return false;
-	return Object.values(value["hooks"]).every(isHookEntries);
-}
-
-function isHookEntries(value: unknown): value is readonly HookEntry[] {
-	return Array.isArray(value) && value.every(isHookEntry);
-}
-
-function isHookEntry(value: unknown): value is HookEntry {
-	return isRecord(value) && Array.isArray(value["hooks"]) && value["hooks"].every(isHookCommand);
-}
-
-function isHookCommand(value: unknown): value is HookCommand {
-	return isRecord(value) && typeof value["command"] === "string";
-}
-
-function isStringRecord(value: unknown): value is Record<string, string> {
-	return isRecord(value) && Object.values(value).every((item) => typeof item === "string");
-}
-
-function isRecord(value: unknown): value is Record<string, unknown> {
-	return typeof value === "object" && value !== null && !Array.isArray(value);
-}

package/packages/omo-codex/plugin/components/git-bash/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook pre-tool-use",
 						"timeout": 5,
-						"statusMessage": "LazyCodex(4.11.1): Recommending Git Bash MCP"
+						"statusMessage": "(OmO) Recommending Git Bash MCP"
 					}
 				]
 			}
@@ -20,7 +20,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-compact",
 						"timeout": 5,
-						"statusMessage": "LazyCodex(4.11.1): Resetting Git Bash MCP Reminder"
+						"statusMessage": "(OmO) Resetting Git Bash MCP Reminder"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/git-bash/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sisyphuslabs/codex-git-bash-hook",
-	"version": "4.11.1",
+	"version": "4.12.1",
 	"description": "Codex hook component that reminds Windows sessions to prefer the OMO git_bash MCP.",
 	"type": "module",
 	"private": true,

package/packages/omo-codex/plugin/components/lazycodex-executor-verify/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/components/lazycodex-executor-verify/dist/cli.js\" hook subagent-stop",
 						"timeout": 10,
-						"statusMessage": "LazyCodex(4.11.1): Verifying LazyCodex Executor Evidence"
+						"statusMessage": "(OmO) Verifying LazyCodex Executor Evidence"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/lazycodex-executor-verify/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@code-yeongyu/codex-lazycodex-executor-verify",
-	"version": "4.11.1",
+	"version": "4.12.1",
 	"description": "Codex SubagentStop evidence verifier for LazyCodex executor completions.",
 	"type": "module",
 	"packageManager": "npm@11.12.1",

package/packages/omo-codex/plugin/components/lsp/hooks/hooks.json

@@ -8,7 +8,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-tool-use",
 						"timeout": 60,
-						"statusMessage": "LazyCodex(4.11.1): Checking LSP Diagnostics"
+						"statusMessage": "(OmO) Checking LSP Diagnostics"
 					}
 				]
 			}
@@ -21,7 +21,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-compact",
 						"timeout": 5,
-						"statusMessage": "LazyCodex(4.11.1): Resetting LSP Diagnostics Cache"
+						"statusMessage": "(OmO) Resetting LSP Diagnostics Cache"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/lsp/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@code-yeongyu/codex-lsp",
-	"version": "4.11.1",
+	"version": "4.12.1",
 	"description": "Codex plugin that exposes Language Server Protocol tools and post-edit diagnostics.",
 	"type": "module",
 	"packageManager": "npm@11.12.1",
@@ -39,7 +39,7 @@
 		"bootstrap": "node scripts/build-lsp-tools.mjs && node scripts/build-lsp-daemon.mjs",
 		"prebuild": "node scripts/build-lsp-tools.mjs && node scripts/build-lsp-daemon.mjs",
 		"build": "node scripts/clean-dist.mjs && tsc -p tsconfig.build.json",
-		"pretest": "node scripts/build-lsp-tools.mjs && node scripts/build-lsp-daemon.mjs",
+		"pretest": "npm run build --silent",
 		"test": "node scripts/test.mjs",
 		"test:watch": "vitest",
 		"pretypecheck": "node scripts/build-lsp-tools.mjs && node scripts/build-lsp-daemon.mjs",

package/packages/omo-codex/plugin/components/lsp/test/package-smoke.test.ts

@@ -1,53 +1,12 @@
-import { readdirSync, readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
-
-type PackageJson = {
-	readonly version: string;
-	readonly type: string;
-	readonly packageManager: string;
-	readonly bin: Record<string, string>;
-	readonly dependencies: Record<string, string>;
-	readonly scripts: Record<string, string>;
-};
-
-type HookCommand = {
-	readonly command: string;
-};
-
-type HookEntry = {
-	readonly hooks: readonly HookCommand[];
-};
-
-type HooksJson = {
-	readonly hooks: Record<string, readonly HookEntry[]>;
-};
-
-type McpServer = {
-	readonly command: string;
-	readonly args: readonly string[];
-};
-
-type McpJson = {
-	readonly mcpServers: Record<string, McpServer>;
-};
-
-function readPackageJson(path: string): PackageJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isPackageJson(parsed)) throw new TypeError(`Invalid package metadata: ${path}`);
-	return parsed;
-}
-
-function readHooksJson(path: string): HooksJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isHooksJson(parsed)) throw new TypeError(`Invalid hooks metadata: ${path}`);
-	return parsed;
-}
-
-function readMcpJson(path: string): McpJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isMcpJson(parsed)) throw new TypeError(`Invalid MCP metadata: ${path}`);
-	return parsed;
-}
+import {
+	listDirectoryEntries,
+	readHooksJson,
+	readMcpJson,
+	readPackageJson,
+	readTextFile,
+	requireScripts,
+} from "../../test-support/package-smoke-fixture.js";
 
 describe("plugin package metadata", () => {
 	it("#given packaged component files #when validating entrypoints #then hook command stays local and MCP command references the package", () => {
@@ -55,10 +14,11 @@ describe("plugin package metadata", () => {
 		const packageJson = readPackageJson("package.json");
 		const hooksJson = readHooksJson("hooks/hooks.json");
 		const mcpJson = readMcpJson(".mcp.json");
-		const cliSource = readFileSync("src/cli.ts", "utf8");
-		const codexHookCliSource = readFileSync("src/codex-hook-cli.ts", "utf8");
-		const codexHookSource = readFileSync("src/codex-hook.ts", "utf8");
-		const sourceFiles = readdirSync("src");
+		const cliSource = readTextFile("src/cli.ts");
+		const codexHookCliSource = readTextFile("src/codex-hook-cli.ts");
+		const codexHookSource = readTextFile("src/codex-hook.ts");
+		const sourceFiles = listDirectoryEntries("src");
+		const scripts = requireScripts(packageJson, "package.json");
 
 		// when
 		const postToolUseCommand = hooksJson.hooks["PostToolUse"]?.[0]?.hooks[0]?.command;
@@ -74,7 +34,8 @@ describe("plugin package metadata", () => {
 		});
 		expect(packageJson.bin["omo-lsp"]).toBe("./dist/cli.js");
 		expect(packageJson.bin["codex-lsp"]).toBeUndefined();
-		expect(packageJson.scripts["build"]).toBe("node scripts/clean-dist.mjs && tsc -p tsconfig.build.json");
+		expect(scripts["build"]).toBe("node scripts/clean-dist.mjs && tsc -p tsconfig.build.json");
+		expect(scripts["pretest"]).toBe("npm run build --silent");
 		expect(cliSource.startsWith("#!/usr/bin/env node")).toBe(true);
 		expect(cliSource).toContain("Usage: omo-lsp [mcp | hook post-tool-use | hook post-compact]");
 		expect(postToolUseCommand).toBe(`node "${pluginRoot}/dist/cli.js" hook post-tool-use`);
@@ -91,55 +52,16 @@ describe("plugin package metadata", () => {
 		expect(sourceFiles.filter((name) => name.startsWith("lazy-mcp") || name === "lazy-lsp-mcp.ts")).toEqual([]);
 	});
 
-});
-
-function isPackageJson(value: unknown): value is PackageJson {
-	return (
-		isRecord(value) &&
-		typeof value["version"] === "string" &&
-		value["type"] === "module" &&
-		value["packageManager"] === "npm@11.12.1" &&
-		isStringRecord(value["bin"]) &&
-		isStringRecord(value["dependencies"]) &&
-		isStringRecord(value["scripts"])
-	);
-}
-
-function isHooksJson(value: unknown): value is HooksJson {
-	if (!isRecord(value) || !isRecord(value["hooks"])) return false;
-	return Object.values(value["hooks"]).every(isHookEntries);
-}
-
-function isHookEntries(value: unknown): value is readonly HookEntry[] {
-	return Array.isArray(value) && value.every(isHookEntry);
-}
-
-function isHookEntry(value: unknown): value is HookEntry {
-	return isRecord(value) && Array.isArray(value["hooks"]) && value["hooks"].every(isHookCommand);
-}
-
-function isHookCommand(value: unknown): value is HookCommand {
-	return isRecord(value) && typeof value["command"] === "string";
-}
-
-function isMcpJson(value: unknown): value is McpJson {
-	if (!isRecord(value) || !isRecord(value["mcpServers"])) return false;
-	return Object.values(value["mcpServers"]).every(isMcpServer);
-}
-
-function isMcpServer(value: unknown): value is McpServer {
-	return (
-		isRecord(value) &&
-		typeof value["command"] === "string" &&
-		Array.isArray(value["args"]) &&
-		value["args"].every((item) => typeof item === "string")
-	);
-}
+	it("#given LSP skill guidance #when validating MCP tool instructions #then tool names are not framed as shell commands", () => {
+		// given
+		const skill = readTextFile("skills/lsp/SKILL.md");
 
-function isStringRecord(value: unknown): value is Record<string, string> {
-	return isRecord(value) && Object.values(value).every((item) => typeof item === "string");
-}
+		// when
+		const mentionsToolInterface = skill.includes("through the tool interface");
+		const rejectsShellExecution = skill.includes("not shell commands");
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-	return typeof value === "object" && value !== null && !Array.isArray(value);
-}
+		// then
+		expect(mentionsToolInterface).toBe(true);
+		expect(rejectsShellExecution).toBe(true);
+	});
+});

package/packages/omo-codex/plugin/components/rules/hooks/hooks.json

@@ -7,7 +7,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook session-start",
 						"timeout": 10,
-						"statusMessage": "LazyCodex(4.11.1): Loading Project Rules"
+						"statusMessage": "(OmO) Loading Project Rules"
 					}
 				]
 			}
@@ -19,7 +19,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook user-prompt-submit",
 						"timeout": 10,
-						"statusMessage": "LazyCodex(4.11.1): Loading Project Rules"
+						"statusMessage": "(OmO) Loading Project Rules"
 					}
 				]
 			}
@@ -32,7 +32,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-tool-use",
 						"timeout": 10,
-						"statusMessage": "LazyCodex(4.11.1): Matching Project Rules"
+						"statusMessage": "(OmO) Matching Project Rules"
 					}
 				]
 			}
@@ -45,7 +45,7 @@
 						"type": "command",
 						"command": "node \"${PLUGIN_ROOT}/dist/cli.js\" hook post-compact",
 						"timeout": 10,
-						"statusMessage": "LazyCodex(4.11.1): Resetting Project Rule Cache"
+						"statusMessage": "(OmO) Resetting Project Rule Cache"
 					}
 				]
 			}

package/packages/omo-codex/plugin/components/rules/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@code-yeongyu/codex-rules",
-	"version": "4.11.1",
+	"version": "4.12.1",
 	"description": "Codex plugin that injects project rule files into model context through lifecycle hooks.",
 	"type": "module",
 	"packageManager": "npm@11.12.1",

package/packages/omo-codex/plugin/components/rules/test/package-smoke.test.ts

@@ -1,48 +1,12 @@
-import { readdirSync, readFileSync } from "node:fs";
 import { describe, expect, it } from "vitest";
-
-type PackageJson = {
-	readonly type: string;
-	readonly packageManager: string;
-	readonly bin: Record<string, string>;
-	readonly files: readonly string[];
-	readonly dependencies?: Record<string, unknown>;
-};
-
-type PluginJson = {
-	readonly hooks: string;
-};
-
-type HookCommand = {
-	readonly command: string;
-};
-
-type HookEntry = {
-	readonly matcher?: string;
-	readonly hooks: readonly HookCommand[];
-};
-
-type HooksJson = {
-	readonly hooks: Record<string, readonly HookEntry[]>;
-};
-
-function readPackageJson(path: string): PackageJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isPackageJson(parsed)) throw new TypeError(`Invalid package metadata: ${path}`);
-	return parsed;
-}
-
-function readPluginJson(path: string): PluginJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isPluginJson(parsed)) throw new TypeError(`Invalid plugin metadata: ${path}`);
-	return parsed;
-}
-
-function readHooksJson(path: string): HooksJson {
-	const parsed: unknown = JSON.parse(readFileSync(path, "utf8"));
-	if (!isHooksJson(parsed)) throw new TypeError(`Invalid hooks metadata: ${path}`);
-	return parsed;
-}
+import {
+	listDirectoryEntries,
+	readHooksJson,
+	readPackageJson,
+	readPluginJson,
+	readTextFile,
+	requireFiles,
+} from "../../test-support/package-smoke-fixture.js";
 
 describe("plugin package metadata", () => {
 	it("#given packaged plugin files #when validating entrypoints #then hook commands use portable plugin root interpolation", () => {
@@ -50,8 +14,9 @@ describe("plugin package metadata", () => {
 		const packageJson = readPackageJson("package.json");
 		const pluginJson = readPluginJson(".codex-plugin/plugin.json");
 		const hooksJson = readHooksJson("hooks/hooks.json");
-		const cliSource = readFileSync("src/cli.ts", "utf8");
-		const bundledRules = readdirSync("bundled-rules").sort();
+		const cliSource = readTextFile("src/cli.ts");
+		const packageFiles = requireFiles(packageJson, "package.json");
+		const bundledRules = [...listDirectoryEntries("bundled-rules")].sort();
 
 		// when
 		const hookConfig = hooksJson.hooks;
@@ -69,7 +34,7 @@ describe("plugin package metadata", () => {
 		expect(packageJson.packageManager).toBe("npm@11.12.1");
 		expect(packageJson.dependencies ?? {}).toEqual({ picomatch: "^4.0.3" });
 		expect(packageJson.bin["omo-rules"]).toBe("./dist/cli.js");
-		expect(packageJson.files).toContain("bundled-rules");
+		expect(packageFiles).toContain("bundled-rules");
 		expect(bundledRules).toContain("windows-git-bash.md");
 		expect(pluginJson.hooks).toBe("./hooks/hooks.json");
 		expect(cliSource.startsWith("#!/usr/bin/env node")).toBe(true);
@@ -106,48 +71,3 @@ describe("plugin package metadata", () => {
 		).toBe(false);
 	});
 });
-
-function isPackageJson(value: unknown): value is PackageJson {
-	if (!isRecord(value)) return false;
-	const dependencies = value["dependencies"];
-	return (
-		value["type"] === "module" &&
-		value["packageManager"] === "npm@11.12.1" &&
-		isStringRecord(value["bin"]) &&
-		isStringArray(value["files"]) &&
-		(dependencies === undefined || isRecord(dependencies))
-	);
-}
-
-function isStringArray(value: unknown): value is readonly string[] {
-	return Array.isArray(value) && value.every((item) => typeof item === "string");
-}
-
-function isPluginJson(value: unknown): value is PluginJson {
-	return isRecord(value) && typeof value["hooks"] === "string";
-}
-
-function isHooksJson(value: unknown): value is HooksJson {
-	if (!isRecord(value) || !isRecord(value["hooks"])) return false;
-	return Object.values(value["hooks"]).every(isHookEntries);
-}
-
-function isHookEntries(value: unknown): value is readonly HookEntry[] {
-	return Array.isArray(value) && value.every(isHookEntry);
-}
-
-function isHookEntry(value: unknown): value is HookEntry {
-	return isRecord(value) && Array.isArray(value["hooks"]) && value["hooks"].every(isHookCommand);
-}
-
-function isHookCommand(value: unknown): value is HookCommand {
-	return isRecord(value) && typeof value["command"] === "string";
-}
-
-function isStringRecord(value: unknown): value is Record<string, string> {
-	return isRecord(value) && Object.values(value).every((item) => typeof item === "string");
-}
-
-function isRecord(value: unknown): value is Record<string, unknown> {
-	return typeof value === "object" && value !== null && !Array.isArray(value);
-}