oh-my-openagent 4.7.2 → 4.7.4

package/packages/omo-codex/plugin/components/ulw-loop/test/quality-gate.test.ts

@@ -81,6 +81,57 @@ describe("validateQualityGate", () => {
 		expect(gate).toMatchObject({ criteriaCoverage: { totalCriteria: 9, passCount: 9 } });
 	});
 
+	it("infers APPROVE/CLEAR when clean reviewer evidence omits structured fields", () => {
+		// given
+		const input = makeGate({
+			codeReview: {
+				evidence: "UNCONDITIONAL APPROVAL\nAll criteria and QA evidence are complete.",
+			},
+		});
+
+		// when
+		const gate = validateQualityGate(input);
+
+		// then
+		expect(gate.codeReview.recommendation).toBe("APPROVE");
+		expect(gate.codeReview.architectStatus).toBe("CLEAR");
+		expect(gate.codeReview.evidence).toBe("UNCONDITIONAL APPROVAL\nAll criteria and QA evidence are complete.");
+	});
+
+	it("infers APPROVE/CLEAR when clean reviewer evidence has blank structured fields", () => {
+		// given
+		const input = makeGate({
+			codeReview: {
+				recommendation: "",
+				architectStatus: "   ",
+				evidence: "UNCONDITIONAL APPROVAL\nAll criteria and QA evidence are complete.",
+			},
+		});
+
+		// when
+		const gate = validateQualityGate(input);
+
+		// then
+		expect(gate.codeReview.recommendation).toBe("APPROVE");
+		expect(gate.codeReview.architectStatus).toBe("CLEAR");
+	});
+
+	it("throws when reviewer fields are omitted and evidence has no approval verdict", () => {
+		// given
+		const input = makeGate({
+			codeReview: {
+				evidence: "review completed without an explicit verdict",
+			},
+		});
+
+		// when
+		const error = getQualityGateError(input);
+
+		// then
+		expect(error.code).toBe("ULW_LOOP_QUALITY_GATE_INVALID");
+		expect(error.message).toContain("UNCONDITIONAL APPROVAL");
+	});
+
 	it("throws UlwLoopError when aiSlopCleaner missing", () => {
 		// when
 		const error = getQualityGateError(makeGate({ aiSlopCleaner: undefined }));

package/packages/omo-codex/plugin/scripts/migrate-codex-config.mjs

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-import { mkdir, readFile, stat, writeFile } from "node:fs/promises";
+import { lstat, mkdir, readFile, writeFile } from "node:fs/promises";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -169,7 +169,9 @@ async function configPaths({ env, cwd }) {
 	const codexHome = resolve(env.CODEX_HOME?.trim() || join(homedir(), ".codex"));
 	const paths = new Set([join(codexHome, "config.toml")]);
 	for (const projectConfig of projectConfigPaths({ cwd, stopAt: homedir() })) {
-		if (await pathExists(projectConfig)) paths.add(projectConfig);
+		if (!(await isRegularFile(projectConfig))) continue;
+		if (!(await isRegularDirectory(dirname(projectConfig)))) continue;
+		paths.add(projectConfig);
 	}
 	return [...paths];
 }
@@ -216,10 +218,18 @@ async function writeState(statePath, state) {
 	await writeFile(statePath, `${JSON.stringify(state, null, 2)}\n`);
 }
 
-async function pathExists(path) {
+async function isRegularFile(path) {
 	try {
-		await stat(path);
-		return true;
+		return (await lstat(path)).isFile();
+	} catch (error) {
+		if (error instanceof Error && "code" in error && error.code === "ENOENT") return false;
+		throw error;
+	}
+}
+
+async function isRegularDirectory(path) {
+	try {
+		return (await lstat(path)).isDirectory();
 	} catch (error) {
 		if (error instanceof Error && "code" in error && error.code === "ENOENT") return false;
 		throw error;

package/packages/omo-codex/plugin/skills/rules/SKILL.md

@@ -14,10 +14,8 @@ Dynamic `PostToolUse` output is injected as additional context and is deduplicat
 
 Supported project sources:
 
-- `AGENTS.md`
-- `CLAUDE.md`
 - `CONTEXT.md`
-- `.sisyphus/rules/**/*.md`
+- `.omo/rules/**/*.md`
 - `.claude/rules/**/*.md`
 - `.cursor/rules/**/*.md`
 - `.github/instructions/**/*.md`
@@ -29,6 +27,6 @@ Supported environment knobs:
 - `CODEX_RULES_MODE=both|static|dynamic|off`
 - `CODEX_RULES_MAX_RULE_CHARS=<number>`
 - `CODEX_RULES_MAX_RESULT_CHARS=<number>`
-- `CODEX_RULES_ENABLED_SOURCES=AGENTS.md,.sisyphus/rules`
+- `CODEX_RULES_ENABLED_SOURCES=CONTEXT.md,.omo/rules`
 
 The legacy `PI_RULES_*` variables are accepted as fallbacks for users migrating from `pi-rules`.

package/packages/omo-codex/plugin/skills/ulw-loop/references/full-workflow.md

@@ -172,7 +172,7 @@ Trigger only when one goal remains and all its criteria are passing.
 1. Run targeted verification for changed behavior.
 2. Run `ai-slop-cleaner` on changed files. If no relevant edits exist, record a passed no-op cleaner report.
 3. Rerun verification after cleanup.
-4. Run `$code-review`.
+4. Judge the change size. Spawn the `codex-ultrawork-reviewer` agent (`spawn_agent(agent_type="codex-ultrawork-reviewer", fork_turns="none", ...)`; fall back to `agent_type="worker"` with a scoped reviewer assignment if unavailable) only when the work is large or risky (multi-file, cross-cutting, new architecture, security/data surfaces, or you are unsure it is sound); for a small, local, low-risk change, do the review yourself and record `codeReview` with `evidence` starting `UNCONDITIONAL APPROVAL` plus a one-line justification of why the change was small enough to self-review.
 5. Clean review means `codeReview.recommendation == "APPROVE"` and `codeReview.architectStatus == "CLEAR"`.
 6. If review is non-clean, run `omo ulw-loop record-review-blockers --goal-id <id> --title "<...>" --objective "<...>" --evidence "<review findings>" --codex-goal-json <snapshot> --json`.
 7. If clean, checkpoint final completion:

package/packages/omo-codex/plugin/test/migrate-codex-config.test.mjs

@@ -1,5 +1,5 @@
 import assert from "node:assert/strict";
-import { mkdir, mkdtemp, readFile, writeFile } from "node:fs/promises";
+import { mkdir, mkdtemp, readFile, rm, symlink, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import test from "node:test";
@@ -32,6 +32,66 @@ test("#given stale root reasoning config #when ensuring config #then replaces st
 	assert.match(result, /\[features\]/);
 });
 
+test("#given project .codex is a symlink #when migrating #then project config is skipped", async (t) => {
+	if (!(await canCreateSymlink("dir"))) t.skip("symbolic links are unavailable in this environment");
+
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-config-symlink-dir-"));
+	const codexHome = join(root, "codex-home");
+	const project = join(root, "project");
+	const projectNested = join(project, "nested");
+	const projectCodexDirectory = join(root, "project-codex-real");
+	const projectConfigTarget = join(projectCodexDirectory, "config.toml");
+	const projectConfig = join(project, ".codex", "config.toml");
+
+	await mkdir(codexHome, { recursive: true });
+	await mkdir(projectCodexDirectory, { recursive: true });
+	await mkdir(dirname(projectConfigTarget), { recursive: true });
+	await mkdir(projectNested, { recursive: true });
+	await writeFile(join(codexHome, "config.toml"), 'model = "gpt-5.2"\n');
+	await writeFile(projectConfigTarget, 'model = "gpt-5.2"\nmodel_context_window = 272000\n');
+	await rm(join(project, ".codex"), { recursive: true, force: true });
+	await symlink(projectCodexDirectory, join(project, ".codex"), "dir");
+
+	const result = await migrateCodexConfig({
+		env: {
+			CODEX_HOME: codexHome,
+			LAZYCODEX_MODEL_CATALOG_STATE_PATH: join(root, "model-state.json"),
+		},
+		cwd: projectNested,
+	});
+
+	assert.deepEqual(result.changed, [join(codexHome, "config.toml")]);
+	assert.match(await readFile(projectConfig, "utf8"), /model = "gpt-5\.2"/);
+});
+
+test("#given project config.toml is a symlink #when migrating #then project config is skipped", async (t) => {
+	if (!(await canCreateSymlink("file"))) t.skip("symbolic links are unavailable in this environment");
+
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-config-symlink-file-"));
+	const codexHome = join(root, "codex-home");
+	const project = join(root, "project");
+	const projectConfigDirectory = join(project, ".codex");
+	const projectConfig = join(projectConfigDirectory, "config.toml");
+	const realConfigSource = join(root, "shared-config.toml");
+
+	await mkdir(codexHome, { recursive: true });
+	await mkdir(projectConfigDirectory, { recursive: true });
+	await writeFile(join(codexHome, "config.toml"), 'model = "gpt-5.2"\n');
+	await writeFile(realConfigSource, 'model = "gpt-5.2"\nmodel_context_window = 272000\n');
+	await symlink(realConfigSource, projectConfig, "file");
+
+	const result = await migrateCodexConfig({
+		env: {
+			CODEX_HOME: codexHome,
+			LAZYCODEX_MODEL_CATALOG_STATE_PATH: join(root, "model-state.json"),
+		},
+		cwd: project,
+	});
+
+	assert.deepEqual(result.changed, [join(codexHome, "config.toml")]);
+	assert.match(await readFile(realConfigSource, "utf8"), /model = "gpt-5\.2"/);
+});
+
 test("#given global and project-local stale Codex configs #when migrating #then both configs are forced to current defaults", async () => {
 	const root = await mkdtemp(join(tmpdir(), "lazycodex-config-migration-"));
 	const codexHome = join(root, "codex-home");
@@ -144,3 +204,29 @@ test("#given managed catalog state #when catalog version advances #then only pre
 	assert.match(content, /model = "gpt-5\.5"/);
 	assert.match(content, /model_context_window = 400000/);
 });
+
+async function canCreateSymlink(type) {
+	const root = await mkdtemp(join(tmpdir(), "lazycodex-symlink-capability-"));
+	const target = join(root, "target");
+	const link = join(root, "link");
+
+	try {
+		if (type === "dir") {
+			await mkdir(target, { recursive: true });
+			await symlink(target, link, "dir");
+		} else {
+			await writeFile(target, "");
+			await symlink(target, link, "file");
+		}
+
+		await rm(link);
+		await rm(target, { recursive: true, force: true });
+		await rm(root, { recursive: true, force: true });
+		return true;
+	} catch (error) {
+		await rm(root, { recursive: true, force: true });
+		if (!(error instanceof Error)) throw error;
+		if (error.code === "EPERM" || error.code === "EEXIST") return false;
+		return false;
+	}
+}

package/packages/omo-codex/scripts/install/config.mjs

@@ -44,6 +44,8 @@ export async function updateCodexConfig({
 	config = removeStaleManagedAgentBlocks(config, new Set(agentConfigs.map((agentConfig) => agentConfig.name)));
 	config = ensureFeatureEnabled(config, "plugins");
 	config = ensureFeatureEnabled(config, "plugin_hooks");
+	config = ensureFeatureEnabled(config, "multi_agent");
+	config = ensureFeatureEnabled(config, "child_agents_md");
 	config = ensureCodexReasoningConfig(config, await readCodexModelCatalog(repoRoot));
 	config = ensureCodexMultiAgentV2Config(config);
 	if (autonomousPermissions === true) config = ensureAutonomousPermissions(config);

package/packages/omo-codex/scripts/install-config-autonomous-features.test.mjs

@@ -6,7 +6,8 @@ import test from "node:test";
 
 import { updateCodexConfig } from "./install/config.mjs";
 
-const AUTONOMOUS_FEATURES = ["multi_agent", "child_agents_md", "unified_exec", "goals"];
+const ALWAYS_ON_FEATURES = ["plugins", "plugin_hooks", "multi_agent", "child_agents_md"];
+const AUTONOMOUS_PERMISSION_FEATURES = ["unified_exec", "goals"];
 
 test("#given autonomous permissions requested #when script installer updates config #then enables Codex autonomy feature flags", async () => {
 	// given
@@ -39,12 +40,15 @@ test("#given autonomous permissions requested #when script installer updates con
 	// then
 	const content = await readFile(configPath, "utf8");
 	assert.match(content, /network_access = "enabled"/);
-	for (const featureName of AUTONOMOUS_FEATURES) {
+	for (const featureName of ALWAYS_ON_FEATURES) {
+		assert.match(content, new RegExp(`${featureName} = true`));
+	}
+	for (const featureName of AUTONOMOUS_PERMISSION_FEATURES) {
 		assert.match(content, new RegExp(`${featureName} = true`));
 	}
 });
 
-test("#given autonomous permissions disabled #when script installer updates config #then preserves autonomy feature opt-outs", async () => {
+test("#given autonomous permissions disabled #when script installer updates config #then keeps native Codex feature flags enabled", async () => {
 	// given
 	const root = await mkdtemp(join(tmpdir(), "omo-codex-script-config-autonomous-features-disabled-"));
 	const configPath = join(root, "config.toml");
@@ -75,9 +79,10 @@ test("#given autonomous permissions disabled #when script installer updates conf
 	// then
 	const content = await readFile(configPath, "utf8");
 	assert.match(content, /network_access = "disabled"/);
-	for (const featureName of AUTONOMOUS_FEATURES) {
+	for (const featureName of ALWAYS_ON_FEATURES) {
+		assert.match(content, new RegExp(`${featureName} = true`));
+	}
+	for (const featureName of AUTONOMOUS_PERMISSION_FEATURES) {
 		assert.match(content, new RegExp(`${featureName} = false`));
 	}
-	assert.match(content, /plugins = true/);
-	assert.match(content, /plugin_hooks = true/);
 });