oh-my-openagent 4.11.0 → 4.12.0

package/.agents/skills/codex-qa/scripts/lib/app-server-client.mjs

@@ -19,99 +19,149 @@
 //                 turn/completed.
 //   CODEX_BIN     codex binary (default "codex"; PATH lookup, no shell function).
 //
-// Prints a JSON summary to stdout. Exit 0 iff the turn completed AND every
-// EXPECT_HOOK fired with status "completed".
+// Prints a JSON summary to stdout. Exit 0 iff the turn completed, every
+// EXPECT_HOOK fired with status "completed", and no hook completed failed.
 import { spawn } from "node:child_process";
+import { pathToFileURL } from "node:url";
 
-const CODEX_BIN = process.env.CODEX_BIN || "codex";
-const MOCK_PORT = process.env.MOCK_PORT;
-const PROMPT = process.env.PROMPT || "say hello";
-const CWD = process.env.QA_CWD || process.cwd();
-const DEADLINE_MS = Number(process.env.DEADLINE_MS || 60000);
-const EXPECT = (process.env.EXPECT_HOOK || "").split(",").map((s) => s.trim()).filter(Boolean);
+export function parseExpectedHooks(value) {
+  return (value || "").split(",").map((s) => s.trim()).filter(Boolean);
+}
 
-if (!MOCK_PORT) {
-  console.error("app-server-client: MOCK_PORT is required (start lib/mock-model.mjs first)");
-  process.exit(2);
+export function summarizeRun({ turnStatus, assistantText, threadId, turnId, expectHook, hooks, stderr }) {
+  const completed = new Set(
+    hooks
+      .filter((h) => h.method === "hook/completed" && h.status === "completed")
+      .map((h) => h.eventName),
+  );
+  const missingHooks = expectHook.filter((eventName) => !completed.has(eventName));
+  const failedHooks = hooks.filter((h) => h.method === "hook/completed" && h.status !== "completed");
+  const ok = turnStatus === "completed" && missingHooks.length === 0 && failedHooks.length === 0;
+  return {
+    ok,
+    turnStatus,
+    assistantText,
+    threadId,
+    turnId,
+    expectHook,
+    missingHooks,
+    failedHooks,
+    hooks,
+    stderrTail: stderr.split("\n").slice(-10).join("\n"),
+  };
 }
 
-// Config overrides force codex onto the local mock provider, never the real one.
-const overrides = [
-  `model="mock-model"`,
-  `model_provider="mock_provider"`,
-  `model_providers.mock_provider.name="codex-qa mock"`,
-  `model_providers.mock_provider.base_url="http://127.0.0.1:${MOCK_PORT}/v1"`,
-  `model_providers.mock_provider.wire_api="responses"`,
-  `model_providers.mock_provider.request_max_retries=0`,
-  `model_providers.mock_provider.stream_max_retries=0`,
-  `approval_policy="never"`,
-  `sandbox_mode="read-only"`,
-];
-const args = overrides.flatMap((o) => ["-c", o]).concat("app-server");
+function main() {
+  const CODEX_BIN = process.env.CODEX_BIN || "codex";
+  const MOCK_PORT = process.env.MOCK_PORT;
+  const PROMPT = process.env.PROMPT || "say hello";
+  const CWD = process.env.QA_CWD || process.cwd();
+  const DEADLINE_MS = Number(process.env.DEADLINE_MS || 60000);
+  const EXPECT = parseExpectedHooks(process.env.EXPECT_HOOK || "");
 
-const child = spawn(CODEX_BIN, args, { stdio: ["pipe", "pipe", "pipe"], env: process.env });
-let stderr = "";
-child.stderr.on("data", (c) => (stderr += c));
+  if (!MOCK_PORT) {
+    console.error("app-server-client: MOCK_PORT is required (start lib/mock-model.mjs first)");
+    process.exit(2);
+  }
 
-const hooks = [];
-let assistantText = null;
-let threadId = null;
-let turnId = null;
-let turnStatus = null;
-let buf = "";
-let finished = false;
+  // Config overrides force codex onto the local mock provider, never the real one.
+  const overrides = [
+    `model="mock-model"`,
+    `model_provider="mock_provider"`,
+    `model_providers.mock_provider.name="codex-qa mock"`,
+    `model_providers.mock_provider.base_url="http://127.0.0.1:${MOCK_PORT}/v1"`,
+    `model_providers.mock_provider.wire_api="responses"`,
+    `model_providers.mock_provider.request_max_retries=0`,
+    `model_providers.mock_provider.stream_max_retries=0`,
+    `approval_policy="never"`,
+    `sandbox_mode="read-only"`,
+  ];
+  const args = overrides.flatMap((o) => ["-c", o]).concat("app-server");
 
-const send = (obj) => child.stdin.write(JSON.stringify(obj) + "\n");
+  const child = spawn(CODEX_BIN, args, { stdio: ["pipe", "pipe", "pipe"], env: process.env });
+  let stderr = "";
+  child.stderr.on("data", (c) => (stderr += c));
 
-function finish() {
-  if (finished) return;
-  finished = true;
-  try { child.kill("SIGTERM"); } catch {}
-  const completed = new Set(hooks.filter((h) => h.method === "hook/completed" && h.status === "completed").map((h) => h.eventName));
-  const missing = EXPECT.filter((e) => !completed.has(e));
-  const ok = turnStatus === "completed" && missing.length === 0;
-  console.log(JSON.stringify({ ok, turnStatus, assistantText, threadId, turnId, expectHook: EXPECT, missingHooks: missing, hooks, stderrTail: stderr.split("\n").slice(-10).join("\n") }, null, 2));
-  process.exit(ok ? 0 : 1);
-}
+  const hooks = [];
+  let assistantText = null;
+  let threadId = null;
+  let turnId = null;
+  let turnStatus = null;
+  let buf = "";
+  let finished = false;
 
-function handle(msg) {
-  if (msg.id === 1 && msg.result) {
-    send({ method: "initialized" });
-    send({ id: 2, method: "thread/start", params: { cwd: CWD } });
-  } else if (msg.id === 2 && msg.result) {
-    threadId = msg.result.thread?.id;
-    send({ id: 3, method: "turn/start", params: { threadId, input: [{ type: "text", text: PROMPT }] } });
-  } else if (msg.id === 3 && msg.result) {
-    turnId = msg.result.turn?.id;
-  } else if (msg.method === "hook/started" || msg.method === "hook/completed") {
-    const run = msg.params?.run || {};
-    hooks.push({ method: msg.method, eventName: run.eventName, status: run.status, source: run.source ?? run.pluginId });
-  } else if (msg.method === "item/completed") {
-    const item = msg.params?.item;
-    if (item?.type === "agentMessage" && typeof item.text === "string") assistantText = item.text;
-  } else if (msg.method === "turn/completed") {
-    turnStatus = msg.params?.turn?.status;
-    finish();
+  const send = (obj) => child.stdin.write(JSON.stringify(obj) + "\n");
+
+  function finish() {
+    if (finished) return;
+    finished = true;
+    try {
+      child.kill("SIGTERM");
+    } catch (error) {
+      const message = error instanceof Error ? `${error.name}: ${error.message}` : String(error);
+      stderr += `\n[driver] failed to terminate app-server: ${message}\n`;
+    }
+    const summary = summarizeRun({ turnStatus, assistantText, threadId, turnId, expectHook: EXPECT, hooks, stderr });
+    console.log(JSON.stringify(summary, null, 2));
+    process.exit(summary.ok ? 0 : 1);
   }
-}
 
-child.stdout.on("data", (chunk) => {
-  buf += chunk;
-  let nl;
-  while ((nl = buf.indexOf("\n")) >= 0) {
-    const line = buf.slice(0, nl).trim();
-    buf = buf.slice(nl + 1);
-    if (!line) continue;
-    let msg;
-    try { msg = JSON.parse(line); } catch { continue; }
-    handle(msg);
+  function handle(msg) {
+    if (msg.id === 1 && msg.result) {
+      send({ method: "initialized" });
+      send({ id: 2, method: "thread/start", params: { cwd: CWD } });
+    } else if (msg.id === 2 && msg.result) {
+      threadId = msg.result.thread?.id;
+      send({ id: 3, method: "turn/start", params: { threadId, input: [{ type: "text", text: PROMPT }] } });
+    } else if (msg.id === 3 && msg.result) {
+      turnId = msg.result.turn?.id;
+    } else if (msg.method === "hook/started" || msg.method === "hook/completed") {
+      const run = msg.params?.run || {};
+      hooks.push({
+        method: msg.method,
+        eventName: run.eventName,
+        status: run.status,
+        source: run.source ?? run.pluginId,
+        pluginId: run.pluginId,
+        hookName: run.hookName ?? run.name,
+        runId: run.id,
+      });
+    } else if (msg.method === "item/completed") {
+      const item = msg.params?.item;
+      if (item?.type === "agentMessage" && typeof item.text === "string") assistantText = item.text;
+    } else if (msg.method === "turn/completed") {
+      turnStatus = msg.params?.turn?.status;
+      finish();
+    }
   }
-});
-child.on("exit", (code) => {
-  if (finished) return;
-  console.log(JSON.stringify({ ok: false, exitCode: code, turnStatus, hooks, stderrTail: stderr.split("\n").slice(-15).join("\n") }, null, 2));
-  process.exit(1);
-});
 
-send({ id: 1, method: "initialize", params: { clientInfo: { name: "codex-qa", version: "0.1.0" }, capabilities: { experimentalApi: true, requestAttestation: false } } });
-setTimeout(() => { stderr += "\n[driver] deadline reached\n"; finish(); }, DEADLINE_MS);
+  child.stdout.on("data", (chunk) => {
+    buf += chunk;
+    let nl;
+    while ((nl = buf.indexOf("\n")) >= 0) {
+      const line = buf.slice(0, nl).trim();
+      buf = buf.slice(nl + 1);
+      if (!line) continue;
+      let msg;
+      try {
+        msg = JSON.parse(line);
+      } catch (error) {
+        if (error instanceof SyntaxError) continue;
+        throw error;
+      }
+      handle(msg);
+    }
+  });
+  child.on("exit", (code) => {
+    if (finished) return;
+    console.log(JSON.stringify({ ok: false, exitCode: code, turnStatus, hooks, stderrTail: stderr.split("\n").slice(-15).join("\n") }, null, 2));
+    process.exit(1);
+  });
+
+  send({ id: 1, method: "initialize", params: { clientInfo: { name: "codex-qa", version: "0.1.0" }, capabilities: { experimentalApi: true, requestAttestation: false } } });
+  setTimeout(() => { stderr += "\n[driver] deadline reached\n"; finish(); }, DEADLINE_MS);
+}
+
+if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
+  main();
+}

package/.agents/skills/codex-qa/scripts/lib/app-server-client.test.js

@@ -0,0 +1,48 @@
+import { describe, expect, it } from "bun:test";
+import { parseExpectedHooks, summarizeRun } from "./app-server-client.mjs";
+
+describe("app-server-client summary", () => {
+  it("#given a completed expected event also has a failed hook run #when summarized #then the QA run fails", () => {
+    const summary = summarizeRun({
+      turnStatus: "completed",
+      assistantText: "ok",
+      threadId: "thread",
+      turnId: "turn",
+      expectHook: ["sessionStart", "userPromptSubmit"],
+      hooks: [
+        { method: "hook/completed", eventName: "sessionStart", status: "completed", source: "plugin" },
+        { method: "hook/completed", eventName: "userPromptSubmit", status: "completed", source: "plugin" },
+        { method: "hook/completed", eventName: "userPromptSubmit", status: "failed", source: "plugin" },
+      ],
+      stderr: "",
+    });
+
+    expect(summary.ok).toBe(false);
+    expect(summary.missingHooks).toEqual([]);
+    expect(summary.failedHooks).toEqual([
+      { method: "hook/completed", eventName: "userPromptSubmit", status: "failed", source: "plugin" },
+    ]);
+  });
+
+  it("#given all expected hooks complete #when summarized #then the QA run passes", () => {
+    const summary = summarizeRun({
+      turnStatus: "completed",
+      assistantText: "ok",
+      threadId: "thread",
+      turnId: "turn",
+      expectHook: ["sessionStart", "userPromptSubmit"],
+      hooks: [
+        { method: "hook/completed", eventName: "sessionStart", status: "completed", source: "plugin" },
+        { method: "hook/completed", eventName: "userPromptSubmit", status: "completed", source: "plugin" },
+      ],
+      stderr: "",
+    });
+
+    expect(summary.ok).toBe(true);
+    expect(summary.failedHooks).toEqual([]);
+  });
+
+  it("#given a comma-separated expectation #when parsed #then whitespace and empties are ignored", () => {
+    expect(parseExpectedHooks(" sessionStart, ,userPromptSubmit ")).toEqual(["sessionStart", "userPromptSubmit"]);
+  });
+});