oh-my-knowledge 0.51.0 → 0.51.1

package/dist/eval-core/dependency-checker.js

@@ -25,7 +25,14 @@ const SYSTEM_ENV_VARS = new Set([
     'TMPDIR', 'EDITOR', 'VISUAL', 'HOSTNAME', 'LOGNAME', 'DISPLAY',
     'XDG_CONFIG_HOME', 'XDG_DATA_HOME', 'XDG_CACHE_HOME',
     'NODE_ENV', 'NODE_PATH', 'NODE_OPTIONS', 'NPM_CONFIG_PREFIX',
+    // Agent Skills resolves this placeholder to the active skill directory.
+    // It is not a user-provided environment prerequisite.
+    'SKILL_ROOT',
 ]);
+// A shell probe that explicitly tolerates failure is discovering the target
+// project shape. Candidate paths on that line are not hard dependencies of the
+// skill itself.
+const OPTIONAL_PROBE_LINE_REGEX = /(?:2>\s*\/dev\/null|\|\|\s*(?:true|:)(?:\s|$))/;
 function extractFromText(text) {
     const tools = new Set();
     const files = new Set();
@@ -42,25 +49,30 @@ function extractFromText(text) {
             tools.add(cmd);
         }
     }
-    // File paths
-    for (const match of text.matchAll(FILE_PATH_REGEX)) {
-        const path = match[1];
-        // Skip paths that look like URLs, package names, or version strings
-        if (path.startsWith('http') || path.startsWith('node_modules') || /^\d/.test(path))
+    // File paths. Keep line context so optional discovery commands do not turn
+    // every candidate project entry point into a fatal preflight requirement.
+    for (const line of text.split(/\r?\n/)) {
+        if (OPTIONAL_PROBE_LINE_REGEX.test(line))
             continue;
-        // Skip very short paths that are likely not real files
-        if (path.length < 5)
-            continue;
-        // Skip extension-mention patterns(`.d.ts` / `.tsx` 这种以点开头的"扩展名讨论"
-        // 不是真路径,SKILL.md 里"查看 .d.ts 文件"会被误识别)
-        if (path.startsWith('.'))
-            continue;
-        // Skip bare filenames without a directory segment(`index.ts` / `package.json`
-        // 这种通用文件名几乎都是示例性提及,真依赖会带路径段。要声明 bare 文件
-        // 走显式 requires)
-        if (!path.includes('/'))
-            continue;
-        files.add(path);
+        for (const match of line.matchAll(FILE_PATH_REGEX)) {
+            const path = match[1];
+            // Skip paths that look like URLs, package names, or version strings
+            if (path.startsWith('http') || path.startsWith('node_modules') || /^\d/.test(path))
+                continue;
+            // Skip very short paths that are likely not real files
+            if (path.length < 5)
+                continue;
+            // Skip extension-mention patterns(`.d.ts` / `.tsx` 这种以点开头的"扩展名讨论"
+            // 不是真路径,SKILL.md 里"查看 .d.ts 文件"会被误识别)
+            if (path.startsWith('.'))
+                continue;
+            // Skip bare filenames without a directory segment(`index.ts` / `package.json`
+            // 这种通用文件名几乎都是示例性提及,真依赖会带路径段。要声明 bare 文件
+            // 走显式 requires)
+            if (!path.includes('/'))
+                continue;
+            files.add(path);
+        }
     }
     // Environment variables
     for (const match of text.matchAll(ENV_VAR_REGEX)) {

package/dist/observability/codex-exec-command.d.ts

@@ -0,0 +1,7 @@
+/** Static extraction for Codex Desktop's JavaScript exec bridge. */
+/**
+ * Extract only literal `cmd` values from real `tools.exec_command(...)` calls.
+ * The bridge source is never evaluated, and examples inside strings/comments
+ * remain ignored.
+ */
+export declare function extractCodexExecCommands(source: string): string[];

package/dist/observability/codex-exec-command.js

@@ -0,0 +1,134 @@
+/** Static extraction for Codex Desktop's JavaScript exec bridge. */
+function skipJsString(source, start) {
+    const quote = source[start];
+    let index = start + 1;
+    while (index < source.length) {
+        if (source[index] === '\\') {
+            index += 2;
+            continue;
+        }
+        if (source[index] === quote)
+            return index + 1;
+        index += 1;
+    }
+    return source.length;
+}
+function skipJsTrivia(source, start) {
+    let index = start;
+    while (index < source.length) {
+        if (/\s/.test(source[index])) {
+            index += 1;
+            continue;
+        }
+        if (source.startsWith('//', index)) {
+            const newline = source.indexOf('\n', index + 2);
+            return newline < 0 ? source.length : skipJsTrivia(source, newline + 1);
+        }
+        if (source.startsWith('/*', index)) {
+            const end = source.indexOf('*/', index + 2);
+            return end < 0 ? source.length : skipJsTrivia(source, end + 2);
+        }
+        break;
+    }
+    return index;
+}
+function commandPropertyEnd(source, index) {
+    const bareKey = source.startsWith('cmd', index)
+        && !/[\w$]/.test(source[index - 1] ?? '')
+        && !/[\w$]/.test(source[index + 3] ?? '');
+    if (bareKey)
+        return index + 3;
+    const quote = source[index];
+    if (quote !== '"' && quote !== "'")
+        return null;
+    const end = skipJsString(source, index);
+    return source.slice(index + 1, end - 1) === 'cmd' ? end : null;
+}
+function commandLiteralValue(source, start, end) {
+    const literal = source.slice(start, end);
+    if (source[start] === '"') {
+        try {
+            const parsed = JSON.parse(literal);
+            if (typeof parsed === 'string')
+                return parsed;
+        }
+        catch {
+            // Fall through to the lossless source slice for non-JSON JS escapes.
+        }
+    }
+    return source.slice(start + 1, Math.max(start + 1, end - 1));
+}
+function extractExecCommandLiteral(source, callStart) {
+    let index = skipJsTrivia(source, callStart + 'tools.exec_command'.length);
+    if (source[index] !== '(')
+        return null;
+    index = skipJsTrivia(source, index + 1);
+    if (source[index] !== '{')
+        return null;
+    let depth = 1;
+    index += 1;
+    while (index < source.length && depth > 0) {
+        index = skipJsTrivia(source, index);
+        const char = source[index];
+        if (depth === 1) {
+            const keyEnd = commandPropertyEnd(source, index);
+            if (keyEnd !== null) {
+                let valueStart = skipJsTrivia(source, keyEnd);
+                if (source[valueStart] !== ':') {
+                    index = keyEnd;
+                    continue;
+                }
+                valueStart = skipJsTrivia(source, valueStart + 1);
+                const quote = source[valueStart];
+                if (quote !== '"' && quote !== "'" && quote !== '`')
+                    return null;
+                const end = skipJsString(source, valueStart);
+                return commandLiteralValue(source, valueStart, end);
+            }
+        }
+        if (char === '"' || char === "'" || char === '`') {
+            index = skipJsString(source, index);
+            continue;
+        }
+        if (char === '{') {
+            depth += 1;
+            index += 1;
+            continue;
+        }
+        if (char === '}') {
+            depth -= 1;
+            index += 1;
+            continue;
+        }
+        index += 1;
+    }
+    return null;
+}
+/**
+ * Extract only literal `cmd` values from real `tools.exec_command(...)` calls.
+ * The bridge source is never evaluated, and examples inside strings/comments
+ * remain ignored.
+ */
+export function extractCodexExecCommands(source) {
+    const commands = [];
+    let index = 0;
+    while (index < source.length) {
+        index = skipJsTrivia(source, index);
+        const char = source[index];
+        if (char === '"' || char === "'" || char === '`') {
+            index = skipJsString(source, index);
+            continue;
+        }
+        if (source.startsWith('tools.exec_command', index)
+            && !/[\w$.]/.test(source[index - 1] ?? '')
+            && !/[\w$]/.test(source[index + 'tools.exec_command'.length] ?? '')) {
+            const command = extractExecCommandLiteral(source, index);
+            if (command)
+                commands.push(command);
+            index += 'tools.exec_command'.length;
+            continue;
+        }
+        index += 1;
+    }
+    return commands;
+}

package/dist/observability/codex-trace-adapter.js

@@ -4,6 +4,7 @@ import { isToolResultFailureText } from './text-signals.js';
 import { correlateTraceToolEvents, createTraceId, normalizeTraceTimestamp, traceTimestampBounds, } from './trace-ir.js';
 import { nonNegativeMetric, optionalTokenCount, splitInclusiveInputTokens, tokenCount, } from '../shared/token-usage.js';
 import { normalizeToolIdentity } from '../shared/tool-identity.js';
+import { extractCodexExecCommands } from './codex-exec-command.js';
 const CODEX_RESPONSE_ITEM_TYPES = new Set([
     'message',
     'reasoning',
@@ -242,8 +243,10 @@ function convertCodexRecords(rawRecords, runId) {
             const explicitStatus = runtimeOutcome.present
                 ? runtimeOutcome.status
                 : statusFromCodex(payloadStatus);
-            const inferredFailure = isToolResultFailureText(output) || codexToolOutputFailed(output);
-            const inferredSuccess = !inferredFailure && codexToolOutputSucceeded(output);
+            const bridgeFailure = codexToolOutputFailed(output);
+            const bridgeSuccess = !bridgeFailure && codexToolOutputSucceeded(output);
+            const inferredFailure = bridgeFailure || (!bridgeSuccess && isToolResultFailureText(output));
+            const inferredSuccess = bridgeSuccess;
             const completedExternalCall = externalEnds.byOccurrence.has(mcpCallOccurrenceKey(callId, externalOccurrence));
             const inferredStatus = inferredFailure
                 ? 'failure'
@@ -609,6 +612,10 @@ function runtimeToolEndOutcome(end) {
 }
 function normalizeCodexTool(sourceName, rawInput, mcpEnd, sourceNamespace) {
     const input = parseToolInput(rawInput);
+    const sourceInput = stringValue(input.input);
+    const execCommands = sourceName.toLowerCase() === 'exec' && sourceInput
+        ? extractCodexExecCommands(sourceInput)
+        : [];
     // Codex desktop's orchestration wrapper names its JavaScript command bridge
     // `exec`. This mapping is source-specific: a generic tool named `exec` must not
     // become shell execution outside the Codex adapter.
@@ -629,10 +636,13 @@ function normalizeCodexTool(sourceName, rawInput, mcpEnd, sourceNamespace) {
             tool,
             input: {
                 ...input,
-                command: stringValue(input.command)
-                    ?? stringValue(input.cmd)
-                    ?? stringValue(input.input)
-                    ?? '',
+                command: execCommands.length > 0
+                    ? execCommands.join('\n')
+                    : stringValue(input.command)
+                        ?? stringValue(input.cmd)
+                        ?? sourceInput
+                        ?? '',
+                ...(execCommands.length > 0 ? { commands: execCommands } : {}),
             },
         };
     }

package/dist/observability/trace-attribution.js

@@ -1,4 +1,5 @@
 /** Skill attribution rules for trace records. */
+import { extractCodexExecCommands } from './codex-exec-command.js';
 export function extractMarkdownLogSkill(text) {
     const patterns = [
         /\b(?:prefer|use|call|invoke)\s+`?([a-zA-Z0-9][\w.-]*)`?\s+skill\b/i,
@@ -192,108 +193,6 @@ function extractInstalledSkillReadRef(text) {
     }
     return null;
 }
-function skipJsString(source, start) {
-    const quote = source[start];
-    let index = start + 1;
-    while (index < source.length) {
-        if (source[index] === '\\') {
-            index += 2;
-            continue;
-        }
-        if (source[index] === quote)
-            return index + 1;
-        index += 1;
-    }
-    return source.length;
-}
-function skipJsTrivia(source, start) {
-    let index = start;
-    while (index < source.length) {
-        if (/\s/.test(source[index])) {
-            index += 1;
-            continue;
-        }
-        if (source.startsWith('//', index)) {
-            const newline = source.indexOf('\n', index + 2);
-            return newline < 0 ? source.length : skipJsTrivia(source, newline + 1);
-        }
-        if (source.startsWith('/*', index)) {
-            const end = source.indexOf('*/', index + 2);
-            return end < 0 ? source.length : skipJsTrivia(source, end + 2);
-        }
-        break;
-    }
-    return index;
-}
-function extractExecCommandLiteral(source, callStart) {
-    let index = skipJsTrivia(source, callStart + 'tools.exec_command'.length);
-    if (source[index] !== '(')
-        return null;
-    index = skipJsTrivia(source, index + 1);
-    if (source[index] !== '{')
-        return null;
-    let depth = 1;
-    index += 1;
-    while (index < source.length && depth > 0) {
-        index = skipJsTrivia(source, index);
-        const char = source[index];
-        if (char === '"' || char === "'" || char === '`') {
-            index = skipJsString(source, index);
-            continue;
-        }
-        if (char === '{') {
-            depth += 1;
-            index += 1;
-            continue;
-        }
-        if (char === '}') {
-            depth -= 1;
-            index += 1;
-            continue;
-        }
-        if (depth === 1
-            && source.startsWith('cmd', index)
-            && !/[\w$]/.test(source[index - 1] ?? '')
-            && !/[\w$]/.test(source[index + 3] ?? '')) {
-            let valueStart = skipJsTrivia(source, index + 3);
-            if (source[valueStart] !== ':') {
-                index += 3;
-                continue;
-            }
-            valueStart = skipJsTrivia(source, valueStart + 1);
-            const quote = source[valueStart];
-            if (quote !== '"' && quote !== "'" && quote !== '`')
-                return null;
-            const end = skipJsString(source, valueStart);
-            return source.slice(valueStart + 1, Math.max(valueStart + 1, end - 1));
-        }
-        index += 1;
-    }
-    return null;
-}
-function extractExecCommandLiterals(source) {
-    const commands = [];
-    let index = 0;
-    while (index < source.length) {
-        index = skipJsTrivia(source, index);
-        const char = source[index];
-        if (char === '"' || char === "'" || char === '`') {
-            index = skipJsString(source, index);
-            continue;
-        }
-        if (source.startsWith('tools.exec_command', index)
-            && !/[\w$.]/.test(source[index - 1] ?? '')
-            && !/[\w$]/.test(source[index + 'tools.exec_command'.length] ?? '')) {
-            const command = extractExecCommandLiteral(source, index);
-            if (command)
-                commands.push(command);
-            index += 'tools.exec_command'.length;
-            continue;
-        }
-        index += 1;
-    }
-    return commands;
-}
 function splitShellCommandSegments(command) {
     const segments = [];
     let start = 0;
@@ -375,7 +274,7 @@ export function extractSkillReadFileRef(record) {
                 ? []
                 : part.name === 'Bash'
                     ? [rawCommand]
-                    : extractExecCommandLiterals(rawCommand);
+                    : extractCodexExecCommands(rawCommand);
             for (const command of commands) {
                 const skillRef = extractShellSkillReadRef(command);
                 if (skillRef)
@@ -408,7 +307,7 @@ export function extractSkillScriptCommandRef(record) {
                     : part.input?.code ?? part.input?.command;
                 if (typeof rawCommand === 'string') {
                     texts.push(...(part.name?.toLowerCase() === 'exec'
-                        ? extractExecCommandLiterals(rawCommand)
+                        ? extractCodexExecCommands(rawCommand)
                         : [rawCommand]));
                 }
             }
@@ -465,9 +364,14 @@ export function extractSkillReadFileRefFromEvent(event) {
         || sourceName === 'js'
         || event.tool.name === 'node_repl.js'
         || event.tool.name.toLowerCase() === 'js';
-    const commands = isOrchestrationWrapper
-        ? extractExecCommandLiterals(rawCommand)
-        : [rawCommand];
+    const normalizedCommands = Array.isArray(event.input.commands)
+        ? event.input.commands.filter((value) => typeof value === 'string')
+        : [];
+    const commands = normalizedCommands.length > 0
+        ? normalizedCommands
+        : isOrchestrationWrapper
+            ? extractCodexExecCommands(rawCommand)
+            : [rawCommand];
     for (const command of commands) {
         const skillRef = extractShellSkillReadRef(command);
         if (skillRef)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oh-my-knowledge",
-  "version": "0.51.0",
+  "version": "0.51.1",
   "packageManager": "yarn@4.16.0",
   "description": "Evaluation framework for LLM knowledge inputs — prompts, RAG corpora, skills, agent workflows. Fix the model, vary the artifact. Built-in statistical rigor: bootstrap CI, Krippendorff α, length-debias, saturation curves.",
   "type": "module",