oh-my-knowledge 0.48.0 → 0.49.0

package/dist/observability/soft-standards/llm-extractor.js

@@ -1,18 +1,18 @@
-import { mkdirSync, writeFileSync } from 'node:fs';
 import { createExecutor } from '../../executors/index.js';
 import { readPromptDocument } from '../../shared/llm-prompts/index.js';
-import { DEFAULT_LLM_ENHANCED_REVIEW_MODEL, PROMPTS_DIR, SOFT_STANDARD_PROMPT_ID, SOFT_STANDARD_PROMPT_VERSION, } from './constants.js';
-import { hashText, loadExisting, markStale, SKILL_DERIVED_STANDARDS_SCHEMA_VERSION, skillDerivedStandardsDir, skillDerivedStandardsPath, } from './skill-standards-store.js';
+import { writeJsonFileAtomic } from '../../shared/atomic-json.js';
+import { PROMPTS_DIR, SOFT_STANDARD_PROMPT_ID, SOFT_STANDARD_PROMPT_VERSION, } from './constants.js';
+import { hashText, loadSkillDerivedStandards, markStale, SKILL_DERIVED_STANDARDS_SCHEMA_VERSION, skillDerivedStandardsPath, } from './skill-standards-store.js';
 import { evaluateRuntimeStandardNodes } from './runtime-evaluator.js';
 export async function extractSkillSoftStandards(options) {
     const { observationsDir, skillChain } = options;
-    const model = options.model || DEFAULT_LLM_ENHANCED_REVIEW_MODEL;
-    const executorName = options.executorName || 'claude';
+    const model = options.model;
+    const executorName = options.executorName;
     const generatedAt = options.now || new Date().toISOString();
     const path = skillDerivedStandardsPath(observationsDir, skillChain.skillName);
     const sourceHash = skillChain.definition.content ? hashText(skillChain.definition.content) : undefined;
     const runtimeEvidenceHash = options.runtimeEvidence ? hashText(JSON.stringify(options.runtimeEvidence)) : undefined;
-    const existing = loadExisting(path);
+    const existing = loadSkillDerivedStandards(observationsDir)[skillChain.skillName];
     const promptDocument = readPromptTemplate();
     const hasReviewedStandards = existing?.standards.some((item) => item.status === 'author_confirmed' || item.status === 'rejected' || item.status === 'stale') ?? false;
     const compatibleCache = existing
@@ -21,8 +21,7 @@ export async function extractSkillSoftStandards(options) {
         && existing.promptHash === promptDocument.hash;
     if (existing && hasReviewedStandards && !options.refresh) {
         const stale = markStale(existing, generatedAt);
-        mkdirSync(skillDerivedStandardsDir(observationsDir), { recursive: true });
-        writeFileSync(path, JSON.stringify(stale, null, 2));
+        writeJsonFileAtomic(path, stale);
         return stale;
     }
     if (compatibleCache && !options.refresh && existing.sourceHash === sourceHash && existing.runtimeEvidenceHash === runtimeEvidenceHash)
@@ -62,8 +61,7 @@ export async function extractSkillSoftStandards(options) {
         enhancedReview,
         standards,
     };
-    mkdirSync(skillDerivedStandardsDir(observationsDir), { recursive: true });
-    writeFileSync(path, JSON.stringify(record, null, 2));
+    writeJsonFileAtomic(path, record);
     return record;
 }
 function buildSoftStandardPrompt(skillChain, flags, runtimeEvidence) {

package/dist/observability/soft-standards/skill-standards-store.d.ts

@@ -1,8 +1,9 @@
+import { type ObservationReviewState } from '../review-state.js';
 import type { ResolveSkillStandardsOptions, ResolvedSkillStandards, SkillDerivedStandardStatus, SkillDerivedStandards } from './types.js';
 export declare const SKILL_DERIVED_STANDARDS_SCHEMA_VERSION = 2;
 export declare function skillDerivedStandardsDir(observationsDir: string): string;
 export declare function skillDerivedStandardsPath(observationsDir: string, skillName: string): string;
-export declare function loadSkillDerivedStandards(observationsDir: string): Record<string, SkillDerivedStandards>;
+export declare function loadSkillDerivedStandards(observationsDir: string, reviewState?: ObservationReviewState): Record<string, SkillDerivedStandards>;
 export declare function updateSkillDerivedStandardStatus(observationsDir: string, skillName: string, standardId: string, status: SkillDerivedStandardStatus, now?: string): SkillDerivedStandards;
 export declare function resolveSkillStandards(skillName: string, options: ResolveSkillStandardsOptions): ResolvedSkillStandards;
 export declare function loadExisting(path: string): SkillDerivedStandards | undefined;

package/dist/observability/soft-standards/skill-standards-store.js

@@ -1,7 +1,11 @@
 import { createHash } from 'node:crypto';
-import { existsSync, mkdirSync, readFileSync, readdirSync, writeFileSync } from 'node:fs';
+import { existsSync, readFileSync, readdirSync } from 'node:fs';
 import { join } from 'node:path';
 import { buildObservationSkillChain } from '../skill-chain.js';
+import { ownRecordValue, setOwnRecordValue, } from '../../shared/record-count.js';
+import { loadObservationReviewState, observationReviewStateKey, } from '../review-state.js';
+import { writeJsonFileAtomic } from '../../shared/atomic-json.js';
+import { isRfc3339Timestamp } from '../../shared/timestamp.js';
 export const SKILL_DERIVED_STANDARDS_SCHEMA_VERSION = 2;
 export function skillDerivedStandardsDir(observationsDir) {
     return join(observationsDir, 'skill-derived');
@@ -9,7 +13,7 @@ export function skillDerivedStandardsDir(observationsDir) {
 export function skillDerivedStandardsPath(observationsDir, skillName) {
     return join(skillDerivedStandardsDir(observationsDir), `${safeSkillFileName(skillName)}.json`);
 }
-export function loadSkillDerivedStandards(observationsDir) {
+export function loadSkillDerivedStandards(observationsDir, reviewState = loadObservationReviewState(observationsDir)) {
     const dir = skillDerivedStandardsDir(observationsDir);
     if (!existsSync(dir))
         return {};
@@ -19,8 +23,9 @@ export function loadSkillDerivedStandards(observationsDir) {
             continue;
         try {
             const parsed = normalizeSkillDerivedStandards(JSON.parse(readFileSync(join(dir, file), 'utf-8')));
-            if (parsed)
-                out[parsed.skillName] = parsed;
+            if (parsed) {
+                setOwnRecordValue(out, parsed.skillName, applySoftStandardReviews(parsed, reviewState));
+            }
         }
         catch {
             // Ignore broken cache files; the extraction command can refresh them.
@@ -28,6 +33,28 @@ export function loadSkillDerivedStandards(observationsDir) {
     }
     return out;
 }
+function applySoftStandardReviews(record, reviewState) {
+    const generatedAt = Date.parse(record.generatedAt);
+    return {
+        ...record,
+        standards: record.standards.map((standard) => {
+            if (standard.status === 'stale')
+                return standard;
+            const targetId = `${record.skillName}:${standard.id}`;
+            const entry = reviewState.entries[observationReviewStateKey('soft_standard', targetId)];
+            if (!entry || Date.parse(entry.reviewedAt) < generatedAt)
+                return standard;
+            if (entry.verdict === 'real_issue')
+                return { ...standard, status: 'author_confirmed' };
+            if (entry.verdict === 'not_issue')
+                return { ...standard, status: 'rejected' };
+            if (entry.verdict === 'needs_more_context' || entry.verdict === 'reviewed') {
+                return { ...standard, status: 'pending_review' };
+            }
+            return standard;
+        }),
+    };
+}
 export function updateSkillDerivedStandardStatus(observationsDir, skillName, standardId, status, now = new Date().toISOString()) {
     const filePath = skillDerivedStandardsPath(observationsDir, skillName);
     const existing = loadExisting(filePath);
@@ -46,19 +73,18 @@ export function updateSkillDerivedStandardStatus(observationsDir, skillName, sta
     };
     if (!found)
         throw new Error(`skill derived standard not found: ${standardId}`);
-    mkdirSync(skillDerivedStandardsDir(observationsDir), { recursive: true });
-    writeFileSync(filePath, JSON.stringify(next, null, 2));
+    writeJsonFileAtomic(filePath, next);
     return next;
 }
 export function resolveSkillStandards(skillName, options) {
     const skillChain = options.skillChain ?? buildObservationSkillChain(skillName, options.cwd ?? process.cwd());
     const directDerived = normalizeSkillDerivedStandards(options.derivedStandards);
     const mappedDerived = options.derivedStandards && !isSkillDerivedStandards(options.derivedStandards)
-        ? normalizeSkillDerivedStandards(options.derivedStandards[skillName])
+        ? normalizeSkillDerivedStandards(ownRecordValue(options.derivedStandards, skillName))
         : undefined;
     const derived = directDerived
         ?? mappedDerived
-        ?? loadSkillDerivedStandards(options.observationsDir)[skillName];
+        ?? ownRecordValue(loadSkillDerivedStandards(options.observationsDir), skillName);
     const active = [];
     const candidates = [];
     const hasFrontmatterHardRules = skillChain.healthCheck.hardRules.declared && skillChain.healthCheck.hardRules.rules.length > 0;
@@ -134,7 +160,7 @@ export function isSkillDerivedStandards(value) {
     return normalizeSkillDerivedStandards(value) !== undefined;
 }
 function normalizeSkillDerivedStandards(value) {
-    if (!value || typeof value !== 'object')
+    if (!value || typeof value !== 'object' || Array.isArray(value))
         return undefined;
     const item = value;
     const kind = item.kind === 'observe-skill-derived-standards' ? item.kind : null;
@@ -142,14 +168,23 @@ function normalizeSkillDerivedStandards(value) {
         return undefined;
     if (item.schemaVersion !== SKILL_DERIVED_STANDARDS_SCHEMA_VERSION)
         return undefined;
-    if (typeof item.skillName !== 'string' || typeof item.generatedAt !== 'string' || typeof item.model !== 'string' || typeof item.executor !== 'string') {
+    if (!isNonEmptyString(item.skillName)
+        || !isTimestamp(item.generatedAt)
+        || !isNonEmptyString(item.model)
+        || !isNonEmptyString(item.executor)) {
         return undefined;
     }
-    if (typeof item.promptId !== 'string' || typeof item.promptVersion !== 'string' || !Array.isArray(item.standards))
+    if (!isNonEmptyString(item.promptId) || !isNonEmptyString(item.promptVersion) || !Array.isArray(item.standards))
+        return undefined;
+    const standards = item.standards.map(normalizeSkillDerivedStandard);
+    if (standards.some((record) => record === null))
         return undefined;
-    const standards = item.standards
-        .map(normalizeSkillDerivedStandard)
-        .filter((record) => record !== null);
+    const validStandards = standards;
+    if (new Set(validStandards.map((record) => record.id)).size !== validStandards.length)
+        return undefined;
+    if (item.enhancedReview !== undefined && (!item.enhancedReview || typeof item.enhancedReview !== 'object' || Array.isArray(item.enhancedReview))) {
+        return undefined;
+    }
     return {
         kind: 'observe-skill-derived-standards',
         schemaVersion: SKILL_DERIVED_STANDARDS_SCHEMA_VERSION,
@@ -163,12 +198,12 @@ function normalizeSkillDerivedStandards(value) {
         promptVersion: item.promptVersion,
         ...(typeof item.promptHash === 'string' ? { promptHash: item.promptHash } : {}),
         ...(typeof item.runtimeEvidenceHash === 'string' ? { runtimeEvidenceHash: item.runtimeEvidenceHash } : {}),
-        ...(item.enhancedReview && typeof item.enhancedReview === 'object' ? { enhancedReview: item.enhancedReview } : {}),
-        standards,
+        ...(item.enhancedReview ? { enhancedReview: item.enhancedReview } : {}),
+        standards: validStandards,
     };
 }
 function normalizeSkillDerivedStandard(value) {
-    if (!value || typeof value !== 'object')
+    if (!value || typeof value !== 'object' || Array.isArray(value))
         return null;
     const item = value;
     const standardKind = item.standardKind === 'hard_rule_candidate' || item.standardKind === 'workflow_candidate'
@@ -178,7 +213,7 @@ function normalizeSkillDerivedStandard(value) {
             : null;
     if (!standardKind)
         return null;
-    if (typeof item.id !== 'string' || typeof item.title !== 'string' || typeof item.body !== 'string')
+    if (!isNonEmptyString(item.id) || !isNonEmptyString(item.title) || typeof item.body !== 'string')
         return null;
     if (item.status !== 'pending_review' && item.status !== 'author_confirmed' && item.status !== 'rejected' && item.status !== 'stale') {
         return null;
@@ -200,6 +235,12 @@ function normalizeSkillDerivedStandard(value) {
         evidence: item.evidence,
     };
 }
+function isNonEmptyString(value) {
+    return typeof value === 'string' && value.trim().length > 0;
+}
+function isTimestamp(value) {
+    return isRfc3339Timestamp(value);
+}
 function candidateRank(status) {
     if (status === 'pending_review')
         return 0;

package/dist/observability/soft-standards/types.d.ts

@@ -197,8 +197,8 @@ export interface ExtractSkillSoftStandardsOptions {
     observationsDir: string;
     skillChain: ObservationSkillChain;
     runtimeEvidence?: SkillLlmEnhancedRuntimeEvidence;
-    model?: string;
-    executorName?: string;
+    model: string;
+    executorName: string;
     refresh?: boolean;
     now?: string;
     executor?: ExecutorFn;

package/dist/observability/trace-adapter.d.ts

@@ -1,22 +1,27 @@
 /**
- * cc session JSONL / agent markdown log → omk ResultEntry adapter.
+ * Source traces / agent markdown logs → omk ResultEntry adapter.
  *
  * This file is intentionally thin: source parsing, attribution, and segmentation
  * live in sibling modules so studio/report code does not inherit one large adapter.
  */
-import type { ResultEntry } from '../types/index.js';
-import { type CcSession } from './trace-source.js';
+import type { ResultEntry, TraceIngestionSummary } from '../types/index.js';
+import type { TraceSession } from './trace-ir.js';
 import { type SkillSegment } from './trace-segmenter.js';
 export type { CcAssistantContent, CcAssistantRecord, CcRecord, CcSession, CcUserRecord, CcUserTextContent, CcUserToolResultContent, } from './trace-source.js';
-export { loadCcSessions } from './trace-source.js';
+export type { TraceEvent, TraceLifecycleEvent, TraceMessageEvent, TraceMessageOrigin, TraceSession, TraceToolCallEvent, TraceToolRef, TraceToolResultEvent, TraceToolStatus, TraceUsageEvent, } from './trace-ir.js';
+export type { TraceIngestionSummary } from '../types/index.js';
+export { loadCcSessions, loadTraceCorpus, loadTraceSessions } from './trace-source.js';
 export { extractAttributionSkill, extractAttributionSkillRef, extractCommandSkill, extractCommandSkillRef, extractCommandEnvelopeText, extractMarkdownLogSkill, extractSkillReadFileRef, extractSkillReadFile, extractSkillToolUse, extractSkillToolUseRef, normalizeSkillName, parseSkillRef, stripCommandEnvelopeText, } from './trace-attribution.js';
 export type { SkillSegment } from './trace-segmenter.js';
-export { segmentBySkill, segmentsToResultEntries } from './trace-segmenter.js';
+export { segmentBySkill, segmentTraceBySkill, segmentsToResultEntries, skillSegmentTimestampObserved, UNOBSERVED_TRACE_TIMESTAMP, } from './trace-segmenter.js';
 /**
  * One-stop conversion: trace path → ResultEntry[].
  */
-export declare function ccTracesToResultEntries(path: string): {
+export declare function tracesToResultEntries(path: string): {
     entries: ResultEntry[];
-    sessions: CcSession[];
+    sessions: TraceSession[];
     segments: SkillSegment[];
+    ingestion: TraceIngestionSummary;
 };
+/** @deprecated Use `tracesToResultEntries`. */
+export declare const ccTracesToResultEntries: typeof tracesToResultEntries;

package/dist/observability/trace-adapter.js

@@ -1,20 +1,22 @@
 /**
- * cc session JSONL / agent markdown log → omk ResultEntry adapter.
+ * Source traces / agent markdown logs → omk ResultEntry adapter.
  *
  * This file is intentionally thin: source parsing, attribution, and segmentation
  * live in sibling modules so studio/report code does not inherit one large adapter.
  */
-import { loadCcSessions } from './trace-source.js';
-import { segmentBySkill, segmentsToResultEntries } from './trace-segmenter.js';
-export { loadCcSessions } from './trace-source.js';
+import { loadTraceCorpus } from './trace-source.js';
+import { segmentTraceBySkill, segmentsToResultEntries } from './trace-segmenter.js';
+export { loadCcSessions, loadTraceCorpus, loadTraceSessions } from './trace-source.js';
 export { extractAttributionSkill, extractAttributionSkillRef, extractCommandSkill, extractCommandSkillRef, extractCommandEnvelopeText, extractMarkdownLogSkill, extractSkillReadFileRef, extractSkillReadFile, extractSkillToolUse, extractSkillToolUseRef, normalizeSkillName, parseSkillRef, stripCommandEnvelopeText, } from './trace-attribution.js';
-export { segmentBySkill, segmentsToResultEntries } from './trace-segmenter.js';
+export { segmentBySkill, segmentTraceBySkill, segmentsToResultEntries, skillSegmentTimestampObserved, UNOBSERVED_TRACE_TIMESTAMP, } from './trace-segmenter.js';
 /**
  * One-stop conversion: trace path → ResultEntry[].
  */
-export function ccTracesToResultEntries(path) {
-    const sessions = loadCcSessions(path);
-    const segments = sessions.flatMap(segmentBySkill);
+export function tracesToResultEntries(path) {
+    const { sessions, ingestion } = loadTraceCorpus(path);
+    const segments = sessions.flatMap(segmentTraceBySkill);
     const entries = segmentsToResultEntries(segments);
-    return { entries, sessions, segments };
+    return { entries, sessions, segments, ingestion };
 }
+/** @deprecated Use `tracesToResultEntries`. */
+export const ccTracesToResultEntries = tracesToResultEntries;

package/dist/observability/trace-attribution.d.ts

@@ -1,5 +1,6 @@
 /** Skill attribution rules for trace records. */
 import type { CcAssistantRecord, CcUserRecord } from './trace-source.js';
+import type { TraceMessageEvent, TraceToolCallEvent } from './trace-ir.js';
 export interface SkillRef {
     skillName: string;
     rawSkillRef: string;
@@ -7,10 +8,9 @@ export interface SkillRef {
 }
 export declare function extractMarkdownLogSkill(text: string): string | null;
 /**
- * 归一化 skill 名: 去掉 plugin 前缀, 过滤 cc 内置命令。
+ * 归一化 skill 名：去掉 plugin 前缀并校验稳定身份。
  * - "impeccable:audit" → "audit"
  * - "pbakaus/impeccable:audit" → "audit"
- * - "clear" / "exit" 等 → null(表示不是 skill)
  */
 export declare function normalizeSkillName(raw: string): string | null;
 export declare function parseSkillRef(raw: string): SkillRef | null;
@@ -22,6 +22,7 @@ export declare function extractCommandEnvelopeText(text: string): string | null;
  */
 export declare function extractCommandSkill(record: CcUserRecord): string | null;
 export declare function extractCommandSkillRef(record: CcUserRecord): SkillRef | null;
+export declare function isClaudeBuiltinCommand(raw: string): boolean;
 /**
  * 从 OpenClaw user message 的业务动作标签里提取 skill 名字(信号 4)。
  *
@@ -38,10 +39,11 @@ export declare function extractSkillToolUse(record: CcAssistantRecord): string |
 export declare function extractSkillToolUseRef(record: CcAssistantRecord): SkillRef | null;
 export declare function extractAttributionSkill(record: CcAssistantRecord): string | null;
 export declare function extractAttributionSkillRef(record: CcAssistantRecord): SkillRef | null;
+export declare function isInstalledSkillAssetPath(value: string, skillName: string): boolean;
 /**
- * 从 assistant message 的 Read tool_use 里提取 skill 名字(信号 3, fallback)。
- * 匹配 file_path 形如 ".claude/skills/<name>/SKILL.md"
- * 或 ".openclaw/workspace/skills/<name>/SKILL.md" 的模式。
+ * 从 assistant message 的 Read / Bash tool_use 里提取 skill 名字(信号 3, fallback)。
+ * Codex 通常用 shell 读取 `.agents/skills/<name>/SKILL.md`，Claude Code 与
+ * OpenClaw 则更常用结构化 Read tool；两种形式统一识别。
  * 返回 null 表示没命中。
  */
 export declare function extractSkillReadFile(record: CcAssistantRecord): string | null;
@@ -53,3 +55,9 @@ export declare function extractSkillReadFileRef(record: CcAssistantRecord): Skil
  * 只会直接执行 ~/.openclaw/workspace-main/skills/<skill>/scripts/*.sh。
  */
 export declare function extractSkillScriptCommandRef(record: CcUserRecord | CcAssistantRecord): SkillRef | null;
+export declare function extractCommandSkillRefFromEvent(event: TraceMessageEvent): SkillRef | null;
+export declare function extractBusinessActionSkillRefFromEvent(event: TraceMessageEvent): SkillRef | null;
+export declare function extractAttributionSkillRefFromEvent(event: TraceMessageEvent): SkillRef | null;
+export declare function extractSkillToolUseRefFromEvent(event: TraceToolCallEvent): SkillRef | null;
+export declare function extractSkillReadFileRefFromEvent(event: TraceToolCallEvent): SkillRef | null;
+export declare function extractSkillScriptCommandRefFromEvent(event: TraceMessageEvent | TraceToolCallEvent): SkillRef | null;