oh-my-codex 0.4.1 → 0.4.3

package/dist/verification/__tests__/verifier.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=verifier.test.d.ts.map

package/dist/verification/__tests__/verifier.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"verifier.test.d.ts","sourceRoot":"","sources":["../../../src/verification/__tests__/verifier.test.ts"],"names":[],"mappings":""}

package/dist/verification/__tests__/verifier.test.js

@@ -0,0 +1,94 @@
+import { describe, it } from 'node:test';
+import assert from 'node:assert/strict';
+import { getVerificationInstructions, determineTaskSize, getFixLoopInstructions, } from '../verifier.js';
+describe('determineTaskSize', () => {
+    it('returns small for low file count and line changes', () => {
+        assert.equal(determineTaskSize(1, 10), 'small');
+        assert.equal(determineTaskSize(3, 99), 'small');
+    });
+    it('returns standard for moderate file count and line changes', () => {
+        assert.equal(determineTaskSize(4, 50), 'standard');
+        assert.equal(determineTaskSize(15, 499), 'standard');
+    });
+    it('returns large for high file count', () => {
+        assert.equal(determineTaskSize(16, 100), 'large');
+    });
+    it('returns large for high line changes', () => {
+        assert.equal(determineTaskSize(5, 500), 'large');
+    });
+    it('returns small at exact boundary (3 files, 99 lines)', () => {
+        assert.equal(determineTaskSize(3, 99), 'small');
+    });
+    it('returns standard when file count exceeds small threshold', () => {
+        assert.equal(determineTaskSize(4, 99), 'standard');
+    });
+    it('returns standard when line changes hit 100 but files are low', () => {
+        assert.equal(determineTaskSize(3, 100), 'standard');
+    });
+    it('returns large at exact boundary (15 files, 500 lines)', () => {
+        assert.equal(determineTaskSize(15, 500), 'large');
+    });
+    it('returns large when file count exceeds standard threshold', () => {
+        assert.equal(determineTaskSize(16, 0), 'large');
+    });
+});
+describe('getVerificationInstructions', () => {
+    it('includes the task description in all sizes', () => {
+        const desc = 'Add login button';
+        for (const size of ['small', 'standard', 'large']) {
+            const result = getVerificationInstructions(size, desc);
+            assert.ok(result.includes(desc), `${size} should include task description`);
+        }
+    });
+    it('includes Verification Protocol header for all sizes', () => {
+        for (const size of ['small', 'standard', 'large']) {
+            const result = getVerificationInstructions(size, 'task');
+            assert.ok(result.includes('## Verification Protocol'));
+        }
+    });
+    it('returns small-specific instructions', () => {
+        const result = getVerificationInstructions('small', 'fix typo');
+        assert.ok(result.includes('type checker on modified files'));
+        assert.ok(result.includes('PASS/FAIL'));
+        // Should NOT contain large/standard-specific items
+        assert.ok(!result.includes('Security review'));
+        assert.ok(!result.includes('Run linter'));
+    });
+    it('returns standard-specific instructions', () => {
+        const result = getVerificationInstructions('standard', 'add feature');
+        assert.ok(result.includes('tsc --noEmit'));
+        assert.ok(result.includes('Run linter'));
+        assert.ok(result.includes('regressions'));
+        // Should NOT contain large-specific items
+        assert.ok(!result.includes('Security review'));
+        assert.ok(!result.includes('Performance impact'));
+    });
+    it('returns large-specific instructions', () => {
+        const result = getVerificationInstructions('large', 'refactor auth');
+        assert.ok(result.includes('Security review'));
+        assert.ok(result.includes('Performance impact'));
+        assert.ok(result.includes('API compatibility'));
+        assert.ok(result.includes('confidence level'));
+    });
+});
+describe('getFixLoopInstructions', () => {
+    it('returns instructions with default maxRetries of 3', () => {
+        const result = getFixLoopInstructions();
+        assert.ok(result.includes('Fix-Verify Loop'));
+        assert.ok(result.includes('up to 3 times'));
+        assert.ok(result.includes('after 3 attempts'));
+    });
+    it('respects custom maxRetries', () => {
+        const result = getFixLoopInstructions(5);
+        assert.ok(result.includes('up to 5 times'));
+        assert.ok(result.includes('after 5 attempts'));
+        assert.ok(!result.includes('up to 3 times'));
+    });
+    it('includes escalation guidance', () => {
+        const result = getFixLoopInstructions();
+        assert.ok(result.includes('escalate'));
+        assert.ok(result.includes('What was attempted'));
+        assert.ok(result.includes('Recommended next steps'));
+    });
+});
+//# sourceMappingURL=verifier.test.js.map

package/dist/verification/__tests__/verifier.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"verifier.test.js","sourceRoot":"","sources":["../../../src/verification/__tests__/verifier.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EACL,2BAA2B,EAC3B,iBAAiB,EACjB,sBAAsB,GACvB,MAAM,gBAAgB,CAAC;AAExB,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,OAAO,CAAC,CAAC;QAChD,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,OAAO,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,UAAU,CAAC,CAAC;QACnD,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,EAAE,EAAE,GAAG,CAAC,EAAE,UAAU,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC3C,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,EAAE,EAAE,GAAG,CAAC,EAAE,OAAO,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,OAAO,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,OAAO,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,UAAU,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE,UAAU,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,EAAE,EAAE,GAAG,CAAC,EAAE,OAAO,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,CAAC,KAAK,CAAC,iBAAiB,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,OAAO,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,IAAI,GAAG,kBAAkB,CAAC;QAChC,KAAK,MAAM,IAAI,IAAI,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAU,EAAE,CAAC;YAC3D,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;YACvD,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,GAAG,IAAI,kCAAkC,CAAC,CAAC;QAC9E,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,KAAK,MAAM,IAAI,IAAI,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAU,EAAE,CAAC;YAC3D,MAAM,MAAM,GAAG,2BAA2B,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YACzD,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,0BAA0B,CAAC,CAAC,CAAC;QACzD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,MAAM,GAAG,2BAA2B,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;QAChE,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,gCAAgC,CAAC,CAAC,CAAC;QAC7D,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC,CAAC;QACxC,mDAAmD;QACnD,MAAM,CAAC,EAAE,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC;QAC/C,MAAM,CAAC,EAAE,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,MAAM,GAAG,2BAA2B,CAAC,UAAU,EAAE,aAAa,CAAC,CAAC;QACtE,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,CAAC;QAC3C,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,CAAC;QACzC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC,CAAC;QAC1C,0CAA0C;QAC1C,MAAM,CAAC,EAAE,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC;QAC/C,MAAM,CAAC,EAAE,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,oBAAoB,CAAC,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;QAC7C,MAAM,MAAM,GAAG,2BAA2B,CAAC,OAAO,EAAE,eAAe,CAAC,CAAC;QACrE,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC;QAC9C,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,oBAAoB,CAAC,CAAC,CAAC;QACjD,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,mBAAmB,CAAC,CAAC,CAAC;QAChD,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;QAC3D,MAAM,MAAM,GAAG,sBAAsB,EAAE,CAAC;QACxC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC;QAC9C,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC;QAC5C,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;QACpC,MAAM,MAAM,GAAG,sBAAsB,CAAC,CAAC,CAAC,CAAC;QACzC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC;QAC5C,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC,CAAC;QAC/C,MAAM,CAAC,EAAE,CAAC,CAAC,MAAM,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8BAA8B,EAAE,GAAG,EAAE;QACtC,MAAM,MAAM,GAAG,sBAAsB,EAAE,CAAC;QACxC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC,CAAC;QACvC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,oBAAoB,CAAC,CAAC,CAAC;QACjD,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,wBAAwB,CAAC,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oh-my-codex",
-  "version": "0.4.1",
+  "version": "0.4.3",
   "description": "Multi-agent orchestration layer for OpenAI Codex CLI",
   "type": "module",
   "main": "dist/index.js",

package/scripts/notify-hook.js

@@ -245,11 +245,29 @@ const DEFAULT_STALL_PATTERNS = [
   'if you want',
   'would you like',
   'shall i',
+  'next i can',
   'do you want me to',
   'let me know if',
+  'do you want',
+  'want me to',
+  'let me know',
+  'just let me know',
   'i can also',
+  'i could also',
   'ready to proceed',
   'should i',
+  'whenever you',
+  'say go',
+  'say yes',
+  'type continue',
+  'and i\'ll continue',
+  'and i\'ll proceed',
+  'keep driving',
+  'keep pushing',
+  'move forward',
+  'drive forward',
+  'proceed from here',
+  'i\'ll continue from',
 ];
 
 function normalizeAutoNudgeConfig(raw) {
@@ -289,9 +307,16 @@ async function loadAutoNudgeConfig() {
 
 function detectStallPattern(text, patterns) {
   if (!text || typeof text !== 'string') return false;
-  // Check the last ~500 characters (roughly last 10 lines) for stall phrases
-  const tail = text.slice(-500).toLowerCase();
-  return patterns.some(p => tail.includes(p.toLowerCase()));
+  // Broader tail window (~800 chars / ~15-20 lines) for context
+  const tail = text.slice(-800).toLowerCase();
+  const lowerPatterns = patterns.map(p => p.toLowerCase());
+  // Focus on last few lines where stall prompts typically appear
+  const lines = tail.split('\n').filter(l => l.trim());
+  const hotZone = lines.slice(-3).join('\n');
+  // Primary: check last few lines (highest signal)
+  if (lowerPatterns.some(p => hotZone.includes(p))) return true;
+  // Secondary: check broader tail window
+  return lowerPatterns.some(p => tail.includes(p));
 }
 
 async function capturePane(paneId, lines = 10) {
@@ -1084,6 +1109,133 @@ function parseTeamWorkerEnv(rawValue) {
   return { teamName: match[1], workerName: match[2] };
 }
 
+function resolveAllWorkersIdleCooldownMs() {
+  const raw = safeString(process.env.OMX_TEAM_ALL_IDLE_COOLDOWN_MS || '');
+  const parsed = asNumber(raw);
+  // Default: 60 seconds. Guard against unreasonable values.
+  if (parsed !== null && parsed >= 5_000 && parsed <= 10 * 60_000) return parsed;
+  return 60_000;
+}
+
+async function readWorkerStatusState(stateDir, teamName, workerName) {
+  if (!workerName) return 'unknown';
+  const statusPath = join(stateDir, 'team', teamName, 'workers', workerName, 'status.json');
+  try {
+    if (!existsSync(statusPath)) return 'unknown';
+    const raw = await readFile(statusPath, 'utf-8');
+    const parsed = JSON.parse(raw);
+    if (parsed && typeof parsed.state === 'string') return parsed.state;
+    return 'unknown';
+  } catch {
+    return 'unknown';
+  }
+}
+
+async function readTeamWorkersForIdleCheck(stateDir, teamName) {
+  // Try manifest.v2.json first (preferred), then config.json
+  const manifestPath = join(stateDir, 'team', teamName, 'manifest.v2.json');
+  const configPath = join(stateDir, 'team', teamName, 'config.json');
+  const srcPath = existsSync(manifestPath) ? manifestPath : existsSync(configPath) ? configPath : null;
+  if (!srcPath) return null;
+
+  try {
+    const raw = await readFile(srcPath, 'utf-8');
+    const parsed = JSON.parse(raw);
+    if (!parsed || typeof parsed !== 'object') return null;
+    const workers = parsed.workers;
+    if (!Array.isArray(workers) || workers.length === 0) return null;
+    const tmuxSession = safeString(parsed.tmux_session || '').trim();
+    return { workers, tmuxSession };
+  } catch {
+    return null;
+  }
+}
+
+async function maybeNotifyLeaderAllWorkersIdle({ cwd, stateDir, logsDir, parsedTeamWorker }) {
+  const { teamName, workerName } = parsedTeamWorker;
+  const nowMs = Date.now();
+  const nowIso = new Date(nowMs).toISOString();
+
+  // Only trigger check when this worker is idle
+  const myState = await readWorkerStatusState(stateDir, teamName, workerName);
+  if (myState !== 'idle') return;
+
+  // Read team config to get worker list and leader tmux target
+  const teamInfo = await readTeamWorkersForIdleCheck(stateDir, teamName);
+  if (!teamInfo) return;
+  const { workers, tmuxSession } = teamInfo;
+  if (!tmuxSession) return;
+
+  // Check cooldown to prevent notification spam
+  const idleStatePath = join(stateDir, 'team', teamName, 'all-workers-idle.json');
+  const idleState = (await readJsonIfExists(idleStatePath, null)) || {};
+  const cooldownMs = resolveAllWorkersIdleCooldownMs();
+  const lastNotifiedMs = asNumber(idleState.last_notified_at_ms) ?? 0;
+  if ((nowMs - lastNotifiedMs) < cooldownMs) return;
+
+  // Check if ALL workers are idle (or done)
+  const states = await Promise.all(
+    workers.map(w => readWorkerStatusState(stateDir, teamName, safeString(w && w.name ? w.name : '')))
+  );
+  const allIdle = states.length > 0 && states.every(s => s === 'idle' || s === 'done');
+  if (!allIdle) return;
+
+  const N = workers.length;
+  const message = `[OMX] All ${N} worker${N === 1 ? '' : 's'} idle. Ready for next instructions. ${DEFAULT_MARKER}`;
+
+  try {
+    await runProcess('tmux', ['send-keys', '-t', tmuxSession, '-l', message], 3000);
+    await new Promise(r => setTimeout(r, 100));
+    await runProcess('tmux', ['send-keys', '-t', tmuxSession, 'C-m'], 3000);
+    await new Promise(r => setTimeout(r, 100));
+    await runProcess('tmux', ['send-keys', '-t', tmuxSession, 'C-m'], 3000);
+
+    // Update cooldown state (atomic: use a tmp file pattern)
+    const nextIdleState = {
+      ...idleState,
+      last_notified_at_ms: nowMs,
+      last_notified_at: nowIso,
+      worker_count: N,
+    };
+    await writeFile(idleStatePath, JSON.stringify(nextIdleState, null, 2)).catch(() => {});
+
+    // Emit team event for the notification
+    const eventsDir = join(stateDir, 'team', teamName, 'events');
+    const eventsPath = join(eventsDir, 'events.ndjson');
+    try {
+      await mkdir(eventsDir, { recursive: true });
+      const event = {
+        event_id: `all-idle-${Date.now()}-${Math.random().toString(16).slice(2, 8)}`,
+        team: teamName,
+        type: 'all_workers_idle',
+        worker: workerName,
+        worker_count: N,
+        created_at: nowIso,
+      };
+      await appendFile(eventsPath, JSON.stringify(event) + '\n');
+    } catch { /* best effort */ }
+
+    // Log the notification
+    await logTmuxHookEvent(logsDir, {
+      timestamp: nowIso,
+      type: 'all_workers_idle_notification',
+      team: teamName,
+      tmux_target: tmuxSession,
+      worker: workerName,
+      worker_count: N,
+    });
+  } catch (err) {
+    await logTmuxHookEvent(logsDir, {
+      timestamp: nowIso,
+      type: 'all_workers_idle_notification',
+      team: teamName,
+      tmux_target: tmuxSession,
+      worker: workerName,
+      error: err instanceof Error ? err.message : safeString(err),
+    }).catch(() => {});
+  }
+}
+
 async function dispatchNativeHookEvent(cwd, eventName, payload, context = {}) {
   try {
     const { buildNativeHookEvent } = await import('../dist/hooks/extensibility/events.js');
@@ -1312,6 +1464,15 @@ async function main() {
     }
   }
 
+  // 4.6. Notify leader when all workers are idle (worker session only)
+  if (isTeamWorker && parsedTeamWorker) {
+    try {
+      await maybeNotifyLeaderAllWorkersIdle({ cwd, stateDir, logsDir, parsedTeamWorker });
+    } catch {
+      // Non-critical
+    }
+  }
+
   // 5. Optional tmux prompt injection workaround (non-fatal, opt-in)
   // Skip for team workers - only the lead should inject prompts
   if (!isTeamWorker) {

package/templates/AGENTS.md

@@ -44,7 +44,7 @@ For non-trivial SDK/API/framework usage, delegate to `dependency-expert` to chec
 </delegation_rules>
 
 <child_agent_protocol>
-Codex CLI spawns child agents via the `spawn_agent` tool (requires `collab = true`).
+Codex CLI spawns child agents via the `spawn_agent` tool (requires `multi_agent = true`).
 To inject role-specific behavior, the parent MUST read the role prompt and pass it in the spawned agent message.
 
 Delegation steps: