oh-my-codex 0.21.39 → 0.21.41

package/dist/config/quality-gates.js

@@ -0,0 +1,232 @@
+/**
+ * Custom Quality Gates Configuration (Minimal)
+ *
+ * Supports configurable custom quality gates for workflow stages via .omx-config.json qualityGates property.
+ *
+ * Schema:
+ * {
+ *   "qualityGates": {
+ *     "deep-interview": ["skill-name" | {skill, mode?, model?}, ...],
+ *     "ralplan": ["skill-name" | {skill, mode?, model?}, ...],
+ *     "code-review": ["skill-name" | {skill, mode?, model?}, ...]
+ *   }
+ * }
+ *
+ * Gates are native subagents that run alongside standard reviewers.
+ * Missing skills produce visible warnings and are skipped.
+ */
+import { existsSync, readFileSync } from 'fs';
+import { join } from 'path';
+import { codexHome } from '../utils/paths.js';
+import { REMOVED_SKILLS } from '../hooks/sunset-stub.js';
+/**
+ * Reserved skill names that cannot be used as gates
+ * These are built-in skills managed by OMX
+ */
+const RESERVED_SKILL_NAMES = new Set([
+    'ai-slop-cleaner',
+    'verification',
+    'code-review',
+    'deep-interview',
+]);
+/**
+ * Sunset/deprecated skill names from sunset-stub.ts
+ */
+function getSunsetSkillNames() {
+    return new Set(Object.keys(REMOVED_SKILLS).map(k => k.toLowerCase()));
+}
+/**
+ * Validate skill name: must be kebab-case, not reserved, not sunset
+ */
+export function validateSkillName(skill) {
+    if (!skill || typeof skill !== 'string') {
+        return { valid: false, error: 'Skill name must be a non-empty string' };
+    }
+    // Check kebab-case format (including leading $ for skill references)
+    const normalized = skill.startsWith('$') ? skill.slice(1) : skill;
+    if (!normalized || !/^[a-z0-9]+(?:-[a-z0-9]+)*$/.test(normalized)) {
+        return { valid: false, error: 'Skill name must be kebab-case (lowercase with hyphens), optionally prefixed with $' };
+    }
+    // Check reserved names
+    if (RESERVED_SKILL_NAMES.has(normalized)) {
+        return { valid: false, error: `Skill "${skill}" is reserved for built-in gates` };
+    }
+    // Check sunset names
+    const sunsetNames = getSunsetSkillNames();
+    if (sunsetNames.has(normalized.toLowerCase())) {
+        return { valid: false, error: `Skill "${skill}" is deprecated and no longer supported` };
+    }
+    return { valid: true };
+}
+/**
+ * Normalize a gate entry (string or object) to the standard internal representation
+ */
+export function normalizeGateEntry(entry) {
+    let skill;
+    let mode = 'blocking';
+    let model;
+    if (typeof entry === 'string') {
+        skill = entry;
+    }
+    else if (entry && typeof entry === 'object' && !Array.isArray(entry)) {
+        const obj = entry;
+        if (!obj.skill || typeof obj.skill !== 'string') {
+            return null;
+        }
+        skill = obj.skill;
+        if (obj.mode && typeof obj.mode === 'string') {
+            if (!['blocking', 'advisory'].includes(obj.mode)) {
+                return null; // Invalid mode
+            }
+            mode = obj.mode;
+        }
+        if (obj.model && typeof obj.model === 'string') {
+            model = obj.model;
+        }
+    }
+    else {
+        return null; // Invalid entry format
+    }
+    // Validate skill name
+    const validation = validateSkillName(skill);
+    if (!validation.valid) {
+        return null;
+    }
+    // Return object without model field if it's undefined
+    const result = { skill, mode };
+    if (model !== undefined) {
+        result.model = model;
+    }
+    return result;
+}
+/**
+ * Read quality gates configuration from .omx-config.json
+ * Reads from both project ./.omx-config.json (if cwd provided) and $CODEX_HOME/.omx-config.json
+ * Project config takes precedence over CODEX_HOME config for the same stage
+ */
+export function readQualityGatesConfig(codexHomeOverride, cwd) {
+    const result = {};
+    let hasConfig = false;
+    // Read CODEX_HOME config first (lower precedence)
+    const codexHomePath = join(codexHomeOverride || codexHome(), '.omx-config.json');
+    if (existsSync(codexHomePath)) {
+        try {
+            const raw = JSON.parse(readFileSync(codexHomePath, 'utf-8'));
+            if (raw && typeof raw === 'object' && !Array.isArray(raw)) {
+                const qualityGates = raw.qualityGates;
+                if (qualityGates && typeof qualityGates === 'object' && !Array.isArray(qualityGates)) {
+                    const codexHomeGates = qualityGates;
+                    for (const [stage, gates] of Object.entries(codexHomeGates)) {
+                        if (gates) {
+                            result[stage] = gates;
+                            hasConfig = true;
+                        }
+                    }
+                }
+            }
+        }
+        catch {
+            // Silently ignore parse errors in CODEX_HOME config
+        }
+    }
+    // Read project config (higher precedence - overwrites CODEX_HOME)
+    if (cwd) {
+        const projectConfigPath = join(cwd, '.omx-config.json');
+        if (existsSync(projectConfigPath)) {
+            try {
+                const raw = JSON.parse(readFileSync(projectConfigPath, 'utf-8'));
+                if (raw && typeof raw === 'object' && !Array.isArray(raw)) {
+                    const qualityGates = raw.qualityGates;
+                    if (qualityGates && typeof qualityGates === 'object' && !Array.isArray(qualityGates)) {
+                        const projectGates = qualityGates;
+                        for (const [stage, gates] of Object.entries(projectGates)) {
+                            if (gates) {
+                                result[stage] = gates;
+                                hasConfig = true;
+                            }
+                        }
+                    }
+                }
+            }
+            catch {
+                // Silently ignore parse errors in project config
+            }
+        }
+    }
+    return hasConfig ? result : null;
+}
+/**
+ * Get normalized quality gates for a specific stage
+ * Returns array of validated and normalized gate entries
+ * Reads from both project and CODEX_HOME config with project taking precedence
+ */
+export function getGatesForStage(stage, codexHomeOverride, cwd) {
+    const config = readQualityGatesConfig(codexHomeOverride, cwd);
+    const stageGates = config?.[stage];
+    if (!stageGates || !Array.isArray(stageGates)) {
+        return [];
+    }
+    // Normalize and filter to valid entries
+    return stageGates
+        .map(entry => normalizeGateEntry(entry))
+        .filter((gate) => gate !== null);
+}
+/**
+ * Validate all gates in the configuration file
+ * Returns validated gates and list of validation errors
+ * Reads from both project and CODEX_HOME config with project taking precedence
+ */
+export function validateAllQualityGates(codexHomeOverride, cwd) {
+    const gates = [];
+    const errors = [];
+    const config = readQualityGatesConfig(codexHomeOverride, cwd);
+    if (!config) {
+        return { gates, errors };
+    }
+    const stages = ['deep-interview', 'ralplan', 'code-review'];
+    for (const stage of stages) {
+        const stageGates = config[stage];
+        if (!stageGates || !Array.isArray(stageGates))
+            continue;
+        for (let i = 0; i < stageGates.length; i++) {
+            const entry = stageGates[i];
+            const entryStr = typeof entry === 'string' ? entry : JSON.stringify(entry);
+            const normalized = normalizeGateEntry(entry);
+            if (normalized) {
+                gates.push(normalized);
+            }
+            else {
+                let error = 'Invalid gate entry';
+                if (typeof entry === 'string') {
+                    error = validateSkillName(entry).error || 'Invalid skill';
+                }
+                else if (entry && typeof entry === 'object' && !Array.isArray(entry)) {
+                    const obj = entry;
+                    if (!obj || !obj.skill) {
+                        error = 'Gate object must have a "skill" property';
+                    }
+                    else if (typeof obj.skill !== 'string') {
+                        error = 'Gate skill must be a string';
+                    }
+                    else if (obj.mode && !['blocking', 'advisory'].includes(obj.mode)) {
+                        error = `Invalid mode: ${obj.mode}; must be 'blocking' or 'advisory'`;
+                    }
+                    else {
+                        error = validateSkillName(obj.skill).error || 'Invalid skill';
+                    }
+                }
+                else {
+                    error = 'Gate entry must be a string or object with {skill, mode?, model?}';
+                }
+                errors.push({
+                    stage,
+                    skillIndex: i,
+                    entry: entryStr,
+                    error,
+                });
+            }
+        }
+    }
+    return { gates, errors };
+}
+//# sourceMappingURL=quality-gates.js.map

package/dist/config/quality-gates.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quality-gates.js","sourceRoot":"","sources":["../../src/config/quality-gates.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,IAAI,CAAC;AAC9C,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,SAAS,EAAE,MAAM,mBAAmB,CAAC;AAC9C,OAAO,EAAE,cAAc,EAAE,MAAM,yBAAyB,CAAC;AAiDzD;;;GAGG;AACH,MAAM,oBAAoB,GAAG,IAAI,GAAG,CAAC;IACnC,iBAAiB;IACjB,cAAc;IACd,aAAa;IACb,gBAAgB;CACjB,CAAC,CAAC;AAEH;;GAEG;AACH,SAAS,mBAAmB;IAC1B,OAAO,IAAI,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC;AACxE,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,iBAAiB,CAAC,KAAa;IAC7C,IAAI,CAAC,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QACxC,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,uCAAuC,EAAE,CAAC;IAC1E,CAAC;IAED,qEAAqE;IACrE,MAAM,UAAU,GAAG,KAAK,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC;IAClE,IAAI,CAAC,UAAU,IAAI,CAAC,4BAA4B,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;QAClE,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,oFAAoF,EAAE,CAAC;IACvH,CAAC;IAED,uBAAuB;IACvB,IAAI,oBAAoB,CAAC,GAAG,CAAC,UAAU,CAAC,EAAE,CAAC;QACzC,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,UAAU,KAAK,kCAAkC,EAAE,CAAC;IACpF,CAAC;IAED,qBAAqB;IACrB,MAAM,WAAW,GAAG,mBAAmB,EAAE,CAAC;IAC1C,IAAI,WAAW,CAAC,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC,EAAE,CAAC;QAC9C,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,UAAU,KAAK,yCAAyC,EAAE,CAAC;IAC3F,CAAC;IAED,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;AACzB,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,kBAAkB,CAAC,KAAc;IAC/C,IAAI,KAAa,CAAC;IAClB,IAAI,IAAI,GAA4B,UAAU,CAAC;IAC/C,IAAI,KAAyB,CAAC;IAE9B,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;QAC9B,KAAK,GAAG,KAAK,CAAC;IAChB,CAAC;SAAM,IAAI,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QACvE,MAAM,GAAG,GAAG,KAAgC,CAAC;QAC7C,IAAI,CAAC,GAAG,CAAC,KAAK,IAAI,OAAO,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;YAChD,OAAO,IAAI,CAAC;QACd,CAAC;QACD,KAAK,GAAG,GAAG,CAAC,KAAK,CAAC;QAClB,IAAI,GAAG,CAAC,IAAI,IAAI,OAAO,GAAG,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YAC7C,IAAI,CAAC,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;gBACjD,OAAO,IAAI,CAAC,CAAC,eAAe;YAC9B,CAAC;YACD,IAAI,GAAG,GAAG,CAAC,IAA+B,CAAC;QAC7C,CAAC;QACD,IAAI,GAAG,CAAC,KAAK,IAAI,OAAO,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;YAC/C,KAAK,GAAG,GAAG,CAAC,KAAK,CAAC;QACpB,CAAC;IACH,CAAC;SAAM,CAAC;QACN,OAAO,IAAI,CAAC,CAAC,uBAAuB;IACtC,CAAC;IAED,sBAAsB;IACtB,MAAM,UAAU,GAAG,iBAAiB,CAAC,KAAK,CAAC,CAAC;IAC5C,IAAI,CAAC,UAAU,CAAC,KAAK,EAAE,CAAC;QACtB,OAAO,IAAI,CAAC;IACd,CAAC;IAED,sDAAsD;IACtD,MAAM,MAAM,GAAmB,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;IAC/C,IAAI,KAAK,KAAK,SAAS,EAAE,CAAC;QACxB,MAAM,CAAC,KAAK,GAAG,KAAK,CAAC;IACvB,CAAC;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,sBAAsB,CAAC,iBAA0B,EAAE,GAAY;IAC7E,MAAM,MAAM,GAAuB,EAAE,CAAC;IACtC,IAAI,SAAS,GAAG,KAAK,CAAC;IAEtB,kDAAkD;IAClD,MAAM,aAAa,GAAG,IAAI,CAAC,iBAAiB,IAAI,SAAS,EAAE,EAAE,kBAAkB,CAAC,CAAC;IACjF,IAAI,UAAU,CAAC,aAAa,CAAC,EAAE,CAAC;QAC9B,IAAI,CAAC;YACH,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,aAAa,EAAE,OAAO,CAAC,CAAC,CAAC;YAC7D,IAAI,GAAG,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;gBAC1D,MAAM,YAAY,GAAG,GAAG,CAAC,YAAY,CAAC;gBACtC,IAAI,YAAY,IAAI,OAAO,YAAY,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,CAAC;oBACrF,MAAM,cAAc,GAAG,YAAkC,CAAC;oBAC1D,KAAK,MAAM,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,CAAC;wBAC5D,IAAI,KAAK,EAAE,CAAC;4BACV,MAAM,CAAC,KAAyB,CAAC,GAAG,KAAK,CAAC;4BAC1C,SAAS,GAAG,IAAI,CAAC;wBACnB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,oDAAoD;QACtD,CAAC;IACH,CAAC;IAED,kEAAkE;IAClE,IAAI,GAAG,EAAE,CAAC;QACR,MAAM,iBAAiB,GAAG,IAAI,CAAC,GAAG,EAAE,kBAAkB,CAAC,CAAC;QACxD,IAAI,UAAU,CAAC,iBAAiB,CAAC,EAAE,CAAC;YAClC,IAAI,CAAC;gBACH,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,iBAAiB,EAAE,OAAO,CAAC,CAAC,CAAC;gBACjE,IAAI,GAAG,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1D,MAAM,YAAY,GAAG,GAAG,CAAC,YAAY,CAAC;oBACtC,IAAI,YAAY,IAAI,OAAO,YAAY,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,CAAC;wBACrF,MAAM,YAAY,GAAG,YAAkC,CAAC;wBACxD,KAAK,MAAM,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,YAAY,CAAC,EAAE,CAAC;4BAC1D,IAAI,KAAK,EAAE,CAAC;gCACV,MAAM,CAAC,KAAyB,CAAC,GAAG,KAAK,CAAC;gCAC1C,SAAS,GAAG,IAAI,CAAC;4BACnB,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YAAC,MAAM,CAAC;gBACP,iDAAiD;YACnD,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC;AACnC,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,gBAAgB,CAAC,KAAuB,EAAE,iBAA0B,EAAE,GAAY;IAChG,MAAM,MAAM,GAAG,sBAAsB,CAAC,iBAAiB,EAAE,GAAG,CAAC,CAAC;IAC9D,MAAM,UAAU,GAAG,MAAM,EAAE,CAAC,KAAK,CAAC,CAAC;IAEnC,IAAI,CAAC,UAAU,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,EAAE,CAAC;QAC9C,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,wCAAwC;IACxC,OAAO,UAAU;SACd,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC,kBAAkB,CAAC,KAAK,CAAC,CAAC;SACvC,MAAM,CAAC,CAAC,IAAI,EAA0B,EAAE,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;AAC7D,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,uBAAuB,CAAC,iBAA0B,EAAE,GAAY;IAI9E,MAAM,KAAK,GAAqB,EAAE,CAAC;IACnC,MAAM,MAAM,GAAyF,EAAE,CAAC;IAExG,MAAM,MAAM,GAAG,sBAAsB,CAAC,iBAAiB,EAAE,GAAG,CAAC,CAAC;IAC9D,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;IAC3B,CAAC;IAED,MAAM,MAAM,GAAuB,CAAC,gBAAgB,EAAE,SAAS,EAAE,aAAa,CAAC,CAAC;IAChF,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,MAAM,UAAU,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;QACjC,IAAI,CAAC,UAAU,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC;YAAE,SAAS;QAExD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,UAAU,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YAC3C,MAAM,KAAK,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;YAC5B,MAAM,QAAQ,GAAG,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;YAE3E,MAAM,UAAU,GAAG,kBAAkB,CAAC,KAAK,CAAC,CAAC;YAC7C,IAAI,UAAU,EAAE,CAAC;gBACf,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACzB,CAAC;iBAAM,CAAC;gBACN,IAAI,KAAK,GAAG,oBAAoB,CAAC;gBAEjC,IAAI,OAAO,KAAK,KAAK,QAAQ,EAAE,CAAC;oBAC9B,KAAK,GAAG,iBAAiB,CAAC,KAAK,CAAC,CAAC,KAAK,IAAI,eAAe,CAAC;gBAC5D,CAAC;qBAAM,IAAI,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;oBACvE,MAAM,GAAG,GAAG,KAA2C,CAAC;oBACxD,IAAI,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,KAAK,EAAE,CAAC;wBACvB,KAAK,GAAG,0CAA0C,CAAC;oBACrD,CAAC;yBAAM,IAAI,OAAO,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;wBACzC,KAAK,GAAG,6BAA6B,CAAC;oBACxC,CAAC;yBAAM,IAAI,GAAG,CAAC,IAAI,IAAI,CAAC,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAc,CAAC,EAAE,CAAC;wBAC9E,KAAK,GAAG,iBAAiB,GAAG,CAAC,IAAI,oCAAoC,CAAC;oBACxE,CAAC;yBAAM,CAAC;wBACN,KAAK,GAAG,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,KAAK,IAAI,eAAe,CAAC;oBAChE,CAAC;gBACH,CAAC;qBAAM,CAAC;oBACN,KAAK,GAAG,mEAAmE,CAAC;gBAC9E,CAAC;gBAED,MAAM,CAAC,IAAI,CAAC;oBACV,KAAK;oBACL,UAAU,EAAE,CAAC;oBACb,KAAK,EAAE,QAAQ;oBACf,KAAK;iBACN,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;AAC3B,CAAC"}

package/dist/hooks/__tests__/code-review-skill-contract.test.js

@@ -46,8 +46,8 @@ describe('code-review skill contract', () => {
         assert.match(codeReviewSkill, /Else if `code-reviewer` recommendation is \*\*REQUEST CHANGES\*\*, final recommendation is \*\*REQUEST CHANGES\*\*/i);
         assert.match(codeReviewSkill, /Else if architect status is \*\*WATCH\*\*, final recommendation is \*\*COMMENT\*\*/i);
         assert.match(codeReviewSkill, /Else final recommendation follows the `code-reviewer` lane/i);
-        assert.match(codeReviewSkill, /\*\*APPROVE\*\* only when `code-reviewer` returns APPROVE, architect status is `CLEAR`, and both independent lanes returned evidence/i);
-        assert.match(codeReviewSkill, /\*\*REQUEST CHANGES\*\* for a blocker, unresolved high\/critical finding, or unavailable lane/i);
+        assert.match(codeReviewSkill, /\*\*APPROVE\*\* only when `code-reviewer` returns APPROVE, architect status is `CLEAR`, both independent lanes returned evidence/i);
+        assert.match(codeReviewSkill, /\*\*REQUEST CHANGES\*\* for a blocker, unresolved high\/critical finding, unavailable lane, or non-passing\/unavailable blocking quality gate/i);
     });
     it('bounds auto-fix wording to the supported omx ralph compatibility path only', () => {
         assert.match(codeReviewSkill, /On the supported `omx ralph` CLI compatibility path/i);

package/dist/hooks/__tests__/code-review-skill-contract.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"code-review-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/code-review-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,eAAe,GAAG,YAAY,CAClC,IAAI,CAAC,SAAS,EAAE,sCAAsC,CAAC,EACvD,OAAO,CACR,CAAC;AAEF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,gFAAgF,EAAE,GAAG,EAAE;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gEAAgE,CAAC,CAAC;QAChG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kFAAkF,CAAC,CAAC;QAClH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,yGAAyG,CAAC,CAAC;QACzI,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mEAAmE,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,iDAAiD,CAAC,CAAC;QACjF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6CAA6C,CAAC,CAAC;QAC7E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QAC7G,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QACzG,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,qBAAqB,CAAC,CAAC;QAC5D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,GAAG,EAAE;QACnF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sBAAsB,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gCAAgC,CAAC,CAAC;QAChE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gDAAgD,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;IAC1H,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kBAAkB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QACtG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+DAA+D,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mCAAmC,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;QACxH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qHAAqH,CAAC,CAAC;QACrJ,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;QACrH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6DAA6D,CAAC,CAAC;QAC7F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,uIAAuI,CAAC,CAAC;QACvK,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gGAAgG,CAAC,CAAC;IAClI,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4EAA4E,EAAE,GAAG,EAAE;QACpF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4DAA4D,CAAC,CAAC;QAC5F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;IACvH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,sBAAsB,CAAC,CAAC;QAClE,MAAM,aAAa,GAAG,eAAe,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,aAAa,CAAC,CAAC;QAC7C,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;QAC3D,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,mBAAmB,CAAC,CAAC;QAC/D,MAAM,QAAQ,GAAG,eAAe,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QACzD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0BAA0B,CAAC,CAAC;QAC1D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,oCAAoC,CAAC,CAAC;QAC3E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,4BAA4B,CAAC,CAAC;QACnE,MAAM,CAAC,EAAE,CAAC,WAAW,IAAI,aAAa,IAAI,SAAS,IAAI,WAAW,IAAI,QAAQ,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CACV,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,EACtB,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACpB,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CACtB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"code-review-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/code-review-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,eAAe,GAAG,YAAY,CAClC,IAAI,CAAC,SAAS,EAAE,sCAAsC,CAAC,EACvD,OAAO,CACR,CAAC;AAEF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,gFAAgF,EAAE,GAAG,EAAE;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gEAAgE,CAAC,CAAC;QAChG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kFAAkF,CAAC,CAAC;QAClH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,yGAAyG,CAAC,CAAC;QACzI,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mEAAmE,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,iDAAiD,CAAC,CAAC;QACjF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6CAA6C,CAAC,CAAC;QAC7E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QAC7G,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QACzG,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,qBAAqB,CAAC,CAAC;QAC5D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,GAAG,EAAE;QACnF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sBAAsB,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gCAAgC,CAAC,CAAC;QAChE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gDAAgD,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;IAC1H,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kBAAkB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QACtG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+DAA+D,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mCAAmC,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;QACxH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qHAAqH,CAAC,CAAC;QACrJ,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;QACrH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6DAA6D,CAAC,CAAC;QAC7F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mIAAmI,CAAC,CAAC;QACnK,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gJAAgJ,CAAC,CAAC;IAClL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4EAA4E,EAAE,GAAG,EAAE;QACpF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4DAA4D,CAAC,CAAC;QAC5F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;IACvH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,sBAAsB,CAAC,CAAC;QAClE,MAAM,aAAa,GAAG,eAAe,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,aAAa,CAAC,CAAC;QAC7C,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;QAC3D,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,mBAAmB,CAAC,CAAC;QAC/D,MAAM,QAAQ,GAAG,eAAe,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QACzD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0BAA0B,CAAC,CAAC;QAC1D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,oCAAoC,CAAC,CAAC;QAC3E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,4BAA4B,CAAC,CAAC;QACnE,MAAM,CAAC,EAAE,CAAC,WAAW,IAAI,aAAa,IAAI,SAAS,IAAI,WAAW,IAAI,QAAQ,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CACV,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,EACtB,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACpB,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CACtB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/hooks/__tests__/session.test.js

@@ -1,6 +1,7 @@
 import { describe, it } from 'node:test';
 import assert from 'node:assert/strict';
 import { spawn } from 'node:child_process';
+import { createHash } from 'node:crypto';
 import { once } from 'node:events';
 import { existsSync } from 'node:fs';
 import { link, lstat, mkdir, mkdtemp, readFile, readdir, readlink, rename, rm, symlink, writeFile } from 'node:fs/promises';
@@ -68,6 +69,38 @@ async function withOwnerEnvironment(sessionId, run) {
             process.env.OMX_SESSION_ID = previous;
     }
 }
+async function withEnvironment(values, run) {
+    const previous = new Map(Object.keys(values).map((key) => [key, process.env[key]]));
+    for (const [key, value] of Object.entries(values)) {
+        if (value === undefined)
+            delete process.env[key];
+        else
+            process.env[key] = value;
+    }
+    try {
+        await run();
+    }
+    finally {
+        for (const [key, value] of previous) {
+            if (value === undefined)
+                delete process.env[key];
+            else
+                process.env[key] = value;
+        }
+    }
+}
+const MANAGED_CODEX_DAEMON_CMDLINE = '/home/test/.codex/packages/app-server/bin/codex app-server --remote-control --listen unix:// --managed-daemon';
+function linuxProcessObservation(cmdline, birth) {
+    return {
+        kind: 'identity',
+        cmdline,
+        identity: {
+            platform: 'linux',
+            birth,
+            cmdline_hash: createHash('sha256').update(cmdline).digest('hex'),
+        },
+    };
+}
 /**
  * Identity fields for a pointer that belongs to the HOST platform.
  *
@@ -774,7 +807,7 @@ describe('isSessionStale', () => {
         }), false);
     });
 });
-describe('verified-dead selected session pointer recovery', { concurrency: false }, () => {
+describe('selected session pointer recovery', { concurrency: false }, () => {
     async function writePointer(cwd, overrides = {}) {
         const context = resolveSessionPointerContext(cwd);
         await mkdir(context.baseStateDir, { recursive: true });
@@ -789,6 +822,152 @@ describe('verified-dead selected session pointer recovery', { concurrency: false
         await writeFile(context.sessionPath, body, 'utf-8');
         return { path: context.sessionPath, body };
     }
+    async function writeManagedDaemonPointer(cwd) {
+        const context = resolveSessionPointerContext(cwd);
+        await mkdir(context.baseStateDir, { recursive: true });
+        const body = JSON.stringify({
+            session_id: '01a18453-9e49-7c21-9c51-cf411286e627',
+            native_session_id: '01a18453-9e49-7c21-9c51-cf411286e627',
+            started_at: '2026-10-28T23:03:37.205Z',
+            cwd,
+            state_root: context.baseStateDir,
+            pid: 57617,
+            platform: 'linux',
+            identity_schema_version: 2,
+            process_identity: linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768').identity,
+            pid_start_ticks: 87768,
+            pid_cmdline: MANAGED_CODEX_DAEMON_CMDLINE,
+        });
+        await writeFile(context.sessionPath, body, 'utf-8');
+        return { path: context.sessionPath, body };
+    }
+    it('lets resume replace a live managed-daemon owner without inheriting a stale OMX selector', async () => {
+        const root = await mkdtemp(join(tmpdir(), 'omx-session-pointer-daemon-resume-'));
+        const cwd = join(root, 'workspace');
+        const home = join(root, 'home');
+        const codexHome = join(root, 'codex-home');
+        const omxRoot = join(root, 'omx-root');
+        await mkdir(cwd, { recursive: true });
+        try {
+            await withEnvironment({
+                HOME: home,
+                CODEX_HOME: codexHome,
+                OMX_ROOT: omxRoot,
+                OMX_SESSION_ID: 'omx-inherited-stale',
+            }, async () => {
+                const pointer = await writeManagedDaemonPointer(cwd);
+                await withPointerDependencies({
+                    runtimePlatform: 'linux',
+                    probePid: () => 'alive',
+                    observeProcess: () => linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768'),
+                }, async () => {
+                    const context = resolveSessionPointerContext(cwd);
+                    assert.equal((await readSessionPointer(context)).status, 'non-runtime-owner');
+                    const established = await establishLaunchSessionBinding(cwd, 'omx-resume-after-daemon');
+                    assert.equal(established.kind, 'committed-released');
+                    if (established.kind !== 'committed-released')
+                        return;
+                    const resumedState = await readSessionState(cwd);
+                    assert.equal(resumedState?.session_id, 'omx-resume-after-daemon');
+                    assert.equal(resumedState?.owner_omx_session_id, undefined, 'unverified inherited OMX_SESSION_ID must not become owner authority');
+                    assert.equal(await closeLaunchSessionBindingOnce(established.binding).then((result) => result.status), 'closed');
+                });
+                assert.notEqual(await readFile(pointer.path, 'utf-8'), pointer.body);
+            });
+        }
+        finally {
+            await rm(root, { recursive: true, force: true });
+        }
+    });
+    it('quarantines a live managed-daemon pointer and permits a subsequent launch without stopping the daemon', async () => {
+        const root = await mkdtemp(join(tmpdir(), 'omx-session-pointer-daemon-recover-'));
+        const cwd = join(root, 'workspace');
+        await mkdir(cwd, { recursive: true });
+        try {
+            await withEnvironment({
+                HOME: join(root, 'home'),
+                CODEX_HOME: join(root, 'codex-home'),
+                OMX_ROOT: join(root, 'omx-root'),
+                OMX_SESSION_ID: 'omx-inherited-stale',
+            }, async () => {
+                const pointer = await writeManagedDaemonPointer(cwd);
+                await withPointerDependencies({
+                    runtimePlatform: 'linux',
+                    probePid: () => 'alive',
+                    observeProcess: () => linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768'),
+                    token: () => SUCCESSOR_TOKEN,
+                }, async () => {
+                    const recovered = await recoverDeadSessionPointer(cwd);
+                    assert.equal(recovered.status, 'recovered', recovered.reason);
+                    assert.equal(recovered.recovered, true);
+                    assert.match(recovered.reason, /managed Codex daemon/);
+                    assert.ok(recovered.quarantinePath);
+                    assert.equal(await readFile(recovered.quarantinePath, 'utf-8'), pointer.body);
+                    assert.equal((await readSessionPointer(resolveSessionPointerContext(cwd))).status, 'absent');
+                    const established = await establishLaunchSessionBinding(cwd, 'omx-resume-after-recovery');
+                    assert.equal(established.kind, 'committed-released');
+                    if (established.kind === 'committed-released') {
+                        assert.equal(await closeLaunchSessionBindingOnce(established.binding).then((result) => result.status), 'closed');
+                    }
+                });
+            });
+        }
+        finally {
+            await rm(root, { recursive: true, force: true });
+        }
+    });
+    it('continues refusing recovery and a fresh launch for a live interactive OMX owner', async () => {
+        const root = await mkdtemp(join(tmpdir(), 'omx-session-pointer-interactive-owner-'));
+        const cwd = join(root, 'workspace');
+        const interactiveCmdline = '/home/test/.local/bin/codex resume active-conversation';
+        const interactiveObservation = linuxProcessObservation(interactiveCmdline, '99123');
+        await mkdir(cwd, { recursive: true });
+        try {
+            await withEnvironment({
+                HOME: join(root, 'home'),
+                CODEX_HOME: join(root, 'codex-home'),
+                OMX_ROOT: join(root, 'omx-root'),
+                OMX_SESSION_ID: undefined,
+            }, async () => {
+                const context = resolveSessionPointerContext(cwd);
+                await mkdir(context.baseStateDir, { recursive: true });
+                const pointerBody = JSON.stringify({
+                    session_id: 'omx-live-interactive',
+                    owner_omx_session_id: 'omx-live-interactive',
+                    launch_lineage_token: TEST_TOKEN,
+                    started_at: '2026-10-28T23:03:37.205Z',
+                    cwd,
+                    state_root: context.baseStateDir,
+                    pid: 57618,
+                    platform: 'linux',
+                    identity_schema_version: 2,
+                    process_identity: interactiveObservation.identity,
+                    pid_start_ticks: 99123,
+                    pid_cmdline: interactiveCmdline,
+                });
+                await writeFile(context.sessionPath, pointerBody, 'utf-8');
+                await withPointerDependencies({
+                    runtimePlatform: 'linux',
+                    probePid: () => 'alive',
+                    observeProcess: () => interactiveObservation,
+                }, async () => {
+                    const established = await establishLaunchSessionBinding(cwd, 'omx-competing-launch');
+                    assert.equal(established.kind, 'precommit-aborted');
+                    if (established.kind === 'precommit-aborted')
+                        assert.equal(established.abort.code, 'session_pointer_owner_conflict');
+                    const refused = await recoverDeadSessionPointer(cwd);
+                    assert.equal(refused.status, 'usable');
+                    assert.equal(refused.recovered, false);
+                    assert.equal(refused.action, 'none');
+                    assert.match(refused.reason, /usable or live/);
+                });
+                assert.equal(await readFile(context.sessionPath, 'utf-8'), pointerBody);
+            });
+        }
+        finally {
+            await rm(root, { recursive: true, force: true });
+        }
+    });
     it('quarantines exact dead evidence, is idempotent, and permits relaunch', async () => {
         const cwd = await mkdtemp(join(tmpdir(), 'omx-session-pointer-recover-dead-'));
         try {
@@ -3451,6 +3630,137 @@ describe('session pointer transaction', () => {
             await rm(cwd, { recursive: true, force: true });
         }
     });
+    it('preserves managed-daemon owner sidecars without publishing them as canonical runtime owners', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-session-daemon-owner-sidecar-'));
+        const nativeSessionId = 'native-daemon-sidecar';
+        const observation = linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768');
+        try {
+            const context = resolveSessionPointerContext(cwd);
+            const sidecarDir = join(context.baseStateDir, 'sessions', nativeSessionId);
+            const sidecarPath = join(sidecarDir, 'session-owner.json');
+            await mkdir(sidecarDir, { recursive: true });
+            await writeFile(sidecarPath, JSON.stringify({
+                session_id: nativeSessionId,
+                native_session_id: nativeSessionId,
+                started_at: '2026-10-28T23:03:37.205Z',
+                cwd,
+                state_root: context.baseStateDir,
+                pid: 57617,
+                platform: 'linux',
+                identity_schema_version: 2,
+                process_identity: observation.identity,
+                pid_start_ticks: 87768,
+                pid_cmdline: MANAGED_CODEX_DAEMON_CMDLINE,
+            }), 'utf-8');
+            await withPointerDependencies({
+                runtimePlatform: 'linux',
+                probePid: () => 'alive',
+                observeProcess: () => observation,
+            }, async () => {
+                assert.equal((await readNativeSessionOwnerEvidence(cwd, nativeSessionId)).status, 'usable');
+                const sidecarBefore = await readFile(sidecarPath, 'utf-8');
+                const owner = await writeNativeSessionOwner(cwd, nativeSessionId, {
+                    pid: 57617,
+                    platform: 'linux',
+                });
+                assert.equal(owner.session_id, nativeSessionId);
+                const sidecarAfterOwnerWrite = await readFile(sidecarPath, 'utf-8');
+                assert.equal(JSON.parse(sidecarAfterOwnerWrite).session_id, nativeSessionId);
+                await assert.rejects(reconcileNativeSessionStart(cwd, nativeSessionId, {
+                    pid: 57617,
+                    platform: 'linux',
+                }), (error) => isSessionPointerLaunchAbort(error)
+                    && error.code === 'session_pointer_owner_conflict');
+                assert.equal((await readSessionPointer(context)).status, 'absent');
+                assert.equal(await readFile(sidecarPath, 'utf-8'), sidecarAfterOwnerWrite);
+                assert.notEqual(sidecarAfterOwnerWrite, sidecarBefore);
+            });
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('P1: rejects SessionStart republishing a managed daemon to the canonical pointer', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-session-daemon-canonical-republish-'));
+        const nativeSessionId = 'native-daemon-codex';
+        const daemonObservation = linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768');
+        try {
+            const context = resolveSessionPointerContext(cwd);
+            // Setup: Create canonical pointer with managed daemon owner (non-runtime-owner status)
+            const pointerPath = join(context.baseStateDir, 'session.json');
+            await mkdir(dirname(pointerPath), { recursive: true });
+            const initialDaemonState = {
+                session_id: 'omx-session-from-daemon',
+                native_session_id: nativeSessionId,
+                started_at: '2026-10-28T23:00:00.000Z',
+                cwd,
+                state_root: context.baseStateDir,
+                pid: 57617,
+                platform: 'linux',
+                identity_schema_version: 2,
+                process_identity: daemonObservation.identity,
+                pid_start_ticks: 87768,
+                pid_cmdline: MANAGED_CODEX_DAEMON_CMDLINE,
+            };
+            await writeFile(pointerPath, JSON.stringify(initialDaemonState), 'utf-8');
+            await withPointerDependencies({
+                runtimePlatform: 'linux',
+                probePid: () => 'alive',
+                observeProcess: () => daemonObservation,
+            }, async () => {
+                // Verify the canonical pointer is classified as non-runtime-owner
+                const canonicalPointerStatus = (await readSessionPointer(context)).status;
+                assert.equal(canonicalPointerStatus, 'non-runtime-owner', 'canonical pointer should be non-runtime-owner before SessionStart');
+                await assert.rejects(reconcileNativeSessionStart(cwd, nativeSessionId, {
+                    pid: 57617,
+                    platform: 'linux',
+                }), (error) => isSessionPointerLaunchAbort(error)
+                    && error.code === 'session_pointer_unusable'
+                    && error.pointerStatus === 'non-runtime-owner');
+                assert.equal(await readFile(pointerPath, 'utf-8'), JSON.stringify(initialDaemonState));
+                assert.equal((await readSessionPointer(context)).status, 'non-runtime-owner');
+            });
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('retains the OMX owner when managed-daemon SessionStart reconciles a launched pointer', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-session-daemon-reconcile-launch-owner-'));
+        const ownerPid = 57616;
+        const daemonPid = 57617;
+        const ownerObservation = linuxProcessObservation('/usr/local/bin/omx', '87767');
+        const daemonObservation = linuxProcessObservation(MANAGED_CODEX_DAEMON_CMDLINE, '87768');
+        try {
+            const context = resolveSessionPointerContext(cwd);
+            await withPointerDependencies({
+                runtimePlatform: 'linux',
+                probePid: () => 'alive',
+                observeProcess: (pid) => pid === daemonPid ? daemonObservation : ownerObservation,
+            }, async () => {
+                const launched = await writeSessionStart(cwd, 'omx-launch-owner', {
+                    pid: ownerPid,
+                    platform: 'linux',
+                });
+                const reconciled = await reconcileNativeSessionStart(cwd, 'native-daemon-reconcile', {
+                    pid: daemonPid,
+                    platform: 'linux',
+                });
+                assert.equal(reconciled.session_id, launched.session_id);
+                assert.equal(reconciled.native_session_id, 'native-daemon-reconcile');
+                assert.equal(reconciled.pid, ownerPid);
+                assert.equal(reconciled.process_identity?.birth, ownerObservation.identity.birth);
+                assert.notEqual(reconciled.process_identity?.cmdline_hash, daemonObservation.identity.cmdline_hash);
+                const pointerAfter = await readSessionPointer(context);
+                assert.equal(pointerAfter.status, 'usable');
+                assert.equal(pointerAfter.state?.pid, ownerPid);
+                assert.equal(pointerAfter.state?.native_session_id, 'native-daemon-reconcile');
+            });
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
     it('rejects a symlinked native owner state root', async () => {
         const cwd = await mkdtemp(join(tmpdir(), 'omx-session-owner-root-symlink-'));
         try {