oh-my-codex 0.20.3 → 0.21.0

package/dist/hooks/__tests__/anti-slop-workflow.test.js

@@ -18,148 +18,79 @@ function assertCanonicalPluginParity(path) {
     assert.ok(existsSync(join(repoRoot, pluginPath)), `${pluginPath} must exist in the plugin mirror`);
     assert.equal(read(pluginPath), read(path), `${path} must match the plugin mirror exactly`);
 }
-const antiSlopWorkingAgreementPatterns = [
-    /^## Working agreements$/m,
-    /^- For cleanup\/refactor\/deslop work, write a cleanup plan and lock behavior with regression tests before editing when coverage is missing\.$/m,
-    /^- Prefer deletion, existing utilities, and existing patterns before new abstractions; add dependencies only when explicitly requested\.$/m,
-    /^- Keep diffs small, reviewable, and reversible\.$/m,
-    /^- Verify with lint, typecheck, tests, and static analysis after changes; final reports include changed files, simplifications, and remaining risks\.$/m,
-];
-const antiSlopWorkflowPatterns = [
-    /^Anti-slop workflow:$/m,
-    /^- Cleanup\/refactor\/deslop work still follows the same `\$deep-interview` -> `\$ralplan` -> `\$team`\/`\$ralph` path; use `\$ai-slop-cleaner` as a bounded helper inside the chosen execution lane, not as a competing top-level workflow\.$/m,
-    /^- Write a cleanup plan before modifying code; lock existing behavior with regression tests first, then make one smell-focused pass at a time\.$/m,
-    /^- Prefer deletion over addition, and prefer reuse plus boundary repair over new layers\.$/m,
-    /^- No new dependencies without explicit request\.$/m,
-    /^- Run lint, typecheck, tests, and static analysis before claiming completion\.$/m,
-    /^- Keep writer\/reviewer pass separation for cleanup plans and approvals; preserve writer\/reviewer pass separation explicitly\.$/m,
-];
-const aiSlopCleanerWorkflowPatterns = [
-    /^Reduce AI-generated slop with a regression-tests-first, smell-by-smell cleanup workflow that preserves behavior and raises signal quality\.$/m,
-    /^## Scoped File Lists and Ralph Workflow$/m,
-    /^- This skill can accept a \*\*file list scope\*\* instead of a whole feature area\.$/m,
-    /^- In the \*\*Ralph workflow\*\*, the mandatory deslop pass should run this skill on Ralph's changed files only, in standard mode unless the caller explicitly requests otherwise\.$/m,
-    /^1\. \*\*Lock behavior with regression tests first\*\*$/m,
-    /^   - For fallback-like code, cover the primary path and any preserved compatibility\/fail-safe fallback before cleanup$/m,
-    /^2\. \*\*Create a cleanup plan before code\*\*$/m,
-    /^   - Include fallback findings, classifications, and escalation status in the plan$/m,
-    /^3\. \*\*Inventory fallback-like code before editing\*\*$/m,
-    /^   - Search the requested scope for fallback-like detection signals: quick hacks?, temporary workaround, temporary fallback, just bypass, just skip, fallback if it fails, swallowed errors, silent defaults, broad compatibility shims, and duplicate alternate execution paths$/m,
-    /^   - Classify each finding before changing it:$/m,
-    /^     - \*\*Masking fallback slop\*\* — hides errors or evidence, bypasses the primary contract, suppresses tests or validation, swallows failures, silently defaults, or adds untested alternate paths$/m,
-    /^     - \*\*Grounded compatibility\/fail-safe fallback\*\* — is scoped to an external\/version\/fail-safe boundary, documents the rationale, preserves failure evidence, and has regression tests for both the primary and fallback behavior$/m,
-    /^   - Prefer root-cause repair, deletion, boundary repair, or explicit failure behavior before preserving fallback paths$/m,
-    /^   - For broad, ambiguous, cross-layer, or architectural fallback-like code, invoke `\$ralplan` for consensus resolution before edits$/m,
-    /^   - Recursion guard: when already inside ralplan, ralph, team, or another OMX workflow, do not spawn a nested `\$ralplan`; record the finding and attach it to the active ralplan, leader, or plan handoff instead$/m,
-    /^4\. \*\*Categorize issues before editing\*\*$/m,
-    /^   - \*\*Fallback-like code\*\* — masking fallbacks, workaround branches, bypasses, swallowed errors, silent defaults, broad shims, alternate execution paths$/m,
-    /^   - \*\*Duplication\*\* — repeated logic, copy-paste branches, redundant helpers$/m,
-    /^   - \*\*Dead code\*\* — unused code, unreachable branches, stale flags, debug leftovers$/m,
-    /^   - \*\*Needless abstraction\*\* — pass-through wrappers, speculative indirection, single-use helper layers$/m,
-    /^   - \*\*Boundary violations\*\* — hidden coupling, leaky responsibilities, wrong-layer imports or side effects$/m,
-    /^   - \*\*UI\/design slop\*\* — review visual outputs as context-sensitive signals, not absolute bans; preserve intentional brand, design-system, accessibility, or product-context exceptions when the rationale is clear$/m,
-    /^     - Korean body text that is too small: challenge 11-12px body copy; Korean body text generally needs 14px or larger unless a dense, accessible system explicitly supports smaller text$/m,
-    /^     - Gratuitous depth: avoid putting box shadows on every logo, surface, card, icon, background, and step block when hierarchy or affordance does not need it$/m,
-    /^     - Repetitive content scaffolding: trim repeated eyebrow \+ title \+ description \+ paragraph stacks, filler explanation text, and generic emoji badges that do not add meaning$/m,
-    /^     - Default AI palettes: question blue\/purple defaults such as #3B82F6 when there is no brand, semantic, or system rationale$/m,
-    /^     - Over-perfect grids: avoid reflexive uniform 3-column or 4-column card grids when the product context would benefit from rhythm, asymmetry, carousel cuts, bento composition, or varied emphasis$/m,
-    /^     - Extreme gradients: tone down "AI demo" gradients unless the brand or campaign intentionally calls for that intensity$/m,
-    /^5\. \*\*Execute passes one smell at a time\*\*$/m,
-    /^   - \*\*Fallback-like code resolution gate\*\* — remove masking fallback slop, repair root causes, or escalate ambiguous cases before continuing$/m,
-    /^   - \*\*Pass 1: Dead code deletion\*\*$/m,
-    /^   - \*\*Pass 2: Duplicate removal\*\*$/m,
-    /^   - \*\*Pass 3: Naming\/error handling cleanup\*\*$/m,
-    /^   - \*\*Pass 4: Test reinforcement\*\*$/m,
-    /^6\. \*\*Run quality gates\*\*$/m,
-    /^   - Regression tests stay green$/m,
-    /^   - Static\/security scan passes when available$/m,
-    /^7\. \*\*Finish with an evidence-dense report\*\*$/m,
-    /^   - Changed files$/m,
-    /^   - Fallback findings, classifications, and escalation status$/m,
-    /^   - Remaining risks$/m,
-];
 describe('anti-slop workflow surfaces', () => {
-    it('adds durable anti-slop guidance to AGENTS surfaces', () => {
-        const templateContent = read('templates/AGENTS.md');
-        assertMatchesAll(templateContent, antiSlopWorkingAgreementPatterns);
-        assertMatchesAll(templateContent, antiSlopWorkflowPatterns);
-        if (existsSync(join(repoRoot, 'AGENTS.md'))) {
-            const content = read('AGENTS.md');
-            if (/^## Working agreements$/m.test(content)) {
-                assertMatchesAll(content, antiSlopWorkingAgreementPatterns);
-            }
+    it('keeps the cleaner a bounded helper with file-list and Ralph scope rules', () => {
+        const skill = read('skills/ai-slop-cleaner/SKILL.md');
+        assertCanonicalPluginParity('skills/ai-slop-cleaner/SKILL.md');
+        assert.ok(skill.trimEnd().split(/\r?\n/).length <= 120, 'task card must stay within the prompt size limit');
+        assert.match(skill, /bounded helper.*not as a competing top-level\s+workflow/is);
+        assert.match(skill, /A file list scope is valid; keep the pass bounded\s+to it/i);
+        assert.match(skill, /Ralph workflow.*changed files only, standard mode/i);
+        assert.match(skill, /requested\s+feature\/files and behavior to preserve/i);
+    });
+    it('requires behavior locking, fallback classification, and smell-focused passes', () => {
+        const skill = read('skills/ai-slop-cleaner/SKILL.md');
+        assert.match(skill, /Lock behavior with regression tests first/i);
+        assert.match(skill, /Create a cleanup plan before code/i);
+        assert.match(skill, /Inventory fallback-like code.*in scope/i);
+        assert.match(skill, /Masking fallback slop/i);
+        assert.match(skill, /Grounded compatibility\/fail-safe fallback/i);
+        assert.match(skill, /primary.*fallback/i);
+        assert.match(skill, /root-cause repair, deletion, boundary repair, or explicit failure behavior/i);
+        assert.match(skill, /broad\/ambiguous\/cross-layer\/architectural findings.*\$ralplan/i);
+        assert.match(skill, /do not spawn a nested `\$ralplan`/i);
+        for (const smell of [
+            /Fallback-like code/i,
+            /Duplication/i,
+            /Dead code/i,
+            /Needless abstraction/i,
+            /Boundary violations/i,
+            /Missing tests/i,
+            /UI\/design slop/i,
+        ]) {
+            assert.match(skill, smell);
+        }
+        for (const pass of [
+            /fallback-like code resolution gate/i,
+            /Pass 1: Dead code deletion/i,
+            /Pass 2: Duplicate removal/i,
+            /Pass 3: Naming\/error\s+handling cleanup/i,
+            /Pass 4: Test reinforcement/i,
+        ]) {
+            assert.match(skill, pass);
+        }
+    });
+    it('requires evidence-dense output and an explicit cleanup stop condition', () => {
+        const skill = read('skills/ai-slop-cleaner/SKILL.md');
+        assert.match(skill, /AI SLOP CLEANUP REPORT/i);
+        for (const field of [
+            /Scope:/i,
+            /Behavior Lock:/i,
+            /Cleanup Plan:/i,
+            /Fallback Findings:/i,
+            /Passes Completed:/i,
+            /Quality Gates:/i,
+            /Changed Files:/i,
+            /Remaining Risks:/i,
+        ]) {
+            assert.match(skill, field);
         }
+        assert.match(skill, /writer\/reviewer separation/i);
+        assert.match(skill, /behavior-lock evidence/i);
+        assert.match(skill, /each selected smell pass is\s+complete or explicitly deferred/i);
+        assert.match(skill, /Never present an unverified cleanup as\s+complete/i);
     });
-    it('documents reviewer-only separation in review and plan review mode', () => {
+    it('documents plan review mode and sunset stub for removed review skill', () => {
         assertCanonicalPluginParity('skills/plan/SKILL.md');
-        const reviewSkill = read('skills/review/SKILL.md');
         const planSkill = read('skills/plan/SKILL.md');
-        assertMatchesAll(reviewSkill, [
-            /Hard-deprecated/i,
-            /Do not invoke or route this skill/i,
-            /Use `\$code-review` directly/i,
-        ]);
         assertMatchesAll(planSkill, [
-            /### Review Mode \(`--review`\)/,
-            /reviewer-only\s+pass/i,
-            /MUST\s+NOT\s+be\s+the\s+context\s+that\s+approves\s+it/i,
-            /cleanup\s+plan,\s*regression\s+tests/i,
+            /### Review \(`--review`\)/,
+            /Critic evaluation/i,
+            /APPROVED\/REVISE\/REJECT/i,
         ]);
-    });
-    it('defines the built-in ai-slop-cleaner workflow', () => {
-        const skill = read('skills/ai-slop-cleaner/SKILL.md');
-        const pluginSkill = read('plugins/oh-my-codex/skills/ai-slop-cleaner/SKILL.md');
-        assert.equal(pluginSkill, skill);
-        assertMatchesAll(skill, aiSlopCleanerWorkflowPatterns);
-        assert.match(skill, /regression tests first/i);
-        assert.match(skill, /cleanup plan/i);
-        assert.match(skill, /duplication/i);
-        assert.match(skill, /dead code/i);
-        assert.match(skill, /needless abstraction/i);
-        assert.match(skill, /boundary violations/i);
-        assert.match(skill, /UI\/design slop/i);
-        assert.match(skill, /Korean body text/i);
-        assert.match(skill, /11-12px/);
-        assert.match(skill, /14px or larger/);
-        assert.match(skill, /box shadows/i);
-        assert.match(skill, /eyebrow \+ title \+ description \+ paragraph/i);
-        assert.match(skill, /generic emoji badges/i);
-        assert.match(skill, /#3B82F6/);
-        assert.match(skill, /3-column or 4-column card grids/i);
-        assert.match(skill, /rhythm, asymmetry/i);
-        assert.match(skill, /Extreme gradients/i);
-        assert.match(skill, /intentional brand, design-system, accessibility, or product-context exceptions/i);
-        assert.match(skill, /Pass 1: Dead code deletion/i);
-        assert.match(skill, /Pass 2: Duplicate removal/i);
-        assert.match(skill, /Pass 3: Naming\/error handling cleanup/i);
-        assert.match(skill, /Pass 4: Test reinforcement/i);
-        assert.match(skill, /quality gates/i);
-        assert.match(skill, /remaining risks/i);
-        assert.match(skill, /file list scope/i);
-        assert.match(skill, /changed files/i);
-        assert.match(skill, /Ralph workflow/i);
-        assert.match(skill, /fallback-like (?:inventory|detection|code)/i);
-        assert.match(skill, /quick hack/i);
-        assert.match(skill, /temporary workaround/i);
-        assert.match(skill, /temporary fallback/i);
-        assert.match(skill, /just bypass/i);
-        assert.match(skill, /fallback if it fails/i);
-        assert.match(skill, /swallowed errors/i);
-        assert.match(skill, /silent defaults/i);
-        assert.match(skill, /broad compatibility shims/i);
-        assert.match(skill, /alternate execution paths/i);
-        assert.match(skill, /Masking fallback slop/i);
-        assert.match(skill, /Grounded compatibility\/fail-safe fallback/i);
-        assert.match(skill, /root-cause repair/i);
-        assert.match(skill, /explicit failure behavior/i);
-        assert.match(skill, /\$ralplan/);
-        assert.match(skill, /consensus resolution/i);
-        assert.match(skill, /Recursion guard/i);
-        assert.match(skill, /do not spawn a nested `?\$ralplan`?/i);
-        assert.match(skill, /active ralplan/i);
-        assert.match(skill, /Fallback Findings/i);
-        assert.match(skill, /classifications/i);
-        assert.match(skill, /escalation status/i);
+        const sunset = read('src/hooks/sunset-stub.ts');
+        assert.match(sunset, /"review":/);
+        assert.match(sunset, /removed.*Use \"\$code-review\"/i);
     });
 });
 //# sourceMappingURL=anti-slop-workflow.test.js.map

package/dist/hooks/__tests__/anti-slop-workflow.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"anti-slop-workflow.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/anti-slop-workflow.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC;AAE9C,SAAS,IAAI,CAAC,IAAY;IACxB,OAAO,YAAY,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,EAAE,OAAO,CAAC,CAAC;AACrD,CAAC;AAED,SAAS,gBAAgB,CAAC,OAAe,EAAE,QAAkB;IAC3D,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,MAAM,CAAC,KAAK,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IACjC,CAAC;AACH,CAAC;AAED,SAAS,2BAA2B,CAAC,IAAY;IAC/C,MAAM,UAAU,GAAG,uBAAuB,IAAI,EAAE,CAAC;IACjD,MAAM,CAAC,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC,EAAE,GAAG,UAAU,kCAAkC,CAAC,CAAC;IACnG,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,GAAG,IAAI,uCAAuC,CAAC,CAAC;AAC7F,CAAC;AAED,MAAM,gCAAgC,GAAG;IACvC,0BAA0B;IAC1B,iJAAiJ;IACjJ,4IAA4I;IAC5I,qDAAqD;IACrD,yJAAyJ;CAC1J,CAAC;AAEF,MAAM,wBAAwB,GAAG;IAC/B,wBAAwB;IACxB,iPAAiP;IACjP,mJAAmJ;IACnJ,6FAA6F;IAC7F,qDAAqD;IACrD,mFAAmF;IACnF,oIAAoI;CACrI,CAAC;AAEF,MAAM,6BAA6B,GAAG;IACpC,gJAAgJ;IAChJ,4CAA4C;IAC5C,wFAAwF;IACxF,uLAAuL;IACvL,0DAA0D;IAC1D,2HAA2H;IAC3H,kDAAkD;IAClD,uFAAuF;IACvF,4DAA4D;IAC5D,qRAAqR;IACrR,mDAAmD;IACnD,2MAA2M;IAC3M,gPAAgP;IAChP,4HAA4H;IAC5H,0IAA0I;IAC1I,wNAAwN;IACxN,iDAAiD;IACjD,kKAAkK;IAClK,sFAAsF;IACtF,6FAA6F;IAC7F,iHAAiH;IACjH,oHAAoH;IACpH,8NAA8N;IAC9N,+LAA+L;IAC/L,oKAAoK;IACpK,wLAAwL;IACxL,qIAAqI;IACrI,2MAA2M;IAC3M,gIAAgI;IAChI,mDAAmD;IACnD,sJAAsJ;IACtJ,4CAA4C;IAC5C,2CAA2C;IAC3C,wDAAwD;IACxD,4CAA4C;IAC5C,kCAAkC;IAClC,qCAAqC;IACrC,qDAAqD;IACrD,qDAAqD;IACrD,uBAAuB;IACvB,mEAAmE;IACnE,yBAAyB;CAC1B,CAAC;AAEF,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,eAAe,GAAG,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACpD,gBAAgB,CAAC,eAAe,EAAE,gCAAgC,CAAC,CAAC;QACpE,gBAAgB,CAAC,eAAe,EAAE,wBAAwB,CAAC,CAAC;QAE5D,IAAI,UAAU,CAAC,IAAI,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC,EAAE,CAAC;YAC5C,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,CAAC,CAAC;YAClC,IAAI,0BAA0B,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;gBAC7C,gBAAgB,CAAC,OAAO,EAAE,gCAAgC,CAAC,CAAC;YAC9D,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QAC3E,2BAA2B,CAAC,sBAAsB,CAAC,CAAC;QAEpD,MAAM,WAAW,GAAG,IAAI,CAAC,wBAAwB,CAAC,CAAC;QACnD,MAAM,SAAS,GAAG,IAAI,CAAC,sBAAsB,CAAC,CAAC;QAE/C,gBAAgB,CAAC,WAAW,EAAE;YAC5B,kBAAkB;YAClB,oCAAoC;YACpC,+BAA+B;SAChC,CAAC,CAAC;QAEH,gBAAgB,CAAC,SAAS,EAAE;YAC1B,gCAAgC;YAChC,uBAAuB;YACvB,yDAAyD;YACzD,uCAAuC;SACxC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,KAAK,GAAG,IAAI,CAAC,iCAAiC,CAAC,CAAC;QACtD,MAAM,WAAW,GAAG,IAAI,CAAC,qDAAqD,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QACjC,gBAAgB,CAAC,KAAK,EAAE,6BAA6B,CAAC,CAAC;QACvD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;QAC/C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,eAAe,CAAC,CAAC;QACrC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC;QACpC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;QAClC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,uBAAuB,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,sBAAsB,CAAC,CAAC;QAC5C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,mBAAmB,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC;QAC/B,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC;QACtC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC;QACpC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,+CAA+C,CAAC,CAAC;QACrE,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,uBAAuB,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC;QAC/B,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kCAAkC,CAAC,CAAC;QACxD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;QAC1C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;QAC1C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,iFAAiF,CAAC,CAAC;QACvG,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6BAA6B,CAAC,CAAC;QACnD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4BAA4B,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,yCAAyC,CAAC,CAAC;QAC/D,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6BAA6B,CAAC,CAAC;QACnD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC;QACtC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC;QACtC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,iBAAiB,CAAC,CAAC;QACvC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6CAA6C,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,aAAa,CAAC,CAAC;QACnC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,uBAAuB,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,qBAAqB,CAAC,CAAC;QAC3C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,cAAc,CAAC,CAAC;QACpC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,uBAAuB,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,mBAAmB,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4BAA4B,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4BAA4B,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,wBAAwB,CAAC,CAAC;QAC9C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6CAA6C,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;QAC1C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4BAA4B,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;QACjC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,uBAAuB,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,sCAAsC,CAAC,CAAC;QAC5D,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,iBAAiB,CAAC,CAAC;QACvC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;QAC1C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,kBAAkB,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"anti-slop-workflow.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/anti-slop-workflow.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,EAAE,WAAW,CAAC,CAAC;AAE9C,SAAS,IAAI,CAAC,IAAY;IACxB,OAAO,YAAY,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,EAAE,OAAO,CAAC,CAAC;AACrD,CAAC;AAED,SAAS,gBAAgB,CAAC,OAAe,EAAE,QAAkB;IAC3D,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,MAAM,CAAC,KAAK,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IACjC,CAAC;AACH,CAAC;AAED,SAAS,2BAA2B,CAAC,IAAY;IAC/C,MAAM,UAAU,GAAG,uBAAuB,IAAI,EAAE,CAAC;IACjD,MAAM,CAAC,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC,EAAE,GAAG,UAAU,kCAAkC,CAAC,CAAC;IACnG,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,GAAG,IAAI,uCAAuC,CAAC,CAAC;AAC7F,CAAC;AAED,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QACjF,MAAM,KAAK,GAAG,IAAI,CAAC,iCAAiC,CAAC,CAAC;QACtD,2BAA2B,CAAC,iCAAiC,CAAC,CAAC;QAC/D,MAAM,CAAC,EAAE,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,MAAM,IAAI,GAAG,EAAE,kDAAkD,CAAC,CAAC;QAC5G,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,2DAA2D,CAAC,CAAC;QACjF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4DAA4D,CAAC,CAAC;QAClF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oDAAoD,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,sDAAsD,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,KAAK,GAAG,IAAI,CAAC,iCAAiC,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,4CAA4C,CAAC,CAAC;QAClE,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oCAAoC,CAAC,CAAC;QAC1D,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,yCAAyC,CAAC,CAAC;QAC/D,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,wBAAwB,CAAC,CAAC;QAC9C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6CAA6C,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oBAAoB,CAAC,CAAC;QAC1C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,6EAA6E,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,mEAAmE,CAAC,CAAC;QACzF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oCAAoC,CAAC,CAAC;QAE1D,KAAK,MAAM,KAAK,IAAI;YAClB,qBAAqB;YACrB,cAAc;YACd,YAAY;YACZ,uBAAuB;YACvB,sBAAsB;YACtB,gBAAgB;YAChB,kBAAkB;SACnB,EAAE,CAAC;YACF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAC7B,CAAC;QAED,KAAK,MAAM,IAAI,IAAI;YACjB,qCAAqC;YACrC,6BAA6B;YAC7B,4BAA4B;YAC5B,2CAA2C;YAC3C,6BAA6B;SAC9B,EAAE,CAAC;YACF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC;QAC5B,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,MAAM,KAAK,GAAG,IAAI,CAAC,iCAAiC,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;QAC/C,KAAK,MAAM,KAAK,IAAI;YAClB,SAAS;YACT,iBAAiB;YACjB,gBAAgB;YAChB,qBAAqB;YACrB,oBAAoB;YACpB,iBAAiB;YACjB,iBAAiB;YACjB,mBAAmB;SACpB,EAAE,CAAC;YACF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAC7B,CAAC;QACD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,8BAA8B,CAAC,CAAC;QACpD,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,yBAAyB,CAAC,CAAC;QAC/C,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,gEAAgE,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,KAAK,EAAE,oDAAoD,CAAC,CAAC;IAC5E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,2BAA2B,CAAC,sBAAsB,CAAC,CAAC;QAEpD,MAAM,SAAS,GAAG,IAAI,CAAC,sBAAsB,CAAC,CAAC;QAE/C,gBAAgB,CAAC,SAAS,EAAE;YAC1B,2BAA2B;YAC3B,oBAAoB;YACpB,2BAA2B;SAC5B,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,IAAI,CAAC,0BAA0B,CAAC,CAAC;QAChD,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;QAClC,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,iCAAiC,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/hooks/__tests__/autopilot-skill-contract.test.js

@@ -4,112 +4,53 @@ import { readFileSync } from 'node:fs';
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 const __dirname = dirname(fileURLToPath(import.meta.url));
-const autopilotSkill = readFileSync(join(__dirname, '../../../skills/autopilot/SKILL.md'), 'utf-8');
-const ralplanSkill = readFileSync(join(__dirname, '../../../skills/ralplan/SKILL.md'), 'utf-8');
-const codeReviewSkill = readFileSync(join(__dirname, '../../../skills/code-review/SKILL.md'), 'utf-8');
-const ultragoalSkill = readFileSync(join(__dirname, '../../../skills/ultragoal/SKILL.md'), 'utf-8');
-const pipelineSkill = readFileSync(join(__dirname, '../../../skills/pipeline/SKILL.md'), 'utf-8');
-const skillsDocs = readFileSync(join(__dirname, '../../../docs/skills.html'), 'utf-8');
-const gettingStartedDocs = readFileSync(join(__dirname, '../../../docs/getting-started.html'), 'utf-8');
-describe('autopilot skill default Ultragoal contract', () => {
-    it('makes deep-interview -> ralplan -> ultragoal -> code-review -> ultraqa the recommended/default contract', () => {
-        assert.match(autopilotSkill, /\$deep-interview\s*->\s*\$ralplan\s*->\s*\$ultragoal\s*\(\+ \$team if needed\)\s*->\s*\$code-review\s*->\s*\$ultraqa/);
-        assert.match(autopilotSkill, /recommended\/default contract/i);
-        assert.match(autopilotSkill, /Ralph is a legacy\/explicit alternate execution loop only/i);
-    });
-    it('returns non-clean code-review or ultraqa findings to ralplan', () => {
-        assert.match(autopilotSkill, /If `\$code-review` or `\$ultraqa` is not clean, Autopilot returns to `\$ralplan`/i);
-        assert.match(autopilotSkill, /COMMENT.*REQUEST CHANGES.*WATCH.*BLOCK/s);
-        assert.match(autopilotSkill, /UltraQA finds issues.*transition back to Phase `ralplan`/s);
-    });
-    it('requires tight phase, cycle, handoff, review state fields', () => {
-        for (const field of [
-            'current_phase',
-            'iteration',
-            'review_cycle',
-            'phase_cycle',
-            'handoff_artifacts',
-            'review_verdict',
-            'qa_verdict',
-            'return_to_ralplan_reason',
-        ]) {
-            assert.match(autopilotSkill, new RegExp(field));
-        }
-    });
-    it('documents minimal state/HUD contracts for code-review and ultragoal child phases', () => {
-        assert.match(codeReviewSkill, /State\/HUD Phase Contract/);
-        assert.match(codeReviewSkill, /not a standalone tracked mode with a `code-review-state\.json` lifecycle/i);
-        assert.match(codeReviewSkill, /skill-active-state\.json.*skill:"code-review".*phase:"planning"/s);
-        assert.match(codeReviewSkill, /current_phase":"code-review"/);
-        assert.match(ultragoalSkill, /State\/HUD Phase Contract/);
-        assert.match(ultragoalSkill, /mode:"ultragoal".*active:true.*current_phase/s);
-        assert.match(ultragoalSkill, /current_phase":"ultragoal"/);
-        assert.match(ultragoalSkill, /handoff_artifacts\.ultragoal/);
-    });
-    it('forbids self-attesting clean review and QA gates without durable stage evidence', () => {
-        assert.match(autopilotSkill, /Do not author `review_verdict:\{clean:true\}` from the leader's own summary/i);
-        assert.match(autopilotSkill, /both gates have durable source evidence/i);
-        assert.match(autopilotSkill, /actual `\$code-review`\/`\$ultraqa` stage or native-subagent\/thread\/tool records/i);
-        assert.match(autopilotSkill, /leader-authored summaries alone are not gate evidence/i);
-        assert.match(autopilotSkill, /`qa_verdict` cites durable `\$ultraqa` evidence or an explicit persisted low-risk skip reason/i);
-        assert.match(autopilotSkill, /keep the active phase at `code-review` or `ultraqa` and record a blocker instead of self-attesting a clean gate/i);
-    });
-    it('requires sequential ralplan Architect and Critic consensus before execution handoff', () => {
-        assert.match(autopilotSkill, /PRD\/test-spec files alone are not completion evidence/i);
-        assert.match(autopilotSkill, /subsequent `Architect` approval first.*subsequent `Critic` approval second/is);
-        assert.doesNotMatch(autopilotSkill, /records an `Architect` approval first/i);
-        assert.match(autopilotSkill, /ralplan_consensus_gate/);
-        assert.match(autopilotSkill, /missing ralplan consensus evidence/i);
-        assert.match(autopilotSkill, /do not progress to `\$ultragoal`, `\$team`, `\$ralph`, or implementation/i);
-    });
-    it('documents dedicated planner routing when Autopilot main is cheap or mini', () => {
-        assert.match(autopilotSkill, /planning_routing/i);
-        assert.match(autopilotSkill, /cheap\/mini lane[\s\S]*`\[main\]`/i);
-        assert.match(autopilotSkill, /dedicated `\[planner\]`/i);
-        assert.match(ralplanSkill, /`agentModels\.planner`/i);
-        assert.match(ralplanSkill, /initial Planner draft/i);
-    });
-    it('documents optional deep-interview execution contract validation without broadness inference', () => {
-        assert.match(autopilotSkill, /execution_contract_required:true/i);
-        assert.match(autopilotSkill, /execution_contract/i);
-        assert.match(autopilotSkill, /execution_stride:"task"\|"deliverable"\|"milestone"/i);
-        assert.match(autopilotSkill, /allow_task_shrink/i);
-        assert.match(autopilotSkill, /completion_unit/i);
-        assert.match(autopilotSkill, /stop_condition/i);
-        assert.match(autopilotSkill, /acceptance_coverage_scope/i);
-        assert.match(autopilotSkill, /shrink_policy/i);
-        assert.match(autopilotSkill, /Preserve legacy behavior when `execution_contract_required` is absent or false/i);
-        assert.match(autopilotSkill, /Do not infer stride from prose, broadness, phase names, snapshots, or task size/i);
-        assert.match(autopilotSkill, /deliberately uses `milestone` rather than `phase`/i);
-        assert.match(autopilotSkill, /New artifacts must write canonical snake_case keys/i);
-        assert.match(autopilotSkill, /runtime may read legacy camelCase field\/marker aliases and direct\/nested `execution_contract` locations only as compatibility input/i);
-    });
-    it('requires role-specific subsequent ralplan reviewer subagents with full context', () => {
-        assert.match(ralplanSkill, /subsequent role-specific `Architect` subagent/i);
-        assert.match(ralplanSkill, /subsequent role-specific `Critic` subagent/i);
-        assert.match(ralplanSkill, /full task statement, context snapshot, PRD\/test-spec paths/i);
-        assert.match(ralplanSkill, /do not substitute an unvalidated reviewer identity or a short improvised reviewer prompt/i);
-        assert.match(ralplanSkill, /do not ask the Architect subagent to perform the Critic gate/i);
-        // Surface-aware role contract (#3118): agent_type is mandatory only where the
-        // native surface exposes role routing; otherwise the adapted role-intent pass
-        // carries the validated role via a correlation token, never a prompt label.
-        assert.match(ralplanSkill, /When the native surface exposes `agent_type` role routing/i);
-        assert.match(ralplanSkill, /role[_ -]?routing[_ -]?unavailable/i);
-        assert.match(ralplanSkill, /omx ralplan role-intent write/i);
-    });
-    it('documents ralplan consensus completion in pipeline and public docs', () => {
-        assert.match(pipelineSkill, /Plan\/test-spec files alone are not consensus evidence/i);
-        assert.match(pipelineSkill, /Architect approval followed by Critic approval/i);
-        assert.match(skillsDocs, /not just PRD\/test-spec files/i);
-        assert.match(skillsDocs, /never leaving ralplan until Architect\/Critic consensus evidence is recorded/i);
-        assert.match(gettingStartedDocs, /Architect review evidence and then Critic review evidence are recorded/i);
-    });
-    it('does not preserve the old broad phase lifecycle as primary behavior', () => {
-        assert.doesNotMatch(autopilotSkill, /All 5 phases completed/i);
-        assert.doesNotMatch(autopilotSkill, /Phase 0 - Expansion/i);
-        assert.doesNotMatch(autopilotSkill, /Phase 4 - Validation/i);
-        assert.match(autopilotSkill, /must not run a separate broad expansion\/planning\/execution\/QA\/validation lifecycle as its primary behavior/i);
-        assert.doesNotMatch(autopilotSkill, /primary contract is exactly:\n\n```text\n\$ralplan\s*->\s*\$ralph\s*->\s*\$code-review/);
+const root = join(__dirname, '../../..');
+const autopilotSkill = readFileSync(join(root, 'skills/autopilot/SKILL.md'), 'utf-8');
+const pluginAutopilotSkill = readFileSync(join(root, 'plugins/oh-my-codex/skills/autopilot/SKILL.md'), 'utf-8');
+const skillsDocs = readFileSync(join(root, 'docs/skills.html'), 'utf-8');
+const gettingStartedDocs = readFileSync(join(root, 'docs/getting-started.html'), 'utf-8');
+const stateModel = readFileSync(join(root, 'docs/STATE_MODEL.md'), 'utf-8');
+const canonicalChain = /\$deep-interview\s*(?:->|->)\s*\$ralplan\s*(?:->|->)\s*\$ultragoal/;
+describe('autopilot canonical orchestrator contract', () => {
+    it('makes deep-interview -> ralplan -> ultragoal the defining default chain', () => {
+        assert.match(autopilotSkill, /first-class canonical orchestrator/i);
+        assert.match(autopilotSkill, canonicalChain);
+        assert.match(autopilotSkill, /not a list of optional hints/i);
+        assert.match(autopilotSkill, /MUST preserve the phase order `deep-interview -> ralplan -> ultragoal`/i);
+        assert.doesNotMatch(autopilotSkill, /was removed in OMX 0\.21/i);
+        assert.doesNotMatch(autopilotSkill, /understand -> execute -> verify -> report/i);
+    });
+    it('keeps Autopilot as the supervisor over child phases', () => {
+        assert.match(autopilotSkill, /Child stages are supervised phases, not peer workflow activations/i);
+        assert.match(autopilotSkill, /keep `mode:"autopilot"` active/i);
+        assert.match(autopilotSkill, /current_phase/);
+        assert.match(autopilotSkill, /phase_cycle/);
+        assert.match(autopilotSkill, /handoff_artifacts/);
+        assert.match(autopilotSkill, /return_to_ralplan_reason/);
+    });
+    it('reconciles progression with current state SSOT without restoring the host-receipt lock', () => {
+        assert.match(autopilotSkill, /current CLI state SSOT/i);
+        assert.match(autopilotSkill, /Do not create a second writer/i);
+        assert.match(autopilotSkill, /missing host provenance is not a blocker/i);
+        assert.match(autopilotSkill, /Do not reintroduce the retired unrecoverable host-receipt lock/i);
+        assert.match(stateModel, /Autopilot is a supervisor over child stages/i);
+        assert.match(stateModel, /missing host provenance\s+must not terminalize Autopilot/i);
+    });
+    it('preserves recoverable cancel, clear, and hook recovery paths', () => {
+        assert.match(autopilotSkill, /Authority-decreasing operations are always recoverable/i);
+        assert.match(autopilotSkill, /\$cancel/);
+        assert.match(autopilotSkill, /exact-session state clear/i);
+        assert.match(autopilotSkill, /hook disable\/uninstall recovery/i);
+        assert.match(autopilotSkill, /must not keep Stop blocked/i);
+        assert.match(autopilotSkill, /never recreate an unconditional hook lock/i);
+    });
+    it('keeps the plugin mirror byte-identical to the canonical skill', () => {
+        assert.equal(pluginAutopilotSkill, autopilotSkill);
+    });
+    it('advertises the canonical chain in public workflow docs', () => {
+        assert.match(skillsDocs, canonicalChain);
+        assert.match(gettingStartedDocs, canonicalChain);
+        assert.doesNotMatch(skillsDocs, /Removed in OMX 0\.21:<\/em> <code>\$autopilot<\/code>/i);
     });
 });
 //# sourceMappingURL=autopilot-skill-contract.test.js.map

package/dist/hooks/__tests__/autopilot-skill-contract.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"autopilot-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/autopilot-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,cAAc,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,oCAAoC,CAAC,EAAE,OAAO,CAAC,CAAC;AACpG,MAAM,YAAY,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,kCAAkC,CAAC,EAAE,OAAO,CAAC,CAAC;AAChG,MAAM,eAAe,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,sCAAsC,CAAC,EAAE,OAAO,CAAC,CAAC;AACvG,MAAM,cAAc,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,oCAAoC,CAAC,EAAE,OAAO,CAAC,CAAC;AACpG,MAAM,aAAa,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,mCAAmC,CAAC,EAAE,OAAO,CAAC,CAAC;AAClG,MAAM,UAAU,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,2BAA2B,CAAC,EAAE,OAAO,CAAC,CAAC;AACvF,MAAM,kBAAkB,GAAG,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,oCAAoC,CAAC,EAAE,OAAO,CAAC,CAAC;AAExG,QAAQ,CAAC,4CAA4C,EAAE,GAAG,EAAE;IAC1D,EAAE,CAAC,yGAAyG,EAAE,GAAG,EAAE;QACjH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,sHAAsH,CAAC,CAAC;QACrJ,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,gCAAgC,CAAC,CAAC;QAC/D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,4DAA4D,CAAC,CAAC;IAC7F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,mFAAmF,CAAC,CAAC;QAClH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yCAAyC,CAAC,CAAC;QACxE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,2DAA2D,CAAC,CAAC;IAC5F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,KAAK,MAAM,KAAK,IAAI;YAClB,eAAe;YACf,WAAW;YACX,cAAc;YACd,aAAa;YACb,mBAAmB;YACnB,gBAAgB;YAChB,YAAY;YACZ,0BAA0B;SAC3B,EAAE,CAAC;YACF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC;QAClD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kFAAkF,EAAE,GAAG,EAAE;QAC1F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,2BAA2B,CAAC,CAAC;QAC3D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,2EAA2E,CAAC,CAAC;QAC3G,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,8BAA8B,CAAC,CAAC;QAC9D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,2BAA2B,CAAC,CAAC;QAC1D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,+CAA+C,CAAC,CAAC;QAC9E,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,4BAA4B,CAAC,CAAC;QAC3D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,8BAA8B,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iFAAiF,EAAE,GAAG,EAAE;QACzF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,8EAA8E,CAAC,CAAC;QAC7G,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,0CAA0C,CAAC,CAAC;QACzE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qFAAqF,CAAC,CAAC;QACpH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,wDAAwD,CAAC,CAAC;QACvF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,gGAAgG,CAAC,CAAC;QAC/H,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,kHAAkH,CAAC,CAAC;IACnJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qFAAqF,EAAE,GAAG,EAAE;QAC7F,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yDAAyD,CAAC,CAAC;QACxF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,8EAA8E,CAAC,CAAC;QAC7G,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,wCAAwC,CAAC,CAAC;QAC9E,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,wBAAwB,CAAC,CAAC;QACvD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qCAAqC,CAAC,CAAC;QACpE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,2EAA2E,CAAC,CAAC;IAC5G,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;QAClF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,mBAAmB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,oCAAoC,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,0BAA0B,CAAC,CAAC;QACzD,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,yBAAyB,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,wBAAwB,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6FAA6F,EAAE,GAAG,EAAE;QACrG,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,mCAAmC,CAAC,CAAC;QAClE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qBAAqB,CAAC,CAAC;QACpD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,sDAAsD,CAAC,CAAC;QACrF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,oBAAoB,CAAC,CAAC;QACnD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,kBAAkB,CAAC,CAAC;QACjD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,iBAAiB,CAAC,CAAC;QAChD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,4BAA4B,CAAC,CAAC;QAC3D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,gBAAgB,CAAC,CAAC;QAC/C,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,iFAAiF,CAAC,CAAC;QAChH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,kFAAkF,CAAC,CAAC;QACjH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,oDAAoD,CAAC,CAAC;QACnF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qDAAqD,CAAC,CAAC;QACpF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,wIAAwI,CAAC,CAAC;IACzK,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gFAAgF,EAAE,GAAG,EAAE;QACxF,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,gDAAgD,CAAC,CAAC;QAC7E,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,6CAA6C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,8DAA8D,CAAC,CAAC;QAC3F,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,2FAA2F,CAAC,CAAC;QACxH,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,+DAA+D,CAAC,CAAC;QAC5F,8EAA8E;QAC9E,8EAA8E;QAC9E,4EAA4E;QAC5E,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,4DAA4D,CAAC,CAAC;QACzF,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,qCAAqC,CAAC,CAAC;QAClE,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,gCAAgC,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC5E,MAAM,CAAC,KAAK,CAAC,aAAa,EAAE,yDAAyD,CAAC,CAAC;QACvF,MAAM,CAAC,KAAK,CAAC,aAAa,EAAE,iDAAiD,CAAC,CAAC;QAC/E,MAAM,CAAC,KAAK,CAAC,UAAU,EAAE,gCAAgC,CAAC,CAAC;QAC3D,MAAM,CAAC,KAAK,CAAC,UAAU,EAAE,+EAA+E,CAAC,CAAC;QAC1G,MAAM,CAAC,KAAK,CAAC,kBAAkB,EAAE,yEAAyE,CAAC,CAAC;IAC9G,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,yBAAyB,CAAC,CAAC;QAC/D,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,sBAAsB,CAAC,CAAC;QAC5D,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,uBAAuB,CAAC,CAAC;QAC7D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,iHAAiH,CAAC,CAAC;QAChJ,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,wFAAwF,CAAC,CAAC;IAChI,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"autopilot-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/autopilot-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,EAAE,UAAU,CAAC,CAAC;AACzC,MAAM,cAAc,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,2BAA2B,CAAC,EAAE,OAAO,CAAC,CAAC;AACtF,MAAM,oBAAoB,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,+CAA+C,CAAC,EAAE,OAAO,CAAC,CAAC;AAChH,MAAM,UAAU,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,kBAAkB,CAAC,EAAE,OAAO,CAAC,CAAC;AACzE,MAAM,kBAAkB,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,2BAA2B,CAAC,EAAE,OAAO,CAAC,CAAC;AAC1F,MAAM,UAAU,GAAG,YAAY,CAAC,IAAI,CAAC,IAAI,EAAE,qBAAqB,CAAC,EAAE,OAAO,CAAC,CAAC;AAE5E,MAAM,cAAc,GAAG,0EAA0E,CAAC;AAElG,QAAQ,CAAC,2CAA2C,EAAE,GAAG,EAAE;IACzD,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QACjF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qCAAqC,CAAC,CAAC;QACpE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,cAAc,CAAC,CAAC;QAC7C,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,+BAA+B,CAAC,CAAC;QAC9D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yEAAyE,CAAC,CAAC;QACxG,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,2BAA2B,CAAC,CAAC;QACjE,MAAM,CAAC,YAAY,CAAC,cAAc,EAAE,4CAA4C,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,oEAAoE,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,iCAAiC,CAAC,CAAC;QAChE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,eAAe,CAAC,CAAC;QAC9C,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,aAAa,CAAC,CAAC;QAC5C,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,mBAAmB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,0BAA0B,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wFAAwF,EAAE,GAAG,EAAE;QAChG,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yBAAyB,CAAC,CAAC;QACxD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,gCAAgC,CAAC,CAAC;QAC/D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,2CAA2C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,iEAAiE,CAAC,CAAC;QAChG,MAAM,CAAC,KAAK,CAAC,UAAU,EAAE,8CAA8C,CAAC,CAAC;QACzE,MAAM,CAAC,KAAK,CAAC,UAAU,EAAE,2DAA2D,CAAC,CAAC;IACxF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yDAAyD,CAAC,CAAC;QACxF,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,UAAU,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,4BAA4B,CAAC,CAAC;QAC3D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,mCAAmC,CAAC,CAAC;QAClE,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,6BAA6B,CAAC,CAAC;QAC5D,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,4CAA4C,CAAC,CAAC;IAC7E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,CAAC,KAAK,CAAC,oBAAoB,EAAE,cAAc,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QAChE,MAAM,CAAC,KAAK,CAAC,UAAU,EAAE,cAAc,CAAC,CAAC;QACzC,MAAM,CAAC,KAAK,CAAC,kBAAkB,EAAE,cAAc,CAAC,CAAC;QACjD,MAAM,CAAC,YAAY,CAAC,UAAU,EAAE,wDAAwD,CAAC,CAAC;IAC5F,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/hooks/__tests__/code-review-skill-contract.test.js

@@ -6,15 +6,12 @@ import { fileURLToPath } from 'node:url';
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const codeReviewSkill = readFileSync(join(__dirname, '../../../skills/code-review/SKILL.md'), 'utf-8');
 describe('code-review skill contract', () => {
-    it('requires parallel code-reviewer and architect lanes', () => {
-        assert.match(codeReviewSkill, /`code-reviewer` and `architect` agents in parallel/i);
-        assert.match(codeReviewSkill, /Both lanes run in parallel/i);
-        assert.match(codeReviewSkill, /clean context/i);
-        assert.match(codeReviewSkill, /explicit scope and artifacts/i);
-        assert.match(codeReviewSkill, /`code-reviewer` lane/i);
-        assert.match(codeReviewSkill, /`architect` lane/i);
-        assert.match(codeReviewSkill, /If either lane cannot be launched or does not return evidence/i);
+    it('requires independent review lanes with explicit scope and unavailable handling', () => {
+        assert.match(codeReviewSkill, /Launch the `code-reviewer` and `architect` agents in parallel/i);
+        assert.match(codeReviewSkill, /Both lanes run in parallel on a clean context with explicit scope and artifacts/i);
+        assert.match(codeReviewSkill, /If either lane cannot be launched or does not return evidence, report `independent review unavailable`/i);
         assert.match(codeReviewSkill, /do \*\*not\*\* substitute the current\/authoring lane/i);
+        assert.match(codeReviewSkill, /do \*\*not\*\* approve or mark the review merge-ready/i);
     });
     it('uses native task agent_type examples without overriding user model or effort', () => {
         assert.match(codeReviewSkill, /Respect the user's current model and reasoning\/effort selection/i);
@@ -26,17 +23,15 @@ describe('code-review skill contract', () => {
         assert.doesNotMatch(codeReviewSkill, /delegate\(\s*role=/s);
         assert.doesNotMatch(codeReviewSkill, /tier="/);
     });
-    it('frames architect as the devil’s-advocate lane with deterministic blocker status', () => {
+    it('frames architect as the devil’s-advocate lane with explicit status values', () => {
         assert.match(codeReviewSkill, /devil['’]s-advocate/i);
         assert.match(codeReviewSkill, /Architectural Status Contract/i);
-        assert.match(codeReviewSkill, /CLEAR/i);
-        assert.match(codeReviewSkill, /WATCH/i);
-        assert.match(codeReviewSkill, /BLOCK/i);
+        assert.match(codeReviewSkill, /Architectural Status: CLEAR \| WATCH \| BLOCK/i);
         assert.match(codeReviewSkill, /If architect status is \*\*BLOCK\*\*, final recommendation is \*\*REQUEST CHANGES\*\*/i);
     });
     it('requires final synthesis across both lanes', () => {
         assert.match(codeReviewSkill, /Final Synthesis/i);
-        assert.match(codeReviewSkill, /Combine the `code-reviewer` recommendation and the architect status/i);
+        assert.match(codeReviewSkill, /Combine the `code-reviewer` recommendation and architect status/i);
         assert.match(codeReviewSkill, /Approval requires explicit evidence from both independent lanes/i);
         assert.match(codeReviewSkill, /missing or failed delegation is a blocking unavailable-review state/i);
         assert.match(codeReviewSkill, /final report must make architect blockers impossible to miss/i);
@@ -44,12 +39,15 @@ describe('code-review skill contract', () => {
     it('forbids self-review fallback approval when delegation is unavailable', () => {
         assert.match(codeReviewSkill, /Do not self-review as a fallback/i);
         assert.match(codeReviewSkill, /missing, unavailable, skipped, or fails/i);
-        assert.match(codeReviewSkill, /block approval until the independent lane evidence exists/i);
+        assert.match(codeReviewSkill, /block approval until independent lane evidence exists/i);
     });
-    it('keeps approval criteria aligned with the deterministic synthesis contract', () => {
-        assert.match(codeReviewSkill, /\*\*APPROVE\*\* - `code-reviewer` returns APPROVE, architect status is `CLEAR`, and both independent lanes returned evidence/i);
-        assert.match(codeReviewSkill, /\*\*REQUEST CHANGES\*\* - `code-reviewer` returns REQUEST CHANGES, architect status is `BLOCK`, or required independent review delegation is unavailable\/skipped\/failed/i);
-        assert.match(codeReviewSkill, /\*\*COMMENT\*\* - `code-reviewer` returns COMMENT with architect status `CLEAR`, architect status is `WATCH`, or only LOW\/MEDIUM improvements remain/i);
+    it('keeps recommendation mapping deterministic', () => {
+        assert.match(codeReviewSkill, /If architect status is \*\*BLOCK\*\*, final recommendation is \*\*REQUEST CHANGES\*\*/i);
+        assert.match(codeReviewSkill, /Else if `code-reviewer` recommendation is \*\*REQUEST CHANGES\*\*, final recommendation is \*\*REQUEST CHANGES\*\*/i);
+        assert.match(codeReviewSkill, /Else if architect status is \*\*WATCH\*\*, final recommendation is \*\*COMMENT\*\*/i);
+        assert.match(codeReviewSkill, /Else final recommendation follows the `code-reviewer` lane/i);
+        assert.match(codeReviewSkill, /\*\*APPROVE\*\* only when `code-reviewer` returns APPROVE, architect status is `CLEAR`, and both independent lanes returned evidence/i);
+        assert.match(codeReviewSkill, /\*\*REQUEST CHANGES\*\* for a blocker, unresolved high\/critical finding, or unavailable lane/i);
     });
     it('bounds auto-fix wording to the explicit ralph path only', () => {
         assert.match(codeReviewSkill, /On the explicit Ralph path/i);

package/dist/hooks/__tests__/code-review-skill-contract.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"code-review-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/code-review-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,eAAe,GAAG,YAAY,CAClC,IAAI,CAAC,SAAS,EAAE,sCAAsC,CAAC,EACvD,OAAO,CACR,CAAC;AAEF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qDAAqD,CAAC,CAAC;QACrF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6BAA6B,CAAC,CAAC;QAC7D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gBAAgB,CAAC,CAAC;QAChD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+BAA+B,CAAC,CAAC;QAC/D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,uBAAuB,CAAC,CAAC;QACvD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mBAAmB,CAAC,CAAC;QACnD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gEAAgE,CAAC,CAAC;QAChG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mEAAmE,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,iDAAiD,CAAC,CAAC;QACjF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6CAA6C,CAAC,CAAC;QAC7E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QAC7G,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QACzG,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,qBAAqB,CAAC,CAAC;QAC5D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iFAAiF,EAAE,GAAG,EAAE;QACzF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sBAAsB,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gCAAgC,CAAC,CAAC;QAChE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;QACxC,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;IAC1H,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kBAAkB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QACtG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QACtG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+DAA+D,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mCAAmC,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4DAA4D,CAAC,CAAC;IAC9F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,GAAG,EAAE;QACnF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+HAA+H,CAAC,CAAC;QAC/J,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4KAA4K,CAAC,CAAC;QAC5M,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wJAAwJ,CAAC,CAAC;IAC1L,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6BAA6B,CAAC,CAAC;QAC7D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4DAA4D,CAAC,CAAC;QAC5F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;IACvH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,sBAAsB,CAAC,CAAC;QAClE,MAAM,aAAa,GAAG,eAAe,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,aAAa,CAAC,CAAC;QAC7C,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;QAC3D,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,mBAAmB,CAAC,CAAC;QAC/D,MAAM,QAAQ,GAAG,eAAe,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QACzD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0BAA0B,CAAC,CAAC;QAC1D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,oCAAoC,CAAC,CAAC;QAC3E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,4BAA4B,CAAC,CAAC;QACnE,MAAM,CAAC,EAAE,CAAC,WAAW,IAAI,aAAa,IAAI,SAAS,IAAI,WAAW,IAAI,QAAQ,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CACV,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,EACtB,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACpB,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CACtB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"code-review-skill-contract.test.js","sourceRoot":"","sources":["../../../src/hooks/__tests__/code-review-skill-contract.test.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAC1C,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AAEzC,MAAM,SAAS,GAAG,OAAO,CAAC,aAAa,CAAC,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AAC1D,MAAM,eAAe,GAAG,YAAY,CAClC,IAAI,CAAC,SAAS,EAAE,sCAAsC,CAAC,EACvD,OAAO,CACR,CAAC;AAEF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,gFAAgF,EAAE,GAAG,EAAE;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gEAAgE,CAAC,CAAC;QAChG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kFAAkF,CAAC,CAAC;QAClH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,yGAAyG,CAAC,CAAC;QACzI,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;QACxF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mEAAmE,CAAC,CAAC;QACnG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sDAAsD,CAAC,CAAC;QACtF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,iDAAiD,CAAC,CAAC;QACjF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6CAA6C,CAAC,CAAC;QAC7E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QAC7G,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QACzG,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,qBAAqB,CAAC,CAAC;QAC5D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,QAAQ,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,GAAG,EAAE;QACnF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sBAAsB,CAAC,CAAC;QACtD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gCAAgC,CAAC,CAAC;QAChE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gDAAgD,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;IAC1H,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kBAAkB,CAAC,CAAC;QAClD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,kEAAkE,CAAC,CAAC;QAClG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,sEAAsE,CAAC,CAAC;QACtG,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,+DAA+D,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,mCAAmC,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wDAAwD,CAAC,CAAC;IAC1F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;QACpD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,wFAAwF,CAAC,CAAC;QACxH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qHAAqH,CAAC,CAAC;QACrJ,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;QACrH,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6DAA6D,CAAC,CAAC;QAC7F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,uIAAuI,CAAC,CAAC;QACvK,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,gGAAgG,CAAC,CAAC;IAClI,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACjE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,6BAA6B,CAAC,CAAC;QAC7D,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,4DAA4D,CAAC,CAAC;QAC5F,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,qFAAqF,CAAC,CAAC;IACvH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,sBAAsB,CAAC,CAAC;QAClE,MAAM,aAAa,GAAG,eAAe,CAAC,KAAK,CAAC,qBAAqB,CAAC,CAAC;QACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,aAAa,CAAC,CAAC;QAC7C,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;QAC3D,MAAM,WAAW,GAAG,eAAe,CAAC,KAAK,CAAC,mBAAmB,CAAC,CAAC;QAC/D,MAAM,QAAQ,GAAG,eAAe,CAAC,KAAK,CAAC,gBAAgB,CAAC,CAAC;QACzD,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0CAA0C,CAAC,CAAC;QAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,0BAA0B,CAAC,CAAC;QAC1D,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,oCAAoC,CAAC,CAAC;QAC3E,MAAM,CAAC,YAAY,CAAC,eAAe,EAAE,4BAA4B,CAAC,CAAC;QACnE,MAAM,CAAC,EAAE,CAAC,WAAW,IAAI,aAAa,IAAI,SAAS,IAAI,WAAW,IAAI,QAAQ,CAAC,CAAC;QAChF,MAAM,CAAC,KAAK,CACV,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,EACtB,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACpB,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CACtB,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/hooks/__tests__/consensus-execution-handoff.test.d.ts

@@ -1,18 +1,6 @@
 /**
- * Consensus mode execution handoff regression tests
- *
- * Verifies that the plan skill's consensus mode (ralplan) mandates:
- * 1. Structured question UI for approval (not plain text)
- * 2. Explicit $ultragoal invocation on durable-goal approval, with Ralph only as explicit fallback
- * 3. Prohibition of direct implementation from the planning agent
- * 4. User feedback step after Planner but before Architect/Critic
- * 5. RALPLAN-DR short mode and deliberate mode requirements
- *
- * Also verifies non-consensus modes (interview, direct, review) are unaffected,
- * and that architect/critic prompts contain required RALPLAN-DR sections.
- *
- * Note: This file loads SKILL.md and prompt content directly via fs.readFileSync()
- * instead of getBuiltinSkill() (which does not exist in OMX).
+ * Planning skill regression tests for the lightweight plan surface and the
+ * independently restored deep-interview requirements workflow.
  */
 export {};
 //# sourceMappingURL=consensus-execution-handoff.test.d.ts.map

package/dist/hooks/__tests__/consensus-execution-handoff.test.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"consensus-execution-handoff.test.d.ts","sourceRoot":"","sources":["../../../src/hooks/__tests__/consensus-execution-handoff.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;GAeG"}
+{"version":3,"file":"consensus-execution-handoff.test.d.ts","sourceRoot":"","sources":["../../../src/hooks/__tests__/consensus-execution-handoff.test.ts"],"names":[],"mappings":"AAAA;;;GAGG"}