oh-my-codex 0.20.3 → 0.20.5

package/dist/cli/__tests__/setup-install-mode.test.js

@@ -1,11 +1,11 @@
 import { after, before, describe, it } from "node:test";
 import assert from "node:assert/strict";
-import { existsSync, lstatSync, readFileSync, renameSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
+import { chmodSync, existsSync, lstatSync, readFileSync, renameSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
 import { chmod, cp, lstat, mkdir, mkdtemp, readFile, readdir, rm, symlink, writeFile, stat, } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { basename, dirname, join } from "node:path";
 import { parse as parseToml } from "@iarna/toml";
-import { decideWindowsNativeHookShimReference, setNativeHookTransactionFailureInjectorForTest, setSetupLatePhaseFailureInjectorForTest, setNativeHookTransactionPlatformForTest, setNativeHookTransactionRegularFileSyncForTest, setNativeHookTransactionTemporaryPathForTest, setup, } from "../setup.js";
+import { decideWindowsNativeHookShimReference, setNativeHookClaimJournalDurabilityForTest, setNativeHookTransactionArtifactLstatForTest, setNativeHookTransactionFailureInjectorForTest, setSetupLatePhaseFailureInjectorForTest, setNativeHookTransactionPlatformForTest, setNativeHookTransactionRegularFileSyncForTest, setNativeHookTransactionTemporaryPathForTest, setup, } from "../setup.js";
 import { resolveSetupRefreshArgs } from "../update.js";
 import { uninstall } from "../uninstall.js";
 import { OMX_DEVELOPER_INSTRUCTIONS, OMX_PLUGIN_DEVELOPER_INSTRUCTIONS, } from "../../config/generator.js";
@@ -1386,11 +1386,13 @@ describe("omx setup install mode behavior", () => {
                     assert.match(config, /User-installed skills may still live under ~\/.codex\/skills/);
                     assert.match(config, /native agent roles are installed as setup-owned Codex agent TOML files in plugin mode so agent_type routing works/i);
                     assert.match(config, /When the native surface exposes `agent_type` role routing, set `agent_type` to an installed role and never omit it for OMX work/i);
-                    assert.match(config, /role_routing_unavailable/i);
+                    assert.match(config, /When it reports `role_routing_unavailable` and adapted Ralplan authority is requested/i);
                     assert.match(config, /do not fabricate `agent_type`/i);
                     assert.match(config, /omx ralplan preflight --json/i);
                     assert.match(config, /unsupported_documented_leader_proof/i);
+                    assert.match(config, /Ordinary work remains under its own workflow gates/i);
                     assert.match(config, /never fake the role via a prompt label/i);
+                    assert.doesNotMatch(config, /before Ralplan planning, state, HUD, runtime, or delegation work, run `omx ralplan preflight --json`/i);
                     assert.doesNotMatch(config, /Native subagents live in \.codex\/agents/);
                     assert.doesNotMatch(config, /Treat installed prompts as narrower execution surfaces/);
                     assert.match(config, /^plugin_hooks = true$/m);
@@ -1518,8 +1520,11 @@ describe("omx setup install mode behavior", () => {
                     const config = await readFile(configPath, "utf-8");
                     assert.match(config, /<omx version=\\"1\\">You have oh-my-codex installed through Codex plugin mode/);
                     assert.match(config, /When the native surface exposes `agent_type` role routing, set `agent_type` to an installed role and never omit it for OMX work/i);
-                    assert.match(config, /role_routing_unavailable/i);
+                    assert.match(config, /When it reports `role_routing_unavailable` and adapted Ralplan authority is requested/i);
+                    assert.match(config, /Ordinary work remains under its own workflow gates/i);
                     assert.match(config, /omx ralplan preflight --json/i);
+                    assert.match(config, /unsupported_documented_leader_proof/i);
+                    assert.doesNotMatch(config, /before Ralplan planning, state, HUD, runtime, or delegation work, run `omx ralplan preflight --json`/i);
                     assert.equal((config.match(/^developer_instructions\s*=/gm) ?? []).length, 1);
                 });
             });
@@ -2409,6 +2414,180 @@ describe("omx setup install mode behavior", () => {
             await rm(wd, { recursive: true, force: true });
         }
     });
+    it("completes Windows native-hook transactions with one directory fsync EPERM warning", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-setup-windows-directory-fsync-eperm-"));
+        const resetPlatform = setNativeHookTransactionPlatformForTest("win32");
+        const resetRegularSync = setNativeHookTransactionRegularFileSyncForTest(async () => undefined);
+        let directorySyncCalls = 0;
+        const stderr = [];
+        const originalStderrWrite = process.stderr.write;
+        process.stderr.write = ((chunk) => {
+            stderr.push(String(chunk));
+            return true;
+        });
+        const resetDurability = setNativeHookClaimJournalDurabilityForTest({
+            platform: "win32",
+            syncRegularFile: async () => "synced",
+            syncDirectory: async () => {
+                directorySyncCalls += 1;
+                return "unsupported-windows-eperm";
+            },
+        });
+        try {
+            await withIsolatedUserHome(wd, async (codexHomeDir) => {
+                await withTempCwd(wd, async () => {
+                    await writeFile(join(codexHomeDir, "config.toml"), 'notify = ["node", "/tmp/user-notify.js"]\n');
+                    await setup({ scope: "user", installMode: "legacy", skipNativeAgentRefresh: true });
+                    assert.ok(directorySyncCalls > 0);
+                    assert.equal(existsSync(join(codexHomeDir, "hooks.json")), true);
+                    assert.equal(existsSync(buildManagedCodexNativeHookWindowsShimPath(codexHomeDir)), true);
+                    assert.equal(existsSync(join(codexHomeDir, "config.toml")), true);
+                });
+                assert.deepEqual(stderr.filter((line) => line.includes("native-hook setup")), ["[omx] warning: Windows EPERM directory fsync unsupported in native-hook setup; operation succeeded with degraded durability.\n"]);
+            });
+        }
+        finally {
+            process.stderr.write = originalStderrWrite;
+            resetDurability();
+            resetRegularSync();
+            resetPlatform();
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
+    for (const fixture of [
+        { platform: "win32", code: "EACCES" },
+        { platform: "linux", code: "EPERM" },
+    ]) {
+        it(`fails native-hook setup for ${fixture.platform} directory fsync ${fixture.code}`, async () => {
+            const wd = await mkdtemp(join(tmpdir(), "omx-setup-directory-fsync-fatal-"));
+            const resetPlatform = setNativeHookTransactionPlatformForTest("win32");
+            const resetDurability = setNativeHookClaimJournalDurabilityForTest({
+                platform: fixture.platform,
+                syncRegularFile: async () => "synced",
+                syncDirectory: async () => {
+                    throw Object.assign(new Error(`${fixture.code}: fsync`), { code: fixture.code });
+                },
+            });
+            try {
+                await withIsolatedUserHome(wd, async () => {
+                    await withTempCwd(wd, async () => {
+                        await assert.rejects(setup({ scope: "user", installMode: "legacy", skipNativeAgentRefresh: true }), new RegExp(fixture.code));
+                    });
+                });
+            }
+            finally {
+                resetDurability();
+                resetPlatform();
+                await rm(wd, { recursive: true, force: true });
+            }
+        });
+    }
+    it("accepts Windows mode synthesis during a newly created hook read-back", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-setup-windows-mode-readback-"));
+        const resetPlatform = setNativeHookTransactionPlatformForTest("win32");
+        const successfulStatsByPath = new Map();
+        const synthesizedPaths = new Set();
+        const resetArtifactLstat = setNativeHookTransactionArtifactLstatForTest(async (path) => {
+            const status = await lstat(path);
+            if (!basename(path).includes("hooks.json"))
+                return status;
+            const successfulStats = successfulStatsByPath.get(path) ?? 0;
+            successfulStatsByPath.set(path, successfulStats + 1);
+            const mode = successfulStats === 0 ? 0o600 : 0o666;
+            if (successfulStats === 1)
+                synthesizedPaths.add(path);
+            return new Proxy(status, {
+                get(target, property, receiver) {
+                    if (property === "mode")
+                        return (target.mode & ~0o7777) | mode;
+                    return Reflect.get(target, property, receiver);
+                },
+            });
+        });
+        try {
+            await withIsolatedUserHome(wd, async (codexHomeDir) => {
+                await withTempCwd(wd, async () => {
+                    await setup({ scope: "user", installMode: "legacy", skipNativeAgentRefresh: true });
+                    assert.equal(existsSync(join(codexHomeDir, "hooks.json")), true);
+                });
+            });
+            assert.ok(synthesizedPaths.size >= 2);
+        }
+        finally {
+            resetArtifactLstat();
+            resetPlatform();
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
+    it("rejects Windows mode drift after a stable hook read-back", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-setup-windows-post-read-mode-drift-"));
+        const resetPlatform = setNativeHookTransactionPlatformForTest("win32");
+        const tempPath = (path, purpose) => join(dirname(path), `.${basename(path)}.post-read-${purpose}.tmp`);
+        const resetTemporaryPath = setNativeHookTransactionTemporaryPathForTest(tempPath);
+        let injected = false;
+        const resetFailureInjector = setNativeHookTransactionFailureInjectorForTest((stage, artifact) => {
+            if (stage !== "before_rename" || artifact.kind !== "hooks" || injected)
+                return;
+            injected = true;
+            chmodSync(tempPath(artifact.path, "write"), 0o666);
+        });
+        try {
+            await withIsolatedUserHome(wd, async (codexHomeDir) => {
+                await withTempCwd(wd, async () => {
+                    await assert.rejects(setup({ scope: "user", installMode: "legacy", skipNativeAgentRefresh: true }), /read-back changed/);
+                    assert.equal(existsSync(join(codexHomeDir, "hooks.json")), false);
+                });
+            });
+            assert.equal(injected, true);
+        }
+        finally {
+            resetFailureInjector();
+            resetTemporaryPath();
+            resetPlatform();
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
+    it("rejects Windows writable-bit drift with unchanged bytes and file identity", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-setup-windows-readonly-drift-"));
+        const resetPlatform = setNativeHookTransactionPlatformForTest("win32");
+        const tempPath = (path, purpose) => join(dirname(path), `.${basename(path)}.readonly-${purpose}.tmp`);
+        const resetTemporaryPath = setNativeHookTransactionTemporaryPathForTest(tempPath);
+        let checkedIdentity = 0;
+        const resetFailureInjector = setNativeHookTransactionFailureInjectorForTest((stage, artifact) => {
+            if (stage !== "before_rename")
+                return;
+            const temporaryPath = tempPath(artifact.path, "write");
+            const before = lstatSync(temporaryPath);
+            const beforeBytes = readFileSync(temporaryPath);
+            chmodSync(temporaryPath, 0o444);
+            const after = lstatSync(temporaryPath);
+            assert.deepEqual(readFileSync(temporaryPath), beforeBytes);
+            assert.equal(after.dev, before.dev);
+            assert.equal(after.ino, before.ino);
+            assert.equal(after.nlink, before.nlink);
+            assert.notEqual(after.mode & 0o200, before.mode & 0o200);
+            checkedIdentity += 1;
+        });
+        try {
+            await withIsolatedUserHome(wd, async (codexHomeDir) => {
+                await withTempCwd(wd, async () => {
+                    const configPath = join(codexHomeDir, "config.toml");
+                    const original = 'notify = ["node", "/tmp/user-notify.js"]\n';
+                    await writeFile(configPath, original);
+                    chmodSync(configPath, 0o600);
+                    await assert.rejects(setup({ scope: "user", installMode: "legacy", skipNativeAgentRefresh: true }), /read-back changed/);
+                    assert.equal(await readFile(configPath, "utf-8"), original);
+                });
+            });
+            assert.equal(checkedIdentity, 1);
+        }
+        finally {
+            resetFailureInjector();
+            resetTemporaryPath();
+            resetPlatform();
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
     it("orders Windows plugin-transition mutations as hooks, shim, then config", async () => {
         const wd = await mkdtemp(join(tmpdir(), "omx-setup-windows-hook-removal-"));
         const forwardOrder = [];