oh-my-codex 0.18.11 → 0.18.13

package/plugins/oh-my-codex/hooks/codex-native-hook.mjs

@@ -9,6 +9,7 @@ const hookDir = dirname(fileURLToPath(import.meta.url));
 const OMX_PLUGIN_HOOK_LAUNCHER_CONTRACT_MARKER = 'omx-plugin-hook-launcher:v1';
 const MAX_WRAPPER_STDIN_BYTES = 1024 * 1024;
 const RAW_EVENT_SCAN_BYTES = 64 * 1024;
+const MAX_STOP_STDOUT_BYTES = 1024 * 1024;
 const CODEX_HOOK_EVENT_NAMES = new Set([
   'SessionStart',
   'PreToolUse',
@@ -270,6 +271,19 @@ function hasActiveAutopilotStateForOversizedStop(input) {
   return shouldContinueAutopilotState(sessionState);
 }
 
+
+function parseSingleJsonObjectOutput(raw) {
+  const text = String(raw ?? '').trim();
+  if (!text) return null;
+  try {
+    const parsed = JSON.parse(text);
+    if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) return null;
+    return parsed;
+  } catch {
+    return null;
+  }
+}
+
 function writeJsonNoop() {
   process.stdout.write(`${JSON.stringify({})}\n`);
   process.exitCode = 0;
@@ -310,13 +324,33 @@ async function main() {
     shell: process.platform === 'win32',
   });
 
+  const stdoutChunks = [];
   let stdoutBytes = 0;
+  let bufferedStopStdoutBytes = 0;
+  let stopStdoutOversized = false;
   let childSpawnError = null;
   let childStdinError = null;
 
   child.stdout.on('data', (chunk) => {
-    stdoutBytes += Buffer.byteLength(chunk);
-    process.stdout.write(chunk);
+    const buffer = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
+    stdoutBytes += buffer.byteLength;
+    if (isStop) {
+      if (!stopStdoutOversized) {
+        const remaining = MAX_STOP_STDOUT_BYTES - bufferedStopStdoutBytes;
+        if (remaining > 0) {
+          const slice = buffer.subarray(0, remaining);
+          stdoutChunks.push(slice);
+          bufferedStopStdoutBytes += slice.byteLength;
+        }
+        if (buffer.byteLength > remaining) {
+          stopStdoutOversized = true;
+          child.stdout.destroy();
+          child.kill();
+        }
+      }
+    } else {
+      process.stdout.write(chunk);
+    }
   });
   child.stderr.pipe(process.stderr);
   child.stdin.on('error', (error) => {
@@ -326,6 +360,23 @@ async function main() {
     childSpawnError = error;
   });
   child.on('close', (code, signal) => {
+    if (isStop && stopStdoutOversized) {
+      writeStopFallback('plugin_stop_hook_launcher_stdout_oversized', `codex-native-hook produced more than ${MAX_STOP_STDOUT_BYTES} bytes of Stop hook stdout`);
+      return;
+    }
+
+    if (isStop && stdoutBytes > 0) {
+      const stdoutText = Buffer.concat(stdoutChunks).toString('utf8');
+      const parsed = parseSingleJsonObjectOutput(stdoutText);
+      if (parsed) {
+        process.stdout.write(`${JSON.stringify(parsed)}\n`);
+        process.exitCode = 0;
+        return;
+      }
+      writeStopFallback('plugin_stop_hook_launcher_invalid_stdout', `codex-native-hook produced invalid Stop hook JSON stdout (${stdoutBytes} bytes)`);
+      return;
+    }
+
     if (isStop && stdoutBytes === 0) {
       if (childSpawnError) {
         writeStopFallback('plugin_stop_hook_launcher_spawn_error', `failed to launch ${command} codex-native-hook: ${childSpawnError.message}`);

package/plugins/oh-my-codex/skills/best-practice-research/SKILL.md

@@ -12,6 +12,10 @@ Use this skill when a task depends on current external best practices, version-a
 
 Produce a cited, reusable best-practice answer or handoff that separates current external evidence from repo-local facts and dependency-selection decisions. For pre-planning investigation, this is the ordinary first research wrapper: gather official/upstream evidence, then hand it to `$ralplan` or the caller as planning input. Do not present `$best-practice-research` as a final architecture component or as a validator-gated research loop.
 
+## Terminal By Default
+
+This skill is terminal and read-only by default. It gathers evidence and produces a cited recommendation with a handoff, then stops. Do not write or edit files, create or amend commits, run mutating commands, or otherwise modify repository state under this skill — even when the question has clear implementation implications. When implementation is warranted, stop and hand off rather than continuing: name `$ralplan` for planning and `$ultragoal`, `$team`, or `executor` for execution, and resume only after the user explicitly switches to that workflow.
+
 ## Activate When
 
 - The user asks for best practices, recommended approach, current guidance, official recommendations, standards, or version-aware external behavior.
@@ -71,7 +75,7 @@ Produce a cited, reusable best-practice answer or handoff that separates current
 <what this research does not decide>
 
 ### Handoff
-<planning/execution/test implications>
+<planning/execution/test implications; name the next workflow — `$ralplan` for planning, `$ultragoal`/`$team`/`executor` for execution — and note that this skill stops here unless the user explicitly switches workflows>
 ```
 
 ## Stop Rules
@@ -79,5 +83,6 @@ Produce a cited, reusable best-practice answer or handoff that separates current
 - Stop after a source-backed recommendation is reusable by the caller.
 - Stop and route upward if the task becomes dependency comparison, broad architecture, or implementation.
 - Do not continue researching when remaining work would only polish wording rather than change the recommendation.
+- This skill never implements. After delivering the recommendation and handoff, stop; do not modify repo files or repo state. Resume only when the user explicitly switches to a planning or implementation workflow named in the handoff.
 
 Task: {{ARGUMENTS}}

package/skills/best-practice-research/SKILL.md

@@ -12,6 +12,10 @@ Use this skill when a task depends on current external best practices, version-a
 
 Produce a cited, reusable best-practice answer or handoff that separates current external evidence from repo-local facts and dependency-selection decisions. For pre-planning investigation, this is the ordinary first research wrapper: gather official/upstream evidence, then hand it to `$ralplan` or the caller as planning input. Do not present `$best-practice-research` as a final architecture component or as a validator-gated research loop.
 
+## Terminal By Default
+
+This skill is terminal and read-only by default. It gathers evidence and produces a cited recommendation with a handoff, then stops. Do not write or edit files, create or amend commits, run mutating commands, or otherwise modify repository state under this skill — even when the question has clear implementation implications. When implementation is warranted, stop and hand off rather than continuing: name `$ralplan` for planning and `$ultragoal`, `$team`, or `executor` for execution, and resume only after the user explicitly switches to that workflow.
+
 ## Activate When
 
 - The user asks for best practices, recommended approach, current guidance, official recommendations, standards, or version-aware external behavior.
@@ -71,7 +75,7 @@ Produce a cited, reusable best-practice answer or handoff that separates current
 <what this research does not decide>
 
 ### Handoff
-<planning/execution/test implications>
+<planning/execution/test implications; name the next workflow — `$ralplan` for planning, `$ultragoal`/`$team`/`executor` for execution — and note that this skill stops here unless the user explicitly switches workflows>
 ```
 
 ## Stop Rules
@@ -79,5 +83,6 @@ Produce a cited, reusable best-practice answer or handoff that separates current
 - Stop after a source-backed recommendation is reusable by the caller.
 - Stop and route upward if the task becomes dependency comparison, broad architecture, or implementation.
 - Do not continue researching when remaining work would only polish wording rather than change the recommendation.
+- This skill never implements. After delivering the recommendation and handoff, stop; do not modify repo files or repo state. Resume only when the user explicitly switches to a planning or implementation workflow named in the handoff.
 
 Task: {{ARGUMENTS}}