oh-my-codex 0.17.3 → 0.18.1

package/dist/cli/__tests__/index.test.js

@@ -6,7 +6,7 @@ import { dirname, join } from "node:path";
 import { tmpdir } from "node:os";
 import { fileURLToPath } from "node:url";
 import { once } from "node:events";
-import { HELP, normalizeCodexLaunchArgs, buildTmuxShellCommand, buildTmuxPaneCommand, shouldSourceTmuxPaneShellRc, buildWindowsPromptCommand, buildTmuxSessionName, resolveCliInvocation, commandOwnsLocalHelp, resolveCodexLaunchPolicy, resolveEffectiveLeaderLaunchPolicyOverride, resolveEnvLaunchPolicyOverride, resolveLeaderLaunchPolicyOverride, classifyCodexExecFailure, resolveSignalExitCode, parseTmuxPaneSnapshot, findHudWatchPaneIds, buildHudPaneCleanupTargets, readTopLevelTomlString, upsertTopLevelTomlString, collectInheritableTeamWorkerArgs, resolveTeamWorkerLaunchArgsEnv, injectModelInstructionsBypassArgs, resolveWorkerSparkModel, resolveSetupInstallModeArg, resolveSetupMcpModeArg, resolveSetupScopeArg, resolveLaunchConfigRepairOptions, readPersistedSetupPreferences, readPersistedSetupScope, resolveCodexConfigPathForLaunch, resolveCodexHomeForLaunch, resolveProjectLocalCodexHomeForLaunch, shouldAutoIsolateMadmaxLaunch, createMadmaxIsolatedRoot, resolveOmxRootForLaunch, resolveDisposableWorktreeOmxRootForLaunch, prepareCodexHomeForLaunch, runtimeCodexHomePath, buildDetachedSessionBootstrapSteps, buildDetachedTmuxSessionName, buildDetachedSessionFinalizeSteps, buildDetachedSessionRollbackSteps, detectDetachedSessionWindowIndex, resolveNotifyTempContract, buildNotifyTempStartupMessages, buildNotifyFallbackWatcherEnv, shouldEnableNotifyFallbackWatcher, reapStaleNotifyFallbackWatcher, cleanupLaunchOrphanedMcpProcesses, reapPostLaunchOrphanedMcpProcesses, cleanupPostLaunchModeStateFiles, resolveBackgroundHelperLaunchMode, shouldDetachBackgroundHelper, resolveNotifyFallbackWatcherScript, resolveHookDerivedWatcherScript, resolveNotifyHookScript, buildDetachedWindowsBootstrapScript, acquireTmuxExtendedKeysLease, resolveNativeSessionName, releaseTmuxExtendedKeysLease, withTmuxExtendedKeys, CODEX_SQLITE_HOME_ENV, } from "../index.js";
+import { HELP, normalizeCodexLaunchArgs, buildTmuxShellCommand, buildTmuxPaneCommand, shouldSourceTmuxPaneShellRc, buildWindowsPromptCommand, buildTmuxSessionName, resolveCliInvocation, commandOwnsLocalHelp, resolveCodexLaunchPolicy, resolveEffectiveLeaderLaunchPolicyOverride, resolveEnvLaunchPolicyOverride, resolveLeaderLaunchPolicyOverride, classifyCodexExecFailure, resolveSignalExitCode, parseTmuxPaneSnapshot, findHudWatchPaneIds, buildHudPaneCleanupTargets, readTopLevelTomlString, upsertTopLevelTomlString, collectInheritableTeamWorkerArgs, resolveTeamWorkerLaunchArgsEnv, injectModelInstructionsBypassArgs, resolveWorkerSparkModel, resolveSetupInstallModeArg, resolveSetupMcpModeArg, resolveSetupScopeArg, resolveLaunchConfigRepairOptions, readPersistedSetupPreferences, readPersistedSetupScope, resolveCodexConfigPathForLaunch, resolveCodexHomeForLaunch, resolveProjectLocalCodexHomeForLaunch, shouldAutoIsolateMadmaxLaunch, createMadmaxIsolatedRoot, buildMadmaxDetachedLaunchContextKey, resolveOmxRootForLaunch, resolveDisposableWorktreeOmxRootForLaunch, prepareCodexHomeForLaunch, persistProjectLaunchRuntimeAuthState, runtimeCodexHomePath, buildDetachedSessionBootstrapSteps, buildDetachedTmuxSessionName, buildDetachedSessionFinalizeSteps, buildDetachedSessionRollbackSteps, detectDetachedSessionWindowIndex, resolveNotifyTempContract, buildNotifyTempStartupMessages, buildNotifyFallbackWatcherEnv, shouldEnableNotifyFallbackWatcher, reapStaleNotifyFallbackWatcher, cleanupLaunchOrphanedMcpProcesses, reapPostLaunchOrphanedMcpProcesses, cleanupPostLaunchModeStateFiles, resolveBackgroundHelperLaunchMode, shouldDetachBackgroundHelper, resolveNotifyFallbackWatcherScript, resolveHookDerivedWatcherScript, resolveNotifyHookScript, buildDetachedWindowsBootstrapScript, acquireTmuxExtendedKeysLease, resolveNativeSessionName, releaseTmuxExtendedKeysLease, withTmuxExtendedKeys, serializeDetachedSessionParentEnv, CODEX_SQLITE_HOME_ENV, } from "../index.js";
 import { mergeConfig, repairConfigIfNeeded } from "../../config/generator.js";
 import { ensureReusableNodeModules } from "../../utils/repo-deps.js";
 import { readAllState } from "../../hud/state.js";
@@ -57,6 +57,33 @@ describe("madmax state isolation", () => {
             await rm(runs, { recursive: true, force: true });
         }
     });
+    it("stamps a stable detached launch context and exposes it to boxed launch", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-madmax-source-"));
+        const runs = await mkdtemp(join(tmpdir(), "omx-madmax-runs-"));
+        try {
+            const env = { OMX_RUNS_DIR: runs };
+            const runDir = createMadmaxIsolatedRoot(wd, ["--madmax", "--xhigh", "--tmux"], env);
+            const metadata = JSON.parse(await readFile(join(runDir, ".omxbox-run.json"), "utf-8"));
+            const expectedContext = buildMadmaxDetachedLaunchContextKey(wd, ["--madmax", "--xhigh", "--tmux"]);
+            assert.equal(metadata.detached_launch_context, expectedContext);
+            assert.equal(env.OMX_MADMAX_DETACHED_CONTEXT, expectedContext);
+            assert.equal(expectedContext, buildMadmaxDetachedLaunchContextKey(wd, ["--madmax", "--xhigh"]), "explicit --tmux is a transport choice and must not create a second context");
+            assert.equal(expectedContext, buildMadmaxDetachedLaunchContextKey(wd, ["--xhigh", "--madmax", "--direct"]), "argument order and transport choices must not create duplicate detached contexts");
+            assert.notEqual(expectedContext, buildMadmaxDetachedLaunchContextKey(wd, ["--madmax", "--low"]), "different launch semantics may run concurrently");
+            assert.notEqual(buildMadmaxDetachedLaunchContextKey(wd, ["--madmax", "--high", "--xhigh"]), buildMadmaxDetachedLaunchContextKey(wd, ["--madmax", "--xhigh", "--high"]), "last reasoning shorthand wins, so reversed reasoning order is a distinct context");
+            const otherWd = await mkdtemp(join(tmpdir(), "omx-madmax-other-source-"));
+            try {
+                assert.notEqual(expectedContext, buildMadmaxDetachedLaunchContextKey(otherWd, ["--madmax", "--xhigh"]), "different work contexts may run concurrently");
+            }
+            finally {
+                await rm(otherWd, { recursive: true, force: true });
+            }
+        }
+        finally {
+            await rm(wd, { recursive: true, force: true });
+            await rm(runs, { recursive: true, force: true });
+        }
+    });
 });
 describe("resolveOmxRootForLaunch", () => {
     it("preserves POSIX absolute OMX_ROOT", () => {
@@ -682,6 +709,72 @@ describe("cleanupPostLaunchModeStateFiles", () => {
             await rm(wd, { recursive: true, force: true });
         }
     });
+    it("preserves review-pending Autopilot state across postLaunch compact cleanup", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-postlaunch-autopilot-review-pending-"));
+        const sessionId = "sess-autopilot-review-pending";
+        const stateDir = join(wd, ".omx", "state");
+        const sessionStateDir = join(stateDir, "sessions", sessionId);
+        try {
+            await mkdir(sessionStateDir, { recursive: true });
+            await writeFile(join(stateDir, "skill-active-state.json"), JSON.stringify({
+                version: 1,
+                active: true,
+                skill: "autopilot",
+                phase: "code-review",
+                session_id: sessionId,
+                initialized_state_path: `.omx/state/sessions/${sessionId}/autopilot-state.json`,
+                active_skills: [
+                    { skill: "autopilot", phase: "code-review", active: true, session_id: sessionId },
+                ],
+            }, null, 2), "utf-8");
+            await writeFile(join(sessionStateDir, "skill-active-state.json"), JSON.stringify({
+                version: 1,
+                active: true,
+                skill: "autopilot",
+                phase: "code-review",
+                session_id: sessionId,
+                active_skills: [
+                    { skill: "autopilot", phase: "code-review", active: true, session_id: sessionId },
+                ],
+            }, null, 2), "utf-8");
+            await writeFile(join(sessionStateDir, "autopilot-state.json"), JSON.stringify({
+                active: true,
+                mode: "autopilot",
+                current_phase: "code-review",
+                iteration: 1,
+                review_cycle: 0,
+                state: {
+                    phase_cycle: ["ralplan", "ralph", "code-review"],
+                    handoff_artifacts: {
+                        ralplan: ".omx/plans/prd-issue-2366.md",
+                        ralph: { verification: ["npm test"], changed_files: ["src/cli/index.ts"] },
+                        code_review: null,
+                    },
+                    review_verdict: null,
+                    return_to_ralplan_reason: null,
+                },
+            }, null, 2), "utf-8");
+            await cleanupPostLaunchModeStateFiles(wd, sessionId, {
+                now: () => new Date("2026-05-16T11:00:00.000Z"),
+            });
+            const autopilotState = JSON.parse(await readFile(join(sessionStateDir, "autopilot-state.json"), "utf-8"));
+            assert.equal(autopilotState.active, true);
+            assert.equal(autopilotState.current_phase, "code-review");
+            assert.equal(autopilotState.completed_at, undefined);
+            assert.equal(autopilotState.state?.review_verdict, null);
+            const sessionSkill = JSON.parse(await readFile(join(sessionStateDir, "skill-active-state.json"), "utf-8"));
+            assert.equal(sessionSkill.active, true);
+            assert.equal(sessionSkill.skill, "autopilot");
+            assert.equal(sessionSkill.phase, "code-review");
+            const rootSkill = JSON.parse(await readFile(join(stateDir, "skill-active-state.json"), "utf-8"));
+            assert.equal(rootSkill.active, true);
+            assert.equal(rootSkill.skill, "autopilot");
+            assert.equal(rootSkill.phase, "code-review");
+        }
+        finally {
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
     it("clears canonical skill-active entries during cleanup and hides them from HUD/overlay readers", async () => {
         const wd = await mkdtemp(join(tmpdir(), "omx-postlaunch-skill-active-cleanup-"));
         const sessionId = "sess-skill-active-cleanup";
@@ -888,6 +981,7 @@ describe("commandOwnsLocalHelp", () => {
         for (const command of [
             "adapt",
             "agents-init",
+            "api",
             "ask",
             "question",
             "autoresearch",
@@ -911,6 +1005,12 @@ describe("commandOwnsLocalHelp", () => {
     });
 });
 describe("resolveCliInvocation", () => {
+    it("resolves api to api command", () => {
+        assert.deepEqual(resolveCliInvocation(["api", "status"]), {
+            command: "api",
+            launchArgs: [],
+        });
+    });
     it("resolves explore to explore command", () => {
         assert.deepEqual(resolveCliInvocation(["explore", "--prompt", "find", "auth"]), {
             command: "explore",
@@ -1274,6 +1374,27 @@ describe("project launch scope helpers", () => {
             await rm(wd, { recursive: true, force: true });
         }
     });
+    it("persists project-scope Codex auth written into the runtime CODEX_HOME mirror", async () => {
+        const wd = await mkdtemp(join(tmpdir(), "omx-launch-runtime-auth-home-"));
+        try {
+            const projectCodexHome = join(wd, ".codex");
+            await mkdir(join(wd, ".omx"), { recursive: true });
+            await mkdir(projectCodexHome, { recursive: true });
+            await writeFile(join(wd, ".omx", "setup-scope.json"), JSON.stringify({ scope: "project" }));
+            await writeFile(join(projectCodexHome, "config.toml"), 'model = "gpt-5.5"\n');
+            const prepared = await prepareCodexHomeForLaunch(wd, "session-auth", {});
+            const runtimeCodexHome = runtimeCodexHomePath(wd, "session-auth");
+            const opaqueAuthState = JSON.stringify({ token: "opaque-test-token" });
+            await writeFile(join(runtimeCodexHome, "auth.json"), opaqueAuthState);
+            await writeFile(join(runtimeCodexHome, "config.toml"), 'model = "gpt-5.5"\n[tui.model_availability_nux]\n"gpt-5.5" = 1\n');
+            await persistProjectLaunchRuntimeAuthState(prepared.runtimeCodexHomeForCleanup, prepared.projectLocalCodexHomeForCleanup);
+            assert.equal(await readFile(join(projectCodexHome, "auth.json"), "utf-8"), opaqueAuthState);
+            assert.equal(await readFile(join(projectCodexHome, "config.toml"), "utf-8"), 'model = "gpt-5.5"\n');
+        }
+        finally {
+            await rm(wd, { recursive: true, force: true });
+        }
+    });
     it("rewrites setup-owned hook trust state for the runtime CODEX_HOME mirror", async () => {
         const wd = await mkdtemp(join(tmpdir(), "omx-launch-runtime-hook-trust-"));
         try {
@@ -1650,10 +1771,40 @@ describe("detached tmux new-session sequencing", () => {
         assert.equal(newSession.args.some((arg) => arg === "OMXBOX_ACTIVE=1"), true);
         assert.equal(newSession.args.some((arg) => arg === "OMX_SOURCE_CWD=/tmp/source-project"), true);
     });
+    it("serializes custom parent env for the interactive detached tmux leader without logging values in tmux args", () => {
+        const envFilePath = "/tmp/omx-runtime/tmux-env/sess.env";
+        const steps = buildDetachedSessionBootstrapSteps("omx-demo", "/tmp/project", "'codex' '--model' 'gpt-5'", "'node' '/tmp/omx.js' 'hud' '--watch'", null, undefined, null, false, "sess-detached-managed", undefined, undefined, undefined, { CUSTOM_LLM_API_KEY: "fake-provider-key", IS_GAJAE_SLOP_GENERATOR: "1" }, undefined, envFilePath);
+        const newSession = steps.find((step) => step.name === "new-session");
+        assert.ok(newSession);
+        const argsText = newSession.args.join("\n");
+        assert.match(argsText, new RegExp(envFilePath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+        assert.doesNotMatch(argsText, /fake-provider-key/);
+        assert.doesNotMatch(argsText, /CUSTOM_LLM_API_KEY=/);
+        const envScript = serializeDetachedSessionParentEnv({
+            CUSTOM_LLM_API_KEY: "fake-provider-key",
+            IS_GAJAE_SLOP_GENERATOR: "1",
+            "not-a-shell-name": "ignored",
+        });
+        assert.match(envScript, /export CUSTOM_LLM_API_KEY='fake-provider-key'/);
+        assert.match(envScript, /export IS_GAJAE_SLOP_GENERATOR='1'/);
+        assert.doesNotMatch(envScript, /not-a-shell-name/);
+    });
+    it("keeps detached tmux bootstrap bounded when no interactive parent env file is requested", () => {
+        const steps = buildDetachedSessionBootstrapSteps("omx-demo", "/tmp/project", "'codex' '--model' 'gpt-5'", "'node' '/tmp/omx.js' 'hud' '--watch'", null, undefined, null, false, "sess-detached-managed", undefined, undefined, undefined, { CUSTOM_LLM_API_KEY: "fake-provider-key" });
+        const newSession = steps.find((step) => step.name === "new-session");
+        assert.ok(newSession);
+        const argsText = newSession.args.join("\n");
+        assert.doesNotMatch(argsText, /CUSTOM_LLM_API_KEY/);
+        assert.doesNotMatch(argsText, /fake-provider-key/);
+    });
     it("runCodex builds inside-tmux HUD command with OMX_SESSION_ID", async () => {
         const source = await readFile(join(repoRoot, 'src', 'cli', 'index.ts'), 'utf-8');
         assert.match(source, /buildTmuxPaneCommand\("env",\s*\[\s*`OMX_SESSION_ID=\$\{sessionId\}`,\s*`\$\{OMX_TMUX_HUD_OWNER_ENV\}=1`,\s*"node",\s*omxBin,\s*"hud",\s*"--watch",?\s*\]\)/);
     });
+    it("runCodex registers a HUD resize hook immediately for inside-tmux launches", async () => {
+        const source = await readFile(join(repoRoot, 'src', 'cli', 'index.ts'), 'utf-8');
+        assert.match(source, /registerHudResizeHook\(hudPaneId,\s*currentPaneId,\s*HUD_TMUX_HEIGHT_LINES\)/);
+    });
     it("buildDetachedSessionBootstrapSteps starts native Windows detached sessions with powershell", () => {
         const hudCmd = buildWindowsPromptCommand("node", [
             "omx.js",
@@ -2226,7 +2377,7 @@ exit 0
     it("reapStaleNotifyFallbackWatcher sends SIGTERM only after confirming watcher identity", async () => {
         const cwd = await mkdtemp(join(tmpdir(), "omx-reap-pid-confirmed-"));
         const pidPath = join(cwd, "watcher.pid");
-        await writeFile(pidPath, JSON.stringify({ pid: 12345, started_at: new Date().toISOString() }));
+        await writeFile(pidPath, JSON.stringify({ pid: 12345, started_at: "2026-04-05T00:00:00.000Z" }));
         const killed = [];
         await reapStaleNotifyFallbackWatcher(pidPath, {
             isWatcherProcess: () => true,
@@ -2235,6 +2386,21 @@ exit 0
         assert.deepEqual(killed, [12345], "should SIGTERM the verified watcher process");
         await rm(cwd, { recursive: true, force: true });
     });
+    it("reapStaleNotifyFallbackWatcher skips recently started watcher records to avoid respawn loops", async () => {
+        const cwd = await mkdtemp(join(tmpdir(), "omx-reap-pid-recent-"));
+        const pidPath = join(cwd, "watcher.pid");
+        await writeFile(pidPath, JSON.stringify({ pid: 24680, started_at: "2026-05-15T00:00:00.000Z" }));
+        const killed = [];
+        const result = await reapStaleNotifyFallbackWatcher(pidPath, {
+            isWatcherProcess: () => true,
+            nowMs: () => Date.parse("2026-05-15T00:00:03.000Z"),
+            reapGraceMs: 5000,
+            tryKillPid: (pid) => { killed.push(pid); return true; },
+        });
+        assert.equal(result, "recent_active");
+        assert.equal(killed.length, 0, "should not kill a watcher still inside the startup grace window");
+        await rm(cwd, { recursive: true, force: true });
+    });
     it("reuses legacy plain-text PID parsing without widening stale reap semantics across PID reuse", async () => {
         const cwd = await mkdtemp(join(tmpdir(), "omx-reap-legacy-pid-"));
         try {
@@ -2460,8 +2626,8 @@ exit 0
         const registerHook = steps.find((step) => step.name === "register-resize-hook");
         const schedule = steps.find((step) => step.name === "schedule-delayed-resize");
         const reconcile = steps.find((step) => step.name === "reconcile-hud-resize");
-        assert.match(registerHook?.args[4] ?? "", />\/dev\/null 2>&1 \|\| true/);
-        assert.match(registerHook?.args[4] ?? "", new RegExp(`-y ${HUD_TMUX_HEIGHT_LINES}\\b`));
+        assert.match(registerHook?.args[5] ?? "", />\/dev\/null 2>&1 \|\| true/);
+        assert.match(registerHook?.args[5] ?? "", new RegExp(`-y ${HUD_TMUX_HEIGHT_LINES}\\b`));
         assert.match(schedule?.args[2] ?? "", />\/dev\/null 2>&1 \|\| true/);
         assert.match(schedule?.args[2] ?? "", new RegExp(`-y ${HUD_TMUX_HEIGHT_LINES}\\b`));
         assert.match((reconcile?.args ?? []).join(" "), />\/dev\/null 2>&1 \|\| true/);
@@ -2495,7 +2661,7 @@ exit 0
         assert.equal(steps[0]?.args[2], "-t");
         assert.equal(steps[0]?.args[3], "omx-demo:0");
         assert.match(steps[0]?.args[4] ?? "", /^client-attached\[\d+\]$/);
-        assert.match(steps[1]?.args[4] ?? "", /^client-resized\[\d+\]$/);
+        assert.match(steps[1]?.args[5] ?? "", /^window-resized\[\d+\]$/);
         assert.deepEqual(steps[2]?.args, ["kill-session", "-t", "omx-demo"]);
     });
     it("buildDetachedSessionRollbackSteps only kills session when no hook metadata exists", () => {