oh-my-codex 0.16.0 → 0.16.2

package/dist/team/__tests__/runtime.test.js

@@ -1,8 +1,9 @@
 import { afterEach, beforeEach, describe, it } from 'node:test';
 import assert from 'node:assert/strict';
+import { createHash } from 'node:crypto';
 import { execFileSync, spawn } from 'child_process';
 import { mkdtemp, rm, writeFile, readFile, mkdir, chmod, readdir } from 'fs/promises';
-import { join } from 'path';
+import { join, relative } from 'path';
 import { tmpdir } from 'os';
 import { existsSync } from 'fs';
 import { HUD_TMUX_TEAM_HEIGHT_LINES } from '../../hud/constants.js';
@@ -32,6 +33,45 @@ async function addWorktree(repo, branchName, pathPrefix) {
     execFileSync('git', ['worktree', 'add', '-b', branchName, worktreePath, 'HEAD'], { cwd: repo, stdio: 'ignore' });
     return worktreePath;
 }
+function computeGitBlobSha1(content) {
+    const buffer = Buffer.from(content, 'utf-8');
+    const header = Buffer.from(`blob ${buffer.length}\0`, 'utf-8');
+    return createHash('sha1').update(header).update(buffer).digest('hex');
+}
+function canonicalContextPackRelativePath(slug) {
+    return `.omx/context/context-20260507T120000Z-${slug}.json`;
+}
+function buildContextPackOutcome(relativePackPath) {
+    return [
+        '## Context Pack Outcome',
+        '',
+        `- pack: created \`${relativePackPath}\``,
+    ].join('\n');
+}
+async function writeReadyContextPack(cwd, slug, prdPath, testSpecPath) {
+    const contextDir = join(cwd, '.omx', 'context');
+    const packPath = join(cwd, canonicalContextPackRelativePath(slug));
+    const prdContent = await readFile(prdPath, 'utf-8');
+    const testSpecContent = await readFile(testSpecPath, 'utf-8');
+    await mkdir(contextDir, { recursive: true });
+    await writeFile(packPath, JSON.stringify({
+        slug,
+        basis: {
+            prd: {
+                path: relative(cwd, prdPath).replaceAll('\\', '/'),
+                sha1: computeGitBlobSha1(prdContent),
+            },
+            testSpecs: [{
+                    path: relative(cwd, testSpecPath).replaceAll('\\', '/'),
+                    sha1: computeGitBlobSha1(testSpecContent),
+                }],
+        },
+        entries: ['scope', 'build', 'verify'].map((role, index) => ({
+            path: `src/${role}-${index}.ts`,
+            roles: [role],
+        })),
+    }, null, 2));
+}
 async function attachDirtyWorkerRepo(teamName, cwd, repoName) {
     const repo = join(cwd, repoName);
     await mkdir(repo, { recursive: true });
@@ -61,6 +101,7 @@ function withIsolatedDefaultModelEnv(run) {
         'OMX_DEFAULT_STANDARD_MODEL',
         'OMX_DEFAULT_SPARK_MODEL',
         'OMX_SPARK_MODEL',
+        'OMX_TEAM_WORKER_LAUNCH_ARGS',
     ]) {
         savedEnv.set(key, process.env[key]);
         delete process.env[key];
@@ -86,6 +127,7 @@ async function withIsolatedDefaultModelEnvAsync(run) {
         'OMX_DEFAULT_STANDARD_MODEL',
         'OMX_DEFAULT_SPARK_MODEL',
         'OMX_SPARK_MODEL',
+        'OMX_TEAM_WORKER_LAUNCH_ARGS',
     ]) {
         savedEnv.set(key, process.env[key]);
         delete process.env[key];
@@ -2840,7 +2882,7 @@ process.exit(0);
             await rm(cwd, { recursive: true, force: true });
         }
     });
-    it('startTeam preserves routed task roles into team state and worker launch args', async () => {
+    it('startTeam preserves routed task roles into team state and override-aware worker launch args', async () => {
         const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-role-routing-'));
         const binDir = join(cwd, 'bin');
         const fakeCodexPath = join(binDir, 'codex');
@@ -2875,10 +2917,19 @@ process.on('SIGTERM', () => process.exit(0));
         delete process.env.OMX_DEFAULT_STANDARD_MODEL;
         let runtime = null;
         try {
-            runtime = await withIsolatedDefaultModelEnvAsync(async () => await withMockPromptModeCodexAllowed(() => withoutTeamWorkerEnv(() => startTeam('team-role-routing', 'heuristic routing handoff', 'executor', 2, [
-                { subject: 'test routing report only', description: 'test routing report only', owner: 'worker-1', role: 'test-engineer' },
-                { subject: 'document routing report only', description: 'document routing report only', owner: 'worker-2', role: 'writer' },
-            ], cwd))));
+            runtime = await withIsolatedDefaultModelEnvAsync(async () => {
+                assert.ok(process.env.CODEX_HOME, 'isolated CODEX_HOME should be set');
+                await mkdir(process.env.CODEX_HOME, { recursive: true });
+                await writeFile(join(process.env.CODEX_HOME, '.omx-config.json'), JSON.stringify({
+                    agentReasoning: {
+                        writer: 'xhigh',
+                    },
+                }));
+                return await withMockPromptModeCodexAllowed(() => withoutTeamWorkerEnv(() => startTeam('team-role-routing', 'heuristic routing handoff', 'executor', 2, [
+                    { subject: 'test routing report only', description: 'test routing report only', owner: 'worker-1', role: 'test-engineer' },
+                    { subject: 'document routing report only', description: 'document routing report only', owner: 'worker-2', role: 'writer' },
+                ], cwd)));
+            });
             assert.equal(runtime.config.worker_launch_mode, 'prompt');
             assert.equal(runtime.config.workers[0]?.role, 'test-engineer');
             assert.equal(runtime.config.workers[1]?.role, 'writer');
@@ -2917,7 +2968,7 @@ process.on('SIGTERM', () => process.exit(0));
             assert.match(worker1Joined, /model_reasoning_effort="medium"/);
             assert.match(worker1Joined, /model_instructions_file=.*worker-1\/AGENTS\.md/);
             assert.match(worker1Joined, /--model gpt-5\.5/);
-            assert.match(worker2Joined, /model_reasoning_effort="high"/);
+            assert.match(worker2Joined, /model_reasoning_effort="xhigh"/);
             assert.match(worker2Joined, /model_instructions_file=.*worker-2\/AGENTS\.md/);
             assert.match(worker2Joined, /--model gpt-5\.5/);
             await shutdownTeam(runtime.teamName, cwd, { force: true });
@@ -5115,6 +5166,56 @@ esac
             await rm(cwd, { recursive: true, force: true });
         }
     });
+    it('resumeTeam fails closed when the persisted approved binding is ambiguous', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-resume-ambiguous-'));
+        const approvedTask = 'Execute approved issue 2111 plan';
+        try {
+            await initTeamState('team-approved-resume', 'approved resume test', 'executor', 1, cwd);
+            await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
+            const prdPath = join(cwd, '.omx', 'plans', 'prd-issue-2111.md');
+            await writeFile(prdPath, [
+                '# Approved plan',
+                '',
+                `Launch via omx team 2:executor "${approvedTask}"`,
+                `Launch via omx team 5:debugger "${approvedTask}"`,
+            ].join('\n'));
+            await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-2111.md'), '# Test spec\n');
+            await writePersistedApprovedTeamExecutionBinding('team-approved-resume', cwd, {
+                prd_path: prdPath,
+                task: approvedTask,
+            });
+            await assert.rejects(() => resumeTeam('team-approved-resume', cwd), /approved_execution_binding_ambiguous:.*Execute approved issue 2111 plan/);
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('resumeTeam fails closed when the persisted approved binding is nonready', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-resume-nonready-'));
+        try {
+            await initTeamState('team-approved-resume', 'approved resume test', 'executor', 1, cwd);
+            await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
+            const prdPath = join(cwd, '.omx', 'plans', 'prd-issue-2112.md');
+            await writeFile(prdPath, [
+                '# Approved plan',
+                '',
+                '## Context Pack Outcome',
+                '',
+                '- pack: created `.omx/context/context-20260507T120000Z-other.json`',
+                '',
+                'Launch via omx team 1:executor "Execute approved issue 2112 plan"',
+            ].join('\n'));
+            await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-2112.md'), '# Test spec\n');
+            await writePersistedApprovedTeamExecutionBinding('team-approved-resume', cwd, {
+                prd_path: prdPath,
+                task: 'Execute approved issue 2112 plan',
+            });
+            await assert.rejects(() => resumeTeam('team-approved-resume', cwd), /approved_execution_binding_nonready:invalid:.*Execute approved issue 2112 plan/);
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
     it('resumeTeam resolves approved binding continuity against the persisted leader cwd', async () => {
         const teamName = 'team-approved-shared-root';
         const leaderCwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-leader-'));
@@ -5312,14 +5413,23 @@ esac
         const fakeCodexPath = join(binDir, 'codex');
         await mkdir(binDir, { recursive: true });
         await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
-        await writeFile(join(cwd, '.omx', 'plans', 'prd-issue-1314.md'), '# Approved plan\n\nLaunch via omx team 1:executor "Execute approved issue 1314 plan"\n');
-        await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-1314.md'), '# Test spec\n');
+        const prdPath = join(cwd, '.omx', 'plans', 'prd-issue-1314.md');
+        const testSpecPath = join(cwd, '.omx', 'plans', 'test-spec-issue-1314.md');
+        await writeFile(prdPath, [
+            '# Approved plan',
+            '',
+            buildContextPackOutcome(canonicalContextPackRelativePath('issue-1314')),
+            '',
+            'Launch via omx team 1:executor "Execute approved issue 1314 plan"',
+        ].join('\n'));
+        await writeFile(testSpecPath, '# Test spec\n');
+        await writeReadyContextPack(cwd, 'issue-1314', prdPath, testSpecPath);
         await writeFakePromptWorkerBinary(fakeCodexPath, `setTimeout(() => {}, 5000);`);
         let runtime = null;
         try {
             runtime = await withPromptModeCodexEnv(binDir, {}, () => withoutTeamWorkerEnv(() => startTeam('team-approved-binding', 'approved binding persistence test', 'executor', 1, [{ subject: 's', description: 'd', owner: 'worker-1' }], cwd, {
                 approvedExecution: {
-                    prd_path: join(cwd, '.omx', 'plans', 'prd-issue-1314.md'),
+                    prd_path: prdPath,
                     task: 'Execute approved issue 1314 plan',
                     command: 'omx team 1:executor "Execute approved issue 1314 plan"',
                 },
@@ -5327,7 +5437,7 @@ esac
             const bindingPath = join(runtime.config.team_state_root ?? join(cwd, '.omx', 'state'), 'team', runtime.teamName, 'approved-execution.json');
             const binding = JSON.parse(await readFile(bindingPath, 'utf-8'));
             assert.deepEqual(binding, {
-                prd_path: join(cwd, '.omx', 'plans', 'prd-issue-1314.md'),
+                prd_path: prdPath,
                 task: 'Execute approved issue 1314 plan',
                 command: 'omx team 1:executor "Execute approved issue 1314 plan"',
             });
@@ -5340,6 +5450,65 @@ esac
             await rm(cwd, { recursive: true, force: true });
         }
     });
+    it('startTeam keeps explicit plan-only approved bindings on the generic path', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-binding-plan-only-'));
+        const binDir = join(cwd, 'bin');
+        const fakeCodexPath = join(binDir, 'codex');
+        await mkdir(binDir, { recursive: true });
+        await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
+        await writeFile(join(cwd, '.omx', 'plans', 'prd-issue-1314-plan-only.md'), '# Approved plan\n\nLaunch via omx team 1:executor "Execute approved issue 1314 plan-only"\n');
+        await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-1314-plan-only.md'), '# Test spec\n');
+        await writeFakePromptWorkerBinary(fakeCodexPath, `setTimeout(() => {}, 5000);`);
+        let runtime = null;
+        try {
+            runtime = await withPromptModeCodexEnv(binDir, {}, () => withoutTeamWorkerEnv(() => startTeam('team-approved-binding-plan-only', 'approved binding generic fallback test', 'executor', 1, [{ subject: 's', description: 'd', owner: 'worker-1' }], cwd, {
+                approvedExecution: {
+                    prd_path: join(cwd, '.omx', 'plans', 'prd-issue-1314-plan-only.md'),
+                    task: 'Execute approved issue 1314 plan-only',
+                    command: 'omx team 1:executor "Execute approved issue 1314 plan-only"',
+                },
+            })));
+            const bindingPath = join(runtime.config.team_state_root ?? join(cwd, '.omx', 'state'), 'team', runtime.teamName, 'approved-execution.json');
+            assert.equal(existsSync(bindingPath), false);
+        }
+        finally {
+            if (runtime) {
+                await shutdownTeam(runtime.teamName, cwd, { force: true }).catch(() => { });
+            }
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('startTeam fails closed when an explicit approved execution binding is nonready', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-binding-nonready-'));
+        const binDir = join(cwd, 'bin');
+        const fakeCodexPath = join(binDir, 'codex');
+        await mkdir(binDir, { recursive: true });
+        await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
+        const prdPath = join(cwd, '.omx', 'plans', 'prd-issue-1314-nonready.md');
+        await writeFile(prdPath, [
+            '# Approved plan',
+            '',
+            '## Context Pack Outcome',
+            '',
+            '- pack: created `.omx/context/context-20260507T120000Z-other.json`',
+            '',
+            'Launch via omx team 1:executor "Execute approved issue 1314 nonready plan"',
+        ].join('\n'));
+        await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-1314-nonready.md'), '# Test spec\n');
+        await writeFakePromptWorkerBinary(fakeCodexPath, `setTimeout(() => {}, 5000);`);
+        try {
+            await assert.rejects(() => withPromptModeCodexEnv(binDir, {}, () => withoutTeamWorkerEnv(() => startTeam('team-approved-binding-nonready', 'approved binding nonready start test', 'executor', 1, [{ subject: 's', description: 'd', owner: 'worker-1' }], cwd, {
+                approvedExecution: {
+                    prd_path: prdPath,
+                    task: 'Execute approved issue 1314 nonready plan',
+                },
+            }))), /approved_execution_binding_nonready:invalid:.*Execute approved issue 1314 nonready plan/);
+            assert.equal(existsSync(join(cwd, '.omx', 'state', 'team', 'team-approved-binding-nonready')), false);
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
     it('startTeam fails closed when an explicit approved execution binding is stale', async () => {
         const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-binding-stale-'));
         const binDir = join(cwd, 'bin');
@@ -5364,6 +5533,35 @@ esac
             await rm(cwd, { recursive: true, force: true });
         }
     });
+    it('startTeam fails closed when an explicit approved execution binding is ambiguous', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-approved-binding-ambiguous-'));
+        const binDir = join(cwd, 'bin');
+        const fakeCodexPath = join(binDir, 'codex');
+        const approvedTask = 'Execute approved issue 1316 plan';
+        await mkdir(binDir, { recursive: true });
+        await mkdir(join(cwd, '.omx', 'plans'), { recursive: true });
+        const prdPath = join(cwd, '.omx', 'plans', 'prd-issue-1316.md');
+        await writeFile(prdPath, [
+            '# Approved plan',
+            '',
+            `Launch via omx team 2:executor "${approvedTask}"`,
+            `Launch via omx team 5:debugger "${approvedTask}"`,
+        ].join('\n'));
+        await writeFile(join(cwd, '.omx', 'plans', 'test-spec-issue-1316.md'), '# Test spec\n');
+        await writeFakePromptWorkerBinary(fakeCodexPath, `setTimeout(() => {}, 5000);`);
+        try {
+            await assert.rejects(() => withPromptModeCodexEnv(binDir, {}, () => withoutTeamWorkerEnv(() => startTeam('team-approved-binding-ambiguous', 'approved binding ambiguous start test', 'executor', 1, [{ subject: 's', description: 'd', owner: 'worker-1' }], cwd, {
+                approvedExecution: {
+                    prd_path: prdPath,
+                    task: approvedTask,
+                },
+            }))), /approved_execution_binding_ambiguous:.*Execute approved issue 1316 plan/);
+            assert.equal(existsSync(join(cwd, '.omx', 'state', 'team', 'team-approved-binding-ambiguous')), false);
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
     it('startTeam remaps repo-aware DAG dependencies after concrete task IDs are created', async () => {
         const cwd = await mkdtemp(join(tmpdir(), 'omx-runtime-'));
         const binDir = join(cwd, 'bin');