oh-my-codex 0.13.1 → 0.14.0

package/Cargo.lock

@@ -32,11 +32,11 @@ checksum = "f8ca58f447f06ed17d5fc4043ce1b10dd205e060fb3ce5b979b8ed8e59ff3f79"
 
 [[package]]
 name = "omx-explore-harness"
-version = "0.13.1"
+version = "0.14.0"
 
 [[package]]
 name = "omx-mux"
-version = "0.13.1"
+version = "0.14.0"
 dependencies = [
  "serde",
  "serde_json",
@@ -44,7 +44,7 @@ dependencies = [
 
 [[package]]
 name = "omx-runtime"
-version = "0.13.1"
+version = "0.14.0"
 dependencies = [
  "omx-mux",
  "omx-runtime-core",
@@ -53,7 +53,7 @@ dependencies = [
 
 [[package]]
 name = "omx-runtime-core"
-version = "0.13.1"
+version = "0.14.0"
 dependencies = [
  "fs2",
  "serde",
@@ -62,7 +62,7 @@ dependencies = [
 
 [[package]]
 name = "omx-sparkshell"
-version = "0.13.1"
+version = "0.14.0"
 dependencies = [
  "omx-mux",
 ]

package/Cargo.toml

@@ -10,7 +10,7 @@ resolver = "2"
 
 [workspace.package]
 
-version = "0.13.1"
+version = "0.14.0"
 
 edition = "2021"
 license = "MIT"

package/README.md

@@ -218,6 +218,8 @@ omx doctor --team
 
 Only use the forced team shutdown for a team you have confirmed is dead or intentionally abandoned.
 
+If `Shift+Enter` still submits instead of inserting a newline inside an OMX-managed tmux session, see [Troubleshooting execution readiness](./docs/troubleshooting.md#shiftenter-submits-instead-of-inserting-a-newline-in-tmux-backed-omx-sessions). Current OMX already enables tmux extended-key forwarding around its own Codex launch paths, so a persistent failure is usually a tmux terminal-capability/discoverability problem rather than a net-new OMX feature gap.
+
 ### Explore and sparkshell
 
 - `omx explore --prompt "..."` is for read-only repository lookup

package/crates/omx-explore/src/main.rs

@@ -12,6 +12,8 @@ const CODEX_BIN_ENV: &str = "OMX_EXPLORE_CODEX_BIN";
 const HARNESS_ROOT_ENV: &str = "OMX_EXPLORE_ROOT";
 const INTERNAL_DIRECT_WRAPPER_FLAG: &str = "--internal-allowlist-direct";
 const INTERNAL_SHELL_WRAPPER_FLAG: &str = "--internal-allowlist-shell";
+const TEMP_ALLOWLIST_DIR_PREFIX: &str = "omx-explore-allowlist-";
+const SHELL_STARTUP_ENV_VARS: &[&str] = &["BASH_ENV", "ENV", "PROMPT_COMMAND"];
 const WINDOWS_UNSUPPORTED_ALLOWLIST_MESSAGE: &str =
     "omx explore built-in harness is not ready on Windows because its allowlist runtime relies on POSIX sh/bash wrappers. Set OMX_EXPLORE_BIN to a compatible custom harness, prefer `omx sparkshell` for shell-native read-only lookups, or run `omx doctor` for readiness details.";
 
@@ -226,6 +228,7 @@ fn invoke_codex(args: &Args, model: &str, prompt_contract: &str) -> io::Result<A
         .env(HARNESS_ROOT_ENV, &args.cwd)
         .env("PATH", &allowlist.bin_dir)
         .env("SHELL", &allowlist.shell_path);
+    sanitize_explore_subprocess_env(&mut command);
     let output = command.output()?;
 
     let markdown = read_to_string(&output_path).ok();
@@ -580,20 +583,46 @@ fn build_direct_wrapper(self_exe: &Path, command: &str) -> Result<String, String
 
 fn resolve_host_command(command: &str) -> Option<PathBuf> {
     let candidate = Path::new(command);
-    if candidate.is_absolute() && is_usable_host_command(candidate) {
+    if candidate.is_absolute()
+        && is_usable_host_command(candidate)
+        && !is_omx_explore_allowlist_path(candidate)
+    {
         return Some(candidate.to_path_buf());
     }
 
     let path = env::var_os("PATH")?;
     for entry in env::split_paths(&path) {
         let resolved = entry.join(command);
-        if is_usable_host_command(&resolved) {
+        if is_usable_host_command(&resolved) && !is_omx_explore_allowlist_path(&resolved) {
             return Some(resolved);
         }
     }
     None
 }
 
+fn is_omx_explore_allowlist_path(path: &Path) -> bool {
+    fn is_under_allowlist_bin(path: &Path) -> bool {
+        path.ancestors().any(|ancestor| {
+            let is_allowlist_root = ancestor
+                .file_name()
+                .and_then(|name| name.to_str())
+                .is_some_and(|name| name.starts_with(TEMP_ALLOWLIST_DIR_PREFIX));
+            if !is_allowlist_root {
+                return false;
+            }
+            path.strip_prefix(ancestor)
+                .ok()
+                .and_then(|relative| relative.components().next())
+                .is_some_and(|component| component.as_os_str() == "bin")
+        })
+    }
+
+    is_under_allowlist_bin(path)
+        || canonicalize_existing_prefix(path)
+            .as_deref()
+            .is_some_and(is_under_allowlist_bin)
+}
+
 fn is_usable_host_command(path: &Path) -> bool {
     let metadata = match path.metadata() {
         Ok(metadata) => metadata,
@@ -617,6 +646,12 @@ fn shell_quote(value: &str) -> String {
     format!("'{}'", value.replace('\'', "'\"'\"'"))
 }
 
+fn sanitize_explore_subprocess_env(command: &mut Command) {
+    for key in SHELL_STARTUP_ENV_VARS {
+        command.env_remove(key);
+    }
+}
+
 fn run_internal_direct_wrapper<I>(mut args: I) -> Result<(), String>
 where
     I: Iterator<Item = OsString>,
@@ -653,6 +688,7 @@ where
     if real_shell.ends_with("bash") {
         child.arg("--noprofile").arg("--norc");
     }
+    sanitize_explore_subprocess_env(&mut child);
     let status = child
         .arg("-lc")
         .arg(&command)
@@ -735,7 +771,7 @@ fn validate_direct_command(command_name: &str, args: &[String]) -> Result<(), St
                 );
             }
         }
-        "find" => {
+        "find"
             if args.iter().any(|arg| {
                 matches!(
                     arg.as_str(),
@@ -749,13 +785,14 @@ fn validate_direct_command(command_name: &str, args: &[String]) -> Result<(), St
                         | "-fprintf"
                         | "-fls"
                 )
-            }) {
-                return Err(
-                    "find actions that execute, delete, or write files are not allowed in omx explore"
-                        .to_string(),
-                );
-            }
+            }) =>
+        {
+            return Err(
+                "find actions that execute, delete, or write files are not allowed in omx explore"
+                    .to_string(),
+            );
         }
+        "find" => {}
         "cat" => {
             let operands = non_option_operands(args);
             if operands.is_empty() {
@@ -987,7 +1024,17 @@ mod tests {
     #[test]
     fn resolve_codex_binary_resolves_bare_env_override_from_path() {
         let _guard = env_lock();
-        let root = temp_allowlist_dir().expect("temp root");
+        let root = TempDirGuard {
+            path: env::temp_dir().join(format!(
+                "omx-explore-resolve-codex-binary-{}-{}",
+                std::process::id(),
+                SystemTime::now()
+                    .duration_since(UNIX_EPOCH)
+                    .unwrap_or_default()
+                    .as_nanos()
+            )),
+        };
+        create_dir_all(&root.path).expect("create temp root");
         let bin_dir = root.path.join("bin");
         create_dir_all(&bin_dir).expect("create bin");
         let fake_codex = bin_dir.join("codex-custom");
@@ -1271,6 +1318,72 @@ exec node "$basedir/../@openai/codex/bin/codex.js" "$@"
         assert!(!wrapper.contains("exit 127"));
     }
 
+    #[cfg(unix)]
+    #[test]
+    fn resolve_host_command_skips_omx_explore_allowlist_wrappers() {
+        let _guard = env_lock();
+        let allowlist_root = temp_allowlist_dir().expect("allowlist root");
+        let real_root = TempDirGuard {
+            path: env::temp_dir().join(format!(
+                "omx-explore-host-resolution-{}-{}",
+                std::process::id(),
+                SystemTime::now()
+                    .duration_since(UNIX_EPOCH)
+                    .unwrap_or_default()
+                    .as_nanos()
+            )),
+        };
+        create_dir_all(&real_root.path).expect("create real root");
+        let real_bin = real_root.path.join("real-bin");
+        let allowlist_bin = allowlist_root
+            .path
+            .join(format!("{TEMP_ALLOWLIST_DIR_PREFIX}fixture"))
+            .join("bin");
+        create_dir_all(&real_bin).expect("create real bin");
+        create_dir_all(&allowlist_bin).expect("create allowlist bin");
+
+        let real_grep = real_bin.join("grep");
+        write_executable(&real_grep, "#!/bin/sh\nexit 0\n").expect("write real grep");
+        let wrapper_grep = allowlist_bin.join("grep");
+        write_executable(&wrapper_grep, "#!/bin/sh\nexit 0\n").expect("write wrapper grep");
+
+        let original_path = env::var_os("PATH");
+        unsafe {
+            env::set_var(
+                "PATH",
+                env::join_paths([allowlist_bin.as_path(), real_bin.as_path()]).expect("join path"),
+            );
+        }
+
+        let resolved = resolve_host_command("grep");
+
+        match original_path {
+            Some(value) => unsafe { env::set_var("PATH", value) },
+            None => unsafe { env::remove_var("PATH") },
+        }
+
+        assert_eq!(resolved, Some(real_grep));
+    }
+
+    #[cfg(unix)]
+    #[test]
+    fn resolve_host_command_rejects_absolute_allowlist_wrapper_paths() {
+        let _guard = env_lock();
+        let root = temp_allowlist_dir().expect("temp root");
+        let wrapper_dir = root
+            .path
+            .join(format!("{TEMP_ALLOWLIST_DIR_PREFIX}fixture"))
+            .join("bin");
+        create_dir_all(&wrapper_dir).expect("create wrapper dir");
+        let wrapper = wrapper_dir.join("grep");
+        write_executable(&wrapper, "#!/bin/sh\nexit 0\n").expect("write wrapper");
+
+        assert_eq!(
+            resolve_host_command(wrapper.to_str().expect("wrapper path")),
+            None
+        );
+    }
+
     #[test]
     fn discover_codex_support_dirs_includes_home_omx_and_codex_when_present() {
         let _guard = env_lock();
@@ -1520,6 +1633,104 @@ exit 17
         let _error = result.expect_err("both attempts should fail");
     }
 
+    #[test]
+    fn invoke_codex_clears_shell_startup_env_before_launching_codex() {
+        let _guard = env_lock();
+        let root = temp_allowlist_dir().expect("temp root");
+        let repo = root.path.join("repo");
+        create_dir_all(&repo).expect("create repo");
+        let prompt_file = root.path.join("prompt.md");
+        write(&prompt_file, "contract").expect("write prompt");
+        let capture_path = root.path.join("capture.txt");
+        let fake_codex = root.path.join("codex-stub");
+        write_executable(
+            &fake_codex,
+            &format!(
+                r#"#!/bin/sh
+set -eu
+output_path=""
+while [ "$#" -gt 0 ]; do
+  if [ "$1" = "-o" ]; then
+    shift
+    output_path="$1"
+  fi
+  shift
+done
+printf 'BASH_ENV=%s\nENV=%s\nPROMPT_COMMAND=%s\n' "${{BASH_ENV:-}}" "${{ENV:-}}" "${{PROMPT_COMMAND:-}}" > {}
+printf '# Answer\nok\n' > "$output_path"
+"#,
+                shell_quote(&capture_path.display().to_string())
+            ),
+        )
+        .expect("write fake codex");
+
+        unsafe {
+            env::set_var(CODEX_BIN_ENV, &fake_codex);
+            env::set_var("BASH_ENV", "/tmp/bash-env-should-not-leak");
+            env::set_var("ENV", "/tmp/env-should-not-leak");
+            env::set_var("PROMPT_COMMAND", "printf should-not-run");
+        }
+        let attempt = invoke_codex(
+            &Args {
+                cwd: repo.clone(),
+                prompt: "find tests".to_string(),
+                prompt_file,
+                spark_model: "spark-model".to_string(),
+                fallback_model: "fallback-model".to_string(),
+            },
+            "spark-model",
+            "contract",
+        )
+        .expect("invoke codex");
+        unsafe {
+            env::remove_var(CODEX_BIN_ENV);
+            env::remove_var("BASH_ENV");
+            env::remove_var("ENV");
+            env::remove_var("PROMPT_COMMAND");
+        }
+
+        assert_eq!(attempt.status_code, 0);
+        assert_eq!(
+            read_to_string(&capture_path).expect("read capture"),
+            "BASH_ENV=\nENV=\nPROMPT_COMMAND=\n"
+        );
+    }
+
+    #[test]
+    fn sanitize_explore_subprocess_env_blocks_bash_env_startup_hooks() {
+        let _guard = env_lock();
+        let root = temp_allowlist_dir().expect("temp root");
+        let bash_env_log = root.path.join("bash-env.log");
+        let bash_env = root.path.join("bash-env.sh");
+        write(
+            &bash_env,
+            format!(
+                "printf 'startup:%s\\n' \"$BASH_ENV\" >> {}\n",
+                shell_quote(&bash_env_log.display().to_string())
+            ),
+        )
+        .expect("write bash env");
+        let bash_path = resolve_host_command("bash").expect("host bash path");
+
+        unsafe {
+            env::set_var("BASH_ENV", &bash_env);
+        }
+        let mut child = Command::new(&bash_path);
+        child
+            .arg("--noprofile")
+            .arg("--norc")
+            .arg("-lc")
+            .arg("true");
+        sanitize_explore_subprocess_env(&mut child);
+        let status = child.status().expect("run bash");
+        unsafe {
+            env::remove_var("BASH_ENV");
+        }
+
+        assert!(status.success());
+        assert_eq!(read_to_string(&bash_env_log).unwrap_or_default(), "");
+    }
+
     #[test]
     fn print_attempt_output_requires_markdown_artifact() {
         let result = print_attempt_output(AttemptResult {

package/dist/autoresearch/__tests__/skill-validation.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=skill-validation.test.d.ts.map

package/dist/autoresearch/__tests__/skill-validation.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-validation.test.d.ts","sourceRoot":"","sources":["../../../src/autoresearch/__tests__/skill-validation.test.ts"],"names":[],"mappings":""}

package/dist/autoresearch/__tests__/skill-validation.test.js

@@ -0,0 +1,91 @@
+import { describe, it } from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdtemp, mkdir, rm, writeFile } from 'node:fs/promises';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { assessAutoresearchCompletionState, normalizeAutoresearchValidationMode, } from '../skill-validation.js';
+describe('autoresearch skill validation', () => {
+    it('normalizes the supported validation modes', () => {
+        assert.equal(normalizeAutoresearchValidationMode('mission-validator-script'), 'mission-validator-script');
+        assert.equal(normalizeAutoresearchValidationMode('prompt-architect-artifact'), 'prompt-architect-artifact');
+        assert.equal(normalizeAutoresearchValidationMode('unknown-mode'), null);
+    });
+    it('treats missing validation mode as incomplete', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-autoresearch-skill-validation-'));
+        try {
+            const result = await assessAutoresearchCompletionState({ active: true }, cwd);
+            assert.equal(result.complete, false);
+            assert.equal(result.reason, 'missing_validation_mode');
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('requires a validator pass artifact for mission-validator-script mode', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-autoresearch-validator-script-'));
+        try {
+            const artifactPath = join(cwd, '.omx', 'specs', 'autoresearch-demo', 'completion.json');
+            await mkdir(join(cwd, '.omx', 'specs', 'autoresearch-demo'), { recursive: true });
+            await writeFile(artifactPath, JSON.stringify({ status: 'running' }, null, 2));
+            const incomplete = await assessAutoresearchCompletionState({
+                active: true,
+                validation_mode: 'mission-validator-script',
+                mission_validator_command: 'node scripts/validate.js',
+                completion_artifact_path: artifactPath,
+            }, cwd);
+            assert.equal(incomplete.complete, false);
+            assert.equal(incomplete.reason, 'validator_not_passed');
+            await writeFile(artifactPath, JSON.stringify({ status: 'passed', passed: true }, null, 2));
+            const complete = await assessAutoresearchCompletionState({
+                active: true,
+                validation_mode: 'mission-validator-script',
+                mission_validator_command: 'node scripts/validate.js',
+                completion_artifact_path: artifactPath,
+            }, cwd);
+            assert.equal(complete.complete, true);
+            assert.equal(complete.reason, 'validator_passed');
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+    it('requires prompt, architect approval, and output artifact for prompt-architect-artifact mode', async () => {
+        const cwd = await mkdtemp(join(tmpdir(), 'omx-autoresearch-architect-validation-'));
+        try {
+            const artifactDir = join(cwd, '.omx', 'specs', 'autoresearch-demo');
+            const completionPath = join(artifactDir, 'completion.json');
+            const outputPath = join(artifactDir, 'report.md');
+            await mkdir(artifactDir, { recursive: true });
+            await writeFile(outputPath, '# Report\n', 'utf-8');
+            await writeFile(completionPath, JSON.stringify({
+                architect_review: { verdict: 'reject' },
+                output_artifact_path: outputPath,
+            }, null, 2));
+            const rejected = await assessAutoresearchCompletionState({
+                active: true,
+                validation_mode: 'prompt-architect-artifact',
+                validator_prompt: 'Review the research output.',
+                completion_artifact_path: completionPath,
+            }, cwd);
+            assert.equal(rejected.complete, false);
+            assert.equal(rejected.reason, 'missing_architect_approval');
+            await writeFile(completionPath, JSON.stringify({
+                validator_prompt: 'Review the research output.',
+                architect_review: { verdict: 'approved' },
+                output_artifact_path: outputPath,
+            }, null, 2));
+            const approved = await assessAutoresearchCompletionState({
+                active: true,
+                validation_mode: 'prompt-architect-artifact',
+                validator_prompt: 'Review the research output.',
+                completion_artifact_path: completionPath,
+            }, cwd);
+            assert.equal(approved.complete, true);
+            assert.equal(approved.reason, 'architect_approved');
+        }
+        finally {
+            await rm(cwd, { recursive: true, force: true });
+        }
+    });
+});
+//# sourceMappingURL=skill-validation.test.js.map

package/dist/autoresearch/__tests__/skill-validation.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-validation.test.js","sourceRoot":"","sources":["../../../src/autoresearch/__tests__/skill-validation.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,WAAW,CAAC;AACzC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAC;AACjE,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AACjC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EACL,iCAAiC,EACjC,mCAAmC,GACpC,MAAM,wBAAwB,CAAC;AAEhC,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;IAC7C,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,CAAC,KAAK,CAAC,mCAAmC,CAAC,0BAA0B,CAAC,EAAE,0BAA0B,CAAC,CAAC;QAC1G,MAAM,CAAC,KAAK,CAAC,mCAAmC,CAAC,2BAA2B,CAAC,EAAE,2BAA2B,CAAC,CAAC;QAC5G,MAAM,CAAC,KAAK,CAAC,mCAAmC,CAAC,cAAc,CAAC,EAAE,IAAI,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,oCAAoC,CAAC,CAAC,CAAC;QAChF,IAAI,CAAC;YACH,MAAM,MAAM,GAAG,MAAM,iCAAiC,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,GAAG,CAAC,CAAC;YAC9E,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;YACrC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,MAAM,EAAE,yBAAyB,CAAC,CAAC;QACzD,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QACpF,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,oCAAoC,CAAC,CAAC,CAAC;QAChF,IAAI,CAAC;YACH,MAAM,YAAY,GAAG,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,OAAO,EAAE,mBAAmB,EAAE,iBAAiB,CAAC,CAAC;YACxF,MAAM,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,OAAO,EAAE,mBAAmB,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAClF,MAAM,SAAS,CAAC,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAE9E,MAAM,UAAU,GAAG,MAAM,iCAAiC,CAAC;gBACzD,MAAM,EAAE,IAAI;gBACZ,eAAe,EAAE,0BAA0B;gBAC3C,yBAAyB,EAAE,0BAA0B;gBACrD,wBAAwB,EAAE,YAAY;aACvC,EAAE,GAAG,CAAC,CAAC;YACR,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;YACzC,MAAM,CAAC,KAAK,CAAC,UAAU,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;YAExD,MAAM,SAAS,CAAC,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAC3F,MAAM,QAAQ,GAAG,MAAM,iCAAiC,CAAC;gBACvD,MAAM,EAAE,IAAI;gBACZ,eAAe,EAAE,0BAA0B;gBAC3C,yBAAyB,EAAE,0BAA0B;gBACrD,wBAAwB,EAAE,YAAY;aACvC,EAAE,GAAG,CAAC,CAAC;YACR,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;YACtC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,EAAE,kBAAkB,CAAC,CAAC;QACpD,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6FAA6F,EAAE,KAAK,IAAI,EAAE;QAC3G,MAAM,GAAG,GAAG,MAAM,OAAO,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,wCAAwC,CAAC,CAAC,CAAC;QACpF,IAAI,CAAC;YACH,MAAM,WAAW,GAAG,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,OAAO,EAAE,mBAAmB,CAAC,CAAC;YACpE,MAAM,cAAc,GAAG,IAAI,CAAC,WAAW,EAAE,iBAAiB,CAAC,CAAC;YAC5D,MAAM,UAAU,GAAG,IAAI,CAAC,WAAW,EAAE,WAAW,CAAC,CAAC;YAClD,MAAM,KAAK,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAC9C,MAAM,SAAS,CAAC,UAAU,EAAE,YAAY,EAAE,OAAO,CAAC,CAAC;YACnD,MAAM,SAAS,CAAC,cAAc,EAAE,IAAI,CAAC,SAAS,CAAC;gBAC7C,gBAAgB,EAAE,EAAE,OAAO,EAAE,QAAQ,EAAE;gBACvC,oBAAoB,EAAE,UAAU;aACjC,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAEb,MAAM,QAAQ,GAAG,MAAM,iCAAiC,CAAC;gBACvD,MAAM,EAAE,IAAI;gBACZ,eAAe,EAAE,2BAA2B;gBAC5C,gBAAgB,EAAE,6BAA6B;gBAC/C,wBAAwB,EAAE,cAAc;aACzC,EAAE,GAAG,CAAC,CAAC;YACR,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,EAAE,4BAA4B,CAAC,CAAC;YAE5D,MAAM,SAAS,CAAC,cAAc,EAAE,IAAI,CAAC,SAAS,CAAC;gBAC7C,gBAAgB,EAAE,6BAA6B;gBAC/C,gBAAgB,EAAE,EAAE,OAAO,EAAE,UAAU,EAAE;gBACzC,oBAAoB,EAAE,UAAU;aACjC,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YACb,MAAM,QAAQ,GAAG,MAAM,iCAAiC,CAAC;gBACvD,MAAM,EAAE,IAAI;gBACZ,eAAe,EAAE,2BAA2B;gBAC5C,gBAAgB,EAAE,6BAA6B;gBAC/C,wBAAwB,EAAE,cAAc;aACzC,EAAE,GAAG,CAAC,CAAC;YACR,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;YACtC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,EAAE,oBAAoB,CAAC,CAAC;QACtD,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,CAAC;IACH,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/autoresearch/skill-validation.d.ts

@@ -0,0 +1,13 @@
+export type AutoresearchValidationMode = 'mission-validator-script' | 'prompt-architect-artifact';
+export interface AutoresearchCompletionStatus {
+    complete: boolean;
+    reason: string;
+    validationMode: AutoresearchValidationMode | null;
+    artifactPath: string | null;
+    outputArtifactPath?: string | null;
+}
+export declare function normalizeAutoresearchValidationMode(value: unknown): AutoresearchValidationMode | null;
+export declare function assessAutoresearchCompletionState(rawState: Record<string, unknown> | null, cwd: string): Promise<AutoresearchCompletionStatus>;
+export declare function readAutoresearchModeState(cwd: string, sessionId?: string): Promise<Record<string, unknown> | null>;
+export declare function readAutoresearchCompletionStatus(cwd: string, sessionId?: string): Promise<AutoresearchCompletionStatus>;
+//# sourceMappingURL=skill-validation.d.ts.map

package/dist/autoresearch/skill-validation.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-validation.d.ts","sourceRoot":"","sources":["../../src/autoresearch/skill-validation.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,0BAA0B,GAAG,0BAA0B,GAAG,2BAA2B,CAAC;AAElG,MAAM,WAAW,4BAA4B;IAC3C,QAAQ,EAAE,OAAO,CAAC;IAClB,MAAM,EAAE,MAAM,CAAC;IACf,cAAc,EAAE,0BAA0B,GAAG,IAAI,CAAC;IAClD,YAAY,EAAE,MAAM,GAAG,IAAI,CAAC;IAC5B,kBAAkB,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CACpC;AA8CD,wBAAgB,mCAAmC,CAAC,KAAK,EAAE,OAAO,GAAG,0BAA0B,GAAG,IAAI,CAKrG;AA2DD,wBAAsB,iCAAiC,CACrD,QAAQ,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,EACxC,GAAG,EAAE,MAAM,GACV,OAAO,CAAC,4BAA4B,CAAC,CA6CvC;AAED,wBAAsB,yBAAyB,CAC7C,GAAG,EAAE,MAAM,EACX,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC,CAWzC;AAED,wBAAsB,gCAAgC,CACpD,GAAG,EAAE,MAAM,EACX,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,4BAA4B,CAAC,CAGvC"}

package/dist/autoresearch/skill-validation.js

@@ -0,0 +1,165 @@
+import { existsSync } from 'fs';
+import { readFile } from 'fs/promises';
+import { join } from 'path';
+import { getReadScopedStatePaths } from '../mcp/state-paths.js';
+function safeString(value) {
+    return typeof value === 'string' ? value.trim() : '';
+}
+function safeObject(value) {
+    return value && typeof value === 'object' ? value : null;
+}
+function safeBoolean(value) {
+    return typeof value === 'boolean' ? value : null;
+}
+function lookupString(raw, ...keys) {
+    if (!raw)
+        return '';
+    for (const key of keys) {
+        const direct = safeString(raw[key]);
+        if (direct)
+            return direct;
+    }
+    const nestedState = safeObject(raw.state);
+    if (nestedState) {
+        for (const key of keys) {
+            const nested = safeString(nestedState[key]);
+            if (nested)
+                return nested;
+        }
+    }
+    return '';
+}
+function lookupBoolean(raw, ...keys) {
+    if (!raw)
+        return null;
+    for (const key of keys) {
+        const direct = safeBoolean(raw[key]);
+        if (direct !== null)
+            return direct;
+    }
+    const nestedState = safeObject(raw.state);
+    if (nestedState) {
+        for (const key of keys) {
+            const nested = safeBoolean(nestedState[key]);
+            if (nested !== null)
+                return nested;
+        }
+    }
+    return null;
+}
+export function normalizeAutoresearchValidationMode(value) {
+    const normalized = safeString(value).toLowerCase();
+    if (normalized === 'mission-validator-script')
+        return 'mission-validator-script';
+    if (normalized === 'prompt-architect-artifact')
+        return 'prompt-architect-artifact';
+    return null;
+}
+function resolveMaybeRelativePath(cwd, rawPath) {
+    if (!rawPath)
+        return rawPath;
+    return rawPath.startsWith('/') ? rawPath : join(cwd, rawPath);
+}
+function deriveDefaultArtifactPath(cwd, rawState) {
+    const slug = lookupString(rawState, 'slug', 'mission_slug', 'missionSlug');
+    if (!slug)
+        return null;
+    return join(cwd, '.omx', 'specs', `autoresearch-${slug}`, 'completion.json');
+}
+function resolveArtifactPath(cwd, rawState) {
+    const explicit = lookupString(rawState, 'completion_artifact_path', 'completionArtifactPath', 'validator_artifact_path', 'validatorArtifactPath');
+    if (explicit)
+        return resolveMaybeRelativePath(cwd, explicit);
+    return deriveDefaultArtifactPath(cwd, rawState);
+}
+async function readJsonIfExists(path) {
+    if (!path || !existsSync(path))
+        return null;
+    try {
+        return JSON.parse(await readFile(path, 'utf-8'));
+    }
+    catch {
+        return null;
+    }
+}
+function isPassingStatus(value) {
+    const normalized = safeString(value).toLowerCase();
+    return ['pass', 'passed', 'complete', 'completed', 'success', 'succeeded', 'approved'].includes(normalized);
+}
+function hasArchitectApproval(artifact) {
+    if (!artifact)
+        return false;
+    const direct = lookupBoolean(artifact, 'architect_approved', 'architectApproved', 'approved');
+    if (direct === true)
+        return true;
+    const architectReview = safeObject(artifact.architect_review) ?? safeObject(artifact.architectReview);
+    const architectValidation = safeObject(artifact.architect_validation) ?? safeObject(artifact.architectValidation);
+    return isPassingStatus(architectReview?.verdict) || isPassingStatus(architectValidation?.verdict);
+}
+function resolveOutputArtifactPath(cwd, rawState, artifact) {
+    const explicit = lookupString(rawState, 'output_artifact_path', 'outputArtifactPath')
+        || lookupString(artifact, 'output_artifact_path', 'outputArtifactPath');
+    if (!explicit)
+        return null;
+    return resolveMaybeRelativePath(cwd, explicit);
+}
+export async function assessAutoresearchCompletionState(rawState, cwd) {
+    const validationMode = normalizeAutoresearchValidationMode(lookupString(rawState, 'validation_mode', 'validationMode'));
+    if (!rawState) {
+        return { complete: false, reason: 'missing_mode_state', validationMode: null, artifactPath: null };
+    }
+    if (!validationMode) {
+        return { complete: false, reason: 'missing_validation_mode', validationMode: null, artifactPath: resolveArtifactPath(cwd, rawState) };
+    }
+    const artifactPath = resolveArtifactPath(cwd, rawState);
+    const artifact = await readJsonIfExists(artifactPath);
+    if (!artifactPath) {
+        return { complete: false, reason: 'missing_completion_artifact_path', validationMode, artifactPath: null };
+    }
+    if (!artifact) {
+        return { complete: false, reason: 'missing_or_invalid_completion_artifact', validationMode, artifactPath };
+    }
+    if (validationMode === 'mission-validator-script') {
+        const validatorCommand = lookupString(rawState, 'mission_validator_command', 'missionValidatorCommand')
+            || lookupString(safeObject(rawState.mission_validator), 'command');
+        if (!validatorCommand) {
+            return { complete: false, reason: 'missing_mission_validator_command', validationMode, artifactPath };
+        }
+        if (lookupBoolean(artifact, 'passed', 'complete', 'completed', 'valid') === true || isPassingStatus(artifact.status)) {
+            return { complete: true, reason: 'validator_passed', validationMode, artifactPath };
+        }
+        return { complete: false, reason: 'validator_not_passed', validationMode, artifactPath };
+    }
+    const validatorPrompt = lookupString(rawState, 'validator_prompt', 'validatorPrompt')
+        || lookupString(artifact, 'validator_prompt', 'validatorPrompt');
+    if (!validatorPrompt) {
+        return { complete: false, reason: 'missing_validator_prompt', validationMode, artifactPath };
+    }
+    const outputArtifactPath = resolveOutputArtifactPath(cwd, rawState, artifact);
+    if (!outputArtifactPath || !existsSync(outputArtifactPath)) {
+        return { complete: false, reason: 'missing_output_artifact', validationMode, artifactPath, outputArtifactPath };
+    }
+    if (!hasArchitectApproval(artifact)) {
+        return { complete: false, reason: 'missing_architect_approval', validationMode, artifactPath, outputArtifactPath };
+    }
+    return { complete: true, reason: 'architect_approved', validationMode, artifactPath, outputArtifactPath };
+}
+export async function readAutoresearchModeState(cwd, sessionId) {
+    const candidates = await getReadScopedStatePaths('autoresearch', cwd, sessionId);
+    for (const candidatePath of candidates) {
+        if (!existsSync(candidatePath))
+            continue;
+        try {
+            return JSON.parse(await readFile(candidatePath, 'utf-8'));
+        }
+        catch {
+            continue;
+        }
+    }
+    return null;
+}
+export async function readAutoresearchCompletionStatus(cwd, sessionId) {
+    const state = await readAutoresearchModeState(cwd, sessionId);
+    return assessAutoresearchCompletionState(state, cwd);
+}
+//# sourceMappingURL=skill-validation.js.map