oh-my-codex 0.13.1 → 0.13.2

package/src/scripts/__tests__/codex-native-hook.test.ts

@@ -464,6 +464,33 @@ describe("codex native hook dispatch", () => {
     }
   });
 
+  it("does not activate Ralph workflow state from a plain conversational mention", async () => {
+    const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-ralph-plain-text-"));
+    try {
+      await mkdir(join(cwd, ".omx", "state"), { recursive: true });
+      const result = await dispatchCodexNativeHook(
+        {
+          hook_event_name: "UserPromptSubmit",
+          cwd,
+          session_id: "sess-ralph-plain-text",
+          thread_id: "thread-ralph-plain-text",
+          turn_id: "turn-ralph-plain-text",
+          prompt: "why does ralph keep blocking stop?",
+        },
+        { cwd },
+      );
+
+      assert.equal(result.omxEventName, "keyword-detector");
+      assert.equal(result.skillState, null);
+      assert.equal(result.outputJson, null);
+      assert.equal(existsSync(join(cwd, ".omx", "state", "skill-active-state.json")), false);
+      assert.equal(existsSync(join(cwd, ".omx", "state", "sessions", "sess-ralph-plain-text", "skill-active-state.json")), false);
+      assert.equal(existsSync(join(cwd, ".omx", "state", "sessions", "sess-ralph-plain-text", "ralph-state.json")), false);
+    } finally {
+      await rm(cwd, { recursive: true, force: true });
+    }
+  });
+
   it("clarifies that prompt-side $ralph activation does not invoke the PRD-gated CLI path", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-ralph-routing-"));
     try {
@@ -2111,7 +2138,13 @@ esac
         { cwd },
       );
 
-      assert.equal(result.outputJson, null);
+      assert.deepEqual(result.outputJson, {
+        decision: "block",
+        reason:
+          `OMX team pipeline is still active (worker-stop-team-terminal) at phase team-exec; continue coordinating until the team reaches a terminal phase.${TEAM_STOP_COMMIT_GUIDANCE}`,
+        stopReason: "team_team-exec",
+        systemMessage: "OMX team pipeline is still active at phase team-exec.",
+      });
     } finally {
       if (typeof prevTeamWorker === "string") process.env.OMX_TEAM_WORKER = prevTeamWorker;
       else delete process.env.OMX_TEAM_WORKER;
@@ -2942,8 +2975,9 @@ esac
     }
   });
 
-  it("does not re-block Ralph when Stop already continued once", async () => {
-    const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-stop-ralph-once-"));
+  it("keeps blocking Ralph Stop replays until the active task advances", async () => {
+    const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-stop-ralph-replay-"));
+    const previousOmxSessionId = process.env.OMX_SESSION_ID;
     try {
       const stateDir = join(cwd, ".omx", "state");
       await mkdir(stateDir, { recursive: true });
@@ -2955,23 +2989,42 @@ esac
         }),
       );
 
-      const result = await dispatchCodexNativeHook(
+      process.env.OMX_SESSION_ID = "sess-stop-ralph-replay";
+      const payload = {
+        hook_event_name: "Stop",
+        cwd,
+        last_assistant_message: "Next active targets:\n\n1. scheduler integration\n\nI am continuing.",
+      };
+      const expected = {
+        decision: "block",
+        reason:
+          "OMX Ralph is still active (phase: executing); continue the task and gather fresh verification evidence before stopping.",
+        stopReason: "ralph_executing",
+        systemMessage:
+          "OMX Ralph is still active (phase: executing); continue the task and gather fresh verification evidence before stopping.",
+      };
+
+      const first = await dispatchCodexNativeHook(payload, { cwd });
+      const replay = await dispatchCodexNativeHook(
         {
-          hook_event_name: "Stop",
-          cwd,
-          session_id: "sess-stop-ralph-once",
+          ...payload,
           stop_hook_active: true,
         },
         { cwd },
       );
 
-      assert.equal(result.omxEventName, "stop");
-      assert.equal(result.outputJson, null);
+      assert.equal(first.omxEventName, "stop");
+      assert.deepEqual(first.outputJson, expected);
+      assert.equal(replay.omxEventName, "stop");
+      assert.deepEqual(replay.outputJson, expected);
     } finally {
+      if (typeof previousOmxSessionId === "string") process.env.OMX_SESSION_ID = previousOmxSessionId;
+      else delete process.env.OMX_SESSION_ID;
       await rm(cwd, { recursive: true, force: true });
     }
   });
 
+
   it("returns Stop continuation output for native auto-nudge stall prompts", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-auto-nudge-"));
     try {
@@ -3002,7 +3055,7 @@ esac
     }
   });
 
-  it("suppresses duplicate native auto-nudge replays for the same Stop reply", async () => {
+  it("re-blocks duplicate native auto-nudge replays for the same Stop reply", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-auto-nudge-once-"));
     try {
       const stateDir = join(cwd, ".omx", "state");
@@ -3035,13 +3088,19 @@ esac
       );
 
       assert.equal(result.omxEventName, "stop");
-      assert.equal(result.outputJson, null);
+      assert.deepEqual(result.outputJson, {
+        decision: "block",
+        reason: DEFAULT_AUTO_NUDGE_RESPONSE,
+        stopReason: "auto_nudge",
+        systemMessage:
+          "OMX native Stop detected a stall/permission-style handoff and continued the turn automatically.",
+      });
     } finally {
       await rm(cwd, { recursive: true, force: true });
     }
   });
 
-  it("suppresses duplicate native auto-nudge replays across native/canonical session-id drift", async () => {
+  it("re-blocks duplicate native auto-nudge replays across native/canonical session-id drift", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-auto-nudge-session-drift-"));
     try {
       const stateDir = join(cwd, ".omx", "state");
@@ -3078,7 +3137,13 @@ esac
       );
 
       assert.equal(result.omxEventName, "stop");
-      assert.equal(result.outputJson, null);
+      assert.deepEqual(result.outputJson, {
+        decision: "block",
+        reason: DEFAULT_AUTO_NUDGE_RESPONSE,
+        stopReason: "auto_nudge",
+        systemMessage:
+          "OMX native Stop detected a stall/permission-style handoff and continued the turn automatically.",
+      });
 
       const persisted = JSON.parse(
         await readFile(join(stateDir, "native-stop-state.json"), "utf-8"),
@@ -3465,7 +3530,7 @@ esac
     }
   });
 
-  it("does not auto-continue native Stop for a plain Codex session started outside OMX runtime", async () => {
+  it("auto-continues native Stop for permission-seeking prompts even outside OMX runtime", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-auto-nudge-plain-session-"));
     try {
       await dispatchCodexNativeHook(
@@ -3487,13 +3552,19 @@ esac
           session_id: "plain-stop-session",
           thread_id: "plain-thread",
           turn_id: "plain-turn-1",
-          last_assistant_message: "Keep going and finish the cleanup.",
+          last_assistant_message: "If you want, I can continue with the cleanup from here.",
         },
         { cwd },
       );
 
       assert.equal(result.omxEventName, "stop");
-      assert.equal(result.outputJson, null);
+      assert.deepEqual(result.outputJson, {
+        decision: "block",
+        reason: DEFAULT_AUTO_NUDGE_RESPONSE,
+        stopReason: "auto_nudge",
+        systemMessage:
+          "OMX native Stop detected a stall/permission-style handoff and continued the turn automatically.",
+      });
     } finally {
       await rm(cwd, { recursive: true, force: true });
     }
@@ -3601,7 +3672,13 @@ esac
       );
 
       assert.equal(duplicate.omxEventName, "stop");
-      assert.equal(duplicate.outputJson, null);
+      assert.deepEqual(duplicate.outputJson, {
+        decision: "block",
+        reason:
+          `OMX team pipeline is still active (current-team) at phase team-verify; continue coordinating until the team reaches a terminal phase.${TEAM_STOP_COMMIT_GUIDANCE}`,
+        stopReason: "team_team-verify",
+        systemMessage: "OMX team pipeline is still active at phase team-verify.",
+      });
 
       const fresh = await dispatchCodexNativeHook(
         {
@@ -3633,6 +3710,126 @@ esac
     }
   });
 
+  it("re-blocks active execution modes on repeated Stop hooks", async () => {
+    const cases = [
+      {
+        mode: "autopilot",
+        phase: "execution",
+        reason:
+          "OMX autopilot is still active (phase: execution); continue the task and gather fresh verification evidence before stopping.",
+      },
+      {
+        mode: "ultrawork",
+        phase: "executing",
+        reason:
+          "OMX ultrawork is still active (phase: executing); continue the task and gather fresh verification evidence before stopping.",
+      },
+      {
+        mode: "ultraqa",
+        phase: "diagnose",
+        reason:
+          "OMX ultraqa is still active (phase: diagnose); continue the task and gather fresh verification evidence before stopping.",
+      },
+    ] as const;
+
+    for (const testCase of cases) {
+      const cwd = await mkdtemp(join(tmpdir(), `omx-native-hook-stop-${testCase.mode}-repeat-`));
+      try {
+        const stateDir = join(cwd, ".omx", "state");
+        await mkdir(stateDir, { recursive: true });
+        await writeJson(join(stateDir, `${testCase.mode}-state.json`), {
+          active: true,
+          current_phase: testCase.phase,
+        });
+
+        await dispatchCodexNativeHook(
+          {
+            hook_event_name: "Stop",
+            cwd,
+            session_id: `sess-stop-${testCase.mode}-repeat`,
+            thread_id: `thread-stop-${testCase.mode}-repeat`,
+            turn_id: `turn-stop-${testCase.mode}-repeat-1`,
+          },
+          { cwd },
+        );
+
+        const repeated = await dispatchCodexNativeHook(
+          {
+            hook_event_name: "Stop",
+            cwd,
+            session_id: `sess-stop-${testCase.mode}-repeat`,
+            thread_id: `thread-stop-${testCase.mode}-repeat`,
+            turn_id: `turn-stop-${testCase.mode}-repeat-1`,
+            stop_hook_active: true,
+          },
+          { cwd },
+        );
+
+        assert.equal(repeated.omxEventName, "stop");
+        assert.deepEqual(repeated.outputJson, {
+          decision: "block",
+          reason: testCase.reason,
+          stopReason: `${testCase.mode}_${testCase.phase}`,
+          systemMessage: `OMX ${testCase.mode} is still active (phase: ${testCase.phase}).`,
+        });
+      } finally {
+        await rm(cwd, { recursive: true, force: true });
+      }
+    }
+  });
+
+  it("re-blocks active ralplan skill state on repeated Stop hooks", async () => {
+    const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-stop-skill-repeat-"));
+    try {
+      const stateDir = join(cwd, ".omx", "state");
+      await mkdir(join(stateDir, "sessions", "sess-stop-skill-repeat"), { recursive: true });
+      await writeJson(join(stateDir, "session.json"), { session_id: "sess-stop-skill-repeat" });
+      await writeJson(join(stateDir, "sessions", "sess-stop-skill-repeat", "skill-active-state.json"), {
+        active: true,
+        skill: "ralplan",
+        phase: "planning",
+      });
+      await writeJson(join(stateDir, "sessions", "sess-stop-skill-repeat", "ralplan-state.json"), {
+        active: true,
+        current_phase: "planning",
+      });
+
+      await dispatchCodexNativeHook(
+        {
+          hook_event_name: "Stop",
+          cwd,
+          session_id: "sess-stop-skill-repeat",
+          thread_id: "thread-stop-skill-repeat",
+          turn_id: "turn-stop-skill-repeat-1",
+        },
+        { cwd },
+      );
+
+      const repeated = await dispatchCodexNativeHook(
+        {
+          hook_event_name: "Stop",
+          cwd,
+          session_id: "sess-stop-skill-repeat",
+          thread_id: "thread-stop-skill-repeat",
+          turn_id: "turn-stop-skill-repeat-1",
+          stop_hook_active: true,
+        },
+        { cwd },
+      );
+
+      assert.equal(repeated.omxEventName, "stop");
+      assert.deepEqual(repeated.outputJson, {
+        decision: "block",
+        reason:
+          "OMX skill ralplan is still active (phase: planning); continue until the current ralplan workflow reaches a terminal state.",
+        stopReason: "skill_ralplan_planning",
+        systemMessage: "OMX skill ralplan is still active (phase: planning).",
+      });
+    } finally {
+      await rm(cwd, { recursive: true, force: true });
+    }
+  });
+
   it("does not block Stop from another session's stale root team state when no scoped team state exists", async () => {
     const cwd = await mkdtemp(join(tmpdir(), "omx-native-hook-stop-stale-root-team-"));
     try {

package/src/scripts/__tests__/generate-release-body.test.ts

@@ -0,0 +1,166 @@
+import assert from 'node:assert/strict';
+import { mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { describe, it } from 'node:test';
+import { spawnSync } from 'node:child_process';
+import {
+  buildFullChangelogLine,
+  generateReleaseBody,
+  renderContributorsSection,
+  type Contributor,
+} from '../generate-release-body.js';
+
+function git(cwd: string, args: string[], env: NodeJS.ProcessEnv = {}): string {
+  const result = spawnSync('git', args, {
+    cwd,
+    encoding: 'utf-8',
+    env: { ...process.env, ...env },
+  });
+  assert.equal(result.status, 0, result.stderr || result.stdout);
+  return String(result.stdout || '').trim();
+}
+
+const TEMPLATE = `# oh-my-codex v0.0.0
+
+## Summary
+
+Custom summary that must stay intact.
+
+## Fixed
+
+- Keep this handwritten section.
+
+## Verification
+
+- npm test
+
+## Contributors
+
+Outdated contributor text.
+
+**Full Changelog**: [\`v0.0.0...v0.0.1\`](https://github.com/example/compare/v0.0.0...v0.0.1)
+`;
+
+describe('generate-release-body', () => {
+  it('preserves custom sections while refreshing contributors and compare metadata from git', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'omx-generate-release-body-'));
+    const originalGitHubRepository = process.env.GITHUB_REPOSITORY;
+    try {
+      git(root, ['init']);
+      git(root, ['config', 'user.name', 'Release Bot']);
+      git(root, ['config', 'user.email', 'release@example.com']);
+      git(root, ['remote', 'add', 'origin', 'https://github.com/example/oh-my-codex.git']);
+
+      await writeFile(join(root, 'RELEASE_BODY.md'), TEMPLATE);
+      await writeFile(join(root, 'notes.txt'), 'base\n');
+      git(root, ['add', '.']);
+      git(root, ['commit', '-m', 'base']);
+      git(root, ['tag', 'v0.12.0']);
+
+      await writeFile(join(root, 'notes.txt'), 'alice\n');
+      git(root, ['add', 'notes.txt']);
+      git(root, ['commit', '-m', 'alice change'], { GIT_AUTHOR_NAME: 'Alice Example', GIT_AUTHOR_EMAIL: 'alice@example.com' });
+
+      await writeFile(join(root, 'notes.txt'), 'bob\n');
+      git(root, ['add', 'notes.txt']);
+      git(root, ['commit', '-m', 'bob change'], { GIT_AUTHOR_NAME: 'Bob Example', GIT_AUTHOR_EMAIL: 'bob@example.com' });
+      git(root, ['tag', 'v0.13.0']);
+
+      delete process.env.GITHUB_REPOSITORY;
+      await generateReleaseBody({
+        cwd: root,
+        templatePath: 'RELEASE_BODY.md',
+        outPath: 'RELEASE_BODY.generated.md',
+        currentTag: 'v0.13.0',
+      });
+
+      const generated = await readFile(join(root, 'RELEASE_BODY.generated.md'), 'utf-8');
+      assert.match(generated, /^# oh-my-codex v0.13.0/m);
+      assert.match(generated, /Custom summary that must stay intact\./);
+      assert.match(generated, /Keep this handwritten section\./);
+      assert.match(generated, /## Contributors\n\nThanks to Alice Example and Bob Example for contributing to this release\./);
+      assert.match(generated, /\*\*Full Changelog\*\*: \[`v0\.12\.0\.\.\.v0\.13\.0`\]\(https:\/\/github\.com\/example\/oh-my-codex\/compare\/v0\.12\.0\.\.\.v0\.13\.0\)/);
+    } finally {
+      if (originalGitHubRepository === undefined) {
+        delete process.env.GITHUB_REPOSITORY;
+      } else {
+        process.env.GITHUB_REPOSITORY = originalGitHubRepository;
+      }
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('prefers GitHub contributor handles when compare metadata is available', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'omx-generate-release-body-gh-'));
+    try {
+      await writeFile(join(root, 'RELEASE_BODY.md'), TEMPLATE);
+      const originalFetch = global.fetch;
+      global.fetch = (async () => new Response(JSON.stringify({
+        commits: [
+          { author: { login: 'alice', html_url: 'https://github.com/alice' } },
+          { author: { login: 'bob', html_url: 'https://github.com/bob' } },
+          { author: { login: 'alice', html_url: 'https://github.com/alice' } },
+        ],
+      }), { status: 200, headers: { 'content-type': 'application/json' } })) as typeof fetch;
+
+      try {
+        await generateReleaseBody({
+          cwd: root,
+          templatePath: 'RELEASE_BODY.md',
+          outPath: 'RELEASE_BODY.generated.md',
+          currentTag: 'v0.13.1',
+          previousTag: 'v0.13.0',
+          repo: 'example/oh-my-codex',
+          githubToken: 'test-token',
+        });
+      } finally {
+        global.fetch = originalFetch;
+      }
+
+      const generated = await readFile(join(root, 'RELEASE_BODY.generated.md'), 'utf-8');
+      assert.match(generated, /Thanks to \[@alice\]\(https:\/\/github\.com\/alice\) and \[@bob\]\(https:\/\/github\.com\/bob\) for contributing to this release\./);
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+
+  it('fails validation when the template is missing required metadata anchors', async () => {
+    const root = await mkdtemp(join(tmpdir(), 'omx-generate-release-body-invalid-'));
+    try {
+      await writeFile(join(root, 'RELEASE_BODY.md'), `# oh-my-codex v0.0.0
+
+## Summary
+
+Missing required sections.
+`);
+      await assert.rejects(
+        generateReleaseBody({
+          cwd: root,
+          templatePath: 'RELEASE_BODY.md',
+          outPath: 'RELEASE_BODY.generated.md',
+          currentTag: 'v0.13.1',
+          previousTag: 'v0.13.0',
+          repo: 'example/oh-my-codex',
+        }),
+        /missing section: ## Contributors|missing the Full Changelog line/,
+      );
+    } finally {
+      await rm(root, { recursive: true, force: true });
+    }
+  });
+
+  it('renders contributor and changelog helpers for edge cases', () => {
+    const contributors: Contributor[] = [];
+    assert.equal(renderContributorsSection(contributors), 'Thanks to the contributors who made this release possible.');
+    assert.equal(
+      buildFullChangelogLine('example/oh-my-codex', 'v0.13.1', 'v0.13.0'),
+      '**Full Changelog**: [`v0.13.0...v0.13.1`](https://github.com/example/oh-my-codex/compare/v0.13.0...v0.13.1)',
+    );
+    assert.equal(
+      buildFullChangelogLine('example/oh-my-codex', 'v0.1.0'),
+      '**Full Changelog**: [`v0.1.0`](https://github.com/example/oh-my-codex/releases/tag/v0.1.0)',
+    );
+  });
+});