oh-my-codex 0.12.5 → 0.12.6

package/src/scripts/notify-hook/tmux-injection.ts

@@ -8,6 +8,7 @@ import { readFile, writeFile } from 'fs/promises';
 import { existsSync } from 'fs';
 import { join, resolve as resolvePath } from 'path';
 import { safeString, asNumber } from './utils.js';
+import { sameFilePath } from '../../utils/paths.js';
 import {
   readJsonIfExists,
   normalizeTmuxState,
@@ -35,7 +36,7 @@ async function resolvePaneCwdMismatch(paneId: string, expectedCwd: any): Promise
   try {
     const paneCwdResult = await runProcess('tmux', ['display-message', '-p', '-t', paneId, '#{pane_current_path}']);
     const paneCwd = safeString(paneCwdResult.stdout).trim();
-    if (paneCwd && resolvePath(paneCwd) !== resolvePath(expectedCwd)) {
+    if (paneCwd && !sameFilePath(paneCwd, expectedCwd)) {
       return {
         paneTarget: null,
         reason: 'pane_cwd_mismatch',

package/src/scripts/run-provider-advisor.ts

@@ -3,12 +3,18 @@ import { mkdir, writeFile } from 'fs/promises';
 import { join } from 'path';
 import process from 'process';
 import { spawnSync } from 'child_process';
+import { CLAUDE_SKIP_PERMISSIONS_FLAG } from '../cli/constants.js';
 
 const PROVIDER_BINARIES: Record<string, string> = {
   claude: 'claude',
   gemini: 'gemini',
 };
 const ASK_ORIGINAL_TASK_ENV = 'OMX_ASK_ORIGINAL_TASK';
+const ISSUE_WORK_PROMPT_PATTERNS = [
+  /\bgh\s+issue\b/i,
+  /\b(?:fix|work on|work|investigate|implement|triage|debug|review|handle)\s+issue\s*#?\d+\b/i,
+  /\bissue\s*#\d+\b/i,
+];
 
 function usage(): void {
   console.error('Usage: omx ask <claude|gemini> "<prompt>"');
@@ -70,6 +76,13 @@ function ensureBinary(binary: string): void {
   }
 }
 
+function shouldUseClaudeIssuePermissionsBypass(provider: string, prompt: string): boolean {
+  if (provider !== 'claude') return false;
+  const trimmed = prompt.trim();
+  if (trimmed === '') return false;
+  return ISSUE_WORK_PROMPT_PATTERNS.some((pattern) => pattern.test(trimmed));
+}
+
 function buildSummary(exitCode: number, output: string): string {
   if (exitCode === 0) {
     return 'Provider completed successfully. Review the raw output for details.';
@@ -148,10 +161,15 @@ async function writeArtifact({ provider, originalTask, finalPrompt, rawOutput, e
 async function main(): Promise<void> {
   const { provider, prompt } = parseArgs(process.argv.slice(2));
   const binary = PROVIDER_BINARIES[provider];
+  const originalTask = process.env[ASK_ORIGINAL_TASK_ENV] ?? prompt;
 
   ensureBinary(binary);
 
-  const run = spawnSync(binary, ['-p', prompt], {
+  const launchArgs = shouldUseClaudeIssuePermissionsBypass(provider, originalTask)
+    ? [CLAUDE_SKIP_PERMISSIONS_FLAG, '-p', prompt]
+    : ['-p', prompt];
+
+  const run = spawnSync(binary, launchArgs, {
     encoding: 'utf8',
     maxBuffer: 10 * 1024 * 1024,
       windowsHide: true,
@@ -164,7 +182,7 @@ async function main(): Promise<void> {
 
   const artifactPath = await writeArtifact({
     provider,
-    originalTask: process.env[ASK_ORIGINAL_TASK_ENV] ?? prompt,
+    originalTask,
     finalPrompt: prompt,
     rawOutput,
     exitCode,

package/src/scripts/smoke-packed-install.ts

@@ -1,22 +1,21 @@
 import {
-  existsSync,
-  lstatSync,
   mkdtempSync,
   rmSync,
-  symlinkSync,
 } from 'node:fs';
 import { mkdirSync } from 'node:fs';
 import { tmpdir } from 'node:os';
-import { basename, dirname, join, resolve } from 'node:path';
+import { join } from 'node:path';
 import { spawnSync } from 'node:child_process';
 import { pathToFileURL } from 'node:url';
+import {
+  ensureReusableNodeModules,
+} from '../utils/repo-deps.js';
 
-const REQUIRED_NODE_MODULE_MARKERS = [
-  join('typescript', 'package.json'),
-  join('@iarna', 'toml', 'package.json'),
-  join('@modelcontextprotocol', 'sdk', 'package.json'),
-  join('zod', 'package.json'),
-];
+export {
+  hasUsableNodeModules,
+  resolveGitCommonDir,
+  resolveReusableNodeModulesSource,
+} from '../utils/repo-deps.js';
 
 export const PACKED_INSTALL_SMOKE_CORE_COMMANDS = [
   ['--help'],
@@ -32,41 +31,10 @@ function usage(): string {
   ].join('\n');
 }
 
-function hasNodeModulesPath(nodeModulesPath: string): boolean {
-  try {
-    lstatSync(nodeModulesPath);
-    return true;
-  } catch {
-    return false;
-  }
-}
-
-export function hasUsableNodeModules(repoRoot: string): boolean {
-  return REQUIRED_NODE_MODULE_MARKERS.every((marker) => existsSync(join(repoRoot, 'node_modules', marker)));
-}
-
-export function resolveGitCommonDir(cwd: string, gitRunner = spawnSync): string | null {
-  const result = gitRunner('git', ['rev-parse', '--git-common-dir'], {
-    cwd,
-    encoding: 'utf-8',
-  });
-  if (result.status !== 0) {
-    return null;
-  }
-  const value = (result.stdout || '').trim();
-  if (!value) {
-    return null;
-  }
-  return resolve(cwd, value);
-}
-
 interface EnsureRepoDepsOptions {
   gitRunner?: typeof spawnSync;
   install?: (cwd: string) => void;
-  remove?: typeof rmSync;
-  symlink?: typeof symlinkSync;
   log?: (message: string) => void;
-  platformName?: string;
 }
 
 interface EnsureRepoDepsResult {
@@ -75,24 +43,6 @@ interface EnsureRepoDepsResult {
   sourceNodeModulesPath?: string;
 }
 
-export function resolveReusableNodeModulesSource(repoRoot: string, gitRunner = spawnSync): string | null {
-  const commonDir = resolveGitCommonDir(repoRoot, gitRunner);
-  if (!commonDir || basename(commonDir) !== '.git') {
-    return null;
-  }
-
-  const primaryRepoRoot = dirname(commonDir);
-  if (resolve(primaryRepoRoot) === resolve(repoRoot)) {
-    return null;
-  }
-
-  if (!hasUsableNodeModules(primaryRepoRoot)) {
-    return null;
-  }
-
-  return join(primaryRepoRoot, 'node_modules');
-}
-
 function formatCommandFailure(cmd: string, args: string[], result: { stdout?: string; stderr?: string }): string {
   return [
     `Command failed: ${cmd} ${args.join(' ')}`,
@@ -114,40 +64,23 @@ export function ensureRepoDependencies(repoRoot: string, options: EnsureRepoDeps
         throw new Error(formatCommandFailure('npm', ['ci'], result));
       }
     },
-    remove = rmSync,
-    symlink = symlinkSync,
     log = () => {},
-    platformName = process.platform,
   } = options;
 
-  if (hasUsableNodeModules(repoRoot)) {
-    return {
-      strategy: 'existing',
-      nodeModulesPath: join(repoRoot, 'node_modules'),
-    };
+  const reusable = ensureReusableNodeModules(repoRoot, { gitRunner });
+  if (reusable.strategy === 'existing') {
+    return reusable;
   }
-
-  const targetNodeModules = join(repoRoot, 'node_modules');
-  if (hasNodeModulesPath(targetNodeModules)) {
-    remove(targetNodeModules, { recursive: true, force: true });
-  }
-
-  const reusableNodeModules = resolveReusableNodeModulesSource(repoRoot, gitRunner);
-  if (reusableNodeModules) {
-    symlink(reusableNodeModules, targetNodeModules, platformName === 'win32' ? 'junction' : 'dir');
-    log(`[smoke:packed-install] Reusing node_modules from ${reusableNodeModules}`);
-    return {
-      strategy: 'symlink',
-      nodeModulesPath: targetNodeModules,
-      sourceNodeModulesPath: reusableNodeModules,
-    };
+  if (reusable.strategy === 'symlink') {
+    log(`[smoke:packed-install] Reusing node_modules from ${reusable.sourceNodeModulesPath}`);
+    return reusable;
   }
 
   log('[smoke:packed-install] Installing repo dependencies with npm ci');
   install(repoRoot);
   return {
     strategy: 'installed',
-    nodeModulesPath: targetNodeModules,
+    nodeModulesPath: join(repoRoot, 'node_modules'),
   };
 }