oh-my-ag 1.2.0 → 1.3.1

package/.agent/skills/backend-agent/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: backend-agent
-description: Backend specialist for APIs, databases, authentication, and server-side logic using FastAPI, Node.js, or other frameworks
+description: Backend specialist for APIs, databases, authentication using FastAPI with clean architecture (Repository/Service/Router pattern)
 ---
 
 # Backend Agent - API & Server Specialist
@@ -16,23 +16,80 @@ description: Backend specialist for APIs, databases, authentication, and server-
 - Frontend UI -> use Frontend Agent
 - Mobile-specific code -> use Mobile Agent
 
+## Core Principles
+
+1. **DRY (Don't Repeat Yourself)**: 비즈니스 로직은 `Service`에, 데이터 접근 로직은 `Repository`에
+2. **SOLID**:
+   - **Single Responsibility**: 클래스와 함수는 하나의 책임만
+   - **Dependency Inversion**: FastAPI의 `Depends`로 의존성 주입
+3. **KISS**: 단순하고 명확한 코드 지향
+
+## Architecture Pattern
+
+```
+Router (HTTP) → Service (Business Logic) → Repository (Data Access) → Models
+```
+
+### Repository Layer
+- **파일**: `src/[domain]/repository.py`
+- **역할**: DB CRUD 및 쿼리 로직 캡슐화
+- **원칙**: 비즈니스 로직 없음, SQLAlchemy 모델 반환
+
+### Service Layer
+- **파일**: `src/[domain]/service.py`
+- **역할**: 비즈니스 로직, Repository 조합, 외부 API 호출
+- **원칙**: 비즈니스 결정은 오직 여기서만
+
+### Router Layer
+- **파일**: `src/[domain]/router.py`
+- **역할**: HTTP 요청 수신, 입력 검증, Service 호출, 응답 반환
+- **원칙**: 비즈니스 로직 금지, DI로 Service 주입
+
 ## Core Rules
-1. Clean architecture: router -> service -> repository -> models
-2. No business logic in route handlers
-3. All inputs validated with Pydantic/Zod
-4. Parameterized queries only (never string interpolation)
-5. JWT + bcrypt for auth; rate limit auth endpoints
-6. Async/await consistently; type hints on all signatures
+
+1. **Clean architecture**: router → service → repository → models
+2. **No business logic in route handlers**
+3. **All inputs validated with Pydantic**
+4. **Parameterized queries only** (never string interpolation)
+5. **JWT + bcrypt for auth**; rate limit auth endpoints
+6. **Async/await consistently**; type hints on all signatures
+7. **Custom exceptions** via `src/lib/exceptions.py` (not raw HTTPException)
+
+## Dependency Injection
+
+```python
+# src/recipes/routers/dependencies.py
+async def get_recipe_service(db: AsyncSession = Depends(get_db)) -> RecipeService:
+    repository = RecipeRepository(db)
+    return RecipeService(repository)
+
+# src/recipes/routers/base_router.py
+@router.get("/{recipe_id}")
+async def get_recipe(
+    recipe_id: str,
+    service: RecipeService = Depends(get_recipe_service)
+):
+    return await service.get_recipe(recipe_id)
+```
+
+## Code Quality
+
+- **Python 3.12+**: 엄격한 타입 힌트 (mypy)
+- **Async/Await**: I/O 바운드 작업에 필수
+- **Ruff**: 린팅/포맷팅 (Double Quotes, Line Length 100)
 
 ## How to Execute
+
 Follow `resources/execution-protocol.md` step by step.
 See `resources/examples.md` for input/output examples.
 Before submitting, run `resources/checklist.md`.
 
 ## Serena Memory (CLI Mode)
-See `../_shared/serena-memory-protocol.md`.
+
+See `../_shared/memory-protocol.md`.
 
 ## References
+
 - Execution steps: `resources/execution-protocol.md`
 - Code examples: `resources/examples.md`
 - Code snippets: `resources/snippets.md`
@@ -45,3 +102,6 @@ See `../_shared/serena-memory-protocol.md`.
 - Clarification: `../_shared/clarification-protocol.md`
 - Context budget: `../_shared/context-budget.md`
 - Lessons learned: `../_shared/lessons-learned.md`
+
+> [!IMPORTANT]
+> 새 모듈 추가 시 반드시 `__init__.py` 포함하여 패키지 구조 유지

package/.agent/skills/frontend-agent/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: frontend-agent
-description: Frontend specialist for React, Next.js, TypeScript, and modern UI development
+description: Frontend specialist for React, Next.js, TypeScript with FSD-lite architecture, shadcn/ui, and design system alignment
 ---
 
 # Frontend Agent - UI/UX Specialist
@@ -16,23 +16,123 @@ description: Frontend specialist for React, Next.js, TypeScript, and modern UI d
 - Backend API implementation -> use Backend Agent
 - Native mobile development -> use Mobile Agent
 
-## Core Rules
-1. TypeScript strict mode; explicit interfaces for all props
-2. Tailwind CSS only (no inline styles, no CSS modules)
-3. Semantic HTML with ARIA labels; keyboard navigation required
-4. Loading, error, and empty states for every async operation
-5. Responsive at 320px, 768px, 1024px, 1440px
-6. shadcn/ui + Radix for component primitives
+## Core Principles
+
+1. **Component Reuse**: Use `shadcn/ui` components first. Extend via `cva` variants or composition. Avoid custom CSS.
+2. **Design Fidelity**: Code must map 1:1 to Design Tokens. Resolve discrepancies before implementation.
+3. **Rendering Strategy**: Default to Server Components for performance. Use Client Components only for interactivity and API integration.
+4. **Accessibility**: Semantic HTML, ARIA labels, keyboard navigation, and screen reader compatibility are mandatory.
+5. **Tool First**: Check for existing solutions and tools before coding.
+
+## 1. Tooling & Performance
+
+- **Metrics**: Target First Contentful Paint (FCP) < 1s.
+- **Optimization**: Use `next/dynamic` for heavy components, `next/image` for media, and parallel routes.
+- **Responsive Breakpoints**: 320px, 768px, 1024px, 1440px
+- **Shadcn Workflow**:
+  1. Search: `shadcn_search_items_in_registries`
+  2. Review: `shadcn_get_item_examples_from_registries`
+  3. Install: `shadcn_get_add_command_for_items`
+
+## 2. Architecture (FSD-lite)
+
+- **Root (`src/`)**: Shared logic (components, lib, types). Hoist common code here.
+- **Feature (`src/features/*/`)**: Feature-specific logic. **No cross-feature imports.** Unidirectional flow only.
+
+### Feature Directory Structure
+```
+src/features/[feature]/
+├── components/           # Feature UI components
+│   └── skeleton/         # Loading skeleton components
+├── types/                # Feature-specific type definitions
+└── utils/                # Feature-specific utilities & helpers
+```
+
+### Placement Rules
+- `components/`: React components only. One component per file.
+- `types/`: TypeScript interfaces and type definitions.
+- `utils/`: All feature-specific logic (formatters, validators, helpers). **Requires >90% test coverage** for custom logic.
+
+> **Note**: Feature level does NOT have `lib/` folder. Use `utils/` for all utilities. `lib/` exists only at root `src/lib/` level.
+
+## 3. Libraries
+
+| Category | Library |
+|----------|---------|
+| Date | `luxon` |
+| Styling | `TailwindCSS v4` + `shadcn/ui` |
+| Hooks | `ahooks` (Pre-made hooks preferred) |
+| Utils | `es-toolkit` (First choice) |
+| State (URL) | `jotai-location` |
+| State (Server) | `TanStack Query` |
+| State (Client) | `Jotai` (Minimize use) |
+| Forms | `@tanstack/react-form` + `zod` |
+
+## 4. Standards
+
+- **Utilities**: Check `es-toolkit` first. If implementing custom logic, **>90% Unit Test Coverage** is MANDATORY.
+- **Design Tokens**: Source of Truth is `packages/design-tokens` (OKLCH). Never hardcode colors.
+- **i18n**: Source of Truth is `packages/i18n`. Never hardcode strings.
+
+## 5. Component Strategy
+
+### Server vs Client Components
+- **Server Components**: Layouts, Marketing pages, SEO metadata (`generateMetadata`, `sitemap`)
+- **Client Components**: Interactive features and `useQuery` hooks
+
+### Structure
+- **One Component Per File**
+
+### Naming Conventions
+| Type | Convention |
+|------|------------|
+| Files | `kebab-case.tsx` (Name MUST indicate purpose) |
+| Components/Types/Interfaces | `PascalCase` |
+| Functions/Vars/Hooks | `camelCase` |
+| Constants | `SCREAMING_SNAKE_CASE` |
+
+### Imports
+- Order: Standard > 3rd Party > Local
+- Absolute `@/` is MANDATORY (No relative paths like `../../`)
+- **MUST use `import type`** for interfaces/types
+
+### Skeletons
+- Must be placed in `src/features/[feature]/components/skeleton/`
+
+## 6. UI Implementation (Shadcn/UI)
+
+- **Usage**: Prefer strict shadcn primitives (`Card`, `Sheet`, `Typography`, `Table`) over `div` or generic classes.
+- **Responsiveness**: Use `Drawer` (Mobile) vs `Dialog` (Desktop) via `useResponsive`.
+- **Customization Rule**: Treat `components/ui/*` as read-only. Do not modify directly.
+  - **Correct**: Create a wrapper (e.g., `components/common/ProductButton.tsx`) or use `cva` composition.
+  - **Incorrect**: Editing `components/ui/button.tsx`.
+
+## 7. Designer Collaboration
+
+- **Sync**: Map code variables to Figma layer names.
+- **UX**: Ensure key actions are visible "Above the Fold".
 
 ## How to Execute
+
 Follow `resources/execution-protocol.md` step by step.
 See `resources/examples.md` for input/output examples.
 Before submitting, run `resources/checklist.md`.
 
 ## Serena Memory (CLI Mode)
-See `../_shared/serena-memory-protocol.md`.
+
+See `../_shared/memory-protocol.md`.
+
+## Review Checklist
+
+- [ ] **A11y**: Interactive elements have `aria-label`. Semantic headings (`h1`-`h6`).
+- [ ] **Mobile**: Functionality verified on mobile viewports.
+- [ ] **Performance**: No CLS, fast load.
+- [ ] **Resilience**: Error Boundaries and Loading Skeletons implemented.
+- [ ] **Tests**: Logic covered by Vitest where complex.
+- [ ] **Quality**: Typecheck and Lint pass.
 
 ## References
+
 - Execution steps: `resources/execution-protocol.md`
 - Code examples: `resources/examples.md`
 - Code snippets: `resources/snippets.md`
@@ -46,3 +146,6 @@ See `../_shared/serena-memory-protocol.md`.
 - Clarification: `../_shared/clarification-protocol.md`
 - Context budget: `../_shared/context-budget.md`
 - Lessons learned: `../_shared/lessons-learned.md`
+
+> [!IMPORTANT]
+> Treat `components/ui/*` as read-only. Create wrappers for customization.

package/.agent/skills/orchestrator/scripts/spawn-agent.sh

@@ -79,7 +79,7 @@ get_vendor_config() {
 # Get CLI for specific agent type from user-preferences.yaml
 get_agent_cli() {
     local agent_type="$1"
-    local prefs="${SCRIPT_DIR}/../../config/user-preferences.yaml"
+    local prefs="${SCRIPT_DIR}/../../../config/user-preferences.yaml"
     if [[ -f "$prefs" ]]; then
         grep -A10 "^agent_cli_mapping:" "$prefs" 2>/dev/null | \
             grep "^  ${agent_type}:" | \
@@ -89,7 +89,7 @@ get_agent_cli() {
 
 # Get default CLI from user-preferences.yaml
 get_default_cli() {
-    local prefs="${SCRIPT_DIR}/../../config/user-preferences.yaml"
+    local prefs="${SCRIPT_DIR}/../../../config/user-preferences.yaml"
     if [[ -f "$prefs" ]]; then
         grep "^default_cli:" "$prefs" 2>/dev/null | sed 's/^[^:]*: *//' | tr -d '"' | xargs
     fi