ofiere-openclaw-plugin 4.50.0-probe.2 → 4.50.1

package/dist/src/tools.js

@@ -21,6 +21,35 @@ function ok(data) {
         content: [{ type: "text", text: JSON.stringify(data, null, 2) }],
     };
 }
+// Extract plain text from a message that may be a plain string, a `{text}`
+// envelope, or — under OpenClaw 2026.5+ — a structured content array such as
+// `[{type:'text', text:'...'}, {type:'thinking', thinking:'...'}]`.
+//
+// BUG 12 fix (cycle 7b BUGSHOOT-5 → cycle 10 pivot): the prior inline
+// expression returned the array value itself instead of joining the text
+// parts because `||` short-circuited on the truthy array. Result: every
+// staff dispatch persisted empty content. Centralising the logic in one
+// helper avoids the same bug recurring at every call site.
+function extractMessageText(msg) {
+    if (typeof msg === "string")
+        return msg;
+    if (typeof msg?.text === "string")
+        return msg.text;
+    if (typeof msg?.content === "string")
+        return msg.content;
+    if (typeof msg?.message?.content === "string")
+        return msg.message.content;
+    const arr = Array.isArray(msg?.content) ? msg.content
+        : Array.isArray(msg?.message?.content) ? msg.message.content
+            : null;
+    if (arr) {
+        return arr
+            .filter((c) => c?.type === "text" && typeof c?.text === "string")
+            .map((c) => c.text)
+            .join("\n");
+    }
+    return "";
+}
 function err(message) {
     return {
         content: [{ type: "text", text: `Error: ${message}` }],
@@ -6385,12 +6414,6 @@ supabase, config) {
     registerAttachmentContextHook({ api, supabase, userId, fallbackAgentId, resolveAgent });
     // ── Register agent_end hook for server-side brain extraction ──
     registerBrainExtractionHook(api, supabase, userId, fallbackAgentId);
-    // ── CYCLE 10 PROBE — verify subagent_* hook payload shapes ─────────────
-    // Probe-only build (4.50.0-probe.x). Logs full payload on first fire of
-    // each native subagent hook + triggers a one-shot subagent.run 8s after
-    // init so we capture spawning → spawned → ended lifecycle. Removed in
-    // 4.50.0 production release.
-    registerCycle10Probe(api);
     // ── Count and log ──
     const toolCount = 16;
     const callerName = getCallingAgentName(api);
@@ -6425,22 +6448,21 @@ function registerBrainExtractionHook(api, supabase, userId, fallbackAgentId) {
                     return;
                 }
                 // Find last user + last assistant message
+                // BUG 12 fix: extractMessageText handles structured content arrays
+                // (OpenClaw 2026.5+ delivers `[{type:'text',text:'X'},{type:'thinking',...}]`,
+                // not plain strings). Prior inline expression returned the array, which
+                // typeof-checked to "object" → both lastUser/lastAssistant became "".
                 let lastUser = "";
                 let lastAssistant = "";
                 for (let i = messages.length - 1; i >= 0; i--) {
                     const msg = messages[i];
                     const role = msg?.role || msg?.message?.role;
-                    const text = typeof msg === "string" ? msg
-                        : msg?.text || msg?.content || msg?.message?.content
-                            ?.filter?.((c) => c.type === "text")
-                            ?.map?.((c) => c.text)
-                            ?.join?.("\n")
-                            || (typeof msg?.message?.content === "string" ? msg.message.content : "");
+                    const text = extractMessageText(msg);
                     if (!lastAssistant && (role === "assistant" || role === "model")) {
-                        lastAssistant = typeof text === "string" ? text : "";
+                        lastAssistant = text;
                     }
                     if (!lastUser && role === "user") {
-                        lastUser = typeof text === "string" ? text : "";
+                        lastUser = text;
                     }
                     if (lastUser && lastAssistant)
                         break;
@@ -6523,15 +6545,23 @@ function registerBrainExtractionHook(api, supabase, userId, fallbackAgentId) {
                             const reportBody = taskId
                                 ? `Staff ${staff.name}${staff.role ? ` (${staff.role})` : ""} reported on task ${taskId}:\n\n${excerpt}`
                                 : `Staff ${staff.name}${staff.role ? ` (${staff.role})` : ""} reported:\n\n${excerpt}`;
-                            await supabase.from("agent_memories").insert({
+                            // BUG 13 fix (cycle 10 pivot): tier was 'L4_episodic' which is
+                            // NOT in the agent_memories.tier CHECK enum (L1_focus, L2_episode,
+                            // L3_pattern, L4_rule, L5_persona) → insert silently failed.
+                            // Use L2_episode (the actual "episodic memory" tier). source
+                            // 'staff_report' added to enum via migration in same cycle.
+                            const { error: memErr } = await supabase.from("agent_memories").insert({
                                 user_id: userId,
                                 agent_id: staff.chief_agent_id,
-                                tier: "L4_episodic",
+                                tier: "L2_episode",
                                 content: reportBody,
                                 source: "staff_report",
                                 importance: 5,
                                 context_key: taskId ? `staff_report:${staffDispatchSubagentId}:${taskId}` : `staff_report:${staffDispatchSubagentId}`,
                             });
+                            if (memErr) {
+                                api.logger.warn?.(`[ofiere-staff-report] memory insert failed: ${memErr.message}`);
+                            }
                             api.logger.info?.(`[ofiere-staff-report] memory written for chief ${staff.chief_agent_id} from staff ${staff.name}`);
                             // BUG 9 fix (BUGSHOOT-2): mark task_dispatch_log row complete
                             // with the assistant's response preview. Without this the log
@@ -6753,102 +6783,6 @@ function registerBrainExtractionHook(api, supabase, userId, fallbackAgentId) {
         api.logger.debug?.("[ofiere] Could not register agent_end hook — may not be supported in this OpenClaw version");
     }
 }
-// ─────────────────────────────────────────────────────────────────────────────
-// CYCLE 10 PROBE — REMOVE/DISABLE BEFORE PRODUCTION 4.50.x
-// ─────────────────────────────────────────────────────────────────────────────
-// One-shot diagnostic that logs the full payload shape of every native
-// subagent_* hook, then triggers a single api.runtime.subagent.run so the
-// lifecycle fires end-to-end. Used to verify field names before the real
-// subagent_ended handler is written. Activated by env var
-// OFIERE_CYCLE10_PROBE=1; otherwise inert.
-//
-// Captured in cycle 10 BUGSHOOT under hook key [ofiere-probe].
-// ─────────────────────────────────────────────────────────────────────────────
-function registerCycle10Probe(api) {
-    const safeStringify = (obj, max = 4000) => {
-        try {
-            const seen = new WeakSet();
-            const out = JSON.stringify(obj, (_k, v) => {
-                if (typeof v === "object" && v !== null) {
-                    if (seen.has(v))
-                        return "[Circular]";
-                    seen.add(v);
-                }
-                if (typeof v === "function")
-                    return `[Function ${v.name || "anon"}]`;
-                return v;
-            }, 2);
-            return out.length > max ? out.slice(0, max) + "...[truncated]" : out;
-        }
-        catch (e) {
-            return `[stringify-fail: ${e instanceof Error ? e.message : String(e)}]`;
-        }
-    };
-    const hookNames = [
-        "subagent_spawning",
-        "subagent_spawned",
-        "subagent_delivery_target",
-        "subagent_ended",
-    ];
-    for (const hook of hookNames) {
-        try {
-            api.on?.(hook, (event, ctx) => {
-                try {
-                    api.logger.info?.(`[ofiere-probe] ${hook} event=${safeStringify(event, 2000)} ctx=${safeStringify(ctx, 2000)}`);
-                }
-                catch (e) {
-                    api.logger.warn?.(`[ofiere-probe] ${hook} log failed: ${e instanceof Error ? e.message : String(e)}`);
-                }
-            });
-            api.logger.info?.(`[ofiere-probe] ${hook} hook registered`);
-        }
-        catch (e) {
-            api.logger.warn?.(`[ofiere-probe] ${hook} hook register failed: ${e instanceof Error ? e.message : String(e)}`);
-        }
-    }
-    // One-shot spawn 8s after init so the gateway is fully up.
-    setTimeout(async () => {
-        const sessionKey = `agent:celia:subagent:probe-${Date.now().toString(36).slice(-6)}`;
-        api.logger.info?.(`[ofiere-probe] firing api.runtime.subagent.run sessionKey=${sessionKey}`);
-        try {
-            const runtime = api?.runtime;
-            if (!runtime?.subagent?.run) {
-                api.logger.error?.(`[ofiere-probe] api.runtime.subagent.run NOT AVAILABLE on this OpenClaw version. ` +
-                    `runtime keys: ${runtime ? Object.keys(runtime).join(",") : "(no runtime)"}`);
-                return;
-            }
-            const result = await runtime.subagent.run({
-                sessionKey,
-                message: "Reply with exactly the text PROBE-OK and nothing else.",
-                deliver: false,
-            });
-            api.logger.info?.(`[ofiere-probe] subagent.run returned ${safeStringify(result, 1000)}`);
-            // Try waitForRun + getSessionMessages immediately so we capture the
-            // full transcript shape even before subagent_ended fires.
-            if (result?.runId && runtime.subagent.waitForRun) {
-                try {
-                    const waitResult = await runtime.subagent.waitForRun({ runId: result.runId, timeoutMs: 30000 });
-                    api.logger.info?.(`[ofiere-probe] waitForRun returned ${safeStringify(waitResult, 2000)}`);
-                }
-                catch (e) {
-                    api.logger.warn?.(`[ofiere-probe] waitForRun threw: ${e instanceof Error ? e.message : String(e)}`);
-                }
-            }
-            if (runtime.subagent.getSessionMessages) {
-                try {
-                    const msgsResult = await runtime.subagent.getSessionMessages({ sessionKey, limit: 10 });
-                    api.logger.info?.(`[ofiere-probe] getSessionMessages returned ${safeStringify(msgsResult, 4000)}`);
-                }
-                catch (e) {
-                    api.logger.warn?.(`[ofiere-probe] getSessionMessages threw: ${e instanceof Error ? e.message : String(e)}`);
-                }
-            }
-        }
-        catch (e) {
-            api.logger.error?.(`[ofiere-probe] subagent.run threw: ${e instanceof Error ? `${e.name}: ${e.message}\n${e.stack}` : String(e)}`);
-        }
-    }, 8000);
-}
 // ── Brain Context Bootstrap Injection ──────────────────────────────────────
 // Injects the calling agent's active memories into the system prompt via
 // api.on("before_prompt_build"). Uses the TMT hierarchy:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ofiere-openclaw-plugin",
-  "version": "4.50.0-probe.2",
+  "version": "4.50.1",
   "type": "module",
   "description": "OpenClaw plugin for Ofiere PM - 16 meta-tools covering tasks, agents, projects, scheduling, knowledge, workflows, notifications, memory, prompts, constellation, space file management, execution plan builder, SOP management, agent brain, talent management, and corporate frameworks",
   "keywords": ["openclaw", "ofiere", "project-management", "agents", "plugin"],

package/src/tools.ts

@@ -36,6 +36,32 @@ function ok(data: unknown): ToolResult {
   };
 }
 
+// Extract plain text from a message that may be a plain string, a `{text}`
+// envelope, or — under OpenClaw 2026.5+ — a structured content array such as
+// `[{type:'text', text:'...'}, {type:'thinking', thinking:'...'}]`.
+//
+// BUG 12 fix (cycle 7b BUGSHOOT-5 → cycle 10 pivot): the prior inline
+// expression returned the array value itself instead of joining the text
+// parts because `||` short-circuited on the truthy array. Result: every
+// staff dispatch persisted empty content. Centralising the logic in one
+// helper avoids the same bug recurring at every call site.
+function extractMessageText(msg: any): string {
+  if (typeof msg === "string") return msg;
+  if (typeof msg?.text === "string") return msg.text;
+  if (typeof msg?.content === "string") return msg.content;
+  if (typeof msg?.message?.content === "string") return msg.message.content;
+  const arr = Array.isArray(msg?.content) ? msg.content
+    : Array.isArray(msg?.message?.content) ? msg.message.content
+    : null;
+  if (arr) {
+    return arr
+      .filter((c: any) => c?.type === "text" && typeof c?.text === "string")
+      .map((c: any) => c.text)
+      .join("\n");
+  }
+  return "";
+}
+
 function err(message: string): ToolResult {
   return {
     content: [{ type: "text" as const, text: `Error: ${message}` }],
@@ -6536,13 +6562,6 @@ export function registerTools(
   // ── Register agent_end hook for server-side brain extraction ──
   registerBrainExtractionHook(api, supabase, userId, fallbackAgentId);
 
-  // ── CYCLE 10 PROBE — verify subagent_* hook payload shapes ─────────────
-  // Probe-only build (4.50.0-probe.x). Logs full payload on first fire of
-  // each native subagent hook + triggers a one-shot subagent.run 8s after
-  // init so we capture spawning → spawned → ended lifecycle. Removed in
-  // 4.50.0 production release.
-  registerCycle10Probe(api);
-
   // ── Count and log ──
   const toolCount = 16;
   const callerName = getCallingAgentName(api);
@@ -6586,23 +6605,22 @@ function registerBrainExtractionHook(
         }
 
         // Find last user + last assistant message
+        // BUG 12 fix: extractMessageText handles structured content arrays
+        // (OpenClaw 2026.5+ delivers `[{type:'text',text:'X'},{type:'thinking',...}]`,
+        // not plain strings). Prior inline expression returned the array, which
+        // typeof-checked to "object" → both lastUser/lastAssistant became "".
         let lastUser = "";
         let lastAssistant = "";
         for (let i = messages.length - 1; i >= 0; i--) {
           const msg = messages[i];
           const role = msg?.role || msg?.message?.role;
-          const text = typeof msg === "string" ? msg
-            : msg?.text || msg?.content || msg?.message?.content
-              ?.filter?.((c: any) => c.type === "text")
-              ?.map?.((c: any) => c.text)
-              ?.join?.("\n")
-            || (typeof msg?.message?.content === "string" ? msg.message.content : "");
+          const text = extractMessageText(msg);
 
           if (!lastAssistant && (role === "assistant" || role === "model")) {
-            lastAssistant = typeof text === "string" ? text : "";
+            lastAssistant = text;
           }
           if (!lastUser && role === "user") {
-            lastUser = typeof text === "string" ? text : "";
+            lastUser = text;
           }
           if (lastUser && lastAssistant) break;
         }
@@ -6689,15 +6707,23 @@ function registerBrainExtractionHook(
               const reportBody = taskId
                 ? `Staff ${staff.name}${staff.role ? ` (${staff.role})` : ""} reported on task ${taskId}:\n\n${excerpt}`
                 : `Staff ${staff.name}${staff.role ? ` (${staff.role})` : ""} reported:\n\n${excerpt}`;
-              await supabase.from("agent_memories").insert({
+              // BUG 13 fix (cycle 10 pivot): tier was 'L4_episodic' which is
+              // NOT in the agent_memories.tier CHECK enum (L1_focus, L2_episode,
+              // L3_pattern, L4_rule, L5_persona) → insert silently failed.
+              // Use L2_episode (the actual "episodic memory" tier). source
+              // 'staff_report' added to enum via migration in same cycle.
+              const { error: memErr } = await supabase.from("agent_memories").insert({
                 user_id: userId,
                 agent_id: staff.chief_agent_id,
-                tier: "L4_episodic",
+                tier: "L2_episode",
                 content: reportBody,
                 source: "staff_report",
                 importance: 5,
                 context_key: taskId ? `staff_report:${staffDispatchSubagentId}:${taskId}` : `staff_report:${staffDispatchSubagentId}`,
               });
+              if (memErr) {
+                api.logger.warn?.(`[ofiere-staff-report] memory insert failed: ${memErr.message}`);
+              }
               api.logger.info?.(`[ofiere-staff-report] memory written for chief ${staff.chief_agent_id} from staff ${staff.name}`);
 
               // BUG 9 fix (BUGSHOOT-2): mark task_dispatch_log row complete
@@ -6932,105 +6958,6 @@ function registerBrainExtractionHook(
   }
 }
 
-// ─────────────────────────────────────────────────────────────────────────────
-// CYCLE 10 PROBE — REMOVE/DISABLE BEFORE PRODUCTION 4.50.x
-// ─────────────────────────────────────────────────────────────────────────────
-// One-shot diagnostic that logs the full payload shape of every native
-// subagent_* hook, then triggers a single api.runtime.subagent.run so the
-// lifecycle fires end-to-end. Used to verify field names before the real
-// subagent_ended handler is written. Activated by env var
-// OFIERE_CYCLE10_PROBE=1; otherwise inert.
-//
-// Captured in cycle 10 BUGSHOOT under hook key [ofiere-probe].
-// ─────────────────────────────────────────────────────────────────────────────
-
-function registerCycle10Probe(api: any): void {
-  const safeStringify = (obj: unknown, max = 4000): string => {
-    try {
-      const seen = new WeakSet<object>();
-      const out = JSON.stringify(obj, (_k, v) => {
-        if (typeof v === "object" && v !== null) {
-          if (seen.has(v)) return "[Circular]";
-          seen.add(v);
-        }
-        if (typeof v === "function") return `[Function ${v.name || "anon"}]`;
-        return v;
-      }, 2);
-      return out.length > max ? out.slice(0, max) + "...[truncated]" : out;
-    } catch (e) {
-      return `[stringify-fail: ${e instanceof Error ? e.message : String(e)}]`;
-    }
-  };
-
-  const hookNames = [
-    "subagent_spawning",
-    "subagent_spawned",
-    "subagent_delivery_target",
-    "subagent_ended",
-  ];
-  for (const hook of hookNames) {
-    try {
-      api.on?.(hook, (event: any, ctx: any) => {
-        try {
-          api.logger.info?.(
-            `[ofiere-probe] ${hook} event=${safeStringify(event, 2000)} ctx=${safeStringify(ctx, 2000)}`,
-          );
-        } catch (e) {
-          api.logger.warn?.(`[ofiere-probe] ${hook} log failed: ${e instanceof Error ? e.message : String(e)}`);
-        }
-      });
-      api.logger.info?.(`[ofiere-probe] ${hook} hook registered`);
-    } catch (e) {
-      api.logger.warn?.(`[ofiere-probe] ${hook} hook register failed: ${e instanceof Error ? e.message : String(e)}`);
-    }
-  }
-
-  // One-shot spawn 8s after init so the gateway is fully up.
-  setTimeout(async () => {
-    const sessionKey = `agent:celia:subagent:probe-${Date.now().toString(36).slice(-6)}`;
-    api.logger.info?.(`[ofiere-probe] firing api.runtime.subagent.run sessionKey=${sessionKey}`);
-    try {
-      const runtime = (api as any)?.runtime;
-      if (!runtime?.subagent?.run) {
-        api.logger.error?.(
-          `[ofiere-probe] api.runtime.subagent.run NOT AVAILABLE on this OpenClaw version. ` +
-          `runtime keys: ${runtime ? Object.keys(runtime).join(",") : "(no runtime)"}`,
-        );
-        return;
-      }
-      const result = await runtime.subagent.run({
-        sessionKey,
-        message: "Reply with exactly the text PROBE-OK and nothing else.",
-        deliver: false,
-      });
-      api.logger.info?.(`[ofiere-probe] subagent.run returned ${safeStringify(result, 1000)}`);
-
-      // Try waitForRun + getSessionMessages immediately so we capture the
-      // full transcript shape even before subagent_ended fires.
-      if (result?.runId && runtime.subagent.waitForRun) {
-        try {
-          const waitResult = await runtime.subagent.waitForRun({ runId: result.runId, timeoutMs: 30000 });
-          api.logger.info?.(`[ofiere-probe] waitForRun returned ${safeStringify(waitResult, 2000)}`);
-        } catch (e) {
-          api.logger.warn?.(`[ofiere-probe] waitForRun threw: ${e instanceof Error ? e.message : String(e)}`);
-        }
-      }
-      if (runtime.subagent.getSessionMessages) {
-        try {
-          const msgsResult = await runtime.subagent.getSessionMessages({ sessionKey, limit: 10 });
-          api.logger.info?.(`[ofiere-probe] getSessionMessages returned ${safeStringify(msgsResult, 4000)}`);
-        } catch (e) {
-          api.logger.warn?.(`[ofiere-probe] getSessionMessages threw: ${e instanceof Error ? e.message : String(e)}`);
-        }
-      }
-    } catch (e) {
-      api.logger.error?.(
-        `[ofiere-probe] subagent.run threw: ${e instanceof Error ? `${e.name}: ${e.message}\n${e.stack}` : String(e)}`,
-      );
-    }
-  }, 8000);
-}
-
 // ── Brain Context Bootstrap Injection ──────────────────────────────────────
 // Injects the calling agent's active memories into the system prompt via
 // api.on("before_prompt_build"). Uses the TMT hierarchy: