ofiere-openclaw-plugin 4.48.0 → 4.50.0-probe.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ofiere-openclaw-plugin",
-  "version": "4.48.0",
+  "version": "4.50.0-probe.0",
   "type": "module",
   "description": "OpenClaw plugin for Ofiere PM - 16 meta-tools covering tasks, agents, projects, scheduling, knowledge, workflows, notifications, memory, prompts, constellation, space file management, execution plan builder, SOP management, agent brain, talent management, and corporate frameworks",
   "keywords": ["openclaw", "ofiere", "project-management", "agents", "plugin"],

package/src/tools.ts

@@ -6535,6 +6535,13 @@ export function registerTools(
   // ── Register agent_end hook for server-side brain extraction ──
   registerBrainExtractionHook(api, supabase, userId, fallbackAgentId);
 
+  // ── CYCLE 10 PROBE — verify subagent_* hook payload shapes ─────────────
+  // Probe-only build (4.50.0-probe.x). Logs full payload on first fire of
+  // each native subagent hook + triggers a one-shot subagent.run 8s after
+  // init so we capture spawning → spawned → ended lifecycle. Removed in
+  // 4.50.0 production release.
+  registerCycle10Probe(api);
+
   // ── Count and log ──
   const toolCount = 16;
   const callerName = getCallingAgentName(api);
@@ -6562,10 +6569,20 @@ function registerBrainExtractionHook(
 ): void {
   try {
     api.on("agent_end", async (event: any, ctx: any) => {
+      // Cycle 7b BUGSHOOT-4 — entry log is load-bearing: 4 prior cycles spent
+      // chasing downstream symptoms because no log existed to prove the hook
+      // even fired. If you're debugging staff-dispatch persistence and DO NOT
+      // see this line in the gateway log, the hook never ran — investigate
+      // hook registration / agent scoping before anything else.
+      const _entrySessionKey = ctx?.sessionKey || event?.sessionKey || event?.context?.sessionKey || "(none)";
+      api.logger.info?.(`[ofiere-brain] agent_end fired (sessionKey=${_entrySessionKey})`);
       try {
         // Extract messages from event — agent_end provides the conversation
         const messages: any[] = event?.messages || event?.context?.messages || [];
-        if (!messages || messages.length < 2) return;
+        if (!messages || messages.length < 2) {
+          api.logger.debug?.(`[ofiere-brain] agent_end early-exit: messages.length=${messages?.length ?? 0} (<2)`);
+          return;
+        }
 
         // Find last user + last assistant message
         let lastUser = "";
@@ -6589,8 +6606,15 @@ function registerBrainExtractionHook(
           if (lastUser && lastAssistant) break;
         }
 
-        // Skip trivial exchanges
-        if (lastUser.length < 20 || lastAssistant.length < 30) return;
+        // Cycle 7b BUGSHOOT-4 — REMOVED early-return on short messages here.
+        // The prior gate (`if lastUser<20 || lastAssistant<30 return`) sat
+        // BEFORE the staff_report / task_dispatch_log / conversation_messages
+        // writes, which silently killed every staff dispatch whose output was
+        // shorter than 30 chars (e.g. smoke tests outputting "SMOKE-OK" = 8).
+        // The trivial-skip is now applied just before the brain L1/L2/L3/L4
+        // extraction below — those are noise filters, not bookkeeping.
+        // Bookkeeping (dispatch_log completion, conversation messages,
+        // staff_report) MUST run regardless of message length.
 
         // ── Agent identity resolution (FIX) ──────────────────────────
         // Priority: ctx.agentId (from PluginHookAgentContext, the CORRECT source)
@@ -6776,6 +6800,16 @@ function registerBrainExtractionHook(
           }
         }
 
+        // Cycle 7b BUGSHOOT-4 — trivial-skip moved here from line ~6593.
+        // Brain L1/L2/L3/L4 extraction skips trivial chit-chat to reduce
+        // memory noise. This MUST sit AFTER staff_report + task_dispatch_log
+        // bookkeeping above, otherwise short-output staff dispatches silently
+        // fail to persist (root cause of cycles 7b BUGSHOOT 1-4).
+        if (lastUser.length < 20 || lastAssistant.length < 30) {
+          api.logger.debug?.(`[ofiere-brain] skip brain extraction (trivial: user=${lastUser.length}c assistant=${lastAssistant.length}c)`);
+          return;
+        }
+
         // ── Fast Stream: Write L1_focus + L2_episode in parallel ──
         const rawContent = `User: ${lastUser}\nAssistant: ${lastAssistant}`;
         const immediateWrites: PromiseLike<any>[] = [];
@@ -6897,6 +6931,105 @@ function registerBrainExtractionHook(
   }
 }
 
+// ─────────────────────────────────────────────────────────────────────────────
+// CYCLE 10 PROBE — REMOVE/DISABLE BEFORE PRODUCTION 4.50.x
+// ─────────────────────────────────────────────────────────────────────────────
+// One-shot diagnostic that logs the full payload shape of every native
+// subagent_* hook, then triggers a single api.runtime.subagent.run so the
+// lifecycle fires end-to-end. Used to verify field names before the real
+// subagent_ended handler is written. Activated by env var
+// OFIERE_CYCLE10_PROBE=1; otherwise inert.
+//
+// Captured in cycle 10 BUGSHOOT under hook key [ofiere-probe].
+// ─────────────────────────────────────────────────────────────────────────────
+
+function registerCycle10Probe(api: any): void {
+  const safeStringify = (obj: unknown, max = 4000): string => {
+    try {
+      const seen = new WeakSet<object>();
+      const out = JSON.stringify(obj, (_k, v) => {
+        if (typeof v === "object" && v !== null) {
+          if (seen.has(v)) return "[Circular]";
+          seen.add(v);
+        }
+        if (typeof v === "function") return `[Function ${v.name || "anon"}]`;
+        return v;
+      }, 2);
+      return out.length > max ? out.slice(0, max) + "...[truncated]" : out;
+    } catch (e) {
+      return `[stringify-fail: ${e instanceof Error ? e.message : String(e)}]`;
+    }
+  };
+
+  const hookNames = [
+    "subagent_spawning",
+    "subagent_spawned",
+    "subagent_delivery_target",
+    "subagent_ended",
+  ];
+  for (const hook of hookNames) {
+    try {
+      api.on?.(hook, (event: any, ctx: any) => {
+        try {
+          api.logger.info?.(
+            `[ofiere-probe] ${hook} event=${safeStringify(event, 2000)} ctx=${safeStringify(ctx, 2000)}`,
+          );
+        } catch (e) {
+          api.logger.warn?.(`[ofiere-probe] ${hook} log failed: ${e instanceof Error ? e.message : String(e)}`);
+        }
+      });
+      api.logger.info?.(`[ofiere-probe] ${hook} hook registered`);
+    } catch (e) {
+      api.logger.warn?.(`[ofiere-probe] ${hook} hook register failed: ${e instanceof Error ? e.message : String(e)}`);
+    }
+  }
+
+  // One-shot spawn 8s after init so the gateway is fully up.
+  setTimeout(async () => {
+    const sessionKey = `agent:celia:subagent:probe-${Date.now().toString(36).slice(-6)}`;
+    api.logger.info?.(`[ofiere-probe] firing api.runtime.subagent.run sessionKey=${sessionKey}`);
+    try {
+      const runtime = (api as any)?.runtime;
+      if (!runtime?.subagent?.run) {
+        api.logger.error?.(
+          `[ofiere-probe] api.runtime.subagent.run NOT AVAILABLE on this OpenClaw version. ` +
+          `runtime keys: ${runtime ? Object.keys(runtime).join(",") : "(no runtime)"}`,
+        );
+        return;
+      }
+      const result = await runtime.subagent.run({
+        sessionKey,
+        message: "Reply with exactly the text PROBE-OK and nothing else.",
+        deliver: false,
+      });
+      api.logger.info?.(`[ofiere-probe] subagent.run returned ${safeStringify(result, 1000)}`);
+
+      // Try waitForRun + getSessionMessages immediately so we capture the
+      // full transcript shape even before subagent_ended fires.
+      if (result?.runId && runtime.subagent.waitForRun) {
+        try {
+          const waitResult = await runtime.subagent.waitForRun({ runId: result.runId, timeoutMs: 30000 });
+          api.logger.info?.(`[ofiere-probe] waitForRun returned ${safeStringify(waitResult, 2000)}`);
+        } catch (e) {
+          api.logger.warn?.(`[ofiere-probe] waitForRun threw: ${e instanceof Error ? e.message : String(e)}`);
+        }
+      }
+      if (runtime.subagent.getSessionMessages) {
+        try {
+          const msgsResult = await runtime.subagent.getSessionMessages({ sessionKey, limit: 10 });
+          api.logger.info?.(`[ofiere-probe] getSessionMessages returned ${safeStringify(msgsResult, 4000)}`);
+        } catch (e) {
+          api.logger.warn?.(`[ofiere-probe] getSessionMessages threw: ${e instanceof Error ? e.message : String(e)}`);
+        }
+      }
+    } catch (e) {
+      api.logger.error?.(
+        `[ofiere-probe] subagent.run threw: ${e instanceof Error ? `${e.name}: ${e.message}\n${e.stack}` : String(e)}`,
+      );
+    }
+  }, 8000);
+}
+
 // ── Brain Context Bootstrap Injection ──────────────────────────────────────
 // Injects the calling agent's active memories into the system prompt via
 // api.on("before_prompt_build"). Uses the TMT hierarchy: