ofiere-openclaw-plugin 3.5.4 → 3.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ofiere-openclaw-plugin",
-  "version": "3.5.4",
+  "version": "3.5.5",
   "type": "module",
   "description": "OpenClaw plugin for Ofiere PM - 10 meta-tools covering tasks, agents, projects, scheduling, knowledge, workflows, notifications, memory, prompts, and constellation agent architecture",
   "keywords": ["openclaw", "ofiere", "project-management", "agents", "plugin"],

package/src/tools.ts

@@ -1697,7 +1697,7 @@ function registerConstellationOps(
   // Resolve the OpenClaw data directory — the plugin runs inside the gateway process
   const fs = require("fs");
   const path = require("path");
-  const { execSync } = require("child_process");
+  const { spawnSync } = require("child_process");
 
   // OpenClaw stores data at /data/.openclaw/ inside the Docker container
   // Fallback: check HOME/.openclaw/ for local dev
@@ -1967,28 +1967,27 @@ function registerConstellationOps(
 
   function tryRegisterAgent(agentName: string): { success: boolean; message: string } {
     const wsPath = getWorkspacePath(agentName);
-    try {
-      const cmd = `${OPENCLAW_CLI} agents add ${agentName} --workspace ${wsPath} --non-interactive 2>&1`;
-      const output = execSync(cmd, { encoding: "utf8", timeout: 15000 });
-      api.logger?.info?.(`[ofiere] Auto-registered agent "${agentName}": ${output.slice(0, 200)}`);
+    // Use spawnSync instead of execSync: spawnSync never throws on non-zero
+    // exit codes, giving us clean access to stdout/stderr/status regardless
+    // of CLI config warnings that cause non-zero exits.
+    const result = spawnSync(OPENCLAW_CLI, [
+      "agents", "add", agentName, "--workspace", wsPath, "--non-interactive",
+    ], { encoding: "utf8", timeout: 15000 });
+
+    const stdout = result.stdout || "";
+    const stderr = result.stderr || "";
+    const combined = stdout + "\n" + stderr;
+
+    // Success indicators: JSON with agentId, agent name present, or zero exit
+    if (result.status === 0 || combined.includes('"agentId"') || combined.includes(`"${agentName}"`)) {
+      api.logger?.info?.(`[ofiere] Auto-registered agent "${agentName}": ${stdout.slice(0, 200)}`);
       return { success: true, message: `Agent "${agentName}" registered in OpenClaw` };
-    } catch (e: any) {
-      // OpenClaw CLI may exit non-zero due to config warnings even when the
-      // actual operation succeeded. Check the combined stdout+stderr for
-      // success indicators before reporting failure.
-      const combined = [e?.stdout, e?.stderr, e?.output?.join?.("\n"), String(e)]
-        .filter(Boolean).join("\n");
-      // Success indicators: JSON output with agentId, or "already exists"
-      if (combined.includes(`"agentId"`) || combined.includes(`"${agentName}"`)) {
-        api.logger?.info?.(`[ofiere] Auto-registered agent "${agentName}" (exit non-zero but output confirms success)`);
-        return { success: true, message: `Agent "${agentName}" registered in OpenClaw` };
-      }
-      if (combined.includes("already exists") || combined.includes("duplicate")) {
-        return { success: true, message: `Agent "${agentName}" was already registered` };
-      }
-      api.logger?.warn?.(`[ofiere] Auto-registration failed for "${agentName}": ${combined.slice(0, 300)}`);
-      return { success: false, message: `Auto-registration failed: ${combined.slice(0, 200)}` };
     }
+    if (combined.includes("already exists") || combined.includes("duplicate")) {
+      return { success: true, message: `Agent "${agentName}" was already registered` };
+    }
+    api.logger?.warn?.(`[ofiere] Auto-registration failed for "${agentName}": ${combined.slice(0, 300)}`);
+    return { success: false, message: `Auto-registration failed: ${combined.slice(0, 200)}` };
   }
 
   // ── Register the tool ──
@@ -2304,21 +2303,20 @@ function registerConstellationOps(
           }
 
           // Unregister from OpenClaw (best-effort)
-          let unregResult = { success: false, message: "" };
-          try {
-            const cmd = `${OPENCLAW_CLI} agents delete ${agentName} --force 2>&1`;
-            const output = execSync(cmd, { encoding: "utf8", timeout: 15000 });
+          // Use spawnSync: never throws, gives clean stdout/stderr/status
+          const unregCmd = spawnSync(OPENCLAW_CLI, [
+            "agents", "delete", agentName, "--force",
+          ], { encoding: "utf8", timeout: 15000 });
+
+          const unregStdout = unregCmd.stdout || "";
+          const unregStderr = unregCmd.stderr || "";
+          const unregCombined = unregStdout + "\n" + unregStderr;
+
+          let unregResult: { success: boolean; message: string };
+          if (unregCmd.status === 0 || unregCombined.includes('"agentId"') || unregCombined.includes(`"${agentName}"`)) {
             unregResult = { success: true, message: `Agent "${agentName}" unregistered from OpenClaw` };
-          } catch (e: any) {
-            // OpenClaw CLI may exit non-zero due to config warnings even when
-            // the delete operation succeeded. Check output for success indicators.
-            const combined = [e?.stdout, e?.stderr, e?.output?.join?.("\n"), String(e)]
-              .filter(Boolean).join("\n");
-            if (combined.includes(`"agentId"`) || combined.includes(`"${agentName}"`)) {
-              unregResult = { success: true, message: `Agent "${agentName}" unregistered from OpenClaw` };
-            } else {
-              unregResult = { success: false, message: `Unregistration may have failed: ${combined.slice(0, 200)}` };
-            }
+          } else {
+            unregResult = { success: false, message: `Unregistration may have failed: ${unregCombined.slice(0, 200)}` };
           }
 
           api.logger?.info?.(`[ofiere] Deleted agent "${agentName}" — ${deletedFiles.length} files removed`);