ofiere-openclaw-plugin 3.5.2 → 3.5.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ofiere-openclaw-plugin",
-  "version": "3.5.2",
+  "version": "3.5.4",
   "type": "module",
   "description": "OpenClaw plugin for Ofiere PM - 10 meta-tools covering tasks, agents, projects, scheduling, knowledge, workflows, notifications, memory, prompts, and constellation agent architecture",
   "keywords": ["openclaw", "ofiere", "project-management", "agents", "plugin"],

package/src/tools.ts

@@ -1705,6 +1705,22 @@ function registerConstellationOps(
     fs.existsSync("/data/.openclaw") ? "/data/.openclaw"
     : path.join(process.env.HOME || process.env.USERPROFILE || "/root", ".openclaw");
 
+  // ── Resolve the `openclaw` CLI binary path ──
+  // Inside Docker, the binary is NOT in PATH — we need the absolute path.
+  const OPENCLAW_CLI = (() => {
+    const candidates = [
+      "/data/.npm-global/bin/openclaw",        // Docker container (npm global)
+      "/usr/local/bin/openclaw",               // Standard global install
+      path.join(process.env.HOME || "/root", ".npm-global/bin/openclaw"),
+      path.join(process.env.HOME || "/root", "node_modules/.bin/openclaw"),
+    ];
+    for (const c of candidates) {
+      try { if (fs.existsSync(c)) return c; } catch {}
+    }
+    // Last resort: hope it's in PATH (works for native installs)
+    return "openclaw";
+  })();
+
   // ── Helpers ──
 
   function getWorkspacePath(agentName: string): string {
@@ -1952,18 +1968,26 @@ function registerConstellationOps(
   function tryRegisterAgent(agentName: string): { success: boolean; message: string } {
     const wsPath = getWorkspacePath(agentName);
     try {
-      const cmd = `openclaw agents add ${agentName} --workspace ${wsPath} --non-interactive 2>&1`;
+      const cmd = `${OPENCLAW_CLI} agents add ${agentName} --workspace ${wsPath} --non-interactive 2>&1`;
       const output = execSync(cmd, { encoding: "utf8", timeout: 15000 });
       api.logger?.info?.(`[ofiere] Auto-registered agent "${agentName}": ${output.slice(0, 200)}`);
       return { success: true, message: `Agent "${agentName}" registered in OpenClaw` };
     } catch (e: any) {
-      const msg = e?.stderr || e?.stdout || String(e);
-      // Check if already registered
-      if (msg.includes("already exists") || msg.includes("duplicate")) {
+      // OpenClaw CLI may exit non-zero due to config warnings even when the
+      // actual operation succeeded. Check the combined stdout+stderr for
+      // success indicators before reporting failure.
+      const combined = [e?.stdout, e?.stderr, e?.output?.join?.("\n"), String(e)]
+        .filter(Boolean).join("\n");
+      // Success indicators: JSON output with agentId, or "already exists"
+      if (combined.includes(`"agentId"`) || combined.includes(`"${agentName}"`)) {
+        api.logger?.info?.(`[ofiere] Auto-registered agent "${agentName}" (exit non-zero but output confirms success)`);
+        return { success: true, message: `Agent "${agentName}" registered in OpenClaw` };
+      }
+      if (combined.includes("already exists") || combined.includes("duplicate")) {
         return { success: true, message: `Agent "${agentName}" was already registered` };
       }
-      api.logger?.warn?.(`[ofiere] Auto-registration failed for "${agentName}": ${msg.slice(0, 300)}`);
-      return { success: false, message: `Auto-registration failed. Manual step: openclaw agents add ${agentName} --workspace ${wsPath}` };
+      api.logger?.warn?.(`[ofiere] Auto-registration failed for "${agentName}": ${combined.slice(0, 300)}`);
+      return { success: false, message: `Auto-registration failed: ${combined.slice(0, 200)}` };
     }
   }
 
@@ -2282,11 +2306,19 @@ function registerConstellationOps(
           // Unregister from OpenClaw (best-effort)
           let unregResult = { success: false, message: "" };
           try {
-            const cmd = `openclaw agents delete ${agentName} --force 2>&1`;
+            const cmd = `${OPENCLAW_CLI} agents delete ${agentName} --force 2>&1`;
             const output = execSync(cmd, { encoding: "utf8", timeout: 15000 });
-            unregResult = { success: true, message: output.slice(0, 200) };
+            unregResult = { success: true, message: `Agent "${agentName}" unregistered from OpenClaw` };
           } catch (e: any) {
-            unregResult = { success: false, message: `Manual step needed: openclaw agents delete ${agentName} --force` };
+            // OpenClaw CLI may exit non-zero due to config warnings even when
+            // the delete operation succeeded. Check output for success indicators.
+            const combined = [e?.stdout, e?.stderr, e?.output?.join?.("\n"), String(e)]
+              .filter(Boolean).join("\n");
+            if (combined.includes(`"agentId"`) || combined.includes(`"${agentName}"`)) {
+              unregResult = { success: true, message: `Agent "${agentName}" unregistered from OpenClaw` };
+            } else {
+              unregResult = { success: false, message: `Unregistration may have failed: ${combined.slice(0, 200)}` };
+            }
           }
 
           api.logger?.info?.(`[ofiere] Deleted agent "${agentName}" — ${deletedFiles.length} files removed`);