octwin-cli 0.7.2 → 0.8.0

package/dist/lib/render-check.js

@@ -58,6 +58,23 @@ export function loadAllowedRenderKeys(packDir) {
     }
     return { lookup, keys: out, nested };
 }
+/** The tap verbs, in the order the platform's compiler picks them. */
+const ON_SELECT_VERBS = ['invoke', 'resume', 'reply', 'agent'];
+/**
+ * `{ if, then, else }` — mirrors `isIfFragment` in the platform's
+ * `interpreter/render-resolver.ts` and `schemas/render.ts`. Three copies is two too
+ * many, but this package is deliberately dependency-free from `src/platform`; the
+ * predicate is identical and `render-check.parity.test.ts` is what keeps it so.
+ */
+function isIfFragment(v) {
+    return !!v && typeof v === 'object' && !Array.isArray(v) &&
+        typeof v.if === 'string' &&
+        Object.keys(v).every(k => k === 'if' || k === 'then' || k === 'else');
+}
+/** The `on_select` NODE itself — the one place an if-fragment is not evaluated. */
+function isOnSelectPath(at) {
+    return at === 'on_select' || at.endsWith('.on_select');
+}
 /**
  * Walk parsed YAML for objects carrying `render_intent` and report keys outside
  * that intent's allowed set. Walks the whole document rather than just `render:`
@@ -81,7 +98,50 @@ export function findRenderKeyViolations(doc, file, allowedByIntent, nestedByInte
         if (!value || typeof value !== 'object')
             return;
         const obj = value;
+        // An if-fragment stands in for the value it selects, so check its branches at the SAME
+        // path. Mirrors the platform's `checkNested`: without this the wrapper's own keys were
+        // reported against the slot it wraps, which rejected the one form that actually works.
+        if (isIfFragment(obj) && !isOnSelectPath(at)) {
+            for (const b of ['then', 'else']) {
+                if (obj[b] !== undefined)
+                    walkNested(obj[b], intent, at, sets, [...path, b]);
+            }
+            return;
+        }
+        // …and at an `on_select` node it is the reported bug, because runtime does not evaluate
+        // it there. One sentence naming the two forms that do work.
+        if (isIfFragment(obj) && isOnSelectPath(at)) {
+            findings.push({
+                file, path: [...path], intent, keys: [], allowed: ON_SELECT_VERBS, nestedAt: at,
+                note: `render_intent '${intent}' at '${at}': '{ if, then, else }' is not evaluated inside ` +
+                    `'on_select' — it fails at render time, not at validate. Wrap the WHOLE entry instead ` +
+                    `({ if, then: { title, on_select }, else: {…} }), or give each row its own on_select in ` +
+                    `data and point at it (on_select: '$item.on_select').`,
+            });
+            return;
+        }
         const allowed = sets[at];
+        // A missing verb is an absence, not an unknown key, so the key check below is blind to it —
+        // and the tap compiler throws on it at render. Only judged where the KB declares the slot,
+        // so a KB pulled before on_select was declared simply does not run this.
+        if (allowed && isOnSelectPath(at)) {
+            const present = ON_SELECT_VERBS.filter(v => obj[v] !== undefined);
+            if (present.length === 0) {
+                findings.push({
+                    file, path: [...path], intent, keys: [], allowed: ON_SELECT_VERBS, nestedAt: at,
+                    note: `render_intent '${intent}' at '${at}': 'on_select' needs exactly one of ` +
+                        `${ON_SELECT_VERBS.join(' / ')} — it has none, so the tap has no target and ` +
+                        `fails at render time.`,
+                });
+            }
+            else if (present.length > 1) {
+                findings.push({
+                    file, path: [...path], intent, keys: [], allowed: ON_SELECT_VERBS, nestedAt: at,
+                    note: `render_intent '${intent}' at '${at}': 'on_select' has more than one verb ` +
+                        `(${present.join(', ')}); only '${present[0]}' would run. Keep one.`,
+                });
+            }
+        }
         if (allowed) {
             const bad = Object.keys(obj).filter(k => !allowed.includes(k));
             if (bad.length)
@@ -126,6 +186,10 @@ export function findRenderKeyViolations(doc, file, allowedByIntent, nestedByInte
 /** One-line human message per finding. */
 export function describeRenderFinding(f) {
     const at = f.line != null ? `:${f.line}` : (f.path.length ? ` (${f.path.join('.')})` : '');
+    // A pre-worded finding (absent verb, if-fragment on a tap payload) carries its own sentence;
+    // the key-list template below cannot say either one.
+    if (f.note)
+        return `${f.file}${at}: ${f.note}`;
     if (f.keys.length === 0) {
         return `${f.file}${at}: unknown render_intent '${f.intent}' — known intents: ${f.allowed.join(', ')}`;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "octwin-cli",
-  "version": "0.7.2",
+  "version": "0.8.0",
   "description": "Octwin external-pack developer CLI (by CEQUENS) — scaffold, validate, deploy, and check pure-YAML packs on your tenant.",
   "type": "module",
   "bin": {