obsidian-plugin-config 1.6.5 → 1.6.7

package/.vscode/tasks.json

@@ -41,6 +41,14 @@
       "presentation": { "reveal": "always", "panel": "shared" },
       "problemMatcher": []
     },
+    {
+      "label": "Check Global CLI Version",
+      "type": "shell",
+      "command": "npm list -g obsidian-plugin-config --depth=0",
+      "group": "build",
+      "presentation": { "reveal": "always", "panel": "shared" },
+      "problemMatcher": []
+    },
     {
       "label": "NPM Publish",
       "type": "shell",

package/PROBLEM_FOR_CLAUDE.md

@@ -0,0 +1,82 @@
+# Windows node_modules Cleanup Problem
+
+## Issue
+Injection fails on Windows with EPERM error when Yarn tries to install dependencies:
+```
+error Error: EPERM: operation not permitted, unlink 'C:\...\node_modules\@esbuild\win32-x64\esbuild.exe'
+```
+
+## Root Cause
+1. Script reports "🗑️ Removed node_modules" but `rmdir /s /q` fails silently on locked .exe files
+2. node_modules remains partially present with corrupted/locked files
+3. Yarn tries to reuse this corrupted node_modules and fails
+
+## Current Code (inject-core.ts, ~line 680)
+```typescript
+if (fs.existsSync(nodeModulesPath)) {
+    console.log(`   ⏳ Removing node_modules (this may take a moment)...`);
+    try {
+        execSync(`rmdir /s /q "${nodeModulesPath}"`, {
+            stdio: 'pipe',
+            windowsHide: true
+        });
+        console.log(`   🗑️  Removed node_modules (will be reinstalled with Yarn)`);
+    } catch {
+        // Rename fallback - BUT THIS NEVER EXECUTES because rmdir doesn't throw!
+        try {
+            const timestamp = Date.now();
+            const oldPath = `${nodeModulesPath}.old.${timestamp}`;
+            fs.renameSync(nodeModulesPath, oldPath);
+            console.log(`   🔄 Renamed locked node_modules to ${path.basename(oldPath)}`);
+        } catch {
+            console.log(`   ⚠️  Could not remove/rename node_modules`);
+            throw new Error('node_modules locked - close processes and retry');
+        }
+    }
+}
+```
+
+## Problem
+`execSync('rmdir /s /q ...')` with `stdio: 'pipe'` does NOT throw an exception when it fails to delete locked files. It exits with code 0 even though files remain.
+
+## Required Fix
+After `rmdir` command, CHECK if node_modules still exists. If yes, execute the rename fallback:
+
+```typescript
+if (fs.existsSync(nodeModulesPath)) {
+    console.log(`   ⏳ Removing node_modules (this may take a moment)...`);
+    
+    // Try to remove
+    execSync(`rmdir /s /q "${nodeModulesPath}"`, {
+        stdio: 'pipe',
+        windowsHide: true
+    });
+    
+    // CHECK if it actually worked
+    if (fs.existsSync(nodeModulesPath)) {
+        // rmdir failed silently - rename instead
+        const timestamp = Date.now();
+        const oldPath = `${nodeModulesPath}.old.${timestamp}`;
+        try {
+            fs.renameSync(nodeModulesPath, oldPath);
+            console.log(`   🔄 Renamed locked node_modules to ${path.basename(oldPath)}`);
+            console.log(`   💡 Delete it manually later: ${oldPath}`);
+        } catch {
+            console.log(`   ⚠️  Could not remove/rename node_modules (locked by processes)`);
+            console.log(`   💡 Close Obsidian/VSCode and run: obsidian-inject again`);
+            throw new Error('node_modules locked - close processes and retry');
+        }
+    } else {
+        console.log(`   🗑️  Removed node_modules (will be reinstalled with Yarn)`);
+    }
+}
+```
+
+## File to Fix
+`scripts/inject-core.ts` - function `cleanNpmArtifactsIfNeeded` (around line 680-730)
+
+## Test Case
+User runs `obsidian-inject` while VSCode is open on the plugin directory. The esbuild.exe file is locked by VSCode's TypeScript server.
+
+Expected: node_modules gets renamed to node_modules.old.{timestamp}, Yarn creates fresh node_modules
+Actual: rmdir fails silently, Yarn tries to use corrupted node_modules, EPERM error

package/README.md

@@ -20,15 +20,24 @@ npm install -g obsidian-plugin-config@latest --force
 ## Usage (global CLI)
 
 ```bash
-# Inject in current plugin directory
+# Inject in current plugin directory (with confirmation)
 obsidian-inject
 
-# Inject by path
+# Inject by path (with confirmation)
 obsidian-inject ../my-plugin
 
+# Inject without confirmation
+obsidian-inject ../my-plugin --no
+
 # Inject with SASS support (adds esbuild-sass-plugin)
 obsidian-inject ../my-plugin --sass
 
+# Interactive mode (choose what to inject)
+obsidian-inject ../my-plugin --interactive
+
+# Use preset
+obsidian-inject ../my-plugin --preset=minimal
+
 # Verification only (no changes)
 obsidian-inject ../my-plugin --dry-run
 
@@ -36,6 +45,14 @@ obsidian-inject ../my-plugin --dry-run
 obsidian-inject --help
 ```
 
+## CLI Options
+
+- `--no`, `-n` - Skip confirmation prompts (auto-confirm)
+- `--sass` - Add SASS support (esbuild-sass-plugin)
+- `--interactive`, `-i` - Choose what to inject interactively
+- `--preset=<name>` - Use preset (minimal, scripts-only, config-only)
+- `--dry-run` - Verification only (no changes)
+
 ## What is injected
 
 - ✅ **Standalone local scripts**: `esbuild.config.ts`, `acp.ts`,

package/bin/obsidian-inject.js

@@ -3,7 +3,7 @@
 /**
  * Obsidian Plugin Config - CLI Entry Point
  * Global command: obsidian-inject
- * Version: 1.6.5
+ * Version: 1.6.7
  */
 
 import { execSync } from 'child_process';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "obsidian-plugin-config",
-  "version": "1.6.5",
+  "version": "1.6.7",
   "description": "Global CLI injection tool for Obsidian plugins",
   "type": "module",
   "bin": {

package/scripts/inject-core.ts

@@ -662,35 +662,27 @@ export async function cleanNpmArtifactsIfNeeded(targetPath: string): Promise<voi
 			// Remove node_modules FIRST (before lock files)
 			if (fs.existsSync(nodeModulesPath)) {
 				console.log(`   ⏳ Removing node_modules (this may take a moment)...`);
-				try {
-					execSync(`rmdir /s /q "${nodeModulesPath}"`, {
-						stdio: 'pipe',
-						windowsHide: true
-					});
-					console.log(
-						`   🗑️  Removed node_modules (will be reinstalled with Yarn)`
-					);
-				} catch {
-					// If locked, rename it
+				
+				execSync(`rmdir /s /q "${nodeModulesPath}"`, {
+					stdio: 'pipe',
+					windowsHide: true
+				});
+
+				if (fs.existsSync(nodeModulesPath)) {
+					// rmdir failed silently (locked .exe files) - rename instead
+					const timestamp = Date.now();
+					const oldPath = `${nodeModulesPath}.old.${timestamp}`;
 					try {
-						const timestamp = Date.now();
-						const oldPath = `${nodeModulesPath}.old.${timestamp}`;
 						fs.renameSync(nodeModulesPath, oldPath);
-						console.log(
-							`   🔄 Renamed locked node_modules to ${path.basename(oldPath)}`
-						);
-						console.log(
-							`   💡 Delete it manually later: ${oldPath}`
-						);
+						console.log(`   🔄 Renamed locked node_modules to ${path.basename(oldPath)}`);
+						console.log(`   💡 Delete it manually later: ${oldPath}`);
 					} catch {
-						console.log(
-							`   ⚠️  Could not remove/rename node_modules (locked by processes)`
-						);
-						console.log(
-							`   💡 Close Obsidian/VSCode and run: obsidian-inject again`
-						);
+						console.log(`   ⚠️  Could not remove/rename node_modules (locked by processes)`);
+						console.log(`   💡 Close Obsidian/VSCode and run: obsidian-inject again`);
 						throw new Error('node_modules locked - close processes and retry');
 					}
+				} else {
+					console.log(`   🗑️  Removed node_modules (will be reinstalled with Yarn)`);
 				}
 			}
 
@@ -788,6 +780,26 @@ export async function performInjection(
 
 		await runYarnInstall(targetPath);
 
+		// Clean up old node_modules if yarn install succeeded
+		const oldDirs = fs.readdirSync(targetPath)
+			.filter(name => name.startsWith('node_modules.old.'))
+			.map(name => path.join(targetPath, name));
+		
+		if (oldDirs.length > 0) {
+			console.log(`\n🧹 Cleaning up old node_modules...`);
+			for (const oldDir of oldDirs) {
+				try {
+					execSync(`rmdir /s /q "${oldDir}"`, {
+						stdio: 'pipe',
+						windowsHide: true
+					});
+					console.log(`   🗑️  Removed ${path.basename(oldDir)}`);
+				} catch {
+					console.log(`   ⚠️  Could not remove ${path.basename(oldDir)} (delete manually)`);
+				}
+			}
+		}
+
 		console.log(`\n📝 Creating injection info...`);
 		await createInjectionInfo(targetPath);
 

package/templates/.vscode/tasks.json

@@ -49,6 +49,14 @@
       "presentation": { "reveal": "always", "panel": "shared" },
       "problemMatcher": []
     },
+    {
+      "label": "Obsidian Inject (no confirm)",
+      "type": "shell",
+      "command": "obsidian-inject --no",
+      "group": "build",
+      "presentation": { "reveal": "always", "panel": "shared" },
+      "problemMatcher": []
+    },
     {
       "label": "Cleanup: Lint + Prettier + Build",
       "dependsOrder": "sequence",